- 13 Jul, 2017 40 commits
-
-
Emil A Eklund authored
Remove the ImagePaintContext class now that ImageQualityController is no more and move the remaining mask and blending logic into PaintFillLayer. Break out tiled image painting and text box painting from PaintFillLayer in to PaintFillLayerBackground & PaintFillLayerTextFillBox respectively. Share border rect logic between PaintFillLayer and PaintFastBottomLayer. Change-Id: Ie77fa832964941e2fee4732824db54042c9b47af Reviewed-on: https://chromium-review.googlesource.com/565024Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#486491}
-
Brian White authored
These are known offenders of the UMA.NegativeSamples.Histogram metric. https://bugs.chromium.org/p/chromium/issues/detail?id=739925 Bug: 682680,739925 Change-Id: Ie3e394baf5e1dfb2cf8f1028c5273c0a3d19ab4a Reviewed-on: https://chromium-review.googlesource.com/570262Reviewed-by:
Alexei Svitkine (slow) <asvitkine@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#486490}
-
Collin Baker authored
Bug: Change-Id: I376d927b3389c436611f924e1c324a7c38eecc5b Reviewed-on: https://chromium-review.googlesource.com/570125Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Peter Williamson <petewil@chromium.org> Commit-Queue: Collin Baker <collinbaker@google.com> Cr-Commit-Position: refs/heads/master@{#486489}
-
Fernando Serboncini authored
This is needed because PPAPI uses Platform without Core, so font names aren't initialized properly there. Bug: 742311 Change-Id: Ia0c89ffa9391759b54a73ec0d020ff437343e7a3 Reviewed-on: https://chromium-review.googlesource.com/570661Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#486488}
-
Siddhartha authored
This reverts commit 7e3d0c03. Reason for revert: The race was on second dump and shutdown. 1. The main thread starts a dump. Posts task on WP2 first for MPD1. 2. WP2-thread posts task to itself for MDP2. 3. WP2-thread posts task to WP1 for MDP1. At this point, WP2-thread is waiting on WP1 to create a new thread. 4. The test finishes with WP1-thread finalizing the dump, main thread returns. 5. The MDM destructor decides to delete it's reference to the task runner (MDPInfo). This clears the WP1 first. Step 5 calls WP1 destructor which calls thread destructor. The thread in Step 3 comes back to life and tries to check if the new thread has been created in WP1. MDM should not destroy the task runner when PostTask is not done. So, hold a reference in SetupNextMemoryDump(). Original change's description: > Revert "memory-infra: Move TracingObserver to service/" > > This reverts commit 15617f0b. > > Reason for revert: > https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20TSan%20Tests/builds/8765 > > base_unittest MemoryDumpManagerTest.PostTaskForSequencedTaskRunner is crashing due to the data race. > > Original change's description: > > memory-infra: Move TracingObserver to service/ > > > > The memory tracing observer along with peak detector and periodic > > scheduler should live in service/resource_coordinator since the peak > > detector needs to know about the OS dump providers. > > The tests were moved in previous CL. > > > > BUG=728199 > > > > Change-Id: Ib4934421d1d057fd7d062258179f17d3ca8209f7 > > Reviewed-on: https://chromium-review.googlesource.com/554280 > > Commit-Queue: Primiano Tucci <primiano@chromium.org> > > Reviewed-by: Helen Li <xunjieli@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Reviewed-by: Primiano Tucci <primiano@chromium.org> > > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#485968} > > TBR=dcheng@chromium.org,primiano@chromium.org,dpranke@chromium.org,hjd@chromium.org,xunjieli@chromium.org,ssid@chromium.org > > Change-Id: Iea202e6099216cb8ccad38d6f0d5354ea82643fe > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 728199 > Reviewed-on: https://chromium-review.googlesource.com/568401 > Reviewed-by: Hongchan Choi <hongchan@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Hongchan Choi <hongchan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#486014} TBR=dcheng@chromium.org,primiano@chromium.org,dpranke@chromium.org,hjd@chromium.org,xunjieli@chromium.org,ssid@chromium.org,hongchan@chromium.org Change-Id: Ic58718b4d4497f9cb28cb2962deb653b45f2f6da Bug: 728199 Reviewed-on: https://chromium-review.googlesource.com/568402 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#486487}
-
Eric Seckler authored
Bug: Change-Id: Idca8b4471422732fdb854ecc29605d27a09b8c46 Reviewed-on: https://chromium-review.googlesource.com/570422Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#486486}
-
Vaclav Brozek authored
BUG=689520 Change-Id: I430bc144a3b566894741b033258e672937053d32 Reviewed-on: https://chromium-review.googlesource.com/562756Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#486485}
-
Quinten Yearsley authored
Bug: 740986 Change-Id: I0b478cb89853994d444e9a17796aa06c6a36a430 Reviewed-on: https://chromium-review.googlesource.com/570676Reviewed-by:
Jeff Carpenter <jeffcarp@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#486484}
-
tedchoc authored
BUG=738628 Review-Url: https://codereview.chromium.org/2963393002 Cr-Commit-Position: refs/heads/master@{#486483}
-
Yuke Liao authored
This CL adds xcode_test_application_name to create_bundle target so that the relationship between xcode unit or ui test target and test application target can be specified in BUILD files instead of being identified by parsing target names in GN. Bug: 741147, 709289 Change-Id: Idf0cb700b300d80d49803dae33eb90c87c0e41a0 Reviewed-on: https://chromium-review.googlesource.com/566587 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#486482}
-
Daniel Bratell authored
There are five different classes in third_party/WebKit/Source/platform/exported named ExtraDataContainer. They are only used as local internal classes so they don't normally collide in the compiler, but they do so in jumbo builds. This patch renames them so that the names are more unique. Bug: 742337 Change-Id: Iad42e0d29f600fabd6ea9081687a7107d3043282 Reviewed-on: https://chromium-review.googlesource.com/570052Reviewed-by:
-
Weidong Guo authored
Changes: 1. Change SearchBoxView and SearchResultPageView's corner radius and layout in state AppListModel::STATE_SEARCH_RESULTS. 2. Remove separators between SearchResultView. 3. Add separators in SearchResultPageView to separate SearchResultContainerView. specs: https://screenshot.googleplex.com/409fBM7pTO2 screenshot: https://screenshot.googleplex.com/zYZqsT9ndum BUG=740732 Change-Id: Iffeb6d726970dacfe0745acd7d809d482e801b19 Reviewed-on: https://chromium-review.googlesource.com/566024 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#486480}
-
Robert Sesek authored
Commit 5fb31977 added this new target but didn't depend on the //sandbox:sandbox_features target so it failed to compile: In file included from ../../sandbox/linux/seccomp-bpf-helpers/seccomp_starter_android.cc:5: ../../sandbox/linux/seccomp-bpf-helpers/seccomp_starter_android.h:10:10: fatal error: 'sandbox/sandbox_features.h' file not found #include "sandbox/sandbox_features.h" NOTRY=true Bug: 742028 Bug: 730066 Bug: 739879 Change-Id: Ib0bc9f34f0cbf35be0f9f3cf412cd0fdcf678f3f Reviewed-on: https://chromium-review.googlesource.com/570514 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Cr-Commit-Position: refs/heads/master@{#486479}
-
Nico Weber authored
Bug: 579255 Change-Id: I30c8e76c6fa35c77bfe731d6bd7e89bb7d8f8c08 Reviewed-on: https://chromium-review.googlesource.com/570513Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#486478}
-
Eric Roman authored
Change-Id: Ice02da6a6906b27bee7ece5e8567c559dbbe0673 Reviewed-on: https://chromium-review.googlesource.com/568911Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#486477}
-
rbpotter authored
"getInitialSettings" should always be the first message from the print preview Javascript, so only call AllowJavascript() in PrintPreviewHandler::HandleGetInitialSettings(). Bug: None Change-Id: I764e72c10a39c82cf85f75b38867def5fae41c99 Reviewed-on: https://chromium-review.googlesource.com/569301 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#486476}
-
Alexei Filippov authored
Bug: 742355 Change-Id: I6b94d7358bd77d6d5d80d2eb608653aecd759cff Reviewed-on: https://chromium-review.googlesource.com/570628 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#486475}
-
Anna Maria authored
Bug: 721802 Change-Id: I12cc789f4052be4b02e175ad6cb9c0c763c3de6b Reviewed-on: https://chromium-review.googlesource.com/567043 Commit-Queue: Anna Maria <paezagon@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#486474}
-
Bruce Dawson authored
When crrev.com/2850863002 added a call to InitChromeLogging() it had to pull in //chrome/common:common, and that necessarily pulls in several MB of code that is not wanted. The tendrils of dependencies are many and varied and since a sword was disallowed there was no practical way to cut this Gordian knot. See the investigation in bug 717103 for details. So, InitChromeLogging() was copied, named as InitChromeWatcherLogging(), and made to work. This gets the size-cost of the logging code down to ~25 KB. A non_code_constants target was added to //chrome/common because the existing constants target was actually the main cause of excess code being pulled in. While testing this change it was discovered that the command-line logging flags were not passed to the chrome_watcher process, so that logging was not actually being enabled. This was also fixed. It may be possible to delete more of the copied code, depending on what logging features are actually needed. Thoughts? Bug: 717103, 715060 Change-Id: I536b0813fff32e513dfd3e0bbb8fc3cb715546c1 Reviewed-on: https://chromium-review.googlesource.com/567030Reviewed-by:
Patrick Monette <pmonette@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#486473}
-
jrummell authored
Previously media/mojo/sevices:lib was done as a source_set due to issue 670094. Now that that issue is fixed, the intermediate "lib" target is no longer needed. Removing the suppression of duplicate symbols revealed that some of the CdmPromiseTemplate methods end up in multiple modules when doing a component build. So fix CdmPromiseTemplate<>::GetResolveParameterType() implementation to avoid this. This also enables //media/mojo/services/media_service_unittests on Windows (which was disabled due to linking issues that are now fixed). BUG=676418,676055,656706 TEST=media_mojo tests compile and run Review-Url: https://codereview.chromium.org/2737513004 Cr-Commit-Position: refs/heads/master@{#486472}
-
Benjamin Pastene authored
All with one shard and 15-16min hard timeout. Will increase pool size by a few bots when this lands. This includes: viz_unittests base_unittests cc_unittests gfx_unittests device_unittests blink_heap_unittests gpu_unittests media_unittests browser_side_navigation_components_browsertests components_browsertests chrome_public_test_vr_apk chrome_sync_shell_test_apk Bug: 670879 Change-Id: Ibdb0e9f2307b2d5fbd897d2df52ac3c11565a0d6 Reviewed-on: https://chromium-review.googlesource.com/568223Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#486471}
-
Varun Khaneja authored
Incorrect: patch: http://screen/QGKMPviZDDf outcome: http://screen/ep69c4GW4uS NOTRY=true Bug: 543161,742463 Change-Id: I0134f1fd992a49f3411be8ea6f4df72d1f4f9e3d Reviewed-on: https://chromium-review.googlesource.com/570843 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
-
kylechar authored
The |root_location| of the synthetic touch event isn't set which breaks event dispatch. Since Ozone X11 is used for testing off device, and proper touch screen associations don't exist, just set |root_location| on the event. Also only parse the --touch-devices flag once with Ozone X11, it's not necessary to do it multiple times. Testing with the following command works for both displays: ./chrome --ash-host-window-bounds=900x900,900+0-900x900 \ --ash-touch-hud --touch-devices=X Bug: 741824 Change-Id: I0377db53eb07a4b1e1412dffbda4cc7325a55118 Reviewed-on: https://chromium-review.googlesource.com/570382 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#486469}
-
Tommy Martino authored
This CL adds accessible content ensuring that errors (e.g., "Email address required") will be read when navigating to the respective profile. Bug: 733684 Change-Id: I595736de370645656964ddd85fc7d7edb02142b9 Reviewed-on: https://chromium-review.googlesource.com/568242Reviewed-by:
Anthony Vallee-Dubois <anthonyvd@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#486468}
-
Wez authored
Change-Id: I2d85d3dc803f9b13ed8da842b9dd0f119e1c03c2 Reviewed-on: https://chromium-review.googlesource.com/569518Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#486467}
-
Valery Arkhangorodsky authored
Extends the use of EasyResizeWindowTargeter to transient children of top level windows that currently use EasyResizeWindowTargeter - as long as those children can themselves be resized. Bug: 741013 Test: added ToplevelWindowEventHandlerTest.EasyResizerUsed Change-Id: I5e9db48e80210a0ee108dcbd8f02dd33b1c62d78 Reviewed-on: https://chromium-review.googlesource.com/567266 Commit-Queue: Valery Arkhangorodsky <varkha@chromium.org> Reviewed-by:
-
Ted Choc authored
BUG= Change-Id: I5d52053de8dba8af8682d907d56e69ad7e545f8d Reviewed-on: https://chromium-review.googlesource.com/570738Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#486465}
-
Penny MacNeil authored
- Dynamic Code Disable >= Win8.1. - Thread opt-out >= Win10 RS1. - Prevents the process from generating dynamic code or modifying executable code. Second option to allow thread-specific opt-out. - VirtualAlloc with PAGE_EXECUTE_* - VirtualProtect with PAGE_EXECUTE_* - MapViewOfFile with FILE_MAP_EXECUTE | FILE_MAP_WRITE - SetProcessValidCallTargets for CFG - MS Code Signing enforcement >= Win10 TH2. - Prevents the process from loading binaries NOT signed by MS. - Image load prefer system32 >= Win10 RS1. - Forces image load preference to prioritize the Windows install System32 folder before dll load dir, application dir and any user dirs set. - Affects IAT resolution standard search path only, NOT direct LoadLibrary or executable search path. TEST= sbox_integration_tests.exe, ProcessMitigationsTest.* BUG=733739 R=forshaw@chromium.org TBR=grt@chromium.org Change-Id: I4347a9002368961e17f3f83ba39d50c469065bdc Reviewed-on: https://chromium-review.googlesource.com/566286 Commit-Queue: Penny MacNeil <pennymac@chromium.org> Reviewed-by:James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#486464}
-
Peter K. Lee authored
UITextView defaults to listen to user interaction and editable. This is not appropriate for sad tab content which should be readonly. Bug: 738426 Change-Id: I36e131ac37218970c0ee58d7df0b2f0913e93361 Reviewed-on: https://chromium-review.googlesource.com/570384Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#486463}
-
muyuanli authored
BUG=b:38505617 TEST= ash_unittests on ShelfLayoutManagerTest.AutohideShelfForAutohideWhenActiveWindow ash unittests on AppListPresenterDelegateTest.ShelfBackgroundRespondsToAppListBeingShown Review-Url: https://codereview.chromium.org/2967543003 Cr-Commit-Position: refs/heads/master@{#486462}
-
Fady Samuel authored
This CL deletes surface_reference.mojom, along with its typemap and StructTraits. SurfaceReferences are an implementation detail of surfaces. TBR=tsepez@chromium.org Bug: 722935 Change-Id: I42236cce804efe574ebcf6abd68dbd1e4ed78e0f Reviewed-on: https://chromium-review.googlesource.com/569978 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#486461}
-
Eugene But authored
On iOS 11 WKWebView loads much slower if it is not a part of the view hierarchy. This is more-likely a system issue, however it is important to have a workaround until Apple fixes the bug. BUG: 739390, 703222, 734669 Change-Id: I09d5c3ffadee44d3a5a6d834d4b5f0839b20f50b Reviewed-on: https://chromium-review.googlesource.com/566183Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
-
Magnus Jedvert authored
This reverts commit fdef07af. Reason for revert: Breaks browser_tests on the chromium.webrtc bots on Linux, Win7, and Mac. Gathering of ICE candidates fails with this error log: [7466:7466:0713/070330.078566:INFO:CONSOLE(13)] "Returning Test failed: Error: Received invalid ICE candidate list from peer: [] at failTest (http://127.0.0.1:52364/webrtc/test_functions.js:46:15) at receiveIceCandidates (http://127.0.0.1:52364/webrtc/peerconnection.js:371:11) at <anonymous>:1:51 to test.", source: http://127.0.0.1:52364/webrtc/test_functions.js (13) ../../chrome/browser/media/webrtc/webrtc_browsertest_base.cc:412: Failure Expected: "ok-received-candidates" To be equal to: ExecuteJavascript( base::StringPrintf("receiveIceCandidates('%s')", ice_candidates.c_str()), to_tab) Which is: "Test failed: Error: Received invalid ICE candidate list from peer: []\n at failTest (http://127.0.0.1:52364/webrtc/test_functions.js:46:15)\n at receiveIceCandidates (http://127.0.0.1:52364/webrtc/peerconnection.js:371:11)\n at <anonymous>:1:51" With diff: @@ -1,1 +1,4 @@ -ok-received-candidates +Test failed: Error: Received invalid ICE candidate list from peer: [] + at failTest (http://127.0.0.1:52364/webrtc/test_functions.js:46:15) + at receiveIceCandidates (http://127.0.0.1:52364/webrtc/peerconnection.js:371:11) + at <anonymous>:1:51 Link to bots: https://build.chromium.org/p/chromium.webrtc/builders/Linux%20Tester https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester https://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester Original change's description: > [scheduler] Reenable timer throttling for background renderers. > > Use renderer scheduler policy to throttle background timer queues > when the renderer is backgrounded. > > R=alexclarke@chromium.org > > Change-Id: Iff6f4b80883f1030b14e9f67345a7df9dd018a63 > Reviewed-on: https://chromium-review.googlesource.com/567932 > Reviewed-by: Alex Clarke <alexclarke@chromium.org> > Commit-Queue: Alexander Timin <altimin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#485947} TBR=alexclarke@chromium.org,altimin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. NOTRY=TRUE Change-Id: Iaf76027f0bc8894f8a8812c0843b27d26192a44a Reviewed-on: https://chromium-review.googlesource.com/570404 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Magnus Jedvert <magjed@chromium.org> Cr-Commit-Position: refs/heads/master@{#486459}
-
Alexis Menard authored
Interactions media queries were returning wrong values on laptops with touch screens which are neither convertible, neither detachable. The reason is that GetSystemMetrics(SM_CONVERTIBLESLATEMODE) returns always 0 on these machines which is buggy as they are not in a slate/tablet mode. One solution would be to check the presence of ConvertibleSlateMode key in the registry (that key is used to know when the laptop is flipped or detached) but it doesn't seem to be consistent across hardware (my desktop PC doesn't have that key but the hardware listed in the bug below has it). The last possible alternative is to query the hardware about screen rotation. If the screen rotation is supported then it's most likely a tablet/detachable/convertible, if not then it's a desktop PC, a non touch laptop or a classic touch laptop. If the screen rotation is not supported, if the laptop doesn't have a screen rotation sensor or if the laptop is in laptop mode then it's not a tablet. BUG=739430, 442418 Change-Id: I1aad26d7d833a425981bf0d46a7dae9878f19cd1 Reviewed-on: https://chromium-review.googlesource.com/566567Reviewed-by:
Ananta Iyengar <ananta@chromium.org> Reviewed-by:
Carlos Pizano <cpu@chromium.org> Commit-Queue: Alexis Menard <alexis.menard@intel.com> Cr-Commit-Position: refs/heads/master@{#486458}
-
John Abd-El-Malek authored
TBR=yszshen@chromium.org NOTRY=true Change-Id: Ia01b7d9027419eb2c055bf2eaaba9fa87834e35b Reviewed-on: https://chromium-review.googlesource.com/570839Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#486457}
-
Etienne Pierre-Doray authored
This reverts commit 9d704fa8. Reason for revert: FYI Buildbot ClangToTLinuxASan fails. We want to find out if this CL caused the failure. Original change's description: > [Zucchini] Introduce buffer_source and buffer_sink. > > Cursors with convenient read and write methods to ease manipulation of > raw data. > > Bug: 729154 > Change-Id: I8a7303964b02b9df7ef033de8756b09716a91eae > Reviewed-on: https://chromium-review.googlesource.com/560657 > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Reviewed-by: Samuel Huang <huangs@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#486238} TBR=huangs@chromium.org,erikchen@chromium.org,etiennep@chromium.org Change-Id: I15d90734a0e8b4791d51ee0b8bc04a4ce4116a45 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 729154 Reviewed-on: https://chromium-review.googlesource.com/570502Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#486456}
-
Justin Schuh authored
This reverts commit f3a69e04. Reason for revert: ios-device and ios-device-xcode-clang broken Original change's description: > Add optimized arm implementations to base/numerics > > BUG=672489 > > Change-Id: I7bb13d0ae3850f3334978bd8d483550ea2f3e3fd > Reviewed-on: https://chromium-review.googlesource.com/567436 > Commit-Queue: Emil A Eklund <eae@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Cr-Commit-Position: refs/heads/master@{#486438} TBR=jschuh@chromium.org,eae@chromium.org Change-Id: I2555ad7458b1379675e2c9fd4385d4bdaef0212c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 672489 Reviewed-on: https://chromium-review.googlesource.com/570898Reviewed-by:
Justin Schuh <jschuh@chromium.org> Commit-Queue: Justin Schuh <jschuh@chromium.org> Cr-Commit-Position: refs/heads/master@{#486455}
-
Justin Schuh authored
This reverts commit 66dbfe27. Reason for revert: ios-device and ios-device-xcode-clang broken Original change's description: > Fix ios builders after refs/heads/master@{#486438} > > TBR=eae@chromium.org > NOPRESUBMIT=true > NOTRY=true > NO_DEPENDENCY_CHECKS=true > > Change-Id: I61a733adb8570b6246da5b3d0dd34780c81d4dce > Reviewed-on: https://chromium-review.googlesource.com/570838 > Reviewed-by: Justin Schuh <jschuh@chromium.org> > Commit-Queue: Justin Schuh <jschuh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#486452} TBR=jschuh@chromium.org,eae@chromium.org Change-Id: I8b3d22b84096b92d7800cb42ae230d1a6307fcf0 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/570878Reviewed-by:
-
Dave Schuyler authored
This CL replaces use of i18n-content/values with $i18n{} in the internal appcache page. This page was and is only partially localized. TBR=michaeln@chromium.org Bug: 677338 Change-Id: I3113d51ab80381291807f298e3885d9128464144 Reviewed-on: https://chromium-review.googlesource.com/569314 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by: -
Justin Schuh authored
TBR=eae@chromium.org NOPRESUBMIT=true NOTRY=true NO_DEPENDENCY_CHECKS=true Change-Id: I61a733adb8570b6246da5b3d0dd34780c81d4dce Reviewed-on: https://chromium-review.googlesource.com/570838Reviewed-by:
-
