- 18 Aug, 2020 40 commits
-
-
Ravjit Singh Uppal authored
JS parts of ExtensionContentSettingsApiTestWithWildcardMatchingDisabled have been cleaned up, and an additional native test is added to verify that trying to add a wildcarded pattern for `plugins` through the chrome.contentSettings API will print a console warning. Bug: 1073883 Change-Id: I010b1d3f25fb68110fc6f72b40ccf103c011731c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289423Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> Auto-Submit: Ravjit Singh Uppal <ravjit@chromium.org> Cr-Commit-Position: refs/heads/master@{#799039}
-
Guido Urdaneta authored
This reverts commit 49422e89. Reason for revert: Speculative revert. Suspect of causing some failures that report Gpu issues with Wayland. https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/1109 Will reland if the revert does not fix the bot. Original change's description: > Reland "RELAND 2: media/gpu/vaapi_video_decoder: keep allocated VASurfaces alive" > > This is a reland of 02aec841 > > Speculative revert was incorrect > > Original change's description: > > RELAND 2: media/gpu/vaapi_video_decoder: keep allocated VASurfaces alive > > > > The relanded CL was reverted due to crashes when used from ARC++: > > Video Frames coming from this path are not GpuMemoryBuffers, so there's > > a DCHECK not verified, and then a crash. This CL addresses that > > situation, fixing `video_decode_accelerator_tests --use_vd_vda`: > > see crrev.com/c/2359734/1..3. > > > > Bug: b:163920993 > > > > Original RELAND description ------------------------------------------- > > > > The original CL was reverted due to crashes in betty initialization: > > betty is a VM which doesn't support VA, so the VideoDecoderPipeline > > constructed-destructed a VaapiVideoDecoder, hitting an unprotected > > nullptr |vaapi_wrapper_| in dtor. Fix in crrev.com/c/2339494/2..3. > > > > TBR=andrescj@chromium.org > > > > Original CL description ----------------------------------------------- > > > > Certain platforms and codecs suffer from horrible artifacts (Intel BYT, > > H264) or crashes (Intel BSW/BDW, VP9). This was traced to some kind of > > error in the tracking of the VASurfaces lifetime in the driver: every > > time we get a new resource from the pool to decode onto, this is > > imported into libva as a VASurface: this works fine almost everywhere > > but doesn't play well in these old platforms (see CreateSurface() body). > > > > This CL adds a map that keeps the ref-counted VASurfaces alive and > > indexed by the unique GpuMemoryBufferId until the VA Context is > > destroyed. In so doing, we're basically observing the "contract" of > > va.h vaDestroySurfaces() [1] "Surfaces can only be destroyed after all > > contexts using these surfaces have been destroyed". > > > > [1] https://github.com/intel/libva/blob/libva-2.0.0/va/va.h#L1134 > > > > Bug: b:142019786 b:143323596 > > Change-Id: I16e74eb2b483b892961eca27aed30112240aa8ba > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339494 > > Reviewed-by: Miguel Casas <mcasas@chromium.org> > > Commit-Queue: Miguel Casas <mcasas@chromium.org> > > Cr-Original-Commit-Position: refs/heads/master@{#795026} > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359734 > > Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org> > > Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> > > Auto-Submit: Miguel Casas <mcasas@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#798931} > > TBR=mcasas@chromium.org,andrescj@chromium.org > > Bug: b:163920993 > Bug: b:142019786 b:143323596 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Change-Id: I6124e960d93f6985dbf9a546bc9d34372815e002 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359975 > Reviewed-by: Fergus Dall <sidereal@google.com> > Commit-Queue: Fergus Dall <sidereal@google.com> > Cr-Commit-Position: refs/heads/master@{#798968} TBR=mcasas@chromium.org,andrescj@chromium.org,sidereal@google.com Change-Id: I5a6c92e18abcfd4d16f67942fa882fdb6cbe4001 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:163920993 Bug: b:142019786 b:143323596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362247Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#799038}
-
David Jean authored
In MW mode, when on iPhones which isn't MW, the frame for a window is set multiple times by iOS private methods, but some of those do not take into account screen rotation and can end up passing in a frame that is in portrait sizes on a landscape device. When that happens, the frame is centered, hence the origin contains a negative coordinate. This CL skips setting the frame on the ChromeOverlayWindow's parent when it has a negative x (or y, in case the bug can be reproduced the inverse way). It applies to iOS 13 and 14. Bug: 1113187 Change-Id: I38b9f9f475502d5123ab381dbde01296416b22d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359137 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#799037}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/26ea611a4edb..0dca23916904 2020-08-18 jleconte@google.com Chrome Perf Dashboard UI links to Monorail bugs are missing project id. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1101773 Tbr: rmhasan@google.com Change-Id: I1cd4d9e70c4be9d06b57bfcf15a6ef8af8324307 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360428Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799036}
-
David Roger authored
Profile.Update and Profile.Delete are bumped by one year as they are still going to be useful in the short term. Gaia.Gaia.ResponseCodesForOAuth2AccessToken and Gaia.BadRequestTypeForOAuth2AccessToken are changed to never expire. Gaia.SuccessCountBeforeBadRequestForOAuth2AccessToken is obsolete. Fixed: 1104942, 1097911 Change-Id: Ibb8a8cad5b4745948b656b91f752fcf438607452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358832Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#799035}
-
Saurabh Nijhara authored
We want to improve the installation time for force installed extensions. For this, we need to first gather the statistics regarding which installation stages are time consuming. This CL adds the UMA statistics for the following installation stages: 1) Unpacking - Time taken to complete the unpacking of the extension archive. 2) Checking - Time taken to perform the final checks to confirm that the extension can be installed. 3) Finalizing - Time taken to install the extension. Following histograms are added: Extensions.ForceInstalledTime.UnpackingStartTo.CheckingStart Extensions.ForceInstalledTime.CheckingStartTo.FinalizingStart Extensions.ForceInstalledTime.FinalizingStartTo.CRXInstallComplete Bug: 1102369 Change-Id: I46ed872a2954edba51ebdaeab8ab0ca9e1f4703b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351996Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#799034}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/8f1c25394047..44b62e8d9182 2020-08-17 miu@chromium.org Fix zero-padding bug for IpV4 address operator<<(). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I04ede1e0672976200ec18c41973b522506ca8eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360945Reviewed-by:
-
Evan Stade authored
This affects: 1. desktop settings 2. android settings 3. desktop sync settings Bug: 1114258 Change-Id: Ia51d1b9684096d3d61bab5108e754fc63c87e9e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352039 Auto-Submit: Evan Stade <estade@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#799032}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I19d842d3530d1ba05c99557c0cc42b59421e6b28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361767Reviewed-by:
-
Dominic Mazzoni authored
We considered making caret browsing reset on startup, but the final UX decision was that would just be more confusing. With this patch, the caret browsing preference persists like any normal preference - if it was enabled when you exit Chrome, it will still be enabled the next time you restart. The only exception is that if you pass the --enable-caret-browsing switch it will be enabled by default; this will keep things seamless for users who have already been using the switch for the past year. Bug: 1116659 Change-Id: I7653242fa2ee0a929855a3f9f77913a47f9eb9da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360335Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#799030}
-
Jan Krcal authored
This CL changes the corner radius of a colored background inside a bubble dialog with the corner radius of the bubble itself, as requested by UX. Bug: 1099286 Change-Id: I47ade9c26e9ff1321e15c37d27aedeebcca65781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359085 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f926b0866fe4..1756465158d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I40e63bcc2508ad76b3b872f5d0341ab4ee8f6cfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360910Reviewed-by:
-
Noel Gordon authored
Ensure entry names are in sort order before checking the entry values. Bot logs say (issue 1103147 #c13) test cannot assume sort order. Bug: 1103147 Change-Id: I0dff82fe9e3b51d84a768ffb6e4e3a205c59b5a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359662Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#799027}
-
Yunke Zhou authored
This is a reland of e771c29c Original change's description: > Oobe: enable child specific signin feature > > Bug: 1101318 > Change-Id: I47864f53018fb7b6ca1fd675953247a6dadc1f7c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352824 > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Yunke Zhou <yunkez@google.com> > Cr-Commit-Position: refs/heads/master@{#798671} Bug: 1101318 Change-Id: I73f8f871c4063b0b8f3718eeb974881728071ff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360061Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#799026}
-
chromium-internal-autoroll authored
Release_Notes:http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202008170800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/v84Xu6J9UdiZkQPrVZVu5ECq1RWmFqIUZgaH-BecwToC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/163420424,b/163420480 Tbr: help-app@grotations.appspotmail.com Change-Id: I0b2cf3a006f8ac81caa3ebc9e87cba2fefb99218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360216Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799025}
-
Hitoshi Yoshida authored
The code generator will be updated soon (issue 839389), and the new generator does not allow to access missing members. This CL adds to check some mebers' exisntence before accessing them to avoid probable crash issues in ImageResouce. Bug: 839389 Change-Id: I06a5519c793269ecbb6d1f0718ff478cfcf0fb02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358932 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#799024}
-
Hiroki Nakagawa authored
For code simplification, this CL moves logic to inquire about optimization hints for Blink from BlinkOptimizationGuideWebContentsObserver to BlinkOptimizationGuideInquirer. The observer creates and starts the inquirer when a main frame navigation gets ready to commit. If the inquirer for the previous navigation exists, it's destroyed at that point to abort inflight inquiries. > Motivation of this change Before this CL, the observer had mainly 2 responsibilities: (1) observing navigation events on WebContents, (2) inquiring the optimization guide service about hints. (1) is bound with the lifetime of WebContents, while (2) is bound with the lifetime of the main frame. The mismatch exists here. In terms of class modeling, (1) and (2) should have been in separate classes. To fix this mismatch, this CL moves (2) into BlinkOptimizationGuideInquirer. Change-Id: I713da144e4716c0d68f9a14fdc7d4ff6930fa77a Bug: 1113980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358948 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Victor Costan authored
Change-Id: I8bfea548a2d9bea527effcdfa1a673ee0f8d06f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360603 Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#799022}
-
Hitoshi Yoshida authored
The code generator will be updated soon (issue 839389), and the new generator does not generate WTF::String for IDL enumerations. In gpu_device.cc, the return type of descriptor->extensions() in the constructor will be Vector<V8GPUExtensionName> from Vector<String>. This CL as an adapter function to make the generators migration easy. The function makes a Vector<String> from either of Vector<String> or Vector<V8GPUExtensionName>. Bug: 839389, 1092328 Change-Id: Ib3c96f1509fa3ba1986222a13f591b42b9759258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352258 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#799021}
-
harrisonsean authored
Add support for Safe Browsing check Including adding managed state popover Add header to safety check page Bug: 1078782 Change-Id: I26dab9d679c5ecc14779d52bc3b4b13c52586ce4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346805Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#799020}
-
Wei-Yin Chen (陳威尹) authored
In crrev.com/c/2209302, the following tests were disabled because they were flaky on Android M builders and P emulators: - testShow_TasksOnly - testShow_TwoPanes - testScroll_OmniboxOnly_Pinned They are re-enabled on builders like android-pie-arm64-rel. Bug: 1081822, 1084176, 1083459 Change-Id: Ie7e2c833ce5e475cc954318a5afacc35c7e8f9fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315996Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#799019}
-
Jan Wilken Dörrie authored
This change implements showing a toast when to screen lock is set up and the user wants to edit a compromised password within the Password Check. Translation Screenshot: https://storage.cloud.google.com/chromium-translation-screenshots/2d5e2a564fc468f0e58bf4ae9d500d14c5b369e1 Bug: 1114720 Change-Id: Ibdcf22391543916e41b21c7a80a2657b7d64629d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360272 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#799018}
-
Guido Urdaneta authored
This reverts commit 1203768f. Reason for revert: Speculative revert. Suspect of causing failures. https://ci.chromium.org/p/chromium/builders/ci/linux-bfcache-rel/7587 Original change's description: > Roll Dawn from 988f19e208bb to d95180deded1 (2 revisions) > > https://dawn.googlesource.com/dawn.git/+log/988f19e208bb..d95180deded1 > > 2020-08-17 rharrison@chromium.org Roll 4 dependencies > 2020-08-17 enga@chromium.org D3D12: only lazy clear OutputAttachment textures with render target ops > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/dawn-chromium-autoroll > Please CC cwallez@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel > Bug: None > Tbr: cwallez@google.com > Change-Id: Ibcb597d53a688ed40d98a8496d24123e219d915f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360962 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#798975} TBR=cwallez@google.com,chromium-autoroll@skia-public.iam.gserviceaccount.com Change-Id: I6cce941901be523a6faaaa915b8174614d794fa6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362022Reviewed-by:
-
Yuke Liao authored
This CL fixes the unit_tests filter. TBR=svenzheng@chromium.org Bug: 1116180 Change-Id: I85da1b1ddb74291edef4bc2e7cf260f521dfd51f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360804Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#799016}
-
Fergus Dall authored
CrostiniExportImportTest.TestExportSuccess CrostiniExportImportTest.TestExportCancelled CrostiniExportImportTest.TestExportDoneBeforeCancelled CrostiniExportImportTest.TestDeprecatedExportSuccess TBR=joelhockey@chromium.org Bug: 1117356 Change-Id: I26c71780a9ae1b363070276f3824a99d962eef12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360108Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#799015}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e9d783c4d235..688e0966cb16 2020-08-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 5e9b29fab92d to d95180deded1 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: stani@google.com Change-Id: I868b21a9c5d45a367e487f1052574cd4b1d04309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361146Reviewed-by:
-
Rachel Wong authored
The launcher privacy notices are currently ignored by the keyboard focus cycle and by ChromeVox, because SearchBoxView manually handles selection for the various search containers and results. This CL adds the launcher privacy notice into SearchBoxView and ChromeVox's focus cycles by doing the following: 1) Make PrivacyInfoView a subclass of SearchResultBaseView, and use its built-in action support for navigation within the privacy notice. 2) Create a PrivacyContainerView to wrap around the PrivacyInfoView. Like the other containers, its creation is handled by ContentsView. This also removes the need for SearchResultPageView to handle the display conditions for the privacy view. 3) Add unit tests. More info about this CL can be found at go/privacy-container-view. Bug: 1112714 Change-Id: Idd6c95721cda3f03ca94694493c87e935d9dca46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269385 Commit-Queue: Rachel Wong <wrong@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#799013}
-
Fergus Dall authored
PrivacyBudgetUkmEntryFilterStandaloneTest.AllowsOtherMetricsByDefault PrivacyBudgetUkmEntryFilterStandaloneTest.BlocksIdentifiabilityMetricsByDefault TBR=caraitto@chromium.org TBR=pauljensen@chromium.org TBR=asanka@chromium.org Bug: 1117358 Change-Id: Iea9ffa9cf7adf0663b6d4e0aa87456ce779270f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361323Reviewed-by:
-
Sergey Ulanov authored
Previously cast runner was using agent_url to connect MetricsRecorder. That doesn't work correctly: the agent that created the component may not provide MetricsRecorder. Updated it to use components incoming_directory. This ensures that MetricsRecorder request is routed properly to the agent that implements the service. Bug: b/157669687 Change-Id: I891ebd852278fd98b543076f82562dbcd416005e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360417 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#799011}
-
Kent Tamura authored
This reverts commit f1a2ccf7. Reason for revert: Caused multiple memory regressions Original change's description: > Enable LayoutNG for BUTTON elements and INPUT buttons by default > > Bug: 1040826 > Change-Id: I0a2f9db962e74a44758293e0711009617e6a42d3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354119 > Commit-Queue: Kent Tamura <tkent@chromium.org> > Commit-Queue: Koji Ishii <kojii@chromium.org> > Auto-Submit: Kent Tamura <tkent@chromium.org> > Reviewed-by: Koji Ishii <kojii@chromium.org> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797991} Change-Id: Iac0d9d51d658f1b45c854bf030f28821f907d94f Tbr: yosin@chromium.org,tkent@chromium.org,kojii@chromium.org Bug: 1040826, 1116415, 1116447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360104Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#799010}
-
Hiroki Nakagawa authored
Before this CL, WorkerThread::GetTaskRunner() took a task runner from the worker scheduler on demand. The worker scheduler is disposed of during worker termination, so GetTaskRunner() must not be called after worker termination starts. Unfortunately it is difficult to enforce the rule everywhere, and this caused issues like https://crbug.com/1104046. To fix this, this CL captures all task runners on worker scheduler initialization, and WorkerThread::GetTaskRunner() return the captured task runner instead of accessing the worker scheduler to create a new task runner. Bug: 1112191 Change-Id: Ic39a515272e77fc3fb2c94ae842a89b15a78466c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342236Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#799009}
-
Sven Zheng authored
Recent 4 jobs all passing: https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/1097? https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/1096? https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/1095? https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/1093? For sheriffs: If there are new test failures, consider rollback offending cl, or disable the tests using IS_LACROS macros (go/chrome-sheriffing-how-to#test-failed). Bug: 1111979 Change-Id: I2f0657ab56cd182cb68e0516b172ab33d7e10603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360982Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#799008}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8d6628854c8b..c298799c3081 2020-08-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-08-17 asraine@google.com Change 'View Trace' button to indicate throttling method If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I54c04cd1c4f8bc8a7df2cbfc26a8d10a59f0aa32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361144Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/693d0e0bb673..863115fb49d7 2020-08-18 ynovikov@chromium.org Re-enable a dEQP-EGL test on SwANGLE If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: Id65dd3e981a1f75b0203f1c6a8ef16cd755159ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361085Reviewed-by:
-
Richard Stotz authored
The MacOS sandbox does not allow calling base::File::SetLength() from the renderer directly, see crbug.com/1084565. The call to setLength is therefore routed through the browser process, which likely decreases performance and increases complexity. Another option would be to create a SeatbeltExtensionToken that allows to pierce the sandbox on MacOS for a single file. As this would likely lead to more complex code, we decided that going through the browser process is the better option for now. Bug: 914488 Change-Id: Idc58d804e19751a2e37cfeb5c645f778edf4639c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257855 Commit-Queue: Richard Stotz <rstz@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#799005}
-
Fergus Dall authored
TBR=alph@chromium.org Bug: 1117342 Change-Id: I6c9f8be480cebc1d74e396f17fbe993fbe2d681a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359953Reviewed-by:
-
Joel Hockey authored
Keep track of the last active terminal by capturing terminal_id sent from the web app. When a new process is opened, we call cicerone GetVshSession to find the container shell pid to set for cwd. Bug: 1113207 Change-Id: Ia6ff0eb43b9bcefa781f19d141b36143cfd48649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351644Reviewed-by:
Jason Lin <lxj@google.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#799003}
-
mhasank authored
Make the success and error more explicit in the OnAuthorizationComplete. In this change we introduce a new method OnAuthorizationResult which will replace the original when Android is updated. BUG=b:146435695 TEST=deploy to dut, disable playstore, re-enable playstore, successfully finish the authorization flow Change-Id: Ife8fdf40cec5f945f98743400a8b2dfe02d947f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346940 Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Muhammad Hasan Khan <mhasank@chromium.org> Cr-Commit-Position: refs/heads/master@{#799002}
-
chrome://media-appDavid authored
Previously we called `launchWithDirectory()` to load in the renamed file. That blocked the renaming IPC finishing on the entire directory loading. This change takes a similar approach to SAVE_AS updating the file in `tokenMap` & `currentFiles` relying on the client app to reload itself (done in `handleChromiumIPC`) so we don't need to load the file again! This change unblocks b/163002455, b/163422302 & b/163432652 as well as adds a return value for invalid tokens. It also prevents losing our edit stack when we rename a file! Bug: b/163422302, b/162281131, b/162281681, 996088 Change-Id: I690963870d1346d31cb77a0c44aeb95802216ef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352586 Commit-Queue: David Lei <dlei@google.com> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#799001}
-
Yu Han authored
See launch bug: crbug.com/1086530 Bug: 1086530 Change-Id: I059958cf508c3fc96dd3295144a55a505d837613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358436Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#799000}
-
