GitLab

The standalone ANGLE GTest-based tests run as isolated scripts.
This change adds support to the Android test_runner.py to store the
result in the "base_test_result" format then convert these base test
results back to the JSON test result format.

Bug: 931731
Bug: angleproject:3162
Change-Id: I4d05902db0ce60c259d7127776eafc5d7864b43e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407181
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806735}

These metrics were used to successfully launch https://crbug.com/875110.
They are no longer actively tracked so this patch removes them. This is
essentially a revert of https://crrev.com/767560.

Bug: 1125653
Change-Id: I1de0ad10a7fe1019989f4a02052313c95b5fbd32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408629Reviewed-by: Daniel Libby <dlibby@microsoft.com>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Auto-Submit: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806734}

Experiment enabled on canary and dev
https://critique-ng.corp.google.com/cl/330618197

This CL prepares for beta rollout

Change-Id: I21a714b24a6119856963064bb155ab6b421cef45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405905Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806733}

This change refactors PasswordsTableViewController, by adding
PasswordsCoordinator. All code related to the presenting/dismissing of
the controllers was moved to the coordinator. Mediator moved to the
coordinator as well. Cleaned includes and deps.

Bug: 1128025

Change-Id: I240cc3ff658c26ff6d9f44fada7313885dff98bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398686
Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806732}

Please see bug for design doc.

Bug: 1121806
Change-Id: I9c67bc3487a64eb1b07b4d0334a63081f85c66fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404947Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Anne Lim <annelim@google.com>
Cr-Commit-Position: refs/heads/master@{#806731}

It seems possible that a race condition to happen between WebViewImpl's
CloseWindowSoon() schedules a call to DoDeferredCloseWindowSoon() and
that method actually being called: even though WebViewImpl will be
alive (otherwise the weak pointer would have prevented that callback
from being called), WebViewImpl::DidDetachRemoteMainFrame() might have
been called in between those two points, unbinding the remote and
causing the issue reported as part of crbug.com/1127329.

Bug: 1127329
Change-Id: I189fc1b38f315dc420d97eda5b5c01d346db8033
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409499Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#806730}

Rollup now always reads resource files from the "preprocessed"
directory. Modify the test to account for this. Also remove the test
importing action link as there is now no manually curated list of non
generated files in rollup_plugin.js, and everything is simply read
from the preprocessed directory directly.

Change-Id: I588959f5a28f105c0006112f16be4af6dcf0819c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410443Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806729}

There are some tests there that cover parts of the spec
not covered anywhere else.

Change-Id: If853e66c6367da5ec37252177dbb911c7ffd3608
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408277
Auto-Submit: Aleks Totic <atotic@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806728}

This CL adds a flag to enable and disable adding a context menu item
that allows a user to copy a URL to the clipboard that links to the page
with the selected text highlighted.

Bug: 1105862
Change-Id: I6cd57bfbb1881f4c4f7d5dd5fcbb95de7f470b2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406697Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806727}

This CL makes sure that:
- flags are reset properly
- `kKnownCredentialsFetched` value is correct if already known
compromised credentials were loaded during scripts refreshment.

Bug: 1127856

Change-Id: Ia63cfd21de34bdb39265de2da81056d3966f7dc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410022
Commit-Queue: Milica Selakovic <selakovic@google.com>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806726}

Due to required data this CL also changes
|AutofillClient::GetPageLanguage()| into |GetLanguageState()|.
This allows autofill code access to the translation state of
the page, which might be useful for future features as well.

Change-Id: I7f3333bbd5b73f71f693cbef752ab17728a59548
Bug: 1121990
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377727Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Scott Little <sclittle@chromium.org>
Reviewed-by: Matthias Körber <koerber@google.com>
Reviewed-by: Christoph Schwering <schwering@google.com>
Commit-Queue: Martynas Sinkievič <marsin@google.com>
Cr-Commit-Position: refs/heads/master@{#806725}

This reverts commit 077d63da.

Reason for revert:

https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak

is constantly failing on

* virtual/module-top-level-await/external/wpt/html/semantics/scripting-1/the-script-element/module/evaluation-order-4-tla.html
* virtual/module-top-level-await/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/module-tla-delayed.html
* virtual/module-top-level-await/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/module-tla-immediate-promise.html
* virtual/module-top-level-await/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/module-tla-import.html


Original change's description:
> [blink] Fix top-level-await error reporting
> 
> - Enable tests with TLA enabled
> - Fix top-level error reporting with TLA
> 
> Based on the discussions on the spec, we fire error events on rejection
> of the result promise:
> https://github.com/whatwg/html/pull/4352#discussion_r435178136
> 
> Bug: 1022182, 1096455c, 1127215, v8:9344
> Change-Id: I16e83cb4e279c1e44be7fa70a51a103ee94aacc3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228881
> Commit-Queue: Camillo Bruni <cbruni@chromium.org>
> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
> Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
> Reviewed-by: Dominic Farolino <dom@chromium.org>
> Reviewed-by: Domenic Denicola <domenic@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#806593}

TBR=hiroshige@chromium.org,kouhei@chromium.org,cbruni@chromium.org,dom@chromium.org,domenic@chromium.org

Change-Id: I66b085b05ad30020772e80324e226275e41a8782
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1022182
Bug: 1096455c
Bug: 1127215
Bug: v8:9344
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410725Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806724}

Roll Chrome Linux PGO profile from chrome-linux-master-1600084447-654ce493c2d2b8d13e6243ff3cb852a603e3ef72.profdata to chrome-linux-master-1600106373-71253587ca194e48d78c58c419f94bf1bf8da7c5.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com
Change-Id: I8e2f385bd9e256d11f99c07456cc23b0e61a6b2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410807Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#806723}

This is a no-op CL that adds an ID needed by http://crrev.com/2386376.

TBR=yusufo@chromium.org

Bug: 1116644
Change-Id: If1826bf79adfc78364a0897d1719dae5a41cbcf2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406836
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806722}

Session restore uses history.pushState to inject URLs and titles into
each WKWebView session.  For large numbers of pages, this can generate
a very large number of IPC calls. iOS 12.2 introduced IPC throttling
that can delay the async pushState calls before the sync history.go
call. This was worked around via a check to see when all the push state
calls are correctly processed.

iOS14 introduced an optimization which breaks the above mentioned
workaround.  Instead, this change uses our own IPC call to native code
(which will be enqueued to the end of the IPC queue) to finalize session
restore.

The effect is faster restore for the average case, but slightly slower
restore for the edge case of a large numbers of pages.

Bug: 1127521, 1126863
Change-Id: Ibb70008afef312897e8165e06f16ed5c03808b38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407332
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806721}

The string-based version of this function takes const inputs, but the
vector-based one did not. Align them so that the vector-based function
is more general.

Change-Id: I25ee663cc1d35fa9b0bb6cffc33dd0cd8b460423
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404067Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806720}

This CL adds the following a11y support to the GTS:
  * Requests focus to the currently selected tab after GTS is finished
    showing.
  * Updates the close button content description for individual tabs and
    tab groups with or without group name.

This CL also updates the placeholder for the
accessibility_close_tab_group_button_with_group_name string.

Note: set `Skip-Translation-Screenshots-Check: True` to bypass error
since the screenshot is the same before and after editing the string.

Everything introduced in this CL is gated by by Finch parameter
"enable_launch_polish" under flag "enable-tab-grid-layout". The changes
in TabSwitcherCoordinator is also gated by the Finch flag
"enable-tab-groups-continuation". Most of the code is verified to be
behind the gating function TabUiFeatureUtilities#isLaunchPolishEnabled
by formal equivalence checking tool here: http://crrev.com/c/1934235.
The changes in following files can't be verified by the tool, but it is
expected and no-op without both flags:
  * new property in TabProperties
  * StartSurfaceLayout#canHostBeFocusable is the only diff
  * Lots of diffs in language files due to the string placeholder
    change

Skip-Translation-Screenshots-Check: True
Bug: 1124921
Change-Id: If665464d82f83596c93449e8910878b4c00d02cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402302
Commit-Queue: Mei Liang <meiliang@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806719}

These files, from
external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-intrinsic-ratio-00*,
have ~20 test cases each. Chrome fails some of them but not others. With
check-layout we can use -expected.txt files to prevent regressions for
the cases that we pass.  With the current ref tests, we have to disable
an entire file if we fail even one case in it.

No expectations were changed in the porting. You can see exactly which
lines changed at [1], because it doesn't rename the files.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2387420

Change-Id: I6fa59df56599c15cccddba4c77afcad6668b9f3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387148Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806718}

Bug: 1127518
Change-Id: I9639b5b047033ec92331a2dc5bb8541e4e08546c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406667
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806717}

Currently, Removable Media is watched at the top-level directory under
/media/removable. Unfortunately, this only works if the removable media
was attached before the inotify is attached (since inotify does not
detect mount event).

This changes listen to the mount events from cros-disks through
ArcVolumeManager (to synchronize with Android volume mounting) and
create a FilePathWatcher per removable media.

BUG=b:150883493
TEST=Mount invisible removable media, the media changes are indexed.
TEST=Reboot DUT with non-visible removable media attached, still indexed.
TEST=Change the removable media to be visible, still indexed.
TEST=Reboot DUT with visible media attached, still indexed
TEST=Change the removable media to be invisible, still indexed.

Change-Id: Ia02012676681e025431d74f2c3f9b951a77ca783
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362376
Auto-Submit: Risan <risan@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Risan <risan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806716}

mini_installer recursively deletes directories left behind from previous
runs. As it recurses through them, it may delete files with reparse
points in those dirs. This is bad, since such files may actually be
maliciously-created links to other entities on the filesystem. This CL
skips anything with a reparse point during deletion -- since Chrome
never creates files/dirs with reparse points, it shouldn't try to delete
them.

BUG=1125018
R=wfh@chromium.org

Change-Id: I9897947ed883a91758c31990ed0b9648c38d2942
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409698
Auto-Submit: Greg Thompson <grt@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806715}

Using wpt-import in Chromium 91b2c272.
With Chromium commits locally applied on WPT:
0cd6359d "Modify failing cookie WPTs to use HTTPS"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=robertma@google.com

No-Export: true
Change-Id: If882f7400fbbf9e8d5778bae83d01037ad18fee1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409923Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#806714}

This CL is a refactor with no intended behavior change. It updates the
method parameter from Callback -> OnceCallback.

Bug: 1127505
Change-Id: I8848dbf345db44a278e9a9cd59e0cebb20b0e5c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406590
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Auto-Submit: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806713}

This allows small raster scales like we see for some directly
composited images to not trip over this particular DCHECK. Since these
raster scales are all chosen by inverting the minimum dimension of the
layer bounds, these minimum values round trip, and the resulting tiles
won't be empty as they are doing a EnclosingContentsRectFromLayerRect
to compute the tiling (and tile) size.

Bug: 1124342
Change-Id: Ifb364e7d569d66903a04f9e4c80d56fc3ef8b9da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398985Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Daniel Libby <dlibby@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#806712}

The window containers for wallpaper all have fill layout, there is no
need to set the bounds manually.

Bug: None
Test: manual and unit test
Change-Id: I60cd9940ec64ab4afe924377cabe8dd7b6b6e908
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406670Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806711}

These targets fail to build if depended upon without
`enable_media_drm_storage`, so prevent that from being possible.
Split out from crrev.com/c/2383400

Bug: 898837
Change-Id: I7e0b94d81d2a722d93e41188812d532533a0255c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407420
Auto-Submit: Glen Robertson <glenrob@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806710}

This fixes an issue where a long-lived child proc can block browser
uninstallation.

BUG=1126506
R=robliao@chromium.org

Change-Id: I47cc3b7d701dcc454fcabce0751f2e08f21fd013
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409493
Auto-Submit: Greg Thompson <grt@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806709}

Bug: 1126424
Change-Id: I17ddbdce78d89a997a73c37f18cd945b83936f7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405644Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Cr-Commit-Position: refs/heads/master@{#806708}

New name for feature is more accurate, as it is used to completely disable Translate and is not UI specific.

Bug: 770776
Change-Id: I2f86da6de3d044d5b4e01186629f58f2c812e757
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404484Reviewed-by: Megan Jablonski <megjablon@chromium.org>
Commit-Queue: Anthony Cui <cuianthony@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806707}

Add WebviewErrorCode @IntDef.

Bug: 1116130
Change-Id: I740ad5b03eb2c03effd16413b57640d872b00a0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401813Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806706}

Else we can't tell if it's working on trunk.

TBR=rnk

Bug: 1127713
Change-Id: I9cefb00517ea71399e382678ce6da81e3629b501
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410817Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806705}

Change-Id: I336a6acb2c60f992be5aab3f76a17ca02df8bc03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406702
Commit-Queue: Ken Rockot <rockot@google.com>
Auto-Submit: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#806704}

Sensitive information are removed from URLs sent with COOP. This was
duplicated several time and way more are coming to support
access-reporting.

This patch:
1. Factorize the logic inside SanitizedURL(url)
2. Clear the #fragment part of the URL. Developers need to know the
   document's URL, not which part of it the user scrolled into.
3. Clear non HTTP/HTTPS urls.
4. As in the ReportingServiceImpl, use GetAsReferrer() instead. This is
   slightly more optimized.
5. Remove the useless sanitization in QueueNavigationReport.

Bug: 1090273
Change-Id: I4b2a23dcb3ed218c58d8a940bed1a34fe42a7fc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401025Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806703}

Fix use-after-move (potential) bugs found by the
"bugprone-use-after-move" clang-tidy check.

Bug: 1122844
Change-Id: I9a3c384c5efb7fc82a65cac1bf615ebdb42e6d9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401660Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806702}

Moves the feature logic to a check-everything paradigm instead of doing
early returns, for the sake of easy to understand metrics.

privacy doc: http://shortn/_99lQLYJfL1

Bug: 1115259
Change-Id: I036a412104d9ccce885789637461314d50f1e967
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388270Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806701}

The issue below is mostly timeouts.
The relevant diff was to DrainWorklist which used to return true for
empty worklists, but now might return false.
The change to DrainWorklist was made to guarantee no draining is done
when we should yield (due to deadline or job scheduling). Before the
change we would also drain at least one item, which could take some
time. This CL adds a check for emptiness before the yielding check.
This restores previous behavior for empty worklists and avoid
draining an object if we should already yield.

Bug: 1127888
Change-Id: I726d205516bc23b7a2345e5e68e35e08d866f722
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409944Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806700}

We no longer merge APKs - the build time saving it provided stopped
working some time ago due to additional dependencies between the ABIs,
and we just archive the symbols from 64-bit bots' 32-bit binaries
separately so there's no real need for the libs to be identical.

Remove the script to make it clear we don't support this any more.

Fixes: 1039881
Change-Id: I5f6f5e102b69518b737664011b7abeb78a40ba65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409924
Commit-Queue: Richard Coles <torne@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Auto-Submit: Richard Coles <torne@chromium.org>
Reviewed-by: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806699}

Pass in a SettingsLauncher when constructing ShareSheetCoordinator that
will eventually be passed to SendTabToSelfShareActivity.

Bug: 1090917
Change-Id: I0690a2b552503e95873b9aec1b993f1a18405476
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250699Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org>
Reviewed-by: Tanya Gupta <tgupta@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806698}

Add implementation to chrome://.

Add implementation to chrome-untrusted://.

Add tests.

Bug: b:162051831
Change-Id: I3749503e240a14b1d4ff76cfd3c477470ae704c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396089
Commit-Queue: Laurențiu Olteanu <lolteanu@google.com>
Reviewed-by: Oleh Lamzin <lamzin@google.com>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Mahmoud Gawad <mgawad@google.com>
Cr-Commit-Position: refs/heads/master@{#806697}

The NPE occurs with the following sequence:
1. show tab-modal dialog.
2. some portion of the containing view hierarchy is removed from a window.
3. dialog dismissed.
4. animation started in 1 finishes, triggering trying to use an object
   that was set to null.

Step 3 needs to cancel the start animation.

BUG=1127254
TEST=covered by test

Change-Id: I58c80c0a1e8330c0b87b2a56e228d67bc61b2cba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406933
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806696}