- 04 Oct, 2019 33 commits
-
-
Maksim Moskvitin authored
Due to not completed investigation about Nigori's not migrated to keystore following histograms were extended until 2020-02-01: Sync.EncryptEverythingWhenCryptographerNotReady Sync.ShouldTriggerMigrationAfterMigration Sync.IsNigoriMigratedAfterMigration Sync.NigoriMigrationTrigger Sync.NigoriMigrationAttemptedBeforeNotMigrated Sync.NigoriMigrationReason Bug: 944831, 995518, 995517, 995510, 995487 Change-Id: I89e834d31a1d41b37f1f070f537d15ae73ee0f18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829351 Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#702676}
-
Joe DeBlasio authored
This CL adds ю to the set of Cyrillic characters that look like Latin characters. It also adds a missing period. Bug: 884693 Change-Id: I13b988e9a03172b143dd23ea83dab08515ad1aeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838476 Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#702675}
-
Maksim Moskvitin authored
The histogram was used for investigation of not completed Nigori migration to keystore. Since it handles very specific corner case and no interesting samples were recorded so far, we don't need to further extend it. Bug: 944831, 995520 Change-Id: I17e73ff7d33491fbc498989a87f85d6ebfd6567a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831909 Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
Matt Falkenhagen authored
It never changes. Change-Id: I04f9f7d6d639fc4d67108b1f4741f8a334a1be56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837562Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#702673}
-
DongJun Kim authored
This patch is for replacing Platform::Current()->GetURLLoaderMockFactory() calls with "url_test_helpers::" under "third_party/blink/renderer". It is initial stage of integrating all helper classes to frame_test_helpers. We will be able to remove url_test_helpers::calls in the future. Bug: 751425 Change-Id: I3c4d92830423f298ca66edd1365a7a7b4bd2bb63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746120 Commit-Queue: DongJun Kim <djmix.kim@samsung.com> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#702672}
-
Mohsen Izadi authored
Before r687426, an incorrect render pass id was inserted into the set of passes with pixel-moving-background filter. This set, along with other things, was to used to determine if a surface has moved pixels, but because it had incorrect values, it didn't have any contribution to that. r687426 fixed that, but it has caused a severe performance regression when background blur is enabled for shelf by expanding ash frame damage to the whole screen. This CL is essentially reverting that. The simple revert is not possible as the code has moved around and changed. This CL removes the code equiavlent to the contribution that set had in determining if a surface has moved pixels. BUG=1008740 Change-Id: I3c8db1a074d70415cd2b15cbca14848a15093ccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833076Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#702671}
-
Bettina authored
Add support for password protection modal warning and pinging when a saved password is reused and the experiment is on. Bug: 1010764 Change-Id: I2eabc3d63e2c1dec6d2bb4d7430b29d4df1ef8a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838211 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#702670}
-
Frank Liberato authored
Adds the feature D3D11VideoDecoderCopyPicture, which lets the decoder copy pictures if binding is not supported. This CL also adds media logging to indicate which mechanism was chosen for the playback. Change-Id: I538dda066561efd7747d5ccfbec6c095e1251016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838680Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#702669}
-
Dan Beam authored
Depends on https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1836607 This will currently only check for FIXED=, but could soon also check for BUG=, TBR=, and/or R= when folks decide we're ready to more fully deprecate these syntaxes. Bug: monorail:4470 Change-Id: Ia5cb39ea3cd43ecde7982688bef81f2ac0187780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837219Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#702668}
-
Bill Budge authored
- Many small reads and writes are observed, especially with the JavaScript code cache. Detect these and write all data into the entry's stream 0, and clear stream 1. When reading, detect the entry size and for small data, skip the stream 1 read and copy the data from the stream 0 read. - Changes the stream 0 data (again) to a header with response time and data size. The data size, while not strictly necessary right now, will be needed if we implement de-duplication of identical entries stored by multiple origins. We can add the code hash to this header, and the size field will disambiguate between small entries and large de-duplicated entries where we use the hash as a key to the data. - This change should make small reads faster than before, as synchronous completion of stream 0 reads is observed. Otherwise, there should be no change in performance. - Renames the buffers and completion callbacks to reflect small/large data distinction. Bug: chromium:992991 Change-Id: I6fb5337ef1e4148dd9f300f0a8c85acb401be62e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834562 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#702667}
-
Renjie Tang authored
Change-Id: Ie2429ec802e315b76f4b4a45b2f57d7064664dc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838671Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#702666}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/65a77757a2cb..68d22ef43dcd git log 65a77757a2cb..68d22ef43dcd --date=short --no-merges --format='%ad %ae %s' 2019-10-03 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-03 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-03 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-03 brianosman@google.com Make SkIPoint x() and y() constexpr 2019-10-03 kjlubick@google.com speculitive fix for flutter roll 2019-10-03 jvanverth@google.com Reland "Add less granular version of GrFence for older Metal versions." 2019-10-03 bsalomon@google.com SkIRect::makeOffset(SkVector) 2019-10-03 bsalomon@google.com Reland "Reland "SkSurface asynchronous read APIs allow client to extend pixel lifetime"" 2019-10-03 brianosman@google.com Don't try to build skparagraph on windows component builds 2019-10-03 brianosman@google.com Remove some unused functions (and an enum) from GrTypesPriv 2019-10-03 kjlubick@google.com [canvaskit] Speculative fix for external wasm library 2019-10-03 kjlubick@google.com [canvaskit] Initial addition of SkParagraph 2019-10-03 brianosman@google.com Remove old SkSL JIT and cleanup include files a bit 2019-10-03 bungeman@google.com Revert "Hold onto FcConfig in SkFontConfigInterface_direct." 2019-10-03 robertphillips@google.com Add SkSurfaceCharacterization::createColorSpace 2019-10-03 bungeman@google.com Hold onto FcConfig in SkFontConfigInterface_direct. Created with: gclient setdep -r src/third_party/skia@68d22ef43dcd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: chromium:973403,chromium:1004254,chromium:1004254 Change-Id: I02034ee95cc546c3a2f0764724675231723c6837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838702Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702665}
-
Etienne Bergeron authored
This CL is extending the expiracy of these histograms: RenderTextHarfBuzz.GetFallbackFontTime RenderTextHarfBuzz.ShapeRunsWithFallbackFontsTime RenderTextHarfBuzz.GetFallbackFontsTime R=asvitkine@chromium.org Bug: 1006993 Change-Id: I0a0561a13e74b0ab669da01c79b8c29076642a37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837375Reviewed-by:Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#702664}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e90e5fe206c9..f3c5fefedbf9 git log e90e5fe206c9..f3c5fefedbf9 --date=short --no-merges --format='%ad %ae %s' 2019-10-03 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-03 ehmaldonado@chromium.org git-cl: Clean-up 2019-10-03 ehmaldonado@chromium.org git-cl: Better warning message for legacy buckets. 2019-10-03 ehmaldonado@chromium.org depot_tools: Run git_footers_test on Python 3. 2019-10-03 ehmaldonado@chromium.org depot_tools: Run git_common_test in Python 3 2019-10-03 ehmaldonado@chromium.org git-cl: Set CC from watchlists only on first upload 2019-10-03 dbeam@chromium.org Make presubmit bark at FIXED= in CL description 2019-10-03 dbeam@chromium.org Support "Fixed:" syntax in BugsFromDescription() 2019-10-03 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@f3c5fefedbf9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:976104,chromium:1009809,chromium:1009809,chromium:1010499 Change-Id: I069b1442b937fdd975e68fb28625182d750e9116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838761Reviewed-by:
-
dpapad authored
Bug: 1003433 Change-Id: Ib6f675338ddea2c5239325349ce07f2f97c67d96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838995 Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#702662}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/19400f0641be..d897a1016473 git log 19400f0641be..d897a1016473 --date=short --no-merges --format='%ad %ae %s' 2019-10-03 primiano@google.com Merge "build: gcc9/gcc6 support and cross fixes" 2019-10-03 primiano@google.com Merge "Remove perfetto_src_tracing_ipc static lib target" 2019-10-03 lalitm@google.com Merge "traceconv: add support for printing traces with compressed packets" 2019-10-03 lalitm@google.com Merge "trace_processor: implement "hash" sql function" 2019-10-03 ssid@google.com Merge "Parse process descriptor to set process names" Created with: gclient setdep -r src/third_party/perfetto@d897a1016473 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I922d0e531cb0231b229627d415540cf927854c22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838368Reviewed-by:
-
Peng Huang authored
This CL also turns on Pixel_CanvasDisplayLinearRGBAccelerated2D test Bug: 974383 Change-Id: I6401731f3630a4a54825486eeea793ab05472266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834676Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#702660}
-
Andrew Grieve authored
Bug: 982762 Change-Id: Ic29c8ab1f5bbdd55cc88cd1ae73194cb6b12aa95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836980Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#702659}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c847a75f95be..1f08ab28305d git log c847a75f95be..1f08ab28305d --date=short --no-merges --format='%ad %ae %s' 2019-10-03 jmadill@chromium.org Re-land "GN: Componentize vulkan back-end build." 2019-10-03 geofflang@chromium.org GL: Refactor BlitGL program types into tuples of enums. 2019-10-03 timvp@google.com Only enable shader array size restrictions for HLSL 2019-10-03 jonahr@google.com Keep state up to date after bindBufferBase/Range Created with: gclient setdep -r src/third_party/angle@1f08ab28305d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Bug: chromium:990368 Change-Id: Ic934880752c80bbeb26e261da2d68a64aa17d028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838704Reviewed-by:
-
John Abd-El-Malek authored
This is a reland of aaa2ec5c with fix from patchset 1 to 2 due to conflict with r702520. Original change's description: > Add weblayer browser_tests APK so we can run the tests on Android. > > The Shell C++ class isn't used on Android (unlike in content_shell) because we want to consume WebLayer there using the idiomatic Java API. At the same time, we want to write browser tests the same way for all platforms. So fake this by creating a Shell that reuses the existing BrowserController class that was created by Java. > > Change-Id: I946957f39eb79cff2e84c8abda56eed98b28d0a0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815884 > Reviewed-by: Clark DuVall <cduvall@chromium.org> > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702563} TBR=cduvall@chromium.org Change-Id: I425b7b15d9f742a25a5b7c9dd306067ca29e551b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838953Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#702657}
-
Hesen Zhang authored
- Proto change for custom suppresion duration support in impression. Bug: 1005954 Change-Id: I309d1579aea526361e1bd7fd6828fb8ad5d77416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836996Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#702656}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f585476f768e..2fe87ab48664 Created with: gclient setdep -r src-internal@2fe87ab48664 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ifddb9fe77d580379c1ed05ceec75656106a48635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838150Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702655}
-
John Budorick authored
Bug: 922145 Change-Id: I51fa49a5bad90a46c57778829d67d5813af1a199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838533Reviewed-by:
Andrew Luo <aluo@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#702654}
-
Michael Liao authored
Changes: - Infobar buttons are keyboard accessible Infobar button focus: https://imgur.com/a/z9r8wvt Reduced button size and added margin (current implementation): https://imgur.com/ZElowjJ Bug: 963183 Change-Id: Ied028e357be961cc70fde45b952ce8dbf4a7c384 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657229 Commit-Queue: Michael Liao <michael.liao@microsoft.com> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#702653}
-
Darren Shen authored
Measure the time it takes for the extension to handle a key event. Bug: 1009903 Change-Id: I4099ab7071d0cbbb414e534b3790d36763553d14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832854Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#702652}
-
Istiaque Ahmed authored
Right now they are not aligned and since guard names are typically long, aligning them *might* be helpful to some. Example: Header using the wrong include guard name FOOBARX_H_ foobar.h:1 *************** Expected: u'FOOBAR_H_' Found: u'FOOBARX_H_' *************** With the CL: *************** Expected: u'FOOBAR_H_' Found: u'FOOBARX_H_' *************** Bug: None Change-Id: I4c51b602a8da3bcb2db405def2d6193519cdea87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836001Reviewed-by:
-
Kevin Bailey authored
When we try to open a singleton tab from a tab-less window (can't open new tabs), it won't search for that singleton in the window that it eventually opens the tab in, and thus could open a second copy in that window. This CL causes it to first search more broadly for singletons from tab-less windows. This should cause it to find the singleton in that situation. Bug: 939388 Change-Id: I96ff82925382e1db545b078b17cade11998711c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837972 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#702650}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/43e91961..5fb11187 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia03b0b0aef2a375f5ec48e7c4abcc2595bd6b393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839052Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702649}
-
Peter Kasting authored
Bug: 1005568 Change-Id: Ieefa04403bfa29bb1c93de5316375fad9205b113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836714Reviewed-by:
-
Jun Mukai authored
This clears the visibility of search results and assistant, while the visibility of horizontal page container (i.e. apps grid) remains. I thought SetActiveState() will update that, but actually it does nothing if the target page is not visible. As the result, this can cause nothing to be shown in the app-list. BUG=b/142069648 TEST=manually, app_list_unittests Change-Id: I6e50b7e1b2f2234bd347ac5b7fdef35ecbe8522d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838303Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#702647}
-
John Budorick authored
Bug: 922145 Change-Id: Iabea0d27059ad64d76a72f80b4a3d88e97e6f6f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836598Reviewed-by:
-
Xianzhu Wang authored
The meaning of the parameter was not obvious at callsites, confusing with layer's element id. Also the parameter was used in tests only, and we already have SetScrollElementId() for the same purpose. Change-Id: I62b0b6ad732389b419f351ac266cfdec73742fdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839034 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#702645}
-
Ian Prest authored
When UIA was enabled, Narrator was timing out because it calls TextRange::GetAttributeValue a lot when trying to navigate between paragraphs. This function was iterating using AXRange, which is relatively expensive. However, since we're just collecting text attribute values, we don't actually need to iterate over all the text positions... we just need to iterate the anchor positions. This change also introduces a test-case for GetAttributeValue. Bug: 1011057 Change-Id: I624e5fccefe88918ad289c0185a501ef290bde48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838373 Commit-Queue: Ian Prest <iapres@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#702644}
-
- 03 Oct, 2019 7 commits
-
-
Aidan Beggs authored
of GetReputationStatusWithEngagedSites to make more sense. This CL removes an extraneous comment about skipping top domains. It doesn't make sense to pass DomainInfo to GetReputationStatusWithEngagedSites, when this method can easily calculate that information, and its caller, GetReputationStatus, never uses this information outside of passing it on. This CL also includes fixes a few transitively included header files. Change-Id: I528d1f22aaee2b46d8758fec2dfa0e7185f3b419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838535Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Aidan Beggs <beggs@google.com> Cr-Commit-Position: refs/heads/master@{#702643}
-
Charles Zhao authored
Some of the tab discarder code are not used any more. (1) We stop recording total_tab_count and mru_index in the ForegroundedOrClosed event because we think it makes more sense to capture these in the TabMetrics event which we are already doing. Related changes include: (1.1) Deprecating MRUIndex and TotalTabCount in the ukm event ForegroundedOrClosed. (1.2) Removing mru_index and total_tab_count from ForegroundedOrClosedMetrics (1.3) Stopping observing WillCloseAllTabs and CloseAllTabsStopped (1.4) Removing TabActivityWatcher::all_closing_tabs_ (2) LogOldestNTabFeatures() is also removed because it is unused. Bug: 1007136 Change-Id: I25a7b9dbd471804d4680db2e95e80646ca1acb50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817871Reviewed-by:Charles . <charleszhao@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#702642}
-
Steven Bennetts authored
This will significantly reduce the amount of includes required when building ash_unittests and chrome. Bug: 996418 Change-Id: Ic9988b1d144f0c422b63d68aafcee20f7860e41c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836277 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#702641}
-
Lukasz Anforowicz authored
There was quite a bit of repetition in ChromeContentBrowserClient::CreateThrottlesForNavigation. This CL helps avoid this, by changing: std::unique_ptr<content::NavigationThrottle> foo_throttle = FooThrottle::MaybeCreateThrottleFor(handle); if (foo_throttle) throttles.push_back(std::move(foo_throttle)); to: MaybeAddThrottle(&throttles, FooThrottle::MaybeCreateThrottleFor(handle)); Bug: 1003957 Change-Id: I6b9d110f101e246b4f8e70b242f8d20798b3aadc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838911 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#702640}
-
Tommy Steimel authored
This CL makes the dismiss X focusable. This fixes an issue where a user could not dismiss with the keyboard. Bug: 1011062 Change-Id: Id35723360abd4619096f1e3a57ec0c3412af32fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838295Reviewed-by:
Jazz Xu <jazzhsu@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#702639}
-
Robert Liao authored
This is better served with a FillLayout and Bounds Change View Observer. BUG=1005568 TEST=browser_tests AppWindowBrowserTest.* Change-Id: I7c93be420241fc95c67479ae14a6c8a49d075890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827943 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#702638}
-
minch authored
Bug: 1002733 Change-Id: Ia01ca067072f2383b76571afb1ca4f864b60c8f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836851 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#702637}
-
