- 17 Apr, 2020 40 commits
-
-
Philip Rogers authored
This test is flaky on all platforms: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_web_tests&tests=media%2Ftrack%2Ftrack-cue-rendering-position-auto-rtl.html TBR=sahel@chromium.org Bug: 979323 Change-Id: I85d7fa4a5959c612e0eed4512cb5f5613ffe3f4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155067Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#760167}
-
dpapad authored
Bug: 1069258 Change-Id: I1c29bad8bb8e320256079f0ac2bfe42b1f6ce33a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152900 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#760166}
-
Lei Zhang authored
Automatically reset the |in_paint_| boolean when DoPaint() finishes, instead of doing it manually. Change-Id: I6049a728f05a691a36ece682062d8a149c4a062b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154232Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#760165}
-
Caitlin Fischer authored
Also cleans up the relevant code in the fieldtrial testing config. Bug: 978849, 1006806 Change-Id: Iecd7f06dd245dbbe9bfca17523b3ebafbc98d372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154527 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#760164}
-
Lei Zhang authored
PrintCompositorImpl ended up with 2 CompleteDocumentToPdf() methods, which is confusing. The first is a required PrintCompositor interface impl. The second is a private method that is only called by CompleteDocumentRequest(). Since CompleteDocumentRequest() is just a minimal wrapper around the private CompleteDocumentToPdf(), merge the two and avoid the confusion. Also remove some methods declared in the header but never defined. Change-Id: I19832cb994a23a02dd7f18ad1757937576bd498c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152919Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/888c0fe76833..e2686734ac51 git log 888c0fe76833..e2686734ac51 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 miladfar@ca.ibm.com Make fetch compatible with py 3.5 Created with: gclient setdep -r src/third_party/depot_tools@e2686734ac51 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I1773a87368d0600993e92dec903a112b846d56fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154973Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760162}
-
Sammie Quon authored
Test: none Bug: 1056490 Change-Id: Ice9fef7222f5af17725dd3812ff633b0fa0a8f92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131151 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#760161}
-
Mugdha Lakhani authored
This is so PageInfoController, which will be componentized soon, can continue to use CookieControlsObserver. See https://chromium-review.googlesource.com/c/chromium/src/+/2151455 for how I build upon this change. Bug: 1052375 Change-Id: I156489282000e92b0a93d6abf5abb5c05d3d2918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152829 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#760160}
-
Roman Sorokin authored
Bug: 1067260 Change-Id: Ic86579fd50c5815c9adadbd3feade22cbd1c37a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144146Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#760159}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/af564a5d0b8b..414782d132e8 git log af564a5d0b8b..414782d132e8 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 bsalomon@google.com Disable testing of D3D9 ANGLE backend on NVIDIA 2020-04-17 mtklein@google.com refactor arm instructions 2020-04-17 mtklein@google.com set up stack frames on aarch64 2020-04-17 michaelludwig@google.com Revert "Respect wrap mode when decimating for blur" Created with: gclient setdep -r src/third_party/skia@414782d132e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: I6525aebde281b3b87a28cfc96fd7f79b92d610f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154970Reviewed-by:
-
Alex Newcomer authored
Focus should be NavWidget->HotseatWidget->StatusAreaWidget. This was missed when we split the shelf into multiple widgets. Bug: 1060338 Change-Id: Ic1d4e259e94338c7110a712bdd70ade147b6986c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153320Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#760157}
-
Eric Orth authored
Split the entry into two, one for autoupgrade and one for UI selection, and remove the no_ecs option from the user-selected one. That parameter was originally added to maintain same-behavior on upgrade, but if it's not an upgrade scenario, the parameter should only be used if added by advanced users through manual URL entry. Bug: 1065338 Change-Id: I52fd4d346595cff78681ccf6f29fd03013c815de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154846Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#760156}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ec7bd4a323c6..15a15152f054 git log ec7bd4a323c6..15a15152f054 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 jbudorick@chromium.org devil: add dependency update script and update chromium deps. Created with: gclient setdep -r src/third_party/catapult@15a15152f054 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1067712 Tbr: wenbinzhang@google.com Change-Id: I7e3d1bc5e2ef13e7bd851cb8ff4b0ce86b80677b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153020Reviewed-by:
-
Devlin Cronin authored
Add a new histogram to track the invocation source for extension toolbar actions. This can include: - The main toolbar - The new extensions menu - The old overflow menu (in the 3-dot menu) - A programmatic API call (currently limited to allowlisted extensions). Bug: 1064111 Change-Id: I373768ba97c67d4b80bdc56585fd5a8e6c5163cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147685 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#760154}
-
Robbie McElrath authored
This CL introduces a SiteSettingsPrefClient interface so site_settings code can access native prefs without depending on Clank's PrefServiceBridge. This is a temporary class to provide access to prefs until PrefServiceBridge is properly componentized. Bug: 1058597 Change-Id: I92c6566e71907646e053eaaa2d7a082fb4b21a5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153787Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#760153}
-
Devlin Cronin authored
ToolbarActionViewController::WantsToRun() is only implemented by ExtensionActionViewController, and is never used outside of tests. Remove it, instead using only the PageActionWantsToRun() and HasBeenBlocked() methods (which are isolated to ExtensionActionViewController instead of exposed on the base class). Bug: None Change-Id: I0d8777785d1a67d1e36f00ee8d3e7bc844c6fdd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1132250 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
-
Todd Sahl authored
Modify the external protocol launch prompt behavior, specifically the behavior of the checkbox that allows the user to opt out of future prompts. Today that opt-out applies universally for a protocol, across all origins. The new behavior is that the opt-out applies only for the current {protocol,origin} tuple. The checkbox is only shown for trustworthy origins, and only if the relevant group policy is not explicitly disabled. This change completely removes the old exceptions and does not migrate them. These old exceptions are from a privacy/security point of view "opt-ins", i.e. they are a relaxation of the default security settings. Clearing the old exceptions recovers users who had encountered the inferior version of this prompt in the past, and gets them into a known safe state. Bug: 1065116 Change-Id: I6c81857894ca479ac723aa642d6ed6795e204f59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124967 Commit-Queue: Todd Sahl <toddsahl@microsoft.com> Reviewed-by:Balazs Engedy <engedy@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Cr-Commit-Position: refs/heads/master@{#760151}
-
Hidehiko Abe authored
To fix build for lacros experiment. BUG=chromium:1043804 TEST=Build locally Change-Id: I164606313cfc1bd7be154b1b811f649d35950dc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154437 Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#760150}
-
Dominic Mazzoni authored
These were the final DumpAccessibilityTree tests that needed to be migrated. They were previously excluded because of an Android issue. Move back the remaining tests to the correct place in the file and get rid of the temporary subclass. For context, this is an incremental step towards eventually trying to include everything in the accessibility tree, rather than having some AXObjects that are "skipped". Bug: 1063155 Change-Id: I6b9363f6cae4020a6263b9d9ada722834849ec94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141219Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#760149}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b613e3ab6b71..00032698ac99 git log b613e3ab6b71..00032698ac99 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 philipel@webrtc.org Clean up old GoPs when the RTP sequence number jump. 2020-04-17 mbonadei@webrtc.org Remove DetermineIceRole workaround. 2020-04-17 hbos@webrtc.org [Adaptation] Move VideoStreamAdapter to call/adaptation/. Created with: gclient setdep -r src/third_party/webrtc@00032698ac99 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1065699,chromium:628676 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ibb7ef90b09b12467be1a464ed50b0167139f4214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154966Reviewed-by:
-
Martin Kreichgauer authored
This reverts commit 1101e55e. Reason for revert: The test failure appears unrelated to me. Original change's description: > Revert "bluetooth: add BluetoothAdapter::IsPeripheralRoleSupported()" > > This reverts commit ba7954e5. > > Reason for revert: This probably caused the failure in > DevToolsBeforeUnloadTest.TestUndockedDevToolsClose > https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8882815412590626512/+/steps/browser_tests_on_Windows-10-15063/0/logs/Deterministic_failure:_DevToolsBeforeUnloadTest.TestUndockedDevToolsClose__status_FAILURE_/0 > > > Original change's description: > > bluetooth: add BluetoothAdapter::IsPeripheralRoleSupported() > > > > It appears that on Windows, Bluetooth hardware does not generally > > support the BLE peripheral role (i.e. BLE advertisements). Add a method > > to BluetoothAdapter that returns the > > BluetoothAdapter.IsPeripheralRoleSupported property [0] on WinRT and > > true everywhere else, so that client code can detect these cases. > > > > [0] > > https://docs.microsoft.com/en-us/uwp/api/windows.devices.bluetooth.bluetoothadapter.isperipheralrolesupported > > > > Bug: 1069140 > > Change-Id: If8f2f448f30db6aaf720c10e00391dea3f65944e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152892 > > Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> > > Reviewed-by: Reilly Grant <reillyg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#759836} > > TBR=reillyg@chromium.org,martinkr@chromium.org > > Change-Id: I993fe1e58bf4704977cd07b18cf61aba04f402ce > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1069140 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153434 > Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759999} TBR=reillyg@chromium.org,mamir@chromium.org,martinkr@chromium.org Change-Id: I2694e301350b8fe4be3d77480ae2437d46174582 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1069140 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155066Reviewed-by:
Martin Kreichgauer <martinkr@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> Cr-Commit-Position: refs/heads/master@{#760147}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6da120098f37..a5ce9072b623 git log 6da120098f37..a5ce9072b623 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 simonmacm@google.com Merge "Add a probe to read the display state at the start of a trace" Created with: gclient setdep -r src/third_party/perfetto@a5ce9072b623 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I47d3b67249b1e77ff89a09dafae868040e2977c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154968Reviewed-by:
-
Rune Lillesveen authored
Change-Id: I1b823c2ec2c99c48fb7cac8c80a73b97bf07d0b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153048Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#760145}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 13fd33e4. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 6c8523d2 "[scroll-timeline] Implement element-based scroll offset" 4de68d38 "fixup! [css-grid] Migrate flex-sizing-columns-min-max-width.html to WPT" 66b7c423 "[css-grid] Migrate grid-content-alignment-with-span-vertical-rl.html to WPT" 6bdfbb8c "[css-grid] Migrate grid-container-margin-border-padding-scrollbar.html to WPT" 2b6bab57 "Fix overscroll behavior manual test automation script" 51dbd7f7 "[css-grid] Migrate grid-automatic-minimum-for-auto-columns to WPT" 4f37ace8 "[css-grid] Migrate grid-container-percentage-rows.html to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: Ief16e74eddf8d80d1e66faaaccc567bf4925d42d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153273Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760144}
-
Joshua Berenhaus authored
Add chromium metrics watch alias to metrics watchlist Change-Id: Iff932b10891ac905a3bc5afd598fe7fb09e063c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153929 Auto-Submit: Joshua Berenhaus <joshber@microsoft.com> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
Egor Pasko authored
CachedMetadataHandlers for inline scripts should not be discarded as part of the experiment because: 1. they were not found to occupy a lot of memory in local experiments 2. there is no mechanism to prevent them from setting the timestamp again and rewriting the cache on disk, which is harder to analyse and imples unnecessary CPU/disk usage Ignoring the discarding for SW scripts just for the reason (1) above and for consistency, to make it easier to reason about. Bug: 1045052 Change-Id: I010037fad0a1354e424fa2cab3e0d48db5a033ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144107Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#760142}
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: I87bb7d17db0961c30d745d174ed31485b128c555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154727Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760141}
-
Alexander Surkov authored
AccessibilityTreeFormatterBrowser is used by AccessibiltiyTreeFromatterBlink only. No point to keep these classes separate. Bug: 1070311 Change-Id: Iccf8301b0ab4f235f3933b701873b5e36576b8cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151704 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#760140}
-
Sahel Sharify authored
http/tests/security/frameNavigation/xss-ALLOWED-parent-navigation-change.html flakes on Mac 10.13 as well, Example build: https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests/23868 TBR: szager@chromium.org Change-Id: I38620b071a1acdb7d0b98ef022cc4062a2304c6f Bug: 1008826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154760 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
-
Alex Turner authored
Bug: 1068386 Change-Id: I3562631bcae9c74415363d0ea595ec33d76a4c65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138593Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#760138}
-
Wan-Teh Chang authored
This allows us to display an AVIF image in the browser using the file: URL. Bug: 1071484 Change-Id: Iea6524f848a7e74b07005a0bedf2ea3a1320807f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153331Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#760137}
-
Elly Fong-Jones authored
Bug: 1011446 Change-Id: Ia2227f00e07d6f1cb26f55f52df571383a8e8137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154728Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#760136}
-
Michael Lippautz authored
This reverts commit bde0ab78. Reason for revert: Possibly causing https://bugs.chromium.org/p/chromium/issues/detail?id=1071874 Original change's description: > heap: Remove GetHeapObjectHeader from mixins > > The methods in the macro are put on every GarbageCollectedMixin which > is expensive in terms of binary size. The HoH getter can be replaced > with GetTraceDescriptor(). > > Change-Id: I0daaf3fc51a95f71baf7f6c7bed387e94963601f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139758 > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#760049} TBR=haraken@chromium.org,mlippautz@chromium.org Bug: chromium:1071874 Change-Id: I7d00fe89223ae32c7a3ad0d5f28f2e056eca6fb8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154947Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#760135}
-
Ian Wells authored
Also add iwells to the feed watchlist. Bug: 1071906 Change-Id: If274e470d9adda8995815122b2e12cd3348be04e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154851Reviewed-by:
Ian Wells <iwells@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#760134}
-
Theresa Wellington authored
Explicitly update the info icon visibility when the history backend alerts that whether the user has other forms of browsing data has changed. This fixes a bug where sometimes the info icon wouldn't appear until after a user scrolled for users who had previously chosen to hide history info. BUG=1071468 Change-Id: I293e78b46fd6fbe5fd8200cbac0bfb7dfc937f3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153930Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#760133}
-
Anastasiia Nikolaienko authored
Update strings on 'info for parents' screen in EDU account addition flow. Bug: 1071144 Change-Id: I4330299f95873c101359028bff9027467c021454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153049Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
-
Yulun Wu authored
Moving logic out of shelf_layout_manager and into a separate controller class. Tests for this behavior are in shelf_drag_handle_unittest.cc: will be refactored into in_app_to_home_nudge_controller_unittest.cc in a follow up CL. Bug: 1062690 Change-Id: Icb44ddcec0a89be131132723d4db0735a4e50825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152953Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#760131}
-
Gang Wu authored
Change-Id: I9966644225507f51d5d22189b5e391491ed03587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153569Reviewed-by:
Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#760130}
-
Devlin Cronin authored
These are no longer being monitored. Remove the code and update the histograms.xml file. This removes the following histograms: - ExtensionInstallSigner.InvalidCount - ExtensionInstallSigner.SecondsSinceLastRequest - ExtensionInstallSigner.RequestCount - ExtensionInstallSigner.ResultWasValid - ExtensionInstallSigner.UptimeAtTimeOfRequest - ExtensionInstallSigner.FetchSuccess * - ExtensionInstallSigner.GetResponseSuccess * - ExtensionInstallSigner.ParseJsonSuccess * - ExtensionInstallSigner.ParseFieldsSuccess * *These histograms were never added to histograms.xml. Bug: 878095 Change-Id: Ib272b4587c86f2f7693b387bcf6326c56766561d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150005 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
-
David Bokan authored
Prior to https://crrev.com/2d6fe2bcbcb3f2, when a scroll animation was created on the inner viewport, we would latch to the inner viewport scroll node by setting it as the currently scrolling node. This wasn't intentional as the inner viewport should never be latched; the outer viewport represents all viewport scrolling so that scrolling code knows to use the cc::Viewport class to correctly distribute between inner and outer scroll nodes. This was part of the overloaded nature of CurrentlyScrollingNode that the above CL and several follow-ups addressed. The above CL missed an important case: when a scroll updates an in-progress inner viewport animation, it must use the animating ScrollNode, the inner viewport scroll node. After the CL, an animating inner viewport sets the CurrentlyScrollingNode to the outer viewport and incorrectly uses that to update an in-progress curve. In LayerTreeHostImpl::ScrollLatchedScroller, in the case of an existing scroll animation, we call ScrollAnimationUpdateTarget on the CurrentlyScrollingNode. This mostly doesn't cause an issue as the animation knows which ScrollNode it's mutating. However, the passed in ScrollNode is used to clamp the updated target offset which can lead to incorrect scroll offsets. In the linked bug, since outer viewport has no horizontal overflow, the maximum scroll offset is 0 in the x-axis. Thus, when the inner viewport animation is updated, any x component will be zeroed out due to clamping, causing horizontal scrolling even if the update was only vertical. This CL fixes the issue by exposing and using the scroll node that the animation is bound to when updating an animation curve. Bug: 1070561 Change-Id: I7bf1993e1ffc4e06447dcb16e57f193c47fb2391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151005 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#760128}
-
