- 27 Jun, 2018 40 commits
-
-
David Roger authored
Invalidated cookies were not handled correctly. This CL adds proper support for them. TBR=treib Bug: 854799 Change-Id: Iad3ee729172a7e44d737b25fb665f0009d78de84 Reviewed-on: https://chromium-review.googlesource.com/1110218 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#570825}
-
Eli Ribble authored
This is one more step towards making the bluetooth service fully async. Bug: 76155468 Test: chromecast/device/bluetooth::cast_bluetooth_unittests Change-Id: Icc9cc151fbf54c5686b56d40008f573fb85ea736 Reviewed-on: https://chromium-review.googlesource.com/1114221Reviewed-by:
Stephen Lanham <slan@chromium.org> Commit-Queue: Eli Ribble <eliribble@chromium.org> Cr-Commit-Position: refs/heads/master@{#570824}
-
Takumi Fujimoto authored
This CL adds a dialog that will pop up when the Media Remoting feature is about to kick in, to ask the user whether the feature should be enabled. This CL just adds strings/layout, so the dialog is not functional yet, and the code path to open it is missing. Screenshot: https://drive.google.com/open?id=12CVIusU7nNR-uALCrRThnJMynZpPqU27 Bug: 849020 Change-Id: I3c85b62df495fc699e5b600a0dbb54808a198daf Reviewed-on: https://chromium-review.googlesource.com/1095571 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#570823}
-
James Wallace-Lee authored
End the test when the CSS transform is reflected in the dump, rather than by using a separate label. Bug: 856367 Change-Id: I7ba49d483705d2ad04d1bc0a10a2ce3546e2c626 Reviewed-on: https://chromium-review.googlesource.com/1114353Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Cr-Commit-Position: refs/heads/master@{#570822}
-
Daniel Rubery authored
Also removed arraysize in this file, since it has been deprecated in favor of base::size(). Bug: 831394 Change-Id: I8b279a188d786f3ef234565de8e4647970b0f0ae Reviewed-on: https://chromium-review.googlesource.com/1114223Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#570821}
-
Florent Castelli authored
Extracts RTCRtpSendParameters from RTCRtpParameters. Extracts RTCRtpEncodingParameters from RTCRtpCodingParameters. Adds required to many fields and update tests accordindly. Bug: 803494 Change-Id: I416c0884abf15ab8d55ce5ae481f15ac8012c73d Reviewed-on: https://chromium-review.googlesource.com/1114844Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/master@{#570820}
-
jdoerrie authored
This change adds kpaulhamus@ and hongjunchoi@ as OWNERs for //device/fido. Both of them have numerous contributions to this folder and are very familiar with the codebase. Furthermore, both of them have obtained the required committer status. Bug: NONE Change-Id: Idfa3343e865f862288a214e06f0b065f205b6546 Reviewed-on: https://chromium-review.googlesource.com/1116921Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#570819}
-
James Wallace-Lee authored
Adds the helper function BlinkAXTreeSource::TruncateAndAddStringAttribute, which truncates string attributes when Blink's tree is serialized for accessibility. String attributes are truncated at BlinkAXTreeSource::kMaxStringAttributeLength bytes, currently set to 10000 bytes. Bug: 644805 Change-Id: Ibd1af03a77814aa524dcb067ad1be3f3f4291c8b Reviewed-on: https://chromium-review.googlesource.com/1113946Reviewed-by:
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/8648a64c83b5..583859d7395c $ git log 8648a64c8..583859d73 --date=short --no-merges --format='%ad %ae %s' 2018-06-24 marpan vp9: Fixes for lossless mode for real-time mode. 2018-06-25 marpan vp9-svc: Fix to frame dropping when layer is skipped. 2018-06-21 huisu Add a partition search breakout model 2018-06-20 jianj VP9 SVC: Add tests for layer sync on base layer. 2018-06-21 zoeliu Add extra altref option for hierarchical structure 2018-06-21 zoeliu Single out ref frame update functionality 2018-06-21 jianj Add capibility to configure decoder in encode tests. 2018-06-20 jingning Refactor block partition level rate distortion cost computation 2018-06-19 zoeliu Add bit allocation for hierarchical layer 2018-06-20 johannkoenig libyuv: remove problematic functions 2018-06-20 jingning Disable tpl model in high bd route 2018-06-18 huisu Add a partition search breakout model 2018-06-12 marpan vp9-svc: Add support for spatial layer sync frames. 2018-06-19 zoeliu Add hierarchical structure in GF group 2018-06-07 jianj vp9: Enable cyclic refresh for HBD in real-time. 2018-05-25 jingning Build temporal prediction dependency propagation 2018-05-30 jingning Refactor partition mode cost calculation 2018-06-12 huisu Improve the partition search breakout speed feature 2018-06-14 luc include msvc.h for snprintf support in benchmarks 2018-06-17 zoeliu Add update types for hierarchical refs (...) Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: I311600eed599ec41c6e6007c155dc3dbddfbd02d Reviewed-on: https://chromium-review.googlesource.com/1115799Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#570817}
-
Becca Hughes authored
Fixes a bug where safe areas are only sent to the main frame. This should be the current fullscreen frame. BUG=855721 Change-Id: I32fcf1190384bd9878711f7ae66e2fb4ea183df4 Reviewed-on: https://chromium-review.googlesource.com/1114144Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#570816}
-
Ryan Tseng authored
Bug: 856451 TBR: tandrii Change-Id: I65a66a6a33e7a9751f2106a1f94a6e0c32120230 Reviewed-on: https://chromium-review.googlesource.com/1117208Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#570815}
-
Sam McNally authored
Mime handlers create a nested WebContents to contain the mime handler extension. Currently, these run with a separate session storage namespace, resulting in session storage being cleared if a tab recreates a mime handler, such as due to a reload. Change mime handler WebContents creation to inherit the session storage namespaces of their embedders so the session storage behaves similarly to iframes within a single tab. Bug: 819761 Change-Id: I3b4f653836190ed86572eb12cdbeef3fbc157683 Reviewed-on: https://chromium-review.googlesource.com/1116633 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#570814}
-
John Abd-El-Malek authored
Also remove the custom URLLoaderFactory in content_hash_fetcher_unittest. This isn't needed anymore as TestURLLoaderFactory now supports Clone. Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Id70ec605886a6b0f2cb9bf7392fac4eff85fc1b3 Reviewed-on: https://chromium-review.googlesource.com/1115346Reviewed-by:
Doug Turner <dougt@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#570813}
-
Torne (Richard Coles) authored
The call to WebViewDelegate.getDataDirectorySuffix() was missing an API level check and only working correctly because the upstream version of the class was a stub that returned null - this broke non-P devices after upstreaming. Bug: 857066 Change-Id: I43e790e3b5ab9f8e26b35fa15c753ab0782a4342 Reviewed-on: https://chromium-review.googlesource.com/1117027Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#570812}
-
Andrew Grieve authored
* Most templates use a hard-coded list of build_utils.py deps. * A few use exec_script() when compute_inputs_for_analyze = true. Bug: 843562 Change-Id: I0bb1ca7927f7366d23c23b8beb56d39a22208a06 Reviewed-on: https://chromium-review.googlesource.com/1114122 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#570811}
-
Peter Kasting authored
Pre-refresh, during dragging, tabs could slide anywhere in the strip (from tab left = 0 to tab right = tabstrip width). In refresh, tabs should not drag over the frame grab width or a LEADING or TRAILING new tab button. This also prevents strange visual artifacts in TRAILING mode that currently happen because a tab can be dragged past the point where it's supposed to be allowed to remain visible. With the updated code, tabs can't be dragged this far, so the artifacts can't occur. Along the way, I moved the Finch feature for the new tab button position into the one function that uses it, because while trying to test locally by commenting out parts of that function, I kept getting "unusued variable" warnings. Bug: 852936 Test: On Mac with refresh enabled, dragging a tab to the right edge of the strip should not result in flickering/disappearing tabs. Change-Id: Idef63702d5c3161a38e1662feec8373239334c0d Reviewed-on: https://chromium-review.googlesource.com/1114299Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#570810}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b0de1093..56b60a2e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ib5be3feec7c019250980dc87c92183b40ec13934 Reviewed-on: https://chromium-review.googlesource.com/1117119Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570809}
-
Becca Hughes authored
This refactors the code that sends the safe areas moving it to WebContentsImpl which will be useful for metrics later on. BUG=855721 Change-Id: I9d4976ec9bdeddef3b0d8a1a824b8a65f78516ba Reviewed-on: https://chromium-review.googlesource.com/1112071Reviewed-by:
-
Marc Treib authored
In particular, this gets rid of ProfileSyncServiceStartupCrosTest, which was not meaningfully different from the non-Cros version. Also adds a few extra assertions and comments. Bug: none Change-Id: Iabba34647d084b1518a2cea239c9f25d463aa27b Reviewed-on: https://chromium-review.googlesource.com/1117073 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#570807}
-
Eugene But authored
Dismissing SSL interstitial may change SSL status, in which case WebStateImpl should call WebStateObserver::DidChangeVisibleSecurityState Bug: None Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If9737cfa13829f17c2f4d9b5d965df2197f71669 Reviewed-on: https://chromium-review.googlesource.com/1114839 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570806}
-
edchin authored
This CL adds keyboard shortcuts related to opening tabs to the tab grid. - Command + n = open new (regular) tab - Command + Shift + n = open new incognito tab - Command + t = open new tab in current window Bug: 818451 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iae029bf53f5a2d71c2fe569b6481ee9eeec98ef0 Reviewed-on: https://chromium-review.googlesource.com/1116257 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570805}
-
Ivan Sandrk authored
Currently managed Chrome OS devices support remote commands issued by the admin on CPanel. Add a command that wipes all the users off of the device when run (equivalent to removing all the user PODs manually from the login screen). Most changes are glue or wiring things through, main files are: - device_command_wipe_users_job - user_removal_manager More details at the design doc @ go/remove-users-command Bug: chromium:827467 Change-Id: I77a130bf4dda0757a60a141713baae27d2b5b5a2 Reviewed-on: https://chromium-review.googlesource.com/1107803Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#570804}
-
Oystein Eftevaag authored
NOTRY=true TBR=nednguyen@chromium.org BUG=857108 Change-Id: I6618a9fd72d4b618d6228d6ab1bc58b98c96664e Reviewed-on: https://chromium-review.googlesource.com/1117209Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#570803}
-
Jason Roberts authored
Bug: 856704 Change-Id: I48b28d389aa602718c5dae2afed98dc19322dd24 Reviewed-on: https://chromium-review.googlesource.com/1115356Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Jason Roberts <jasonroberts@chromium.org> Cr-Commit-Position: refs/heads/master@{#570802}
-
chrome://killWez authored
The implementation of this debug URL was changed in https://chromium-review.googlesource.com/c/chromium/src/+/907675 to one which _exit()s the process under POSIX, rather than self-terminating via kill(). Since we detect process kills (versus self-termination, crashes etc) by checking for SIGTERM, this broke chrome://kill. Fix chrome://kill by explicitly kill()ing the process, and structure the implementation to make clear that we need to simulate termination by a peer process, specifically. Bug: 806451, 854926 Change-Id: I0408dd1d248e04b3045f37d46051c220b33ab081 Reviewed-on: https://chromium-review.googlesource.com/1116076Reviewed-by:
-
Justin Cohen authored
Bug: 852705 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I611e9625e988e077f61e71e58a7f44b741a20eab Reviewed-on: https://chromium-review.googlesource.com/1116702Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
-
Scott Graham authored
This reverts commit 0895c797. Reason for revert: Missed a hardcoded gn location: https://crbug.com/857107. Original change's description: > Pull GN via CIPD package > > The gn binary will be downloaded into third_party/gn. This CL rolls > buildtools forward to a revision where gn is no longer in buildtools. > > Because buildtools has no way to cleanup after itself, add > build/util/gn_cleanup.py to delete the old binaries so that we don't > accidentally depend on them. > > Update mb.py to use the new location. > > Update explicit location in ios/web_view/BUILD.gn for the new location. > > Update explicit location in > tools/traffic_annotation/auditor/traffic_annotation_auditor.cc for the new > location. > > Update explicit location in tools/licenses.py with for the new location. > > Bug: 855791 > Bug: 794764 > Bug: 856883 > Bug: 856884 > Bug: 856878 > Bug: 856899 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I92c908faf4f868850eafa1b4adf6e7c33c365116 > Reviewed-on: https://chromium-review.googlesource.com/1112840 > Commit-Queue: Scott Graham <scottmg@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570792} TBR=dpranke@chromium.org,scottmg@chromium.org Change-Id: I89e180710b5ce483106fa3b4ff6e8dec06780c07 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 855791, 794764, 856883, 856884, 856878, 856899 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1117219Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#570799}
-
danakj authored
If the gpu process crashes, the viz service is gone and bitmaps need to be re-registered, but they are still valid bitmaps. So we can keep the ResourceId alive and not returned it as lost to the client in that case. R=kylechar@chromium.org Bug: 826886 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1ef6af3a90bf90310793fcdbbb70ea00a0d85d25 Reviewed-on: https://chromium-review.googlesource.com/1115591Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#570798}
-
Qiang Xu authored
changes: MagnifierType is only used in chrome/. This CL moves it to chrome/. TBR=emaxx@chromium.org Bug: none Test: compile Change-Id: I75241de96f77004b906cfb762829c9bd01e470b9 Reviewed-on: https://chromium-review.googlesource.com/1116760 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by:
-
gogerald authored
Bug: 856743 Change-Id: Icee41ddd6bd4d593ae19b12ac601644d0a004be1 Reviewed-on: https://chromium-review.googlesource.com/1115803 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#570796}
-
Adithya Srinivasan authored
Using a double timestamp is error prone and it's hard to tell which units are being used. Bug: 763980 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2bb9e1fba0df15be9954cf055abed78016c39c9a Reviewed-on: https://chromium-review.googlesource.com/1114180 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#570795}
-
Jonathan Backer authored
ContextState is meant to track GL state. It is used for virtual context switching and temporary changes to GL state (e.g. temporarily change GL state and restore back to ContextState). Whenever we call Ganesh we must assume that GL state has diverged from ContextSate. This CL does 2 things within RasterDecoder: (1) Whitelists certain commands as not caring if GL state has diverged from ContextState. This would be if the command doesn't access GL state (e.g. InsertSyncPoint) or is using Ganesh (RasterCHROMIUM). (2) Does a hard reset back to ContextState whenever the GL state could have diverged from ContextState and a command is not whitelisted. The purpose of the whitelist is to avoid unnecessary state resets on the common OOP-R codepaths. Correctness: - GLES2Decoder: The GL state matches the ContextState before and after a command is executed here. The interesting case is making a GLES2Decoder current. If using a virtual context, we will restore state appropriately when the GLES2Decoder is made current because of RasterDecoderImpl::GetContextState. - RasterDecoder: There are two cases to consider Case 1: Making a RasterDecoder current. If we are using virtual contexts, we will restore to |state_| and GrContext::resetContext because of RasterDecoderImpl::{GetContextState,RestoreState}. If not, we will restore to the previous GL state (either |state_| or GrContext consistent with previous GL state). Case 2a: Executing a whitelisted command: Either the command doesn't inspect/modify GL state (InsertSyncPoint, CreateAndConsumeTexture) or it requires and maintains that GrContext state tracking matches GL context state (e.g. *RasterCHROMIUM). Case 2b: Executing a command that is not whitelisted: We now force GL state to match |state_| with as necessary RestoreState(nullptr). This will GrContext::resetContext. Bug: 856219 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I85d9391f833760b37cb70d216e9e1e44ffe1c23f Reviewed-on: https://chromium-review.googlesource.com/1114136 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#570794}
-
Owen Min authored
Bug: 855378 Change-Id: I4c14ad013f891f6abe76604321c52e97cecaf874 Reviewed-on: https://chromium-review.googlesource.com/1115433Reviewed-by:
-
Scott Graham authored
The gn binary will be downloaded into third_party/gn. This CL rolls buildtools forward to a revision where gn is no longer in buildtools. Because buildtools has no way to cleanup after itself, add build/util/gn_cleanup.py to delete the old binaries so that we don't accidentally depend on them. Update mb.py to use the new location. Update explicit location in ios/web_view/BUILD.gn for the new location. Update explicit location in tools/traffic_annotation/auditor/traffic_annotation_auditor.cc for the new location. Update explicit location in tools/licenses.py with for the new location. Bug: 855791 Bug: 794764 Bug: 856883 Bug: 856884 Bug: 856878 Bug: 856899 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I92c908faf4f868850eafa1b4adf6e7c33c365116 Reviewed-on: https://chromium-review.googlesource.com/1112840 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
Previous CL crrev.com/c/775550 was supposed to be pure refactoring, but changed behavior that ComputeInlineBoxPosition no longer enters inline blocks, because the CL moved the branch handling atomic inlines above the branch that moves input position into inline blocks. This patch fixes the regression by moving the branches back to their old positions. Bug: 856417 Change-Id: I94a22259f723af11b701d3a1078e68b5729bb0d0 Reviewed-on: https://chromium-review.googlesource.com/1116357Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#570791}
-
Kouhei Ueno authored
This CL follows signed exchange spec change: https://github.com/WICG/webpackage/commit/3903da6e Bug: 803774 Change-Id: I7f122272cf93f46a26757b08fe8a9d80f0404518 Reviewed-on: https://chromium-review.googlesource.com/1114403Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#570790}
-
Kevin McNee authored
In EventFactoryEvdev::DispatchPinchEvent, we were attempting to set the scale for pinch begin (and end) events, instead of just pinch update events, which hits the DCHECK in GestureEventDetails::set_scale. Bug: None Change-Id: I6fc89469b4ec1ddc21f102cf3bb181e10243c545 Reviewed-on: https://chromium-review.googlesource.com/1114249Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#570789}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fa2ef190cd68..32dc063f6647 git log fa2ef190cd68..32dc063f6647 --date=short --no-merges --format='%ad %ae %s' 2018-06-27 lalitm@google.com Merge "trace_processor: cleanup code in trace parser" 2018-06-25 lalitm@google.com trace_processor: cleanup code in trace parser Created with: gclient setdep -r src/third_party/perfetto@32dc063f6647 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:80416541 TBR=perfetto-bugs@google.com Change-Id: I91d82b062e45888e587348cadc80a356a3124686 Reviewed-on: https://chromium-review.googlesource.com/1116818 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570788}
-
Emily Hanley authored
Bug: 840427 Change-Id: I1f11ed443c31afe50607cde766df13e610a07762 Reviewed-on: https://chromium-review.googlesource.com/1104793 Commit-Queue: Emily Hanley <eyaich@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#570787}
-
James Wallace-Lee authored
When a button's textContent changes, post a textChanged notification. A button's textContent is a child of the button container, but in the accessibility tree button elements cannot have children, so ChildrenChanged previously did not update the button. Bug: 793078 Test: DumpAccessibilityTreeTest.AccessibilityButtonContentChanged Change-Id: I2be389c77763cb60fd2fc9951070370856b0c894 Reviewed-on: https://chromium-review.googlesource.com/1110658 Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
-
