GitLab

Unify sandbox:: APIs to always take /proc/ file descriptors
instead of /proc/self/ or /proc/self/task/.

Moreover, require |proc_fd| arguments to critical APIs rather
than rely on the caller to perform the right checks.

A descriptor to /proc is a better choice than a descriptor to
/proc/self/* because it keeps the same semantics after a fork().

BUG=312380, 457377
TBR=nasko

Review URL: https://codereview.chromium.org/938223004

Cr-Commit-Position: refs/heads/master@{#317757}

This cl adds a gpu_perftests_apk target to build an apk for android.
It also adds a check that detects if the timings are valid and discards them if they're not.
The number of valid runs (where we could get timings) is printed out along the other perf results as "sample_runs".

BUG=423481

Review URL: https://codereview.chromium.org/944073005

Cr-Commit-Position: refs/heads/master@{#317756}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5108083..2bc1ff3

TBR=zmo@chromium.org,hiroshige@chromium.org

Review URL: https://codereview.chromium.org/935453003

Cr-Commit-Position: refs/heads/master@{#317755}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4d068d4..5108083

TBR=zmo@chromium.org,hiroshige@chromium.org

Review URL: https://codereview.chromium.org/945813004

Cr-Commit-Position: refs/heads/master@{#317754}

This CL adds support to setting properties to all requests which are used
by EntryUpdatePerformer.

TEST=google_apis_unittests
BUG=451113

Review URL: https://codereview.chromium.org/944413003

Cr-Commit-Position: refs/heads/master@{#317753}

This pulls in the following Native Client changes:

db9cc20: (kschimpf@google.com) Allow generation of trybots for sanitized toolchain.
0d8d330: (tfarina@chromium.org) More source_prereqs -> inputs changes.
db7f23a: (dschuff@chromium.org) Update newlib revision in COMPONENT_REVISIONS
88ba651: (dschuff@chromium.org) Update revision for PNaCl

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_arm_compile,linux_nacl_sdk_build

Review URL: https://codereview.chromium.org/951733002

Cr-Commit-Position: refs/heads/master@{#317752}

BUG=359210

Review URL: https://codereview.chromium.org/947673002

Cr-Commit-Position: refs/heads/master@{#317751}

BUG=461182
TEST=covered by RenderTextTest.Multiline_HorizontalAlignemnt

Review URL: https://codereview.chromium.org/915383003

Cr-Commit-Position: refs/heads/master@{#317750}

- Refine tabindex following visual and logical order
- Make the breadcrumbs focusable  (except the last one)

BUG=459693
TEST=manually

Review URL: https://codereview.chromium.org/947083002

Cr-Commit-Position: refs/heads/master@{#317749}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/7af3c4a..4d068d4

TBR=zmo@chromium.org,hiroshige@chromium.org

Review URL: https://codereview.chromium.org/950823004

Cr-Commit-Position: refs/heads/master@{#317748}

service_worker_037.wpr was recorded before we introduced the script path restriction (crbug.com/423983).
This registration code in this record always fails.
  navigator.serviceWorker.register('/trained-to-thrill/static/js/sw.js', {
    scope: '/trained-to-thrill/'
  })
So we have to update the WPR file

I recorded service_worker_038.wpr using this command.
./tools/perf/record_wpr --browser=exact --browser-executable=~/chromium/src/out/Debug/chrome --also-run-disabled-tests service_worker_page_set

BUG=433943
TEST=./tools/perf/run_benchmark --output-format=chartjson --upload-results --browser-executable=~/chromium/src/out/Debug/chrome --also-run-disabled-tests service_worker.service_worker

Review URL: https://codereview.chromium.org/906883003

Cr-Commit-Position: refs/heads/master@{#317747}

content: Add valid handle check to ChildDiscardableSharedMemoryManager::AllocateLockedDiscardableSharedMemory.

This check allows us to distinguish between allocation failure
on the browser side and failure to map the memory in the child
process.

BUG=460995

Review URL: https://codereview.chromium.org/939343003

Cr-Commit-Position: refs/heads/master@{#317746}

The motivation behind this change is to:
- not block the registration queue on a "while(true) {}" worker
- mitigate SW's from eating too much CPU/battery without being stopped

This adds a "ping" protocol from the browser to the worker thread. If the
worker thread is busy executing JS it will fail to ack the ping.

Each ping waits 30 seconds for a pong. If a pong is received, the next
ping is sent after 10 seconds. Otherwise, the worker is stopped.

This only stops workers that are busy executing synchronous JS. If the
worker does something like repeatedly extend a Promise chain, it will still
be able to ACK and live on. Remaining work is to set a time limit for an
inflight request.

Depends on https://codereview.chromium.org/930213002/

BUG=445150,372436

Review URL: https://codereview.chromium.org/912753002

Cr-Commit-Position: refs/heads/master@{#317745}

Ideally web_view.js show know as little as possible about the internals of
WebView attributes and vice versa. This will allow WebView attributes to
eventually become GuestView attributes that can be shared with other GuestViewContainer
types.

This CL takes us in that direction by plumbing attach/detach into attributes which can
then decide how to respond to those events.

BUG=none
TBR=lazyboy@chromium.org

Review URL: https://codereview.chromium.org/950963002

Cr-Commit-Position: refs/heads/master@{#317744}

Now that Files.app has own file-type icons with Material Design, many icons in
theme_resources.grd are not in use.

BUG=none
TEST=full build and run browser_tests

Review URL: https://codereview.chromium.org/937373002

Cr-Commit-Position: refs/heads/master@{#317743}

The purpose of this change is to minimize chances of hitting
crbug/456029.

1) Call ModelTypeToRootTag only when the root folder could
potentially be created on the client i.e. model type is
defined in client EntitySpecifics and it is one of supported
model types.
2) Rename is_type_root_folder to is_client_creatable_type_root_folder
to make it clear that the checks are specific to client
created type root folders.
3) Narrow the scope of where is_client_creatable_type_root_folder
has to be calculated.

BUG=456029

Review URL: https://codereview.chromium.org/948113005

Cr-Commit-Position: refs/heads/master@{#317742}

Update the libvpx GN build files with the cpu_arch -> current_cpu change:
https://codereview.chromium.org/942153003

TBR=johannkoenig@google.com
BUG=344767

Review URL: https://codereview.chromium.org/948193003

Cr-Commit-Position: refs/heads/master@{#317741}

In the Chrome signin page, we expect it to be possible to navigate on dragging URLs
from outside of the content area into the content area. In <webview>, we do not wish
to navigate the <webview> on link drop but the embedder. Currently navigation on drop
is disabled within a <webview>. This CL provides a droplink event that the embedder can
listen to and navigate when a link is dropped into a <webview> from outside of its
bounds.

Note that this behavior is not identical to other Chrome tabs. In other tabs, if a link is dropped onto
a drop target, the page will not navigate. In this implementation, any external link drop will fire the droplink
event. This is probably not important for the signin
page however because no fields expect to take in links there. The plumbing in this patch
is less disruptive so I'll leave at that unless there is a pressing need to plumb the
navigation decision out of the guest Blink instance and up into the embedder.

BUG=460757

Review URL: https://codereview.chromium.org/945333002

Cr-Commit-Position: refs/heads/master@{#317740}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/6bc1b5f..1a9600f

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=reed@google.com

Review URL: https://codereview.chromium.org/917423008

Cr-Commit-Position: refs/heads/master@{#317739}

TBR=rockot@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/949003003

Cr-Commit-Position: refs/heads/master@{#317738}

This CL is a follow-up to https://codereview.chromium.org/908033003/  to remove cc dependency from ui/base on android platform.

BUG=458889

Review URL: https://codereview.chromium.org/929903002

Cr-Commit-Position: refs/heads/master@{#317737}

BUG=

Review URL: https://codereview.chromium.org/946723002

Cr-Commit-Position: refs/heads/master@{#317736}

BUG=458416

Review URL: https://codereview.chromium.org/923273003

Cr-Commit-Position: refs/heads/master@{#317735}

After this only the startup benchmarks will have a dependency. The goal is to remove CanRunForPage entirely.

session_restore has used CanRunForPage to select one page from the typical_25. The URL is not used because the navigation action is skipped. The only reason it is there is because there is a test when setting up Web Page Replay that the archive has the URL.

BUG=440101

Review URL: https://codereview.chromium.org/808893002

Cr-Commit-Position: refs/heads/master@{#317734}

Make the appropriate conversions between pixel-space and dip-space
coordinates/sizes depending on the display's device scale factor.

BUG=400837
R=pkotwicz@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/924853002

Cr-Commit-Position: refs/heads/master@{#317733}

R=rmsousa@chromium.org
TBR=beaudoin, binjin, kaliamoorthi, noms, rmsousa
BUG=461160

Review URL: https://codereview.chromium.org/949953004

Cr-Commit-Position: refs/heads/master@{#317732}

He seems to not work on Chromium anymore.

BUG=None
R=nsylvain@chromium.org

Review URL: https://codereview.chromium.org/947843002

Cr-Commit-Position: refs/heads/master@{#317731}

DevToolsClientBackend.StopChromeTracing() tries to call console.time & console.timeEnd.
But in ServiceWorker telemetry tests, ServiceWorker may have already stopped by itself.
This is causing the test flakiness.

So this cl add checking if the context type is 'iframe', 'page'  or 'webview'.

BUG=433943
TEST=./tools/perf/run_benchmark --browser-executable=~/chromium/src/out/Debug/chrome --also-run-disabled-tests service_worker.service_worker

Review URL: https://codereview.chromium.org/884573004

Cr-Commit-Position: refs/heads/master@{#317730}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/abc2d6b..7af3c4a

TBR=zmo@chromium.org,hiroshige@chromium.org

Review URL: https://codereview.chromium.org/938823006

Cr-Commit-Position: refs/heads/master@{#317729}

The definition of nacl_irt_icache was moved to irt.h in the NaCl repository,
so irt_nonsfi.h is no longer necessary.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=4033

Review URL: https://codereview.chromium.org/935743004

Cr-Commit-Position: refs/heads/master@{#317728}

This CL fixes an issue where closing dialog boxes in the app list would
not restore focus to the search box. This is fixed by refocusing the
search box when the app list overlay is hidden.

BUG=450922

Review URL: https://codereview.chromium.org/945373002

Cr-Commit-Position: refs/heads/master@{#317727}

That should prevent it from be used in production code.

BUG=280157
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/948143003

Cr-Commit-Position: refs/heads/master@{#317726}

Currently, when an ObserverList iterator is rewound or reaches the end
of the list, it will trigger list compacting. However, the majority of
the time, no compacting is required as no elements were removed.

Change the policy to only compact if an element was removed during
list iteration, avoiding unnecessary O(N) list walks.

BUG=440134

Review URL: https://codereview.chromium.org/943303005

Cr-Commit-Position: refs/heads/master@{#317725}

BUG=None
TEST=git cl presubmit -uv
TBR=maruel@chromium.org,sky@chromium.org

Review URL: https://codereview.chromium.org/948223002

Cr-Commit-Position: refs/heads/master@{#317724}

This CL prevents http: or https: urls from referring to file: urls as search descriptor xmls.
Allowing urls to refer to other urls with the same scheme has been considered (e.g. a file: url
referring to an OSDD xml from a file: url), but this currently doesn't work for file: urls
because of http://b/863583, so is not implemented here.

BUG=429838

Review URL: https://codereview.chromium.org/917313004

Cr-Commit-Position: refs/heads/master@{#317723}

Log events and debugging information related to HID devices through the
device event log component so that these errors are visible at
chrome://device-log. A DEVICE_PLOG macro has been added which includes
the last reported system error in the log message.

BUG=448901

Review URL: https://codereview.chromium.org/947663002

Cr-Commit-Position: refs/heads/master@{#317722}

BUG=434363
TEST=git cl presubmit -uv
R=kalman@chromium.org

Review URL: https://codereview.chromium.org/942263002

Cr-Commit-Position: refs/heads/master@{#317721}

Show menu item to view original image if the request could go over
the data reduction proxy.

BUG=456247

Review URL: https://codereview.chromium.org/944533002

Cr-Commit-Position: refs/heads/master@{#317720}

It turns out that the permissions are working fine, but the documentation
is inadequate.

BUG=434430

Review URL: https://codereview.chromium.org/949543002

Cr-Commit-Position: refs/heads/master@{#317719}

Passed in argument was not meant to be deleted upon merge:
https://codereview.chromium.org/920523002

BUG=457385
TEST=trybots

Review URL: https://codereview.chromium.org/954503003

Cr-Commit-Position: refs/heads/master@{#317718}