- 24 Oct, 2019 40 commits
-
-
Vladimir Levin authored
This replaces a leaky new with a local static variable for the display lock fuzzer environment. This is a speculative fix for the referenced bug. R=schenney@chromium.org Bug: 1013486 Change-Id: I717437eac8d3d6f3d81515e2822209a676047698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873916 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#709212}
-
Zhenyao Mo authored
It seems they cause video frame drop. BUG=995396 TEST=user R=sunnyps@chromium.org Change-Id: I0e0d227e564ba1390478b8020ab84fa2f7e28fae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877049 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#709211}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/13b94d068bdf..154145a8f4cf git log 13b94d068bdf..154145a8f4cf --date=short --no-merges --format='%ad %ae %s' 2019-10-24 tmrts@chromium.org [vinn] Enable snapshots and update Windows d8 binary to 7.6.303.31 Created with: gclient setdep -r src/third_party/catapult@154145a8f4cf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:1001953 Change-Id: Ife50995ac73df07dad06c01e8ce970ba921b971b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878868Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709210}
-
Mitsuru Oshima authored
Bug: 1001696 Test: tast ui.OverviewPerf Change-Id: I9dd9ce83b2d626deed1bac718db46fc9c325967a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877533 Commit-Queue: Mitsuru Oshima (slow) <oshima@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#709209}
-
Etienne Pierre-Doray authored
This refactors UnPackArchive to return UnPackStatus instead of GetLaastError(). Some errors don't have a clear DWORD mapping and it's more straigthforward to return UnPackStatus as the main result, and use it to decide success/failure at call sites. Change-Id: I0aef82ba65a7cd134a2ecd552cee9b600f188e89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846312Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#709208}
-
Hans Wennborg authored
Bug: 1016947 Change-Id: I5e5f36f5d0e727e35a7d8375cf47eefbfe47eec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879927 Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#709207}
-
Tao Bai authored
This reverts commit b01447e6. Reason for revert: The issue cause the test failure has been fixed. Original change's description: > Disable flaky AwSettingsTest#testCacheModeWithBlockedNetworkLoads > > Test is flaky on Lollipop Tablet Tester > > TBR=boliu@chromium.org > > Bug: 1010034 > Change-Id: Ie0de96720fe2396da9032b1cc745445c06dfab61 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851707 > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> > Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> > Cr-Commit-Position: refs/heads/master@{#704537} TBR=boliu@chromium.org,perezju@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1010034 Change-Id: I295e3f92ba300297e550b9b1164fbf90ec85abb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879334Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#709206}
-
Scott Violet authored
https://chromium-review.googlesource.com/c/chromium/src/+/1845506 modified LayoutBox::SizesLogicalWidthToFitContent() to return true for webkit-blox/webkit-inline-box. This is problematic as the display type does not necessarily correlate to the LayoutObject that is used. The right fix is to look at the display type *and* the LayoutObject used. BUG=1014001 TEST=external/wpt/compat/webkit-box-fieldset.html Change-Id: I80cc6d166e02c1e2ec6c2c0c58bcf770793ca41e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874250 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#709205}
-
Kyle Horimoto authored
Spinner functionality in <network-config> broke due to a refactor [1] which started using a template with if="[[!managedProperties_]]". However, managedProperties_ starts out as undefined, and Polymer does not evaluate if's whose properties are all undefined [2]. Since, in this case, the managedProperties_ property is the only one used, all of the properties are undefined, and the template was never evaluated until the properties were received and the spinner was no longer needed. This CL fixes the issue by explicitly using null instead of undefined in this case. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1803724 [2] https://polymer-library.polymer-project.org/2.0/docs/devguide/observers#observers-and-element-initialization Fixed: 1014057 Change-Id: I1f8775fc3136387508959f1fc914aa564434fac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879752Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#709204}
-
Matt Menke authored
These used to query a global set of factories reflecting all schemes that Chrome supported, which have mostly long since gone away. The only remaining global factories it queries against are for http(s) and ws(s). I want to clean up those remaining two global factories, so this CL removes those functions and inlines the schemes into the pre-existing lists of all other supported schemes. Bug: 488166 Change-Id: I2ff34752a91a1c4eede18e271a90b6ed922314c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869398Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#709203}
-
Rohit Rao authored
BUG=987646 Change-Id: I2443f70f0981be8c9022e63c540625f88956d40a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869331 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#709202}
-
Varun Khaneja authored
R=holte Bug: 963165,966646 Change-Id: I20bbbeaa848528e7a0705dc1c22492fd0efee8aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877665 Auto-Submit: Varun Khaneja <vakh@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#709201}
-
Eric Seckler authored
This was missing before, rendering the flag useless for non-browser process tracing. Change-Id: I49222c8582432b1ebe72695bca5d434f0097130f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877016 Auto-Submit: Eric Seckler <eseckler@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#709200}
-
Fan Yang authored
https://quiche.googlesource.com/quiche.git/+log/4cc508c720ac..3ccd7703dc37 $ git log 4cc508c72..b38e63550 --date=short --no-merges --format='%ad %ae %s' 2019-10-24 renjietang Make QuicStreamTest to check on OnDataAvailable() calls. 2019-10-24 wub Fix 10 ClangTidy - Performance findings in //depot/google3/third_party/quic/. 2019-10-24 wub Fix 2 clang-tidy findings in third_party/quic. 2019-10-24 fayang Remove unused variables in QuicVersionsTest.QuicEnableVersion. 2019-10-24 ianswett Add flag counts for two flags that had none. 2019-10-24 dschinazi Fix QUIC_EXPORT_PRIVATE compilation on Windows 2019-10-23 nharper gfe-relnote: deprecate gfe2_reloadable_flag_quic_enable_version_48_2 2019-10-23 renjietang Close connection when stream receives wrong data regarding close offset. 2019-10-23 vasilvv Add a simple integration test for QuicTransport. 2019-10-23 dschinazi Enable -Wexit-time-destructors in QUIC 2019-10-23 dschinazi Add QUIC_EXPORT_PRIVATE to prepare for presubmit 2019-10-23 fayang gfe-relnote: Add QuicCoalescedPacket class. Not used in prod, not protected. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Idd70e621540c3f4d52dcd9854a243d1a34dd0d41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878628Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#709199}
-
Ryan Sleevi authored
Rather than converting a net::CertStatus into a net:Error, and then back from a net::Error into a net::CertStatus, use the original net::CertStatus passed through the layers. For iOS, we don't use the Chrome network stack for these loads, and so there will only ever be an NSError and not a net::Error. Bug: 618799 Change-Id: Ic94c2e248e74651e78cb604421dd93c6067250be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879796 Auto-Submit: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#709198}
-
Ted Choc authored
Command used: find chrome/browser/ -type d -wholename '*java/src' | sort | sed -e 's/\(.*\)$/ <classpathentry kind="src" path="\1"\/>/gm' BUG= Change-Id: I613bba9fa2035bc09d873e0a9b028996da583360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879598 Auto-Submit: Ted Choc <tedchoc@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#709197}
-
Jamie Madill authored
This will allow clients that use the subtree mirror to specify a revision for GoogleTest without needing nested DEPS. Also cleans up the gitignore for the subtree mirror so gclient revert will work properly. Bug: 1017514 Change-Id: I17f6e1299c62b9a4cc4b7726501a9d6cf599ac9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877597Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#709196}
-
Eric Lawrence authored
The current text of the checkbox is "Always open these types of links in the associated app" but this string does not make sense as the wrong element is plural. A link has only one type, and the checkbox only acts on one type. Change text to "Always open links of this type in the associated app". Bug: 1017841 Change-Id: Ibb5ae5b52d84c068144ef1bb974dd11ebb11b8f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879771Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#709195}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/151f5fbf383d..f9b58fba9eab git log 151f5fbf383d..f9b58fba9eab --date=short --no-merges --format='%ad %ae %s' 2019-10-24 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@f9b58fba9eab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I2c9b9dd4e34550127cc5522eb739bd14f06030d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879700Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709194}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3a8b8908605b..6b652b335259 git log 3a8b8908605b..6b652b335259 --date=short --no-merges --format='%ad %ae %s' 2019-10-24 ianelliott@google.com Vulkan: Update expectations for SwiftShader sRGB fix 2019-10-24 jmadill@chromium.org Vulkan: Enable multithreading tests. 2019-10-24 jmadill@chromium.org GN: Fix one missing check for 'angle_has_build'. Created with: gclient setdep -r src/third_party/angle@6b652b335259 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: None Change-Id: I50c0eb41c0d2d6a598f80a45c341a97cdd2fe3d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879701Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709193}
-
Emily Stark authored
This doesn't appear to be used. Bug: 998925 Change-Id: I9c9698cca201d75b0e5c395d0a3863deaeacaeaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879314Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#709192}
-
Dale Curtis authored
This associates a completed underflow count and total underflow duration with each segment of watch time reported to UKM. Generally the completion will always fall within a given segment of watch time, however it is possible that a completion can happen after a resolution change or other secondary property update and thus end up in a subsequent segment. We impose impose a maximum value of 1 minute for rebuffer durations to avoid noise from rebuffers which may cross a suspend/resume boundary. BUG=994021 TEST=new unittests TBR=meacer,sandersd,holte Change-Id: I7359d329259ce2cc2c6643c61741cb7ca8473b0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879847Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#709191}
-
Kaan Alsan authored
When performing snapping on a root scroller that is not the main frame's layout viewport we now perform snapping using the RootFrameViewport instead of only using the layout viewport (the PaintLayerScrollableArea). Also added a test to check this behaviour. Bug: 1015451 Change-Id: I2276b904adef1bb970bd290b49d44ac5e7153982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865048 Commit-Queue: Kaan Alsan <alsan@google.com> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#709190}
-
Rayan Kanso authored
Resources used need to be pre-declared in the shell. Since we don't know how many shortcuts are needed for a web app until the creation request, we create 4 copies of the needed resources to declare a shortcut, since that is the maximum number of shortcuts allowed on Android. The following resources are needed (per shortcut): - name - short_name - icon (placeholder taken from https://material.io/resources/icons/?icon=filter_1&style=baseline) The shortcuts.xml is also partially generated to use the resources, so that building the shell apk doesn't fail. They are all disabled by default, and will need to be re-enabled on the server-side. Bug: 1010471 Change-Id: I5371b145afd943029de8eb679b0cf3044545cbe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875755Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#709189}
-
Vlad Tsyrklevich authored
GWP-ASan tries to allocate its memory region in upper memory (e.g. above the first 32-bits on 64-bit platforms) to limit false positive reports that can result when randomly overwritten pointer values point into the GWP-ASan region. Since introducing the mechanism to hint that the region should be allocated in high memory, these inactionable reports have decreased, but still occasionally occur on Windows. Try to map the region in high memory multiple times to account for the unlikely probability that the memory is already reserved. Bug: 969146 Change-Id: Ide3ae093debcf4a3eee758dbe526ae6c1a66f7d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876754 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#709188}
-
Karan Bhatia authored
This CL adds "regexFilter" to schema of declarative net request rules. These rules are also serialized to flatbuffer. Tests are added to check rule validation and serialization logic. In subsequent CLs matching for these rules will be implemented. Skipping presubmits due to crbug.com/956368. BUG=974391 Doc=https://docs.google.com/document/d/1mRErUMII_gSSPaHmxyn31UOYWUaZLj0xOaezekxD2-Y/edit?usp=sharing (Internal) NOPRESUBMIT=true Change-Id: I356e57ed25ce187f145306e50ca169369f09262e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869556 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#709187}
-
Bailey Berro authored
Updates the string used for the notification that appears when a user connects more monitors than their device can support. Bug: 1017375 Fixed: 1017375 Change-Id: Id88ae042e19e16f0739598f08dca98339e29f46a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875519Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#709186}
-
Vlad Tsyrklevich authored
- Mention its backronym - Note that it is now enabled by default on macOS/Windows - List 2 more limitations I thought of Change-Id: I19108d66b8f3ec88732f62a10fe9777d675139d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879790 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#709185}
-
Nikita Podguzov authored
Bug: 992218 Change-Id: Ia5548a156040954aba3e902762f97967e211c7b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879907Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#709184}
-
David Benjamin authored
This test does not produce much output, but the debugging information added to diagnose https://crbug.com/869227 caused this test to send too much output. Switch it to a TEST_P to divide it back up. Bug: 1017036 Change-Id: I54e5582859ae271401c69e3241f47bd5f12ff42e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879971 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#709183}
-
Dana Fried authored
Previously, when animating layout manager was set to "animate bounds" mode (see SetShouldAnimateBounds()), it assumed it would always be given enough space for its preferred size at any point in the animation. This CL makes it so that an animation can stop short if the containing view stops granting the animating view more space. This allows a view with an AnimatingLayoutManager to be more easily embedded in a view that has, for example, a FlexLayout layout manager. The primary use case will be capping the size of the account icon container so the account name text is elided when the browser window is too narrow to show the entire text without making the Omnibox too small to effectively use. The current behavior is that when space runs out, the kebab/wrench icon slides off the right side of the window (see attached bug). A follow-up will actually engage this new functionality to fix the problem. Bug: 1012681 Change-Id: Ia8e41bb15776a72a8d0869a3c387703e5e443c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875107 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#709182}
-
Kevin Bailey authored
Change fuzzer to avoid data we know AutocompleteInput isn't designed to handle. Change-Id: I755db8375adf0f629af6a656d9494033cae5bb39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876551Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#709181}
-
Peng Huang authored
With the this change, the https://crbug.com/1014236 will not be reproducible with Nvidia. Bug: 1014236 Change-Id: If6a82f7e797bca2c726359575a2134f206ae72fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879749 Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#709180}
-
Xiaoqian Dai authored
Bug: 997885 Change-Id: Ib479e05d744d5e85c2319fb1873e1b94033320fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875553Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#709179}
-
Etienne Bergeron authored
Uniscribe based fallback fonts got removed and replaced by the Skia version, which is using DWrite. Thus, the locale is now supported on win7. Turn on the test on win7. Change-Id: Iae4017a8636333e95d3ff771323fe56ba4b48ade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877911 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#709178}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/09b50796402d..f8df30f1ad44 git log 09b50796402d..f8df30f1ad44 --date=short --no-merges --format='%ad %ae %s' 2019-10-24 sugoi@google.com Fix stencil+MSAA Created with: gclient setdep -r src/third_party/swiftshader@f8df30f1ad44 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: Idf76afabb4cd14e1b81daa032fa7aa980dce497d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879511Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709177}
-
Min Qin authored
When network service is enabled by default, page transition type is not propagated to download when intercepting a navigation. This CL fixes the issue by sending the transition type from NavigationRequest, and also fixes an issue that we only check for DownloadItem::HasUserGesture() when new download backend is enabled. BUG=1014451 Change-Id: Ie3d7614fbfc007a221c86125ac124087ac09a75d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879612Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#709176}
-
Carlos IL authored
Android webview interstitials will require this code. Moving it into components to avoid duplication. Bug: 1016581 Change-Id: I79c9f7f274f6880a7ae102f5b747b79acb72835d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872736Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#709175}
-
Avery Musbach authored
Change-Id: I5f7ee685fd794ec55685c55164a12eda6debf0c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879557Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#709174}
-
Justin Cohen authored
iOS13 will commit a URL change when using window.open followed by a child.location change. If the browser triggers a reload here we shouldn't rewrite URLs to chrome, as window.open to chrome URLs are not allowed. Bug: 1017564 Change-Id: I09384f4e6825c9ae34523458516b20715d4b4961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879328Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#709173}
-