- 28 Sep, 2018 40 commits
-
-
Alex Clarke authored
The intent of this patch is to define the interfaces which will be implemented by subsequent patches. The interfaces are a subset of the C++ ones including what we believe is the minimum requried to be useful. Design doc: https://docs.google.com/document/d/1z1BDq9vzcEpkhN9LSPF5XMnZ0kLJ8mWWkNAi4OI7cos/edit# Bug: 863341, 872372 Change-Id: Ic608660a13c55c4b17d3ba5fa3bb636783735645 Reviewed-on: https://chromium-review.googlesource.com/1245790 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#595057}
-
Michael van Ouwerkerk authored
This reflects the implementation of onNavigationEvent. Bug: 882442 Change-Id: I15a96adf98707e6c18fe19646724076623db85c4 Reviewed-on: https://chromium-review.googlesource.com/1246161Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#595056}
-
Vadym Doroshenko authored
That's good both for privacy and storage reasons. Bug: 831123 Change-Id: Ie41b6d1f25fe37f86aea9eb4625d8aa878e0a52e Reviewed-on: https://chromium-review.googlesource.com/1249205 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#595055}
-
Tanja Gornak authored
Bug: 801985 Change-Id: I182041d580aff43661c227e421fc596506280cee Reviewed-on: https://chromium-review.googlesource.com/1203998Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#595054}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9b89897915c5..e14a15df1635 Created with: gclient setdep -r src-internal@e14a15df1635 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib84c6ec4132160f5eb272c9a61dbd6e8038fff82 Reviewed-on: https://chromium-review.googlesource.com/1250944Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595053}
-
Daniel Bratell authored
Jumbo compilation in components/sync broke when a kInvalidId clone appeared with the same name. This build unbreaking patch renames it to kInvalidNodeId. A longer term fix is probably to move the constant to modules/sync/base or another shared location. Regression from https://chromium-review.googlesource.com/c/chromium/src/+/1164742 TBR=mastiz@chromium.org,treib@chromium.org Bug: 870624 Change-Id: Ie300cf3338c8ffb93a2a0b3b656838bdbf10248a Reviewed-on: https://chromium-review.googlesource.com/1250965 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#595052}
-
Koji Ishii authored
Fragment caching and paint needs to know if fragments created for a constraint space are for the regular layout that are to be painted, or it's for intermediate computation. Since the layout results for column balancing should not be painted, this patch marks so. This change alone doesn't fix all weird paint data inconsistencies when block fragmentation is turned on. Other issues need further investigation. Bug: 714962 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I14d44ca10fd23726f2c08be45b10c2b0abe16bf7 Reviewed-on: https://chromium-review.googlesource.com/1250685 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#595051}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d50988f0..686dfc3f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I30cfb03e8ddeda5c99f5ed7626ad7d7ca625ba39 Reviewed-on: https://chromium-review.googlesource.com/1251021Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595050}
-
Sam Zackrisson authored
Bug: webrtc:9535 Change-Id: I4bf1136184c4d09b7381f53d4ce85937b929f748 Reviewed-on: https://chromium-review.googlesource.com/1250961Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Sam Zackrisson <saza@chromium.org> Cr-Commit-Position: refs/heads/master@{#595049}
-
Kent Tamura authored
We changed the coverage of :unresolved and :defined in crrev.com/594582. But the CL didn't invalidate style correctly. This CL fixes it. * node.cc: - Invalidate :unresolved on V1 custom element state change - Invalidate :defined on V0 custom element state change * Tests: Add v1 custom element + :unresolved test to existing unresolved-pseudo.html. Add :defined invalidation test. Bug: 889336 Change-Id: Id69ba3f9cb62d2805877b648762f4f94bd02e1f9 Reviewed-on: https://chromium-review.googlesource.com/1250721 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#595048}
-
Finnur Thorarinsson authored
They remain disabled on KitKat, which was the problematic version before. Bug: 888931, 656015 Change-Id: I853ea893bfbb60dc6e08095a303ecd32a39325d4 Reviewed-on: https://chromium-review.googlesource.com/1245710 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#595047}
-
Jérôme Lebel authored
Adding implementation to open sync passphrase and restart authentication flow. This is related to: + SyncSetupService::kSyncServiceUnrecoverableError + SyncSetupService::kSyncServiceNeedsPassphrase Bug: 849754 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: If8ac0eb0f5b93adf5d16685085a07f9ad127e777 Reviewed-on: https://chromium-review.googlesource.com/1246065 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#595046}
-
Oriol Brufau authored
GridAreaPositionForInFlowChild could return a wrong end position for grid items adjacent to a collapsed track, because it didn't take into account that gutters collapse in that case. Therefore, "center" or "end" alignments displayed the item at the wrong position. BUG=801881 TEST=external/wpt/css/css-grid/alignment/grid-gutters-013.html Change-Id: I8223f102e3fd581ab0a2d6f23d18c188e23807c7 Reviewed-on: https://chromium-review.googlesource.com/1245727Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Sergio Villar <svillar@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#595045}
-
Ramin Halavati authored
As bookmarks are shared between incognito and regular mode, partner bookmark mapping is added to incognito persistent list. Bug: 861722 Change-Id: I98a10094b2734c32316a6aea0e477391305b19f2 TBR: wychen@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1251101 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#595044}
-
Eric Seckler authored
Bug: 878356, 882872 Change-Id: I16af203c203b82efc408d2153c43eb3cb6fcc7b9 Reviewed-on: https://chromium-review.googlesource.com/1246361Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#595043}
-
Patrik Höglund authored
I forgot to rename these in the last patch. No-try since no trybots run these configs. Tbr: justincohen@chromium.org. Bug: 877018 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: If9213ceabdeb70b2feb21fddbb446d7b742bbccc No-try: True Reviewed-on: https://chromium-review.googlesource.com/1251084 Commit-Queue: Patrik Höglund <phoglund@chromium.org> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#595042}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f7f0def7921b..40a2e1ea2449 git log f7f0def7921b..40a2e1ea2449 --date=short --no-merges --format='%ad %ae %s' 2018-09-28 primiano@google.com Merge "trace_processor: change cursor class to be scoped to a filter operation" Created with: gclient setdep -r src/third_party/perfetto@40a2e1ea2449 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Icac7a74ced7d89ae597c2af391c3d3aad24ed8c2 Reviewed-on: https://chromium-review.googlesource.com/1250943Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595041}
-
Mirko Bonadei authored
While working on removing field_trial_default and metrics_default (in order to avoid link time replacement and use better defaults), we discovered that runtime_enabled_features (which also has a _default implementation) is not used (more info on this here: https://bugs.chromium.org/p/webrtc/issues/detail?id=9631#c21). Usage of this code has been removed in WebRTC with this CL: https://webrtc-review.googlesource.com/c/src/+/102361. Bug: webrtc:9631 Change-Id: Ief33059cd329f429b9bbdd7520808e62e3f6f62b Reviewed-on: https://chromium-review.googlesource.com/1249029Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#595040}
-
Hajime Hoshi authored
This CL is pure refactoring. We aim to reduce ThreadTaskRunnerHandle: :Get() usages as much as possible. Change-Id: I13cb655c77f5b6c78d977e680fa92aa4278f38f5 Reviewed-on: https://chromium-review.googlesource.com/1249477Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#595039}
-
Yoichi Osato authored
This patch is refactoring. Since we have only inserted Text node rather than Node(see L263), we should type the internal hash map key to Text rather than Node. Bug: 868229 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I582b3b0b5f3090ac94d89dfb99a32f1fd43527d4 Reviewed-on: https://chromium-review.googlesource.com/1248362 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#595038}
-
Ryo Hashimoto authored
BUG=None TEST=None Change-Id: I27db32e1fe44e2c3ab2d39f79790396959f2cf61 Reviewed-on: https://chromium-review.googlesource.com/1250562Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#595037}
-
Mikel Astiz authored
A USS bridge has been recently introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1164742 to allow integrating legacy SyncableService sync datatypes into the most modern USS architecture. In this patch, a controller is introduced to do the necessary plumbing and use the new codepath behind feature toggles. We do this for a first set of datatypes that are simplest, i.e. the ones that live in the UI thread and without complex logic in their controllers. Follow-up patches will add support for more. Bug: 870624 Change-Id: Ibdcc01133103296bd9c53e165a37b63cc32dcb87 Reviewed-on: https://chromium-review.googlesource.com/1251102Reviewed-by:
-
Marc Treib authored
This solves a (presumably) rare case where we'd get the same invalid token again and again. Bug: 889896 Change-Id: I10f569f195a91c6912ac700ccc5dd0c1c8f3c06c Reviewed-on: https://chromium-review.googlesource.com/1249087 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b5c6dd434907..1ee9160a2e0b git log b5c6dd434907..1ee9160a2e0b --date=short --no-merges --format='%ad %ae %s' 2018-09-28 oprypin@webrtc.org Don't use nonstandard tryjobs for autoroller 2018-09-28 buildbot@webrtc.org Roll chromium_revision 2985a247..f63f90fb (594820:594935) Created with: gclient setdep -r src/third_party/webrtc@1ee9160a2e0b The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:888417,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib740628d8c18e1d56650279c9efdaaaa636f1f71 Reviewed-on: https://chromium-review.googlesource.com/1250802Reviewed-by:
-
Patrik Höglund authored
I have a green waterfall which confirms the experimental src-side config works now, so make BuildBot use the new config. This will make it easier to switch from BuildBot to LUCI. This CL needs to land concurrently with the infra CLs + restart of the WebRTC Chromium FYI master since the bots change names as a part of this process. Bug: 877018 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I2811718874bb9f6079488fc0ee17e6f324ae50b0 Reviewed-on: https://chromium-review.googlesource.com/1249103 Commit-Queue: Patrik Höglund <phoglund@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#595033}
-
Stephane Zermatten authored
The reset and stop actions control what happens after the script has finished executing. Without any of these, after the script ends, Autofill Assistant checks for more scripts that can be run, keeping in mind which scripts have been run and what their status was. If the script ran a reset action, the memory of which scripts were run is forgotten. Autofill Assistant restarts on the current URL, as if nothing had happened. If the script ran a stop action, Autofill Assistant shuts down after the end of the script. The UI and everything attached to it goes away. Bug: 806868 Change-Id: I924aa2e0681c7824fb6fd70e24f1477a997577eb Reviewed-on: https://chromium-review.googlesource.com/1245796 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#595032}
-
Gemene Narcis authored
This CL moves HttpCredentialCleaner instance inside password_manager_utils.cc in order to be added in the clean-up runner's queue. Bug: 871140 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Iaf321e3b136c235ea9eb0ab1489acbeefa8208d1 Reviewed-on: https://chromium-review.googlesource.com/1249071 Commit-Queue: Narcis Gemene <gemene@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Anders Hartvoll Ruud authored
Currently, custom property animations are applied in quite a roundabout way: StyleResolver applies the value assisted by CSSVariableResolver, which may call into StyleResolver again depending on the variables it sees during resolution. It has a const_cast. It side-channels a HashSet via StyleResolverState. It's just not nice. To fix this, create CSSVariableAnimator which owns the state and functionality we need to apply the animated properties (in the right order). This is a pure refactor. It is already covered well by tests, specifically by animations/custom-properties/registered-var*. Change-Id: I6ed4ef2457f990d89930a5c802e01e64ac420174 Reviewed-on: https://chromium-review.googlesource.com/1243087Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#595030}
-
Marina Ciocea authored
This reverts commit 57c883df. Reason for revert: Temporary check is no longer needed because we gathered enough data for investigating https://crbug.com/867827#c40. Conclusion: global allocator is initialized by the time audio service reports UMA metrics. Original change's description: > Temporary check global histogram allocator in audio service output controller. > > Add a temporary check to investigate audio service experiment output controller > histograms count mismatch. If histogram persistent memory is not setup before > output controller metrics are reported, the check will fail > (see https://crbug.com/867827#c40). This CL will be reverted in a couple of days > after gathering data from canary. > > Bug: 867827 > Change-Id: I08cce13476f851d9ab24434add30f65abbf1e600 > Reviewed-on: https://chromium-review.googlesource.com/1215246 > Reviewed-by: Olga Sharonova <olka@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Marina Ciocea <marinaciocea@chromium.org> > Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589879} TBR=guidou@chromium.org,olka@chromium.org,marinaciocea@chromium.org Bug: 867827 Change-Id: Ie9f4ebabf8dfd4773466be0e75d878ce3508f19e Reviewed-on: https://chromium-review.googlesource.com/1250881 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#595029}
-
Koji Ishii authored
For AddSelfOutlineRects to reach to LayoutInline that has a continuation, this patch splits the logic in AddSelfOutlineRects so that it can be called recursively. In doing so, the logic flow and functions are organized to match to the one in LayoutObject tree. Bug: 889721 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I79e00ea7c37c94bf06e564a69fe7fc5da4f72349 Reviewed-on: https://chromium-review.googlesource.com/1246881 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#595028}
-
Hayato Ito authored
No behavior change. Re-oder declarations so that related functions are grouped together. Bug: 869308 Change-Id: I63db39350291cef18deb96c6a4bb9d1a27eedfcd Reviewed-on: https://chromium-review.googlesource.com/1250822Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#595027}
-
Kenichi Ishibashi authored
After calling |fallback_callback_|, we shouldn't use |url_loader_client_|. Before this CL ServiceWorkerNavigationLoader attempted to call OnCompleted(net::ERR_ABORT) on the client when a request is routed to service worker but the request was fall back to network. This wasn't a serious problem as the client wasn't active at that point but ideally we shouldn't use it. Change status to kCompleted when the request is fallback to network. Bug: N/A Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I0c59b1b69e6916c05a36f79b6ea9a9962bbb173c Reviewed-on: https://chromium-review.googlesource.com/1249468Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#595026}
-
Ben Wells authored
This enables individual default web apps to be gradually rolled out to different segments of the population. Bug: 855281 Change-Id: I733af23d24b906dd3f494af86a5a89cab6040d0a Reviewed-on: https://chromium-review.googlesource.com/1242580 Commit-Queue: Ben Wells <benwells@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#595025}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/466fcd2bc4b3..9b89897915c5 Created with: gclient setdep -r src-internal@9b89897915c5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I790eab707c062a611aea17b15a29d8d946baac7b Reviewed-on: https://chromium-review.googlesource.com/1250801Reviewed-by:
-
Findit authored
This reverts commit b5d11746. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 595002 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYjVkMTE3NDYzNzAyOGM1ZjMxYWM1OTYxMTQ0MTEwMWRmZTEwMzU3Zgw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20TSan%20Tests/26603 Sample Failed Step: content_browsertests Sample Flaky Test: SignedExchangeAcceptHeaderBrowserTest/SignedExchangeAcceptHeaderBrowserTest.DisabledOrigin/3 Original change's description: > Send SXG accept header of navigation only to limited origins for Origin Trial. > > Before this patch: > The SXG accept header is sent to all origins when SignedHTTPExchange feature > or SignedHTTPExchangeOriginTrial feature is enabled. > > After this patch: > The SXG accept header is sent when > - SignedHTTPExchange feature is enabled. > or > - SignedHTTPExchangeOriginTrial feature and SignedHTTPExchangeAcceptHeader > feature are enabled and the origin of the URL is in the OriginList of > SignedHTTPExchangeAcceptHeader field trial. > > Bug: 887201 > Change-Id: Ic67a8bc0644b1b6172030ff75162c04663dd33f0 > Reviewed-on: https://chromium-review.googlesource.com/1242768 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Commit-Queue: Tsuyoshi Horo <horo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595002} Change-Id: Ic52f50aa70de8d3f21c55fff4517e7b0d58565fa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 887201 Reviewed-on: https://chromium-review.googlesource.com/1251022 Cr-Commit-Position: refs/heads/master@{#595023}
-
Achuith Bhandarkar authored
BUG=None Test=browser tests. Change-Id: Ifa7477e130ffb8e7b526a40d903382c9dce9e116 Reviewed-on: https://chromium-review.googlesource.com/1235715Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#595022}
-
Mathias Carlen authored
Before this patch, the client and server protos differed in the fields ids and the structure of the element to wait for. This resulted in selectors being empty and timeout values off. This patch fixes the numbering and replaces the element field with a repeated string field. After this patch, WaitForDomProto messages can properly be parsed. Props to szermatt@ for finding this difference. R=rouslan@chromium.org Bug: 806868 Change-Id: Ib2c9822c6ef24001706b78c339f3d4b97c3aa947 Reviewed-on: https://chromium-review.googlesource.com/1249274 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c0b96b43..d50988f0 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I972893012e34368d8f5a358c48aad6ba0a761735 Reviewed-on: https://chromium-review.googlesource.com/1250053Reviewed-by:
-
Gauthier Ambard authored
This CL removes the limitation of the width of the tools menu string as it is now possible to span them on multiple lines. Bug: 833947 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I98126537ff4e57a23e297a8dee3b862c2b6a1120 Reviewed-on: https://chromium-review.googlesource.com/1238502Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#595019}
-
Ramin Halavati authored
The following preferences are removed from the persistent storage list for incognito mode: - kBackgroundTracingLastUpload - kDefaultAudioCaptureDevice - kDefaultTasksByMimeType - kDefaultTasksBySuffix - kDefaultVideoCaptureDevice - kMediaGalleriesRememberedGalleries - kMediaGalleriesUniqueId - kPartnerBookmarkMappings - kPepperFlashSettingsEnabled - kPerformanceTracingEnabled - kWebRTCIPHandlingPolicy - kWebRTCMultipleRoutesEnabled - kWebRTCNonProxiedUdpEnabled These preferences are either never changed from incognito mode, or if changed, they do not need to be written to user profile. Bug: 861722 Change-Id: I03fb38784b57460b4d2e74c1abfdb01e83ddbda2 TBR: guidou@chromium.org TBR: oysteine@chromium.org TBR: satorux@chromium.org TBR: tommycli@chromium.org TBR: wychen@chromium.org TBR: zork@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1250521 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
-
