- 03 Mar, 2018 40 commits
-
-
Istiaque Ahmed authored
This CL adds two tests to exercise scenarios where verified_contents.json fetch can fail. The tests make sure that the fetch fails and ContentHashFetcher responds correctly. FetchInvalidVerifiedContents: Fetched hash contains invalid signature content. Fetch404VerifiedContents: Hash fetch results in 404. Bug: 818315, 796395 Change-Id: I3606bf504bf1e710705d2020bdf0ac3afa84d77a Reviewed-on: https://chromium-review.googlesource.com/942182 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#540747}
-
Chris Harrelson authored
This is mostly a re-land of https://chromium-review.googlesource.com/c/chromium/src/+/923089, now that a squashing bug was fixed in https://chromium.googlesource.com/chromium/src/+/8e4234fdc272ddda5ec9c156a2397c64d7a69f60. It differs from a straight-reland in that it also does not mark the PaintLayer with SetNeedsGraphicsLayerUpdate. Bug: 770343 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: If4a29f30b42ff45eb6a456bced4ab2e837f81d3e Reviewed-on: https://chromium-review.googlesource.com/947579Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#540746}
-
Siddhartha authored
This cl adds ukm for background memory dump providers. This only adds the providers approved in the privacy review: https://docs.google.com/document/d/1mzRM7TzDHo-blauk5nfG34zX_4_amCoshPE1iptoOdQ UMA for these metrics will be added in next cl. BUG=730783 Change-Id: Ife23dd28cd443725a7b8a6d74ba532220f4bb46f Reviewed-on: https://chromium-review.googlesource.com/939904 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#540745}
-
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/23d80a8f4bd2..644d1e63d9ad $ git log 23d80a8f4..644d1e63d --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I29796a786d06a2adc196b72706f7e3107c4c5d00 Reviewed-on: https://chromium-review.googlesource.com/947472Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#540744}
-
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I3bff32bad8e5a5b92b5770337065ec3cacd9350a Reviewed-on: https://chromium-review.googlesource.com/947885 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#540743}
-
Mike Wasserman authored
Bug: 771980 Change-Id: I600e523b71c8c4261c47b12a477cc2d394a222bf Reviewed-on: https://chromium-review.googlesource.com/944715 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#540742}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0f1f2246..222d8fe8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I6d9ed03082ddb6d3175742adabc58061aae01044 Reviewed-on: https://chromium-review.googlesource.com/947823Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#540741}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 61cb4782. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13088 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: If108b515e590fafc9da4748cb8d4f0839e2d0225 Reviewed-on: https://chromium-review.googlesource.com/947763 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#540740}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=anantha@chromium.org Change-Id: I0739bb5f016b2617ac05a8679b54899f692438b6 Reviewed-on: https://chromium-review.googlesource.com/947747Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#540739}
-
Andrew Grieve authored
This reverts commit f3af7e37. Reason for revert: Broke ContextualSearchManagerTest#testTapALotDLD Original change's description: > [TTS] mojo-ify ShowUnhandleTapUIIfNeeded. > > Replaces the whole call chain for ShowUnhandledTapUIIfNeeded > between Blink and Chrome/WebView with Mojo messaging. > > Removes the Blink WebTappedInfo class in favor of a new UnhandledTapInfo > that sends a Mojo construct of the same name to the Browser which > has a service installed via a RenderHostFrame observer. > > All functionality should remain unchanged. > > NEW CODE: > The CSTabHelper now creates an UnhandledTapWebContentsObserver that > connects the Mojo service via UnhandledTapNotifierImpl. That Impl > calls back through Java to the CSTabHelper to the CSManager to notify > that a Tap has occurred. The CSTabHelper ignores these notifications > when CS is disabled. > > The mojo message is only sent to the browser if the tap is unhandled > and the other required conditions are met. > > UPDATED TESTS: > Test notification is now done through mojo messaging, so we now only > know if the tap was unhandled, not whether the page changed or other > details about why the tap was unhandled. > > Updated the test page by adding nodes that do not trigger, and removed > the mousemove handler since it's unrelated to tap handling. > > BUG=754862 > > Change-Id: I18111f2537cfb16a4523d7f0cc766037fbf6050a > Reviewed-on: https://chromium-review.googlesource.com/841544 > Reviewed-by: Yoichi Osato <yoichio@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#540629} TBR=dcheng@chromium.org,kinuko@chromium.org,yfriedman@chromium.org,rockot@chromium.org,donnd@chromium.org,yoichio@chromium.org,twellington@chromium.org Change-Id: Ib65533422cef13b6231dba93990b4e5cac77adba Bug: 754862, 818374 Reviewed-on: https://chromium-review.googlesource.com/947642 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#540738}
-
Khushal authored
R=piman@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I3cd322f9fad475377e748a322fbc39c90dc2bca9 Reviewed-on: https://chromium-review.googlesource.com/942476Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#540737}
-
Min Qin authored
No major change in functionality, just moving the files Bug: 803135 Change-Id: I93737ed4539c1b3ddc25212814ef9b9c903ac882 Reviewed-on: https://chromium-review.googlesource.com/944545Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#540736}
-
Mitsuru Oshima authored
This reverts commit 63c07973. Reason for revert: This is causing crbug.com/818010 and crbug.com/817957. Original change's description: > Handle WebContents occlusion on aura. > > With this CL, when a WebContents is occluded on aura: > - WebContents::GetVisibility returns OCCLUDED > - RenderWidgetHostImpl::WasHidden is called on all > RenderWidgetHostImpls that belong to the WebContents. > That allows: > - Changing the priority of renderer processes to background. > - Not rendering frames unnecessarily. > > Bug: 668690 > Change-Id: Ie1c86d271276576a6b5c7adfb11bd0e42d5d491e > Reviewed-on: https://chromium-review.googlesource.com/937820 > Reviewed-by: Peter Beverloo <peter@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#540149} TBR=avi@chromium.org,sky@chromium.org,peter@chromium.org,fdoray@chromium.org,dominickn@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 668690 Change-Id: Id58705c66157cb18be220cc59b29a50fd3b14d95 Reviewed-on: https://chromium-review.googlesource.com/947802Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#540735}
-
Alexander Alekseev authored
This Cl doesn't include the bindings, only the UI. Bug: 818366 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4d07d68700e60e31a1b1260b48ea40c511c27be3 Reviewed-on: https://chromium-review.googlesource.com/947567Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#540734}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d0de9616e5bb..462839ea9942 $ git log d0de9616e..462839ea9 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Iadd42c2297e920de51d2312527c5cbcffde4a7a7 Reviewed-on: https://chromium-review.googlesource.com/947662Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#540733}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e1de5c82..0f1f2246 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I3c6b1dbe92c38eb33dfdc757fbf1b40d593bf12c Reviewed-on: https://chromium-review.googlesource.com/947131Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#540732}
-
Shenghua Zhang authored
Due to 10.9 macs are not supported and os is upgraded to 10.13, the builders names with '10.9' in chromium.mac should be renamed to '10.13'. This cl includes buildbot config and luci infra config. Bug: 805475, 790169 Change-Id: I4bb24757dc3d728a319de279c793172c010097e0 Reviewed-on: https://chromium-review.googlesource.com/946746 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#540731}
-
Marijn Kruisselbrink authored
Bug: 813046 Change-Id: Ie8775a418059b5c69dd47ea06668101e69f6ee72 Reviewed-on: https://chromium-review.googlesource.com/939714Reviewed-by:
Siddhartha S <ssid@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#540730}
-
Robert Iannucci authored
Bug: 818054,818230 Change-Id: Ia3c395bf89845c683bba74b4944e5c673ae3a0b0 Reviewed-on: https://chromium-review.googlesource.com/946747 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
David Tu <dtu@chromium.org> Cr-Commit-Position: refs/heads/master@{#540729}
-
Devlin Cronin authored
Update chrome/test/data/extensions/api_test/system to manifest v2. This involved complying to manifest v2's CSP requirements. Bug: 816679 Change-Id: I14b3f139770722a7312786c582ca0e74fef892db Reviewed-on: https://chromium-review.googlesource.com/946906Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#540728}
-
Emily Stark authored
We currently log a warning message for subresources that use Symantec certificates that have been distrusted. This message didn't fire, however, for iframe main resources because Blink isn't notified about them in the same way as it is other failed resource loads. To log for iframe main resources, the logging logic is moved in RenderFrameImpl (from LocalFrameClientImpl) and called when a frame fails to load. This doesn't work 100% reliably for OOPIFs because of https://crbug.com/817881. Bug: 815219 Change-Id: I961a3e664c0383a7ff81be7def6de17185501243 Reviewed-on: https://chromium-review.googlesource.com/943984Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#540727}
-
Ella Ge authored
This cl remove setting cursor style to default cursor in HandleDrag. The SetCursor here is before reach drag threshold, we shouldn't do it here because drag may not going to start. We always update cursor style on mousemove events, setting cursor here may cause cursor blink when mousedown on a draggable item and slowly move. Drag-and-drop will control the cursor after start dragging, so no need to setting cursor. Bug: 799799 Change-Id: I9168d05f3b861a5e50dbb0b7e9e1bb5e5ebe19b1 Reviewed-on: https://chromium-review.googlesource.com/941504Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#540726}
-
Robert Sesek authored
Switch to using -exported_symbols_list with the specified saves file to preserve specific global symbols. Then use the strip command to remove all remaining local symbols. The strip command is now applied via //build/config/mac:strip_all rather than explicitly on specific executables. Bug: 805453 Change-Id: I8d21b12116842eda1f9eb5c0758f52d6198a116f Reviewed-on: https://chromium-review.googlesource.com/922987 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#540725}
-
Jeremy Roman authored
Bug: 755727 Change-Id: Ief44c8e53de86bb86fa01f423da5bb59ec8b7105 Reviewed-on: https://chromium-review.googlesource.com/946124Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#540724}
-
James Cook authored
The container holds the ChromeVoxPanel window, which is created by chrome. Future CLs will make the ash::ChromeVoxLayoutManager manage the bounds of ChromeVoxPanel and updates to the display work area. This is needed to support mustash, as the information needed to compute the window bounds is owned by ash, but ChromeVox is implemented with an extension owned by chrome. Bug: 628655 Test: ash_unittests, open and close ChromeVox via Ctrl-Alt-Z Change-Id: I02ac4384b949043eafc0578b06676b7e757888c5 Reviewed-on: https://chromium-review.googlesource.com/946517 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#540723}
-
Pavel Feldman authored
Bug: 816688 Change-Id: I29beeae9ce49169204ec867cc9636b00a360a26a Reviewed-on: https://chromium-review.googlesource.com/941980Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#540722}
-
xlai authored
A follow-up CL to do more cleaning on code duplication in WebGL rendering context, after https://chromium-review.googlesource.com/943761. Bug: 794706 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8c9de02c113a36b4c6b95bb1dd3af25079b4c4d3 Reviewed-on: https://chromium-review.googlesource.com/946899Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Olivia Lai <xlai@chromium.org> Cr-Commit-Position: refs/heads/master@{#540721}
-
Devlin Cronin authored
This reverts commit 4d546d6e. Reason for revert: this patch caused a bug where we leave extraneous windows around when coming out of sleep. TBR=sky@chromium.org (c/b/ui/browser - clean revert) Bug: 818351 Change-Id: I3cf6d60a4588b36619dc4e461c3b8cf29722d6cd Reviewed-on: https://chromium-review.googlesource.com/947473 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#540720}
-
John Rummell authored
These new tests require a DRM sytem that isn't available to content_shell, so they can't be run. BUG=818254 Change-Id: I228864c991a452c86c465e388b03366fac0d7f12 Reviewed-on: https://chromium-review.googlesource.com/947564Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#540719}
-
https://pdfium.googlesource.com/pdfium.git/+log/71cdd20e9d74..9a7c2396705a $ git log 71cdd20e9..9a7c23967 --date=short --no-merges --format='%ad %ae %s' 2018-03-02 thestig Make EmbedderTest::WriteBitmapToPng() work with grayscale images. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ib2576939b2aa4b5b7980ee6b8c80e59327532c90 Reviewed-on: https://chromium-review.googlesource.com/947379Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#540718}
-
Vitaliy Rebrov authored
SQL statements forbid binding another variable after "Step()" has been called, until "Reset()" is called. However, the Reset() call was sometimes being skipped due to early continue stmts used in the loop body. Change-Id: Icc2c13b0524d002e10e72a0cabb45d1d09c567c4 Reviewed-on: https://chromium-review.googlesource.com/939787Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#540717}
-
Bruce Dawson authored
The switch to clang-cl has made many of the build instructions incorrect or misleading, and some build-speed tips are sorely needed. Cleanups include: - Correct the SDK requirements (FCU SDK doesn't work) - Clarify that VS is still needed even though we compile with clang-cl - Correct goma instructions and recommend it more strongly - Update linker options for the clang-cl world - Add troubleshooting instructions for slow builds including NINJA_STATUS, NINJA_SUMMARIZE_BUILD, ninjatracing, and -d stats. The results were tested with both https://dillinger.io/ and python tools/md_browser/md_browser.py docs\windows_build_instructions.md since neither one gives 100% correct results. Bug: 787983 Change-Id: Ic0d16d884439723dfb3feb610892d7e667e7ae3a Reviewed-on: https://chromium-review.googlesource.com/947573 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#540716}
-
Penny MacNeil authored
For all child processes, only enable PreferSys32 after startup. TBR=forshaw@chromium.org TEST=sbox_integration_tests.exe, ProcessMitigationsTest.CheckWin10ImageLoadPreferSys32* Change-Id: I72d1e6fd2f88e14e1042832fc47663b0b7b76c8e Reviewed-on: https://chromium-review.googlesource.com/947503Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Penny MacNeil <pennymac@chromium.org> Commit-Queue: Penny MacNeil <pennymac@chromium.org> Cr-Commit-Position: refs/heads/master@{#540715}
-
Katie D authored
The event rewriter needs to allow mouse movement events to pass even when those events are used by Select-to-Speak. It should only cancel mouse click events used by Select-to-Speak. Another solution would be to re-write all used "drag" events to be simply "move" events, which may reduce the likelyhood that these events will be used by any other part of Chrome / Chrome OS besides Select-to-Speak and drawing the mouse. This bug also impacted some devices (like snappy) even without large mouse cursor on. Note: The additional "drag" and "move" events were manually tested and do not appear to cause any behavior problems on tabs, the launcher, system windows, etc. Bug: 818329 Change-Id: I466a15a0f7a5ba0abe4f082a9cfb9b59760d690c Reviewed-on: https://chromium-review.googlesource.com/947210 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#540714}
-
Wez authored
The Shutdown() API was added to RenderProcessHost with parameters reflecting those of the underlying base::Process::Terminate() API, which include a synchronous |wait| option. We never use Shutdown(.., wait=true) in production code, and in tests we can instead use a RenderProcessHostObserver to wait for a process to crash or exit, so we can remove the |wait| parameter and simplify both callers and the implementation. Bug: 806451 Change-Id: I2aeae32a3d20488b4970cf96959eaa287642b7ed Reviewed-on: https://chromium-review.googlesource.com/936450 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#540713}
-
Andrii Shyshkalov authored
R=jchinlee No-Try: True Bug: 731545 Change-Id: I4655d2aaa1f78ff350336743b19627bd4cfc1e2d Reviewed-on: https://chromium-review.googlesource.com/947572 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#540712}
-
Fan Yang authored
In QUIC, replace ack_frame with largest_acked and ack_delay_time in QuicSentPacketManager::MaybeUpdateRTT. No functional change expected. Merge internal change: 187224206 R=rch@chromium.org Change-Id: Ibdae257e3b57c85a828f14a2e97df7869eade34a Reviewed-on: https://chromium-review.googlesource.com/946268Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Fan Yang <fayang@chromium.org> Cr-Commit-Position: refs/heads/master@{#540711}
-
https://chromium.googlesource.com/angle/angle.git/+log/888081d59aae..b27b03a2c9ea $ git log 888081d59..b27b03a2c --date=short --no-merges --format='%ad %ae %s' 2018-02-19 lfy GLES1: caps: GLES1-specific context limits 2018-02-26 xinghua.cao ES31: Implement memoryBarrier on D3D backend 2018-02-28 jmadill Rename signal utils to Observer. 2018-02-27 jiawei.shao ES31: Add link validations on geometry shader uniforms Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I80cd4b6ae98bd0f4490701c5c8b762a2a7dd8355 Reviewed-on: https://chromium-review.googlesource.com/946884Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#540710}
-
Alex Moshchuk authored
After this CL, certain cross-site, main frame, browser-initiated navigations will use a new BrowsingInstance. This includes navigations initiated from the address bar (typing in the URL or searching) and bookmarks. Note that this works even if the navigated frame has an opener, since these user-initiated navigations indicate that it's ok to break the opener relationship. This change helps avoid unneeded process sharing. For example, after being on a A-embed-B page, any future browser-initiated navigation to B would've stayed in the same BrowsingInstance, SiteInstance, and process as the B subframe on the old page, and if the subframe reused another tab's process due OOPIF process reuse policy, this resulted in both tabs unnecessarily ending up in that process. Bug: 803367 Change-Id: I3a2461a67cb626329c20a887f993d4c9a1494236 Reviewed-on: https://chromium-review.googlesource.com/881836 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#540709}
-
agrieve authored
This reverts commit f0d1cf1e. Reason for revert: Breaking bots with: C 1086.301s Main [FAIL] org.chromium.chrome.browser.offlinepages.OfflinePageApiFunctionTest#testError: C 1086.301s Main java.lang.VerifyError: org/chromium/chrome/browser/ClassRegister C 1086.301s Main at org.chromium.chrome.browser.init.ChromeBrowserInitializer.onStartNativeInitialization(ChromeBrowserInitializer.java:381) Original change's description: > [Android] Pass SurfaceView to HandleObserver for Chrome. > > Since Chrome uses SurfaceView for compositing, we will get nothing from > the ContentView passed to |SelectionPopupController| in > |HandleObserver|. > > In this CL, we are passing SurfaceView to HandleObserver from > |CompositorViewHolder| through |WindowAndroid| if it's Chrome's case. > > Bug: 805531 > Change-Id: I7dbf1bd16387eec76dc69031037530b3cb00e753 > Reviewed-on: https://chromium-review.googlesource.com/923021 > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Reviewed-by: Changwan Ryu <changwan@chromium.org> > Commit-Queue: Shimi Zhang <ctzsm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#540675} TBR=mthiesse@chromium.org,boliu@chromium.org,dtrainor@chromium.org,yusufo@chromium.org,changwan@chromium.org,ctzsm@chromium.org Change-Id: Ia7a183e28b05e5dd2f2156fcd3b956e8986686dc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 805531, 818370 Reviewed-on: https://chromium-review.googlesource.com/947602Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#540708}
-