GitLab

Original fix:
https://codereview.chromium.org/427723004/

The original fix was reverted, however it actually shouldn't have been because it was mostly correct. This fix is the same as the old one, with an additional change. The call to DidStopLoading() in Instance::DocumentLoadComplete was moved to an earlier part of the function, causing DidStopLoading to be called before the print preview request.

BUG=376969

Review URL: https://codereview.chromium.org/467343003

Cr-Commit-Position: refs/heads/master@{#290010}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290010 0039d316-1c4b-4281-b951-d872f2087c98

- bytes read / written per socket
- total bytes read / written across all sockets

Also changed the Logger class to hold a Log proto instead of individual
fields.

BUG=343228

Review URL: https://codereview.chromium.org/475463002

Cr-Commit-Position: refs/heads/master@{#290009}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290009 0039d316-1c4b-4281-b951-d872f2087c98

When split-view mode, make sure dragging the tiel to switch between
windows works as expected.

BUG=397272
R=mfomitchev@chromium.org, mukai@chromium.org

Review URL: https://codereview.chromium.org/468763002

Cr-Commit-Position: refs/heads/master@{#290008}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290008 0039d316-1c4b-4281-b951-d872f2087c98

BUG=385295
TEST=Press Ctrl+Shift+F3, screen rotates.

Review URL: https://codereview.chromium.org/431183003

Cr-Commit-Position: refs/heads/master@{#290007}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290007 0039d316-1c4b-4281-b951-d872f2087c98

This name seems to be used in super old default profiles (I think it may
have been used before First User came around).

BUG=403881

Review URL: https://codereview.chromium.org/478543002

Cr-Commit-Position: refs/heads/master@{#290006}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290006 0039d316-1c4b-4281-b951-d872f2087c98

This saves the logic in PluginURLFetcher and WebURLLoader that has to replicate
the method-munging, referrer-munging, and first-party-URL-munging logic that is
already done in net/.

BUG=384609

Review URL: https://codereview.chromium.org/398903002

Cr-Commit-Position: refs/heads/master@{#290005}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290005 0039d316-1c4b-4281-b951-d872f2087c98

Add a metric for measuring the time it takes to process the very first
gesture scroll update input event. The first scroll gesture can often
get delayed by work related to page loading, which is what we hope to
improve with the Blink scheduler. This metric will help us track the
effectiveness of those improvements.

Original patch from Simon Pick <picksi@chromium.org>

BUG=391005

Review URL: https://codereview.chromium.org/467343002

Cr-Commit-Position: refs/heads/master@{#290004}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290004 0039d316-1c4b-4281-b951-d872f2087c98

The method usage is added here: https://chrome-internal-review.googlesource.com/172629

BUG=403891
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/479573002

Cr-Commit-Position: refs/heads/master@{#290003}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290003 0039d316-1c4b-4281-b951-d872f2087c98

This CL only turns on the non-nullable check for validation tests.

There will be separate CLs for:
- add DCHECK at the sending side.
- make the existing APIs pass the non-nullable check and turn on the check everywhere.

BUG=324170
TEST=New and revised validation tests.

Review URL: https://codereview.chromium.org/466613002

Cr-Commit-Position: refs/heads/master@{#290002}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290002 0039d316-1c4b-4281-b951-d872f2087c98

Now when performing single tap, the tap timer to begin one finger passthrough is not started. This problem originally arose because touch explore released state and single tap released state are treated similarly in the code, but one finger passthrough should be a state reachable only from single tap released.

Another state change is that if the user presses in single tap/touch explore released and there is no previous touch exploration location, the user is redirected to the wait state.

TEST=TouchExplorationTest.SingleTapLongPress
BUG=402544

Review URL: https://codereview.chromium.org/465543003

Cr-Commit-Position: refs/heads/master@{#290001}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290001 0039d316-1c4b-4281-b951-d872f2087c98

R=lcwu@chromium.org,byungchul@chromium.org
BUG=403104,403101

Review URL: https://codereview.chromium.org/467043002

Cr-Commit-Position: refs/heads/master@{#290000}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290000 0039d316-1c4b-4281-b951-d872f2087c98

This doesn't do anything effective anymore.

BUG=245900

Review URL: https://codereview.chromium.org/469003006

Cr-Commit-Position: refs/heads/master@{#289998}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289998 0039d316-1c4b-4281-b951-d872f2087c98

Nothing registers for the callback in WasShown if using
synchronous compositor, so this does not change any behavior.
So this is only removing unneeded RequestVSyncUpdate

BUG=

Review URL: https://codereview.chromium.org/476233002

Cr-Commit-Position: refs/heads/master@{#289997}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289997 0039d316-1c4b-4281-b951-d872f2087c98

Application of special storage policy is split out into chrome/browser/net/quota_policy_channel_id_store. 

TEST=net_unittests --gtest_filter=SQLiteChannelIDStoreTest*
TEST=unit_tests --gtest_filter=QuotaPolicyChannelIDStore*

BUG=397545

Review URL: https://codereview.chromium.org/381073002

Cr-Commit-Position: refs/heads/master@{#289996}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289996 0039d316-1c4b-4281-b951-d872f2087c98

The webui cert viewer was still using x509_certificate_model::GetCertChainFromCert instead of X509Certificate::GetIntermediateCertificates. This was fixed in the gtk cert viewer in r135231, but the webui cert viewer was missed. (x509_certificate_model::GetCertChainFromCert was not implemented on OpenSSL, and on NSS the chain it returned may differ from the the chain that was actually used.)

BUG=77757,338887

Review URL: https://codereview.chromium.org/376753002

Cr-Commit-Position: refs/heads/master@{#289994}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289994 0039d316-1c4b-4281-b951-d872f2087c98

BUG=403872

Review URL: https://codereview.chromium.org/478453002

Cr-Commit-Position: refs/heads/master@{#289993}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289993 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#289988}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289988 0039d316-1c4b-4281-b951-d872f2087c98

This updates the entries in DEPS for the w3c repos to track the
tip-of-tree on the 'blink' branch.

This is patch 4 of 6 in the roll.

TBR=phoglund@chromium.org
BUG=404022

Review URL: https://codereview.chromium.org/475173003

Cr-Commit-Position: refs/heads/master@{#289987}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289987 0039d316-1c4b-4281-b951-d872f2087c98

BUG=398062
R=sadrul@chromium.org
TBR=volick@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/473113002

Cr-Commit-Position: refs/heads/master@{#289986}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289986 0039d316-1c4b-4281-b951-d872f2087c98

BUG=317718
TEST=manually tested

Review URL: https://codereview.chromium.org/382973002

Cr-Commit-Position: refs/heads/master@{#289985}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289985 0039d316-1c4b-4281-b951-d872f2087c98

Introduce WindowListProviderImpl that simply works with the stacking order of
child windows of the container. This changes the behaviour of repeated bezel
swipes from the left edge to swipe between the last two active windows, which
is the desired behaviour.

BUG=403444
R=mfomitchev@chromium.org, oshima@chromium.org

Review URL: https://codereview.chromium.org/470083004

Cr-Commit-Position: refs/heads/master@{#289984}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289984 0039d316-1c4b-4281-b951-d872f2087c98

BUG=403868
R=sadrul@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/464213006

Cr-Commit-Position: refs/heads/master@{#289982}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289982 0039d316-1c4b-4281-b951-d872f2087c98

SearchProvider enforces that if the user is in keyword mode, the
only suggestions allowed to be the default match are keyword mode
suggestions, lest they break the user out of keyword mode.

Previously, this constraint was applied with an after-the-fact
correction to allowed_to_be_default_match.  This change sets
allowed_to_be_default_match correctly when the AutocompleteMatches
are created.

All tests pass.  (And yes, this constraint enforcement is tested.
Here you can see the tests that were added when the constraint was put
in place: https://codereview.chromium.org/67693004 .)

BUG=398135
R=msw@chromium.org

Review URL: https://codereview.chromium.org/476263002

Cr-Commit-Position: refs/heads/master@{#289981}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289981 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#289980}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289980 0039d316-1c4b-4281-b951-d872f2087c98

This picks up:

3186999  Fix for incorrect builtin with clang 3.6

BUG=400849
R=fdegans@chromium.org, navabi@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/479623003

Cr-Commit-Position: refs/heads/master@{#289979}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289979 0039d316-1c4b-4281-b951-d872f2087c98

The "Resource-Freshness" header was temporarily named
"Chromium-Resource-Freshness" during development.

Since Chrome policy is to avoid using vendor prefixes, we should not
ship the browser to stable with this header name.

Rename the header to "Resource-Freshness".

TEST=net_unittests
BUG=348877

Review URL: https://codereview.chromium.org/469993008

Cr-Commit-Position: refs/heads/master@{#289978}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289978 0039d316-1c4b-4281-b951-d872f2087c98

The inner class needs to be exported in case any uses in inline methods
or vtable of the outer class causes it to potentially be referenced across
a shared library boundary.

On non-Windows, the visibility attribute is already inherited by nested
classes, but on Windows, they must be marked explicitly.

BUG=82385
R=thakis@chromium.org, willchan@chromium.org

Review URL: https://codereview.chromium.org/476013002

Cr-Commit-Position: refs/heads/master@{#289977}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289977 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#289976}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289976 0039d316-1c4b-4281-b951-d872f2087c98

Focus and activation are closely related. Focus could
perhaps be considered a view manager concept, but
activation is window-manager specific, and cannot. Event
dispatch is influenced by (among other things) focus. So,
move event dispatch to the window manager.

I still like the idea of the view manager client lib
providing a "flattened" API to users that allows
setting/querying focus state & observing changes, rather
than obliging everyone connect to the window manager
independently (though they may want to do so for other
reasons). So I'm having the view manager client connect
to the window manager & continue to provide the
SetFocus()/FocusChanged APIs. This causes a minor dilemma
in that we have two window managers but only one view
manager client. Right now I resolved this by defaulting
to the original window manager and allowing others to be
specified on the command line to the shell, but I think
we will eventually want a way to register a default
window manager.

R=sky@chromium.org
BUG=

Review URL: https://codereview.chromium.org/474883003

Cr-Commit-Position: refs/heads/master@{#289975}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289975 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r13624: (dschuff) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r13625: (jvoung) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r13626: (dschuff) Update revision for PNaCl r13616->r13625

BUG=none
TEST=browser_tests and nacl_integration

Review URL: https://codereview.chromium.org/480473003

Cr-Commit-Position: refs/heads/master@{#289974}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289974 0039d316-1c4b-4281-b951-d872f2087c98

This makes the following changes to media.gyp to make it compile for iOS (for
the Chromoting iOS client):

- Don't use ffmpeg or libvpx in media (just like Android)
- Do use libyuv
- Add yasm flag to decorate functions correctly for iOS (just like in the Mac)

BUG=134226

Review URL: https://codereview.chromium.org/474693002

Cr-Commit-Position: refs/heads/master@{#289973}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289973 0039d316-1c4b-4281-b951-d872f2087c98

BUG=https://code.google.com/p/webrtc/issues/detail?id=3601

Review URL: https://codereview.chromium.org/466843002

Cr-Commit-Position: refs/heads/master@{#289972}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289972 0039d316-1c4b-4281-b951-d872f2087c98

BUG=403515

Review URL: https://codereview.chromium.org/474573003

Cr-Commit-Position: refs/heads/master@{#289971}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289971 0039d316-1c4b-4281-b951-d872f2087c98

verifier_test_dll_1.dll.exp : warning LNK4070: /OUT:verifier_test_dll.dll directive in .EXP differs from output filename 'verifier_test_dll_1.dll'; ignoring directive
BUG=

Review URL: https://codereview.chromium.org/473693003

Cr-Commit-Position: refs/heads/master@{#289970}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289970 0039d316-1c4b-4281-b951-d872f2087c98

BUG=377978

Review URL: https://codereview.chromium.org/420543002

Cr-Commit-Position: refs/heads/master@{#289969}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289969 0039d316-1c4b-4281-b951-d872f2087c98

The header include order checks were running on all
affected files, including third_party for example,
this causes issues when rolling harfbuzz-ng.

BUG=404105
NOTRY=true

Review URL: https://codereview.chromium.org/462323003

Cr-Commit-Position: refs/heads/master@{#289968}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289968 0039d316-1c4b-4281-b951-d872f2087c98

CRX file code currently lives under extensions/. However, 
component_updater also uses them to package components. The 
CRX code should therefore live as its own component.

BUG=371463
TBR=blundell@chromium.org

Review URL: https://codereview.chromium.org/474633005

Cr-Commit-Position: refs/heads/master@{#289966}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289966 0039d316-1c4b-4281-b951-d872f2087c98

Metrics to track how many times users open a distilled page or distilled page
preferences.

BUG=383630

Review URL: https://codereview.chromium.org/476953002

Cr-Commit-Position: refs/heads/master@{#289965}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289965 0039d316-1c4b-4281-b951-d872f2087c98

BUG=404066

Review URL: https://codereview.chromium.org/476133002

Cr-Commit-Position: refs/heads/master@{#289964}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289964 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#289962}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289962 0039d316-1c4b-4281-b951-d872f2087c98