- 23 Nov, 2019 40 commits
-
-
Tim Schumann authored
Flaky on Windows and Mac platforms. TBR=crouleau@chromium.org BUG: 1027902 Change-Id: I354fd7411f1c7e65748550fcc297f576f0753e46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932656 Commit-Queue: Tim Schumann <tschumann@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#718455}
-
David Bokan authored
This threshold goes all the way back to: https://crrev.com/ee5bc3acd0986e8fa87df7f804c49c120b8c9bc2 and was initially added to avoid superfluous scrolling of form controls on horizontally scrollable pages. If an element horizontally overlaps the scrollport by at least this threshold it's considered "fully visible" as per the scroll into view algorithm: https://drafts.csswg.org/cssom-view/#scroll-an-element-into-view Horizontal scrollable pages and partially visible form controls should be rather uncommon and we should remove magical numbers from platform behavior. If this behaivor is truly required for form controls we can special case those but lets first try removing this altogether. This does have some small impact on web-facing APIs in that scrollIntoView (as well as fragment navigations) will now align an element that's only partially on screen with the left edge. This matches the behavior in FireFox and the spec. I've modified the input-placeholder-paint-order.html and the ShowUnhandledTapUIIfNeeded tests to avoid scrolling and anchor-frames-same-origin.html to expect horizontal scrolling for this reason. [Reland Note] When first landed this caused SitePerProcessHitTestBrowserTest.ScrolledNestedPopupMenuTest/0 to start failing on linux-chromeos-rel with viz disabled. It now passes when relanded on ToT since https://crrev.com/c/1928895 turned Viz on by default on ChromeOS so this CL is a simple reland. TBR=szager@chromium.org Bug: 916631,1027403 Change-Id: Ic830083defa3684b0f2570edc5ae92249a6d9f18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931381Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#718454}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a346870b. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I5206e5aa3180fa00fb999f5918d22e525ed71646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932676Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718453}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d8ffff17ad6f..79330b60ac89 Created with: gclient setdep -r src-internal@79330b60ac89 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None,chromium:None,chromium:None Tbr: jbudorick@google.com Change-Id: I90e85c758bb3f2a08a107173fa693a605e1158bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932696Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718452}
-
Maggie Chen authored
After adding more thread time and 60 seconds to the watchdog timeout, we don't need full 60 seconds for initialization timeout. 30 seconds (kInitFactor=2) should be a good number. We can adjust it later when Timeout histogram data is available. (gpu/OWNERS is added to the owner list of gpu_watchdog_timeout.h. The constants defined in this file are for watchdog internal use and there is no security concern.) Bug: 988344, 949839 Change-Id: I9c5148f961e5db53c1b7123a7d5c7e2b13de6b89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930143Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#718451}
-
Vaclav Brozek authored
CSVPasswordSequence is the new CSV parser for importing credentials. Unlike its predecessor, CSVPasswordSequence does not create all of the parsed passwords in memory at once. Instead it parses the CSV row-per-row on demand. This reduces the memory usage (high water mark). This CL replaces the uses of the old CSV parser with CSVPasswordSequence and removes the old parser. It also changes base::Callback to base::OnceCallback for the importing callback to better reflect the flow of the program. Finally, it adds a test for PasswordManagerPorter to cover importing / writing to PasswordStore. Due to introducing the new parser, the csv_reader_fuzzer should reduce its memory consumption. Bug: 934326 Change-Id: If90a7483f826e83047114ac2b07ba1c62377c07d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920121 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#718450}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bbfce899. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rob.buis@samsung.com: external/wpt/quirks NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I83538e154e96d2b25783d7cec2623ffaa04dbf0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932198Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3bc4235baa96..50299de39976 git log 3bc4235baa96..50299de39976 --date=short --no-merges --format='%ad %ae %s' 2019-11-23 robertphillips@google.com Reland "Revert "Make FP optimizations helpers use SkAlphaType not GrColorType"" 2019-11-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-23 bsalomon@google.com Revert "Revert "Make FP optimizations helpers use SkAlphaType not GrColorType"" 2019-11-22 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-22 bsalomon@google.com Test texture domain effect with local matrix. 2019-11-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 b8e748be6b94..4c7db77e0185 (21 commits) 2019-11-22 halcanary@google.com LICENSE file: clean up Created with: gclient setdep -r src/third_party/skia@50299de39976 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:None Tbr: robertphillips@google.com Change-Id: Ibb83f38b7fe64f1138cd6a31a7536c222167ecc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932240Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718448}
-
Tim Schumann authored
and the subsequent PowerSaveBlockerLinux [3/4] and PowerSaveBlockerLinux [4/4] patches This reverts commit 2fdeba1b. ("Rewrite PowerSaveBlockerLinux [2/4]") This reverts commit 38fdf074. ("Rewrite PowerSaveBlockerLinux [3/4]") This reverts commit 3bc463b4. ("Rewrite PowerSaveBlockerLinux [4/4]") The patch caused timeouts in WakeLockTest.ChangeType() and other tests in the services_unittests on Linux Tests (dbg). More details in crbug/1027852. TBR=thomasanderson@chromium.org Bug: 1013812,1027852 Change-Id: I7688c72f9d9d6c12ff3731f3abde6a05508cfbeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932357 Commit-Queue: Tim Schumann <tschumann@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/485166945452..d8ffff17ad6f Created with: gclient setdep -r src-internal@d8ffff17ad6f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Ifaa804a17f33937722d774600087c1db3d7d0966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932397Reviewed-by:
-
Tim Schumann authored
This reverts commit 713420fb. Reason for revert: Causes MSAN failure More details in crbug/1027853 Original change's description: > ozone: Build with xkbcommon by default on is_linux && !is_chromecast > > This is necessary on Linux targets unless you don't want keyboard > support or only need support for a hardcoded US layout. > > Noticed because the CQ broke after building for ozone locally. This > reduces the number of flags needed to build as the Linux Ozone builder > does. > > Bug: 1026476 > > Change-Id: I77352c133b1f7552301b6e1f252d40a4f2c72106 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925370 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Kevin Schoedel <kpschoedel@chromium.org> > Commit-Queue: Michael Spang <spang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718240} TBR=sky@chromium.org,spang@chromium.org,kpschoedel@chromium.org Change-Id: I4fa0de1881acbf1eaf7e70bfe4b24dbc84647f43 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1026476 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932436Reviewed-by:
-
Antonio Gomes authored
Note that this CL does not move RTCSessionDescriptionPlatform to Oilpan heap. This is saved for a follow up step, in order to reduce th functionality change. R=guidou@chromium.org, haraken@chromium.org BUG=787254 Change-Id: Ib634f68efd25869518c16b564e0a2edcd05569f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929497Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#718444}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3c3fc55c. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Id84faba4a32d038b802098f5c40cc558efe29523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932197Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4489e0e098c3..485166945452 Created with: gclient setdep -r src-internal@485166945452 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Idd2a6169b97e33c23733c9d214b46cc5e6c45caf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932026Reviewed-by:
-
Denis Kuznetsov authored
Remove unused oobe_change_picture that was not cleaned up during work that removed code that used it: https://chromium-review.googlesource.com/c/chromium/src/+/1488018 Bug: 903577 Change-Id: Ib327d1eaa3ff1ea2c62478c726cc8be6399ceefb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919205Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#718441}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/031361ca8db6..4489e0e098c3 Created with: gclient setdep -r src-internal@4489e0e098c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I2fd83cf2b42f12cbe1eef3683eb945f99daca6c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932025Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/86258aab8096..38b4db48f98c git log 86258aab8096..38b4db48f98c --date=short --no-merges --format='%ad %ae %s' 2019-11-23 cepheus@frii.com Fix #1983: __ is okay starting with ES 300, rather than 310. Created with: gclient setdep -r src/third_party/glslang/src@38b4db48f98c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com Change-Id: If44dc21fe7ccb9ab6550c4aa71dfc26945f1cd11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932022Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/16974ce1435b..031361ca8db6 Created with: gclient setdep -r src-internal@031361ca8db6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I0824897324d4e26cdfb5dbc4cb8a8e7f08788b82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932021Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5a1f7181. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ib46d725e68fcd89e0988a2226b4d719a7d043a80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932196Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9d28b54b9e21..16974ce1435b Created with: gclient setdep -r src-internal@16974ce1435b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I5d3055850d2803264940f0eee830ef192ef786f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932019Reviewed-by:
-
David Tseng authored
- rename all *.extjs and *.unitjs files to *.js - fix all linter errors - run clang-format on all files (which are now enforced as .js files). Change-Id: Ia2064db1caed23e3cf85bee3f46ad716fac4e5dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925339 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#718435}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/733842c59dd2..8e9c3f663ccd git log 733842c59dd2..8e9c3f663ccd --date=short --no-merges --format='%ad %ae %s' 2019-11-23 cwallez@chromium.org Fix compilation on MSVC Created with: gclient setdep -r src/third_party/dawn@8e9c3f663ccd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I4331a9b3d24bae0a07bd3aa94f7cd19afbd2618e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932017Reviewed-by:
-
nancy authored
When using AppService, all apps use launch process. However, for Chrome apps or Web apps, previous extension class uses ChromeLauncherController's ActivateApp interface: https://chromium-review.googlesource.com/c/chromium/src/+/1858538/16/chrome/browser/ui/app_list/search/extension_app_result.cc#b85 https://cs.chromium.org/chromium/src/chrome/browser/ui/app_list/app_list_client_impl.cc?q=ActivateApp&l=494&dr=CSs So update the AppService code to use the same interface for the non-platform apps, so that the user can switch back to the previous app window when using search, which is the consistent behaviour with M77. BUG=1026730 Change-Id: I3318f3cecc075394383dc2ed42836dad83c8edb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930245 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#718433}
-
George Zhang authored
Change-Id: I996471f830c2fc5f00b4f9e45d9da5b2ed331b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929844Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#718432}
-
Sam McNally authored
low-pressure-touch-filtering is no longer used for any board. touch-noise-filtering and touch-calibration were only used by link, which is now AUE so remove the flags and related code. Bug: 1022236 Change-Id: I5df344823ed318b5f8880c6010724207ebc141bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913686Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#718431}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f8be29faf549..9d28b54b9e21 Created with: gclient setdep -r src-internal@9d28b54b9e21 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I805edad01f15896a1adddd68c1de6658f88682cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931924Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/aef9e1f7..30319dfe Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9db919c33dc41179e04e2cb2f27ca20c4427175f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931626Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718429}
-
Oystein Eftevaag authored
This avoids a deadlock on Win7 due to the ThreadLocalStorage::Slot requiring the loader lock to be taken. R=ssid@chromium.org Bug: 10229997 Change-Id: I0fd38b6493a5cbf83b732d659c34c302e3cc73e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928294 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
This change simplifies ExtensionErrorUI and two of its related classes. Specifically, this change: 1) Makes ExtensionErrorUI a pure virtual interface by moving all its behavior into the only subclass that benefits from it (namely ExtensionErrorUIDefault) 2) Demotes ExtensionErrorUIDefault::ExtensionGlobalError to a non-nested class to get it out of the header file; 3) Has ExtensionGlobalError (as it is now known) directly call the given ExtensionErrorUI::Delegate rather than funneling back through the ExtensionErrorUI base class; 4) Reworks the logic for generating the bubble's message so that it a) uses std::transform instead of open-coded loops b) does not iteratively append a base::string16 c) does not do manual string-handling to get newlines to line up (in fact, GlobalErrorView supports multi-line messages natively, so doing so was never necessary) 5) Generally spruces up the involved code via NULL -> nullptr, raw pointers -> unique_ptr, some use of auto, etc etc. Bug: None Change-Id: I0f48e2e3bd901d2eae2b65b0dc1dbd79b38b9687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929754 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#718427}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/8b5853d4f91a..86258aab8096 git log 8b5853d4f91a..86258aab8096 --date=short --no-merges --format='%ad %ae %s' 2019-11-23 johnkslang@users.noreply.github.com Merge pull request #1972 from andflo-Arm/master Created with: gclient setdep -r src/third_party/glslang/src@86258aab8096 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com Change-Id: Ia383b64f09ac6a054640f41d4a162a3648127b89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931921Reviewed-by:
-
Tom Anderson authored
* Build power_save_blocker_linux.cc for Linux/Ozone in addition to Linux/X11. * Refactor complex behavior in BUILD.gn BUG=1013812 TEST=Tested on GNOME and KDE environments R=blundell Change-Id: I87ae2cfedcc5d4d2d995f9a94a9f77354bb1c4ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926855 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#718425}
-
Peter Kasting authored
I don't think it makes sense to override a few colors to be Windows-native-y but not most of them. Furthermore, the colors used are the return values from GetSysColor(), which for the majority of our users aren't the colors in native UI anyway (e.g. a Win 10 File Explorer tree view does not use COLOR_HIGHLIGHT for selections), so while this looks _different_ than before, it doesn't particularly look less native. The main visible effect of this is to replace some bright blue selection colors (trees, focused tables) with greys. This increases consistency since we already use greys in menus (which are more frequently seen). Bug: 1024091 Change-Id: I38822d3e3972cd077950c4c1ee859da21e73f4cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931582 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#718424}
-
David Van Cleve authored
Recent change crrev.com/c/1906511 made URLPattern reject invalid URLs as inputs to URLPattern::MatchesURL in order to avoid violating a precondition of GURL::PathForRequest, which requires the GURL in question to have a nonempty path. However, this wasn't quite enough: fuzzing exposed another bug, namely that valid-but-pathless inputs to URLPattern::MatchesURL (for instance, "javascript:") can still make MatchesURL call into PathForRequest. This change makes MatchesURL explicitly reject URLs with empty paths unless matches_all_urls_ is set. R=devlin Test: Added regression tests. Bug: 1026016 Change-Id: I87f49cd558cdfac7d76cd9d1ba01941ee7d6845c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925756 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
-
Tom Anderson authored
* Renames power_save_blocker_x11.cc into power_save_blocker_linux.cc * Made the power save blocker compatible with non-X11 linux, so ozone builds can use it. This requires guarding X11-specific behavior behind #if defined(USE_X11). BUG=1013812 TEST=Tested on GNOME and KDE environments R=blundell Change-Id: I7e23439bb9b7d7d961d1dc9f5a803ce7226b0706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926928 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/df3cd06cdbe8..f8be29faf549 Created with: gclient setdep -r src-internal@f8be29faf549 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Id2ebd4a7b3a1cd6d714b61794afb665269b57154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931918Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts RemotingDataStreamSender to new Mojo types using PendingRemote, PendingReceiever, Receiver, and Remote. Bug: 955171 Change-Id: I6e19b01ee378d1996e1bed31dea0fed7bc8baefc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923972 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#718420}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I5787e3e65d9b4596ba483fc96e96724dd3c52ed2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931916Reviewed-by:
-
Pavel Feldman authored
Change-Id: I1fe3dfdf032c5780eb7a14f27816f235b4e27c6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931345 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Auto-Submit: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#718418}
-
Tom Anderson authored
* Removed SelectAPI() which relied on the XDG_CURRENT_DESKTOP environment variable. The correct approach is to check the presence of each DBus API directly. * Remove unnecessary |freedesktop_suspend_delegate_|. PowerSaveBlocker::Delegate can now hold multiple inhibit cookies, so having multiple delegates is no longer needed. BUG=1013812 TEST=Tested on GNOME and KDE environments R=blundell Change-Id: Ia338a12a70e3deed72166e5a980eec64767a7f92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926852 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f72b13cb..aef9e1f7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iadc505d2d650f6e5c0f6adb81ddc8482bbd8aaa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931623Reviewed-by:
-
