- 18 Oct, 2019 5 commits
-
-
minch authored
see recorded video: https://drive.google.com/file/d/0B5I0jFeLxqIiWTBWSk5Pd0JsQ0hva0x0MTUtNVBqZGoyWGtV/view?usp=sharing Bug: 1002733 Change-Id: Ia4e1bc3f4d913c8543f8b593454abf3f4d3d7871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865623Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#707175}
-
Henrique Nakashima authored
The main purpose of ChromeIntentUtil is to construct an intent to ChromeLauncherActivity, so it makes sense to be in the same package as ChromeLauncherActivity, for the lack of a better place. Bug: 995916 Change-Id: Ieb3d01d080f418f664ce5ff881831516cf02b1fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867291Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#707174}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/db8df1765017..e8b962bd3c97 git log db8df1765017..e8b962bd3c97 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 60f3e975..1d5b803f (706891:707010) 2019-10-17 peah@webrtc.org AEC3: Removed some usages of DirectPathFilterDelays 2019-10-17 kcwu@google.com Use FakeRenderer when fuzzing 2019-10-17 peah@webrtc.org AEC3: Add multichannel support in the ERLE estimation Created with: gclient setdep -r src/third_party/webrtc@e8b962bd3c97 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:952606,chromium:1009077,chromium:1009073 Change-Id: I6c0eb417fd1b5818ff363ef3f770dc2629027793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867430Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707173}
-
Hesen Zhang authored
Bug: 1013685 Change-Id: Ie6d891ea3b97eaee29f694390d8b093d307b4c86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865132 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
-
Christopher Thompson authored
When working on crrev.com/c/1829462, I noticed in manual testing that the component loading the configuration from disk can take upwards of 6 seconds to complete, causing the configuration to not be loaded by the time an affected page navigation has completed (causing the UI to not be shown correctly). The current version of the TLSDeprecationConfigComponentInstallerPolicy loads the configuration proto from disk using a PostTask with priority BEST_EFFORT, causing the configuration load to be delayed, especially near browser startup. Changing the priority of the load task to USER_VISIBLE (since the state of the config affects security UI shown to users) causes this race to go away (or become much, much less likely to occur, which is sufficient in this case). Bug: 1011089 Change-Id: Idd98b225a7ae9d6444acf0d8121fa6055f8e06e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831451 Commit-Queue: Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#707171}
-
- 17 Oct, 2019 35 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/74af4241e484..12fa2ef9c6d1 Created with: gclient setdep -r src-internal@12fa2ef9c6d1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I8386523369031da30388ba010781da73fe4091a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867429Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707170}
-
Xiaoqian Dai authored
Clamshell mode behavior will remain the same, i.e., tapping on the overview background will return to its previous state, it can either be in-app or home screen. Bug: 997885 Change-Id: I5006c69081157b30f695a05642d20e3d7f505822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867375Reviewed-by:
-
Daniel Cheng authored
This uses the terminology from http://www.chromium.org/developers/design-documents/blink-coordinate-spaces. Change-Id: I800f69b8a39c99ad79e52873464dbf106d60497d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865654 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#707168}
-
Clark DuVall authored
This is a reland of cf1e154f Added in the fixes from http://crrev.com/c/1867289 to fix browsertests. Original change's description: > [WebLayer] Load pak files correctly on Android > > Loading pak files was not quite working right in weblayer, since we were > not loading locale paks. This caused text on e.g. submit buttons to not > show up in some configurations like loading from monochrome. > > This change makes weblayer load pak assets similar to webview, and > uses the webview pak deps for the weblayer support APK, since those > should be sufficient for weblayer. > > As an added bonus this also allows l10n to work, so switching the > default language of the device will show buttons and labels in that > language. > > Change-Id: I1a2b47009e7bb74f1ea3c16dc6f52451e2b78066 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865015 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706978} TBR=jam@chromium.org,torne@chromium.org Change-Id: I58961564500bcc92d05bf84e7372c2aca8a17c57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866925Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#707167}
-
Peter Boström authored
ToolbarButton is already responsible for interior margins as insets on both sides. Prior to this all ToolbarButtons could have a leading margin but no trailing margin. In practice it just consolidates code for consistency. This change ends up removing duplication of GetAnchorBoundsInScreen() and UpdateBorder() both of which are already handled in ToolbarButton. As a bonus (!) this applies Fitts' law to toolbars shown in fullscreen windows, which I needed to verify that extending trailing margins still worked as expected on Mac. Bug: None Change-Id: I72bdd6be6663167226a8e9b8446d874859774cb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866982Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#707166}
-
Thanh Nguyen authored
This CL adds required metrics for Improved App Search on Chrome OS project. Bug: 990684 Change-Id: I8c940317af0ef1bca1856ee3790d53b6e96b321a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850678 Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#707165}
-
danakj authored
This IPC was sent in order to tell WebViews without a local main frame about the value. Since each RenderWidget has a value for this property, we can set the value on the WebView from there, removing the need for the IPC. Note that the RenderWidgetHostViewChildFrame does compute some different value for the visible_viewport_size when auto-resize is enabled, instead of using the value that the main frame RenderWidget uses. It's unclear why this happens. It means after this CL child frames may see a different value (the one their RenderWidgetHost sees) on their WebView, instead of the value from the root RenderWidgetHost directly. This will give the child frames a more consistent view however as the RenderWidget itself receives the value its RenderWidgetHost computes. Child frames in the same RenderView frame tree as the main frame has the unfortunate situation of possibly conflicting with the main frame and having a different value between the main frame and themselves, while sharing the same WebView, and in this case they can not win. They do not clobber the value that the main frame sets on the WebView though. This CL clarifies a bunch of code and documents the RenderWidget waterfall dance. The RenderWidget waterfall dance for visual properties propagates visual properties set for the top level main frame RenderWidget down the tree of local root RenderWidgets to reach every RenderWidget - and as a result to each RenderViewImpl and WebView also. The plumbing goes like: 1. Browser: parent RenderWidgetHost 2. IPC -> WidgetMsg_UpdateVisualProperties 3. Renderer A: parent RenderWidget (sometimes blink involved) 4. Renderer A: child RenderFrameProxy 5. IPC -> FrameHostMsg_SynchronizeVisualProperties 6. Browser: child CrossProcessFrameConnector 7. Browser: parent RenderWidgetHost (We're here if |is_child_frame|.) 8. IPC -> WidgetMsg_UpdateVisualProperties 9. Renderer B: child RenderWidget 10. (sometimes RenderViewImpl/WebViewImpl) We remove PageMsg_UpdatePageVisualProperties which was bypassing the waterfall to each RenderViewImpl directly, which jumps past the compositor synchronization done with UpdateVisualProperties in the waterfall dance. See also https://docs.google.com/document/d/1G_fR1D_0c1yke8CqDMddoKrDGr3gy5t_ImEH4hKNIII/edit R=avi@chromium.org, dcheng@chromium.org Bug: 419087 Change-Id: I298538a71e6428b2182baf6742c21c104a3a5d75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863512 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#707164}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f483d4ee4696..5fcfcea4a937 git log f483d4ee4696..5fcfcea4a937 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 jmadill@chromium.org Add more test_utils functions. 2019-10-17 geofflang@chromium.org Fix compiler warning in NativeBufferImageSiblingAndroid.h. 2019-10-17 tobine@google.com Make invalid extension directive a CHROMEOS warning 2019-10-17 geofflang@chromium.org Fix building libpng on arm CPUs. 2019-10-17 lehoangq@gmail.com Report Metal as unavailable Created with: gclient setdep -r src/third_party/angle@5fcfcea4a937 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@google.com Bug: chromium:1003005 Change-Id: I620c909b8941cc7ffc5062dda02e9c55099d473d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867369Reviewed-by:
-
Joe DeBlasio authored
This CL adds dark mode detection and images for the Safety Tip banner. Bug: 1013401 Change-Id: I1be3f117fcc87f84b0add44610f5776fddc1431c TBR: oshima@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866855Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#707162}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b594247e39a4..fd843fa45664 git log b594247e39a4..fd843fa45664 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 erikchen@chromium.org Add diagnostics to git_cache. Created with: gclient setdep -r src/third_party/depot_tools@fd843fa45664 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I5be899470437b1a7ebc06a1bc417ef593ec2063a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867303Reviewed-by:
-
Jinsuk Kim authored
Tab reparenting task is used for custom tab or in multi window mode to move a Tab object from an activity to another. This CL refactors it into its own per-tab class to drive the task. Bug: 995903 Change-Id: I5d9565765902a5669fdd9cb2c3b7439228a53598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829618 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#707160}
-
Xiaoqian Dai authored
Repro steps: - Enable hotseat feature --shelf-hotseat - Open an app window - Swipe on the shelf to bring up hotseat - Swipe on the shelf again to start drag the active window The window can be dragged only upward, but not downward. The reason is ShouldHomeGestureHandleEvent() has filtered out the downward scroll update events when hotseat is enabled. We should always let HomeLauncherGestureHandler handle the scroll event if it has handled the press down event. Bug: 997885 Change-Id: I3029be80d27ca31d470084973575218b8966626f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867020Reviewed-by:
-
Andrew Luo authored
Test: wpt run --test-type=testharness android_webview --no-manifest-download Change-Id: Iefbfb67d37be0281c0520fb9a6cb7e23995c611b Bug: 1011098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867038 Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#707158}
-
Yann Dago authored
Bug: 999569 Change-Id: Iace05a9990f8de8a67ddd0485fa898dd90b11f7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866230Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#707157}
-
Kai Ninomiya authored
This reverts commit 1b433749. Reason for revert: Next branch point Original change's description: > Revert "Disable use_dawn for the branch point." > > This reverts commit b524af00. > > Reason for revert: M78 has branched (r693954) > > Original change's description: > > Disable use_dawn for the branch point. > > > > This flag controls the inclusion of Dawn and the availability of WebGPU > > which we want to keep limited to Canary for now. > > > > TBR=kbr@chromium.org > > BUG=chromium:985142 > > > > Change-Id: I7677ec0571bcf394af4442829ad86e92a87b8a6b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784611 > > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > > Commit-Queue: Corentin Wallez <cwallez@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#693224} > > TBR=kbr@chromium.org,cwallez@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: chromium:985142 > Change-Id: Ia5128d014026d46c0138d9a948b851856da5d310 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789430 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Commit-Queue: Kai Ninomiya <kainino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694516} TBR=kbr@chromium.org,cwallez@chromium.org,kainino@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:985142 Change-Id: If23eeb89a3130eafe1def72e293d60c0bd0222e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867091Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#707156}
-
W. James MacLean authored
This CL modifies RenderViewHostImpl to walk the frame tree when setting ForceEnableZoom, so that all child RenderWidgetHosts are notified of the desired value. Bug: 1009232 Change-Id: I5047456c9bb230c40d753e0ddf3dc0f06d8c7ca6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856239 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#707155}
-
Sanket Joshi authored
This change fixes a bug where the popup for the color picker and color suggestion picker appears larger than expected on certain device form factors, leaving a lot of spare whitespace surrounding the picker inside the popup. The issue is that the zoom factor used in popup window resizing does not take into account viewport scale. (Other popups like date do this, but the color popups do not.) Bug: 1015301 Change-Id: I74f92cdb1649d531a2964fe7974ca4d8ff4bc0bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866278 Commit-Queue: Sanket Joshi <sajos@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#707154}
-
chrome://flagsCarlos IL authored
Bug: 987294 Change-Id: I7ada477ea649652bca83eb3db7a9100662548cf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867298 Commit-Queue: Carlos IL <carlosil@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
-
Simeon Anfinrud authored
Android can default to the WebContents' default handling of key events. Merge-With: eureka-internal/326040 verify that key events are plumbed to JavaScript. Bug: Internal b/142758140 Test: cast_shell_junit_tests Test: cast_shell_unittests Test: Use chrome://inspect to monitor key events in Cast app to Change-Id: Ibb4a50ab3832acfdfa6115f5771ff6b7ffbb5c73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865756 Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#707152}
-
Min Qin authored
In Chrome, URL size is limited to 2MB when serializing the IPC. As a result, downloading a large data URL will fail. This CL fixes the issue by creating a blob to hold the data and pass it across process boundaries. It also changes the implementation of RenderFrameImpl::SaveImageFromDataURL() to also use a blob instead of passing a large std::string in IPC. BUG=947395 Change-Id: I21779af402bb8cf4fbfa7cf73acd8cac594d0c2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832723Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
Ken Buchanan authored
This metric has been useful in helping understand the availability of Bluetooth adapters among Chrome users on different platforms, which is informing decisions on Web Authentication strategy around Bluetooth authenticators, especially as we move toward supporting smartphones as Bluetooth-connected authenticators. Moving the expiry out a year so that we can continue to collect this data. Change-Id: Iaba3675f08d9f9d4b8eacfe0098289b3f7bf5b9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867201Reviewed-by:
-
John Abd-El-Malek authored
Change-Id: I4ca87e1c8ef4f03a24003d2119a1b49e2108a007 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865684Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#707149}
-
Ben Pastene authored
The recipe will essentially run a custom analyzer on chrome metric-related config files. So it shouldn't need any build or test configs. Bug: 1015221 Change-Id: I77cf81ed428a559727b78ad5241b382778e2306f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866926Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#707148}
-
Yulun Wu authored
The old approach of adding title as a disabled item meant that this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1788198 causes the menu title to be displayed in grey text instead of solid black text. This CL introduces a new menu type that, while still disabled and non-reactive, be displayed in solid black text. Bug: 1006203 Change-Id: I9fa38132160228ebde5bd43d8db9c2f60d5f001c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841583Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Auto-Submit: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#707147}
-
Eric Lawrence authored
The |Accept-Encoding| request header should be omitted from the cURL command line to avoid problems decompressing responses on platforms where cURL does not support the same set of decompressors as Chrome itself. Bug: 1015321 Change-Id: I2948affb89ff46ad1b9869b2532f75efb4acf6f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865608Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#707146}
-
Ken Rockot authored
This structure is fully replaced by a C++ KeyValuePair type. The LevelDBDatabaseImpl::GetPrefixed() API has been removed as well, and callers have been updated to use the underlying DomStorageDatabase's GetPrefixed API directly instead. To support this usage cleanly, LevelDBDatabaseImpl's RunDatabaseTask helper API has been adapted to allow tasks to return a tuple, which will then be unpacked into explicit function arguments passed to the task's result callback. This is used with one of the new GetPrefixed conversions, and is also used to improve the readability of SessionStorageContextMojo's metadata retrieval and parsing logic. Bug: 1000959 Change-Id: Id012594dcacddbc4b708df6bd363b1a4029bb455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864466Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#707145}
-
Jinsuk Kim authored
Peek 1.5 items to give first-time gesture users a sense of what's in the list. Bug: 1015004 Change-Id: I908426d659cceedee590b83ce573d360e257ddc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865920Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#707144}
-
Philip Jägenstedt authored
https://dom.spec.whatwg.org/#interface-element This makes it more clear where the `part` attribute is defined. Change-Id: I89a5e98a26bb1aceb1dbf19e6782841545c7d4f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863797 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#707143}
-
Alexander Timin authored
R=arthursonzogni@chromium.org,nasko@chromium.org CC=clamy@chromium.org,alexmos@chromium.org Change-Id: Id611558b25577926a759f98620419755d3f32253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865332Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#707142}
-
Mario Bianucci authored
These tests started being flaky as soon as they were initially landed. It seems to be a timing issue, so I added in two pieces to ensure timing is correct: 1. MainThreadFrameObserver - I was seeing that occasionally, the frame wouldn't have been produced by the time the test was sending the first scroll or zoom, resulting in the scroll or zoom bailing early and not happening. The MainThreadFrameObserver will make sure that execution waits until a frame is produced and everything is in sync before continuing. 2. InputMsgWatcher - This ensures that the test receives an ACK back from the expected event type each time a scroll or zoom is performed. The ACK can technically be a few different things based on different conditions but it doesn't really matter what it is, just that an ACK is received. This allows us to be certain that we are waiting long enough before checking the zoom or scroll amounts. Bug: 1010911 Change-Id: Ieb1c3993cdc17afacd8aecb5e823881c539a1e12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837892Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#707141}
-
Lan Wei authored
RecommendAppsScreenTest.ParseError is very flaky on ChromeOS since 2019/10/16. https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSBUZsYWtlIjljaHJvbWl1bUBicm93c2VyX3Rlc3RzQFJlY29tbWVuZEFwcHNTY3JlZW5UZXN0LlBhcnNlRXJyb3IM&show_all_occurrences=1 TBR=tbarzic@chromium.org Bug: 1015013 Change-Id: Ia93fcd4624b6c35fae4e53c740e415e3a28f9b41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867469Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#707140}
-
Miriam Zimmerman authored
The text contrast was previously either far too low or borderline too low for all text. This CL makes the default text darker and uses the same color for the legal/privacy paragraph as the rest of the text. BUG=chromium:1005543 TEST=Take screenshot (on eve), check with color contrast companion. Change-Id: I791a79c92238f4b65f3e9e52c917104b153a82dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864363Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
J Kardatzke <jkardatzke@chromium.org> Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Cr-Commit-Position: refs/heads/master@{#707139}
-
Ben Pastene authored
betty-pi-arc should be identical to betty, but with a newer version of android. Since basic gtest unittest suites shouldn't interact with that level of the system, running them on both the vanilla betty and betty-pi-arc bots is redundant. Also rename & refactor several chromeos suites in test_suites.pyl to make things clearer. Bug: 1000513 Change-Id: I7755323689bb85f11174132267927c46e4885a42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867207Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#707138}
-
Albert Chaulk authored
We can handle this by not Finish()ing in this case when a read fails Bug: b/142069294 Test: force an error to occur Change-Id: I8383b01d1a6abbe7b6e523a37b4ea0e8be986976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867436Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Albert Chaulk <achaulk@chromium.org> Cr-Commit-Position: refs/heads/master@{#707137}
-
Matt Reynolds authored
This CL adds a HidConnectionWatcher client interface for observing whether a HID connection is still open. When the connection is closed, the HidConnectionWatcher's pipe is also closed. In a future CL, this will enable HidService to track the number of open connections to HID devices for the purpose of showing a tab indicator when there are open connections. BUG=1007539 Change-Id: I2349e3169c58f1b9477b13d840b03643622500f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823980Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#707136}
-
