GitLab

(╯^□^)╯︵ ❄☃❄

BUG=557422
R=avi@chromium.org
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/1557553002

Cr-Commit-Position: refs/heads/master@{#367133}

This change fixed the bug in framebuffer-object-attachment.html

BUG=295792
TEST=conformance2/renderbuffers/framebuffer-object-attachment.html

Committed: https://crrev.com/23cf53ece33a651b28a1d87e57f02a14f22d3c3d
Cr-Commit-Position: refs/heads/master@{#367053}

Review URL: https://codereview.chromium.org/1549393002

Cr-Commit-Position: refs/heads/master@{#367132}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/a5bb31a30eb7..ad9e64c0e18d

$ git log a5bb31a30..ad9e64c0e --date=short --no-merges --format='%ad %ae %s'

CQ_INCLUDE_TRYBOTS=
TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1550413002

Cr-Commit-Position: refs/heads/master@{#367131}

(╯^□^)╯︵ ❄☃❄

BUG=557422
R=avi@chromium.org

Review URL: https://codereview.chromium.org/1552733002

Cr-Commit-Position: refs/heads/master@{#367130}

These tests will run against the same content each time, which will allow
us to track any change in data savings at a very detailed level.

BUG=573035

Review URL: https://codereview.chromium.org/1556593002

Cr-Commit-Position: refs/heads/master@{#367129}

(╯^□^)╯︵ ❄☃❄

BUG=557422
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/1551033002

Cr-Commit-Position: refs/heads/master@{#367128}

(╯^□^)╯︵ ❄☃❄

BUG=557422
R=avi@chromium.org
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/1550383002

Cr-Commit-Position: refs/heads/master@{#367127}

Currently, ExternalDataUseObserver buffers data use reports until the
sum of bytes across all reports exceeds |kDefaultDataUseReportMinBytes|.
This leads to loss of buffered reports, when Chromium is closed. By
reporting the bytes whenever Chromium goes into the background we can
reduce the unreported bytes.

BUG=570001

Review URL: https://codereview.chromium.org/1544633002

Cr-Commit-Position: refs/heads/master@{#367126}

BUG=529962

Review URL: https://codereview.chromium.org/1544863003

Cr-Commit-Position: refs/heads/master@{#367125}

This CL handles captureStream(0) case where we are expected
to capture frames from a canvas only when requestFrame() is called.
It adds a new CanvasDrawListener.

BUG=524218
TEST=Ran the demo below with MediaCaptureFromElement flag enabled.
https://rawgit.com/uysalere/js-demos/master/canvascapture6.html

Review URL: https://codereview.chromium.org/1505753005

Cr-Commit-Position: refs/heads/master@{#367124}

ContentCaptureSubscription should only create a window activity tracker
if the RenderWidgetHostView on the source is not deleted.

BUG= 572577

Review URL: https://codereview.chromium.org/1555513004

Cr-Commit-Position: refs/heads/master@{#367123}

BUG=295792
TEST=No functional changes, current conformance test covers the test.

Review URL: https://codereview.chromium.org/1543233002

Cr-Commit-Position: refs/heads/master@{#367122}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/58d01d4a8c8c..a5bb31a30eb7

$ git log 58d01d4a8..a5bb31a30 --date=short --no-merges --format='%ad %ae %s'

CQ_INCLUDE_TRYBOTS=
TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1557513003

Cr-Commit-Position: refs/heads/master@{#367121}

Use FileLock in the data directory to enforce exclusive access to it.

Attempting to share the data directory between two browser processes
will most likely lead to data corruption.

BUG=558377

Review URL: https://codereview.chromium.org/1555513003

Cr-Commit-Position: refs/heads/master@{#367120}

(╯^□^)╯︵ ❄☃❄

BUG=557422
R=boliu@chromium.org

Review URL: https://codereview.chromium.org/1552723002

Cr-Commit-Position: refs/heads/master@{#367119}

This CL handles captureStream(frameRate) case where we are expected
to capture frames from a canvas with respect to the given frame rate
constraints. It adds a new CanvasDrawListener, and refactors the existing
interface.

BUG=524218
TEST= Ran the demo with MediaCaptureFromElement flag enabled.
https://rawgit.com/uysalere/js-demos/master/canvascapture4.html

Review URL: https://codereview.chromium.org/1508023002

Cr-Commit-Position: refs/heads/master@{#367118}

https://codereview.chromium.org/1509723003/ removed all dependencies on the
implementation of shared memory. This CL removes the remaining references.

BUG=547247

Review URL: https://codereview.chromium.org/1509063003

Cr-Commit-Position: refs/heads/master@{#367117}

BUG=529962

Review URL: https://codereview.chromium.org/1547543003

Cr-Commit-Position: refs/heads/master@{#367116}

https://chromium.googlesource.com/chromium/src/+/54342454b

BUG=549277
TBR=jbroman@chromium.org

Review URL: https://codereview.chromium.org/1550373002 .

Cr-Commit-Position: refs/heads/master@{#367115}

Review URL: https://codereview.chromium.org/1550963002

Cr-Commit-Position: refs/heads/master@{#367114}

08e3393 Let breakpad build with -Wall on OS X and Linux.
8ef927c Remove use of deprecated CFURLCreateDataAndPropertiesFromResource function.
51e5c56 Fix ExploitabilityLinuxUtilsTest::DisassembleBytesTest to not fail
eb6262d dump_syms: add a -v flag
016f568 Fix file descriptor leaks in linux CrashGenerationServer
dc210a5 Make dump_syms buildable under newer versions of Xcode.

BUG=
R=thestig@chromium.org
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/1555583002 .

Cr-Commit-Position: refs/heads/master@{#367113}

The latest comment in bug 475940, though dated, seems to indicate the
tests run just fine.  The only way to know for sure is to re-enable them
and confirm they are no longer flaky.

BUG=475940
TBR=simonhatch@chromium.org

Review URL: https://codereview.chromium.org/1553573002

Cr-Commit-Position: refs/heads/master@{#367112}

Refactor SynchronousCompositorOutputSurface to expose the SwapBuffers
call to client. For IPC implementation, send the reply IPC inside
SwapBuffers instead of waiting for OnDraw to return.

This allows more code to run in parallel, since OnDraw generally calls
PrepareTiles after DrawAndSwap; now PrepareTiles can run in parallel
with IO/UI code. Depending on scheduling and available cores, this can
save up to ~0.7ms per frame of waiting time on UI thread.

BUG=545633

Review URL: https://codereview.chromium.org/1546383002

Cr-Commit-Position: refs/heads/master@{#367111}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/427ee9ea6162..58d01d4a8c8c

$ git log 427ee9ea6..58d01d4a8 --date=short --no-merges --format='%ad %ae %s'

CQ_INCLUDE_TRYBOTS=
TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1552703002

Cr-Commit-Position: refs/heads/master@{#367110}

Fix some small nits along the way.

Review URL: https://codereview.chromium.org/1554533002

Cr-Commit-Position: refs/heads/master@{#367109}

A few more things that are present in GYP builds but not GN builds...

(╯^□^)╯︵ ❄☃❄

BUG=557422
R=vmpstr@chromium.org
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/1558513002

Cr-Commit-Position: refs/heads/master@{#367108}

https://chromium.googlesource.com/chromium/src/+/f03ecfc1e

BUG=571248
TBR=jzern@chromium.org

Review URL: https://codereview.chromium.org/1551833002 .

Cr-Commit-Position: refs/heads/master@{#367107}

Introduces RtpTimeDelta and RtpTimeTicks to media::cast, modeled after
base::TimeDelta and base::TimeTicks, that track RTP time and provide a
strict set of valid math and comparison operators, bit truncation and
re-expansion, and timebase conversion.

All instances of raw uint32 used to represent RTP timestamps has been
replaced with the new data type.

BUG=530839
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1515433002

Cr-Commit-Position: refs/heads/master@{#367106}

In particular:
- when hovering or pressing the thumb, repaint only the thumb
- when thumb position changes, repaint the track only if it changes
  (e.g. due to a button being disabled upon reaching the end)

BUG=549277
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_oilpan_rel,mac_blink_oilpan_rel

Review URL: https://codereview.chromium.org/1558493002

Cr-Commit-Position: refs/heads/master@{#367105}

BUG=572987,572240
TBR=marja@chromium.org

Review URL: https://codereview.chromium.org/1550193003 .

Cr-Commit-Position: refs/heads/master@{#367104}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/56baa6c6..eecaedd7

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1553553002

Cr-Commit-Position: refs/heads/master@{#367103}

The seccomp bpf filter was complaining because getsockopt and setsockopt were being called but they're not allowed. I had fixed this for x86-64 in r360114 but the change should have also allowed ARM. Really, it's anything other than 32 bit Linux (which doesn't have a specific id for these methods).

BUG=572795,561803

Review URL: https://codereview.chromium.org/1553543002

Cr-Commit-Position: refs/heads/master@{#367102}

BUG=571248

Review URL: https://codereview.chromium.org/1546003002

Cr-Commit-Position: refs/heads/master@{#367101}

This case fixes clicking on an item with no children to show the menu,
then right clicking on the (empty) text and choosing 'delete'. In this
case 'delete' removes the item, so the menu needs to close.

BUG=571362
TEST=create folder with no bookmarks on the bookmark bar, click on
folder so it opens, right click in '(empty)' area, and choose
delete. The menu should close.
R=rdevlin.cronin@chromium.org

Review URL: https://codereview.chromium.org/1550173002

Cr-Commit-Position: refs/heads/master@{#367100}

This currently describes just the building and running of the WebGL
conformance tests on the new Linux and Mac Release and Debug builders
and testers. Once this is working, the other tests will be added.

BUG=542370

Review URL: https://codereview.chromium.org/1547383002

Cr-Commit-Position: refs/heads/master@{#367099}

testHTTPResponseTimelineRecorder was failing due to an occasional favicon
request which would occassional cause the test to fail.  To fix the issue
it will now filter out any favicon requests before validation.

testChromeProxyMetricForBlockOnce failed to due not being updated when
the BlockOnce case was changed.  I also renamed the metrics we store in the
test to be consistent with other cases.

Last item is adding myself to OWNERS for chrome_proxy tests.

BUG=452279,449979,455269

Review URL: https://codereview.chromium.org/1550973002

Cr-Commit-Position: refs/heads/master@{#367098}

BUG=561190

Review URL: https://codereview.chromium.org/1553533002

Cr-Commit-Position: refs/heads/master@{#367097}

Revert of Make ScrollbarThemeAura selectively invalidate scrollbar parts. (patchset #10 id:180001 of https://codereview.chromium.org/1525803002/ )

Reason for revert:
Oilpan unit test failure: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Oilpan/builds/28217

Original issue's description:
> Make ScrollbarThemeAura selectively invalidate scrollbar parts.
>
> In particular:
> - when hovering or pressing the thumb, repaint only the thumb
> - when thumb position changes, repaint the track only if it changes
>   (e.g. due to a button being disabled upon reaching the end)
>
> BUG=549277
>
> Committed: https://crrev.com/0e8396ada46f085c23343450d850d81751053c94
> Cr-Commit-Position: refs/heads/master@{#367082}

TBR=ccameron@chromium.org,skobes@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=549277

Review URL: https://codereview.chromium.org/1550983002

Cr-Commit-Position: refs/heads/master@{#367096}

To avoid scrollbars ruining the ref test, I removed a non-test-relevent line.

Patch based on https://bugs.webkit.org/show_bug.cgi?id=113970 by Benjamin Poulain.

R=timloh
BUG=cr227282

Review URL: https://codereview.chromium.org/1482493003

Cr-Commit-Position: refs/heads/master@{#367095}

Problem 1: the cross-fading was not executed properly. It should start by
drawing the attached bar at full opacity and transition to detached by
painting detached on top of that at partial opacity (defined by
animation state).

Problem 2: it painted as fully detached when current_state was 0. At this
point it should be painting as fully attached. This led to a single-frame
flash of lightness at the start of the attached->detached animation.

BUG=none

Review URL: https://codereview.chromium.org/1547563003

Cr-Commit-Position: refs/heads/master@{#367094}