GitLab

because there is an existing TabDragController when a new one is
created. Right after we create the new TabDragController it replaces
the old, but if we create the new one before the old is destroyed it
means the old is still set as a delegate on the TabContents so that
when the new restores the delegates it restores the old
TabDragController, which has now been deleted.

BUG=107172
TEST=none
R=ben@chromium.org


Review URL: http://codereview.chromium.org/8915026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114653 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104399
TEST=TwoClientExtensionsSyncTest.UninstallPreinstalledExtensions

Review URL: http://codereview.chromium.org/8889048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114652 0039d316-1c4b-4281-b951-d872f2087c98

R=avi@chromium.org
TBR=rlp@chromium.org
BUG=98716
TEST=

Review URL: http://codereview.chromium.org/8921021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114651 0039d316-1c4b-4281-b951-d872f2087c98

with modal dialogs on mac.
Also, don't inline scripts in view_checks.html and do print filter for rerunning
failed tests.
BUG=103434,107573
TEST=none

Review URL: http://codereview.chromium.org/8943001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114650 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106209
TEST=none
R=davemoore@chromium.org

Review URL: http://codereview.chromium.org/8938007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114646 0039d316-1c4b-4281-b951-d872f2087c98

for chromeos gtk builds (non-aura), now they're disabled for all views
gtk builds.

BUG=104945
TEST=none
TBR=mazda
Review URL: http://codereview.chromium.org/8957010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114645 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit r114642 - it broke ChromeOS.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114644 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114643 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=compiles

Review URL: http://codereview.chromium.org/8944001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114642 0039d316-1c4b-4281-b951-d872f2087c98

control group is http://codereview.chromium.org/8952015
Review URL: http://codereview.chromium.org/8953014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114641 0039d316-1c4b-4281-b951-d872f2087c98

This makes it possible to provide more helpful spoken feedback when focusing
a toolbar button or infobar button - e.g. it can now read the full text of
the infobar when you move focus to any of its buttons.

BUG=106724
TEST=Adds new unit tests; will need new ChromeVox push to test manually.
Review URL: http://codereview.chromium.org/8850004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114640 0039d316-1c4b-4281-b951-d872f2087c98

Small oversight in r112774: function __update_fps replaced with
__record_frame_time in head.js. __update_fps was still referenced
in head_animation.js

BUG=http://code.google.com/p/chromium/issues/detail?id=106557
TEST=performance_ui_tests, gpu_frame_rate_test

Review URL: http://codereview.chromium.org/8915020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114639 0039d316-1c4b-4281-b951-d872f2087c98

Allow the AudioLowLatencyInputOutput, WinAudioOutputTest and WinAudioInputTest tests to run on bots where audio hardware is available.
The tests will succeed (to avoid breaking the tree) with a warning printed out on bots that don't have the necessary hardware.

TEST=Run media_unittests on the build bots.
Review URL: http://codereview.chromium.org/8949015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114638 0039d316-1c4b-4281-b951-d872f2087c98

Fixed Test{TCP|UDP}SocketPrivateShared.

BUG=105863
TEST=


Review URL: http://codereview.chromium.org/8840007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114637 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None.
TEST=None.


Review URL: http://codereview.chromium.org/8805003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114636 0039d316-1c4b-4281-b951-d872f2087c98

Also, update the URL with info on suppressing Valgrind errors
BUG=107696,107698,107699
TBR=hbono
Review URL: http://codereview.chromium.org/8947020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114634 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106522
TEST=trybot

Review URL: http://codereview.chromium.org/8817014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114633 0039d316-1c4b-4281-b951-d872f2087c98

BUG=98716
R=jam@chromium.org

Review URL: http://codereview.chromium.org/8910011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114632 0039d316-1c4b-4281-b951-d872f2087c98

Looks like I've underestimated the new builder's speed!
TBR=thestig
Review URL: http://codereview.chromium.org/8954012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114631 0039d316-1c4b-4281-b951-d872f2087c98

http://codereview.chromium.org/7717023 added more granular options to
BrowsingDataRemover. This CL exposes those options to the chrome.clear
extension API. Among other things, this means that chrome.clear.cookies()
will _only_ clear cookies, not cookies and site data.

At the moment, clearing any quota managed data type will clear them all.
That is being addressed in http://codereview.chromium.org/7839029/
but is independent from changing the public interface.

BUG=94334
TEST=browser_tests


Review URL: http://codereview.chromium.org/8952014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114630 0039d316-1c4b-4281-b951-d872f2087c98

TEST=`gclient presubmit cl` with different errors in tools/valgrind/tsan/suppressions.txt
Review URL: http://codereview.chromium.org/8951011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114629 0039d316-1c4b-4281-b951-d872f2087c98

Remove the RecordWithSlowSink test.  The test has problems running on the build bots and after discussing its benefits, we decided that we don't need to test this level of tolerance and that the Record test is enough.

BUG=107546
Review URL: http://codereview.chromium.org/8957006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114628 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:16659
TEST=chrome and tests build


Review URL: http://codereview.chromium.org/8934019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114627 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114626 0039d316-1c4b-4281-b951-d872f2087c98

TBR=kbr@chromium.org

BUG=none
TEST=browser_tests,ui_tests,interactive_ui_tests,webkit_tests

Review URL: http://codereview.chromium.org/8960001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114625 0039d316-1c4b-4281-b951-d872f2087c98

Extend the controlled settings bubble code to allow for an event to be
fired upon user request to apply the recommended setting. Handle the
recommended case properly for the internet detail dialog by enabling
controls for recommended settings and handling resets by restoring the
default value in the control.

BUG=chromium-os:23124
TEST=Configure recommended settings for a network (currently only AutoConnect is relevant) and check the "Options" dialog for that network.

Review URL: http://codereview.chromium.org/8815014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114624 0039d316-1c4b-4281-b951-d872f2087c98

This makes sure policy-configured networks get assigned to the correct profile. Also, they're now removed from the profile when the policy doesn't specify them any longer. Relies on the GUID fields in the network specifications, and requires https://gerrit.chromium.org/gerrit/#change,12437 on the flimflam side.

BUG=chromium-os:19411
TEST=Configure a network through policy. Remove that network and reload policy. The network should disappear from the network list.

Review URL: http://codereview.chromium.org/8804021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114623 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:23124
TEST=Set up a policy-configured ONC network, observe that the network settings are locked down and the network cannot be removed.

Review URL: http://codereview.chromium.org/8804020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114622 0039d316-1c4b-4281-b951-d872f2087c98

BUG=95971
TEST=This requires a special branded build to test (and master_preferences set to have auto_launch_chrome: true or specify mini_installer param --auto-launch-chrome), but after installing it you should see an item under the Wrench \ Options \ Basics that lets you configure Chrome to not auto-launch. If you instead, log out and log in again, Chrome should start with an infobar saying that it was auto-launched. The infobar should stay for a max of 5 launches and then not appear again. Pressing "Cut it out!" on the infobar should turn off this feature. If you just want to test the infobar, launch chrome with --auto-launch-at-startup. Also, uninstall and make sure Chrome is not auto-launched (a Windows error about Chrome not being found should not be shown).
Review URL: http://codereview.chromium.org/8729009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114621 0039d316-1c4b-4281-b951-d872f2087c98

Adding tests + minor code cleanup.

BUG=NONE
TEST=BrowserListTest.AttemptRestart, BrowserInitTest.ReadingWasRestartAfter(Restart|NormalStart)


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114441

Review URL: http://codereview.chromium.org/8929027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114620 0039d316-1c4b-4281-b951-d872f2087c98

Revert 114615 - chrome.clear: Increasing granularity of public API

http://codereview.chromium.org/7717023 added more granular options to
BrowsingDataRemover. This CL exposes those options to the chrome.clear
extension API. Among other things, this means that chrome.clear.cookies()
will _only_ clear cookies, not cookies and site data.

At the moment, clearing any quota managed data type will clear them all.
That is being addressed in http://codereview.chromium.org/7839029/
but is independent from changing the public interface.

BUG=94334
TEST=browser_tests

Review URL: http://codereview.chromium.org/8008012

TBR=mkwst@chromium.org
Review URL: http://codereview.chromium.org/8949014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114619 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114618 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rnk
BUG=105667,107181
Review URL: http://codereview.chromium.org/8947015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114616 0039d316-1c4b-4281-b951-d872f2087c98

http://codereview.chromium.org/7717023 added more granular options to
BrowsingDataRemover. This CL exposes those options to the chrome.clear
extension API. Among other things, this means that chrome.clear.cookies()
will _only_ clear cookies, not cookies and site data.

At the moment, clearing any quota managed data type will clear them all.
That is being addressed in http://codereview.chromium.org/7839029/
but is independent from changing the public interface.

BUG=94334
TEST=browser_tests

Review URL: http://codereview.chromium.org/8008012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114615 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106845
TBR=thestig
Review URL: http://codereview.chromium.org/8951010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114614 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107063
TEST=none
TBR=jam
Review URL: http://codereview.chromium.org/8951008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114611 0039d316-1c4b-4281-b951-d872f2087c98

Also, this CL moves chrome/browser/ui/webui/sync_promo_* to
chrome/browser/ui/webui/sync_promo/sync_promo_*.

BUG=107223
R=stevet@chromium.org,rogerta@chromium.org,sail@chromium.org
TEST=The sync promo responds to brand code and records results of the field
trial correctly.

Review URL: http://codereview.chromium.org/8933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114608 0039d316-1c4b-4281-b951-d872f2087c98

schema_generated_bindings.js.


BUG=80310
TEST=browser_tests --gtest_filter=*Extensions*


Review URL: http://codereview.chromium.org/8916019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114606 0039d316-1c4b-4281-b951-d872f2087c98

Print preview: A quick hack to support printing to the default printer without user confirmation in kiosk mode.

BUG=31395
TEST=none

Review URL: http://codereview.chromium.org/8915027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114605 0039d316-1c4b-4281-b951-d872f2087c98

- Add RUN_TEST_WITH_REFERENCE_CHECK macro which run a test then check leaked
 pepper objects.
- Use that macro to run all WebSocket related PPAPI unit tests
- Fix some object leak in tests found by the macro

BUG=87310
TEST=ui_tests --gtest_filter='PPAPITest.WebSocket_*'

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114389

Review URL: http://codereview.chromium.org/8934003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114604 0039d316-1c4b-4281-b951-d872f2087c98