GitLab

This adds a base layer that individual logging protocols (like tracing)
can use to send their data to Perfetto, using Mojo messaging and
shared memory.

First CL of several, after this comes the Chrome tracing layer: https://chromium-review.googlesource.com/c/chromium/src/+/981270

A preview of the full integration can be seen here: https://chromium-review.googlesource.com/c/chromium/src/+/852808

The design doc for the integration: https://docs.google.com/document/d/1a8lvN3zYWEyAsBjtuRRsy0fWOWdUdbw6bGnKLBscGdw/edit

R=primiano@chromium.org,skyostil@chromium.org

Change-Id: Ie1db5745ebffdcf1e2d74e2f6b12395f447c8552
Reviewed-on: https://chromium-review.googlesource.com/980578Reviewed-by: oysteine <oysteine@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Commit-Queue: oysteine <oysteine@google.com>
Cr-Commit-Position: refs/heads/master@{#551019}

If an extension has an <iframe> it should be allowed to autoplay.

BUG=821284

Change-Id: I1e11cbdef6a81acf5ea3e6d3dcaadc8c13464c16
Reviewed-on: https://chromium-review.googlesource.com/962803Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551018}

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I7aa90dcc7026df4c14950b5f0aee21134fe9ddb0
Reviewed-on: https://chromium-review.googlesource.com/1013335Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551017}

In previous implementations of the login screen, a user with SmartLock
enabled could press return with an empty password field in order to
authenticate. This behavior appears to not have been carried over in the
newer Views implementation.

The fix is to special case the auth attempt and divert the attempt to
the SmartLock flow in the case where the user has tap-to-unlock and the
password field is empty.

R=xiyuan@chromium.org

Bug: 818400
Test: LoginAuthUserViewUnittest.PressReturnWithTapToUnlockEnabled
Change-Id: I1ecaba0d285fd43b231ca8028c19b0682f073b77
Reviewed-on: https://chromium-review.googlesource.com/1013398
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551016}

The class is named ConeEffect but the file was cone.h and cone.cc.
Rename the files to cone_effect.h and cone_effect.cc

Fix a blink style issue in cone_effects.cc too.

Bug: 832708
Change-Id: I5acd880ba61cd1597c10e488aa318e939ac1c321
Reviewed-on: https://chromium-review.googlesource.com/1011455Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551015}

This is a follow up CL to crrev.com/c/1011102. It removes the old header
file that was kept around in order to avoid breaking ios downstream.

TBR=pkl@

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I53034903eeae0bfcae20cf048fd6ced845e02e06
Reviewed-on: https://chromium-review.googlesource.com/1014188Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551014}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/c90ccbc26d04..d88eaf5315d4

$ git log c90ccbc26..d88eaf531 --date=short --no-merges --format='%ad %ae %s'
2018-04-15 cmtice [release builders] Disable CFI on caroline & terra.

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:830321


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I9289723920afdf2dda519c0cb1c750efadc2f29f
Reviewed-on: https://chromium-review.googlesource.com/1014175Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#551013}

- Expose LeakDetector interface in render process, remove unneeded plumbing.
- Switch from IPCs to Mojo in layout test runner.
- Move implementation to controller.
- Migrate inspector usage to browser.
- Merged two methods of LeakDetector into a single one.
- Fixed leaks in existing tests.

Needs a followup to not register fetchers in leak detector,
but instead have a collection in ResourceFetcher.

Change-Id: Iba0ffc95de5b8beb27409b4eb51435c5e1397951
Reviewed-on: https://chromium-review.googlesource.com/999170Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Yuzu Saijo <yuzus@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551012}

We did not allow recalculating style for reattachment as part of
RecalcStyle when we had custom style hooks because some elements had
CustomStyleForLayoutObject() methods which depended on parent layout
objects. This is no longer true, so we can now always recalc style for
re-attachment. That means we'll also need to call custom style hooks
WillRecalcStyle/DidRecalcStyle for re-attacment styles as well.

Bug: 813057
Change-Id: I403c30e0f9f6934bd96d3da84488a6b3c489a50e
Reviewed-on: https://chromium-review.googlesource.com/925702Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551011}

Gives the omnibox a soft shadow.

Bug: 833375
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: I17b9bbf4fdd2d8830e0157ddfd6b9ef57008ecb2
Reviewed-on: https://chromium-review.googlesource.com/1014010
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551010}

https://chromium.googlesource.com/catapult.git/+log/ac39bc379194..dc1e62593e6c

$ git log ac39bc379..dc1e62593 --date=short --no-merges --format='%ad %ae %s'
2018-04-16 simonhatch Dashboard - Remove code/command_line from TestMetadata.
2018-04-16 simonhatch Dashboard - Remove debug log statement.

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I7bd186e0b22267e61c73b1e0b0cbcaf1377a22a3
Reviewed-on: https://chromium-review.googlesource.com/1012731Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#551009}

This will make it easier to write tests and send events directly
to the dialog.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ib9a25666a213e1279a6491bd61331b4e7c8321e4
Reviewed-on: https://chromium-review.googlesource.com/1012917
Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
Reviewed-by: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551008}

Change-Id: I839b4f520300b17e3ba22cf0ea62d2a03b376c5e
Reviewed-on: https://chromium-review.googlesource.com/760419Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551007}

This CL moves the call to VaapiPicture::DownloadFromSurface,
which in turn calls VaapiWrapper::BlitSurface(), to be executed
in the decoder thread of VaVDA. This considerable offloads the
Gpu main thread for more urgent tasks, and anyway the said
decoder thread is idle most of the time (seen in chrome:trace),
so utilizing it more doesn't impact the overall performance but
increases responsiveness.

This Chrome:tracing details shows the change (soraka vp9 720p@30)
before: https://i.imgur.com/CkqXqTp.png (https://imgur.com/a/pYVpf)
after: https://i.imgur.com/o0c4ksW.png (https://imgur.com/a/wblx0)
(the actual duration is inconsequential since it depends on the
actual frame).

nit: TRACE_EVENT1 is moved to the Vaapi*Picture because it results
in easier syntax around the PostTaskAndReplyWithResult().

TEST= simplechrome+crosvideo and v_d_a_unittest h264/vp8/vp9
on soraka. No perf regression observed in the produced numbers.

Bug: 717265
Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Icc4af2ef96141cebf95ac8fbb89c6e386e194a30
Reviewed-on: https://chromium-review.googlesource.com/947341
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551006}

CL https://chromium-review.googlesource.com/c/chromium/src/+/1008824 added
two consts inside SessionStorageDataMap::GetOptions() that shadow existing
consts and generate warnigs in jumbo builds.  These consts were only
used once each, so we may as well just use the values directly.

TBR=dmurph@chromium.org

Bug: 716490
Change-Id: I09505a9df50ef6d3cc2bc002254027cd791cdcdf
Reviewed-on: https://chromium-review.googlesource.com/1013458Reviewed-by: Daniel Bratell <bratell@opera.com>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#551005}

This CL makes several changes to the layout of the streamlined sign-in
screen:
1. Hide secondary TextView in the account picker widget if there's
   no full name available for the account. This includes changing IDs of
   TextViews, replacing RelativeLayout with two LinearLayouts and some
   changes in SigninFragmentBase code. See https://crrev.com/c/1010484
   for similar changes in AccountPickerDialogFragment.
2. Revise text style for TextViews in SigninView: replace BlackHint2
   with BlackBody. These two styles are identical, but used in different
   contexts.
3. Reorder some XML attributes to match AS ordering (it follows
   start-top-end-bottom ordering).

Bug: 814728
Change-Id: I4a974e3e9360aaa3468f7410315ed8af8cfcdfe4
Reviewed-on: https://chromium-review.googlesource.com/1012841Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551004}

This switch is not useful for controlling feature launch. The rollout of
USM accounts itself will be gradual and staged, so we can respond to any
issues that arise on Chrome in future versions.

Bug: 826299
Change-Id: Ib18935f38584d0ad6fb19aee10c769993a95b89a
Reviewed-on: https://chromium-review.googlesource.com/1012242
Commit-Queue: Bruno Kim Medeiros Cesar <brunokim@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551003}

The wasm_downgrade_test uses special testing functions which allow to
serialize and deserialize a WebAssembly module. The deserialization
function takes a DOMArrayBuffer as parameter, converts it into a String,
and then uses the String to create a SerializedScriptValue. However,
if the length of the DOMArrayBuffer is not even, one byte gets lost
in the conversion to a String. With this CL we create the
SerializedScriptValue directly from the DOMArrayBuffer, and thereby
guarantee that all bytes from the DOMArrayBuffer are copied into the
SerializedScriptValue.

The bug caused by the conversion to a String was hiding another bug
which I'm currently fixing in V8. As soon as the fix in V8 rolled to
Chrome, we can continue with this CL.

R=binji@chromium.org, pkasting@chromium.org

Change-Id: I65b35676b764cd3d64c437b331510897b032b33b
Reviewed-on: https://chromium-review.googlesource.com/1006962Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Ben Smith <binji@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551002}

Using wpt-import in Chromium 9702d1ea.
With Chromium commits locally applied on WPT:
303956b6 "Enable WPT tests for the Generic Sensor classes"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15651

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
rouslan@chromium.org, mathp@chromium.org:
  external/wpt/payment-request
yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
  external/wpt/fetch

TBR=raphael.kubo.da.costa@intel.com

No-Export: true
Change-Id: Ia9bd9207a039d0f67f40fc1febb6dc002b0ad4e8
Reviewed-on: https://chromium-review.googlesource.com/1013753
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551001}

Offline page loads don't have headers attached to the navigation
handle, which would otherwise cause a DCHECK / crash when trying to
read the header.

Bug: 829323
Change-Id: I04118b7a80816f65b42e1d2be78a56f61c1a1cb1
Reviewed-on: https://chromium-review.googlesource.com/1012025
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551000}

Create directory for credentials cache and krb5.conf
Fixing regression was introduced in CL:974108.

BUG=815158
TEST=manual

Change-Id: I9ec9ce411de25df504e165c1b1a025e5878c3ae7
Reviewed-on: https://chromium-review.googlesource.com/1013921Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550999}

The contract for |forwarding_client_| is that the implementation is
free to delete the loader synchronously after calling any of its
methods.

There is one case where we reach into |this| after doing so, which this
CL fixes.

Bug: 833292
Change-Id: Ic5e41649da9e692407f0433a72d2d784f174497b
Reviewed-on: https://chromium-review.googlesource.com/1014024
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550998}

Change-Id: I41d086b4f3754d08c1cb8952a9f0da35cd170a43
Reviewed-on: https://chromium-review.googlesource.com/1013609Reviewed-by: Leon Scroggins <scroggo@chromium.org>
Commit-Queue: Yuqian Li <liyuqian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550997}

Bug: 812641
Change-Id: Iea73bd9ead16bbda3e8a10576072f5b968d9ad35
Reviewed-on: https://chromium-review.googlesource.com/1013079Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550996}

Don't require the "update" URL to be specified for the
extension force installation policy. It should default to the
Web Store URL.

BUG=chromium:747944
TEST=unit and browser tests

Change-Id: I1dcf028573af5260f15a1dc92608192bd6a554a2
Reviewed-on: https://chromium-review.googlesource.com/1008183Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550995}

Bug: None
Change-Id: I98eeaff0d8de99074c6c3823bfcbe6a16ce0506b
Reviewed-on: https://chromium-review.googlesource.com/1012109Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550994}

Set the timestamp of last fetch time of MachineLevelUserCloudPolicy
if it's enabled.

Bug: 832907
Change-Id: I80084e82932479b7e2ee29474f069c685d96f063
Reviewed-on: https://chromium-review.googlesource.com/1013044Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Marc-André Decoste <mad@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550993}

This reverts commit c3991fe1.

Reason for revert: Several tests became flaky on ChromeOS
 - crbug.com/c/833176
 - crbug.com/c/833237
 - crbug.com/c/833219
 - crbug.com/c/833127
 - crbug.com/c/833030

This is not the first time a test becomes flaky on ChromeOS for the same reason: it hangs while waiting in SendKeyToPopupAndWait(). Giving such an issue has been there for a long time, I think it may be time to investigate what's going on and trying to come up with an explanation.

Original change's description:
> [af] Run AutofillInteractiveTest with AutofillExpandedPopupViews enabled
> 
> This parameterizes AutofillInteractiveTest and subclasses to run with
> the feature either enabled or disabled. The goal is to help us
> ensure it's to enable the feature for Canary/Dev.
> 
> I'm investigating if there are other tests that should be affected by
> the feature, and will update them in follow up CLs.
> 
> Bug: 768881
> Change-Id: I13b0bf654374728749ce7c5b3829bc02ff386cd3
> Reviewed-on: https://chromium-review.googlesource.com/1005888
> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
> Reviewed-by: Roger McFarlane <rogerm@chromium.org>
> Reviewed-by: Evan Stade <estade@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#550759}

TBR=rogerm@chromium.org,estade@chromium.org,tmartino@chromium.org,ftirelo@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 768881
Change-Id: I157dcf789abfa57ad924a24967ab3ed83e48145c
Reviewed-on: https://chromium-review.googlesource.com/1014141Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550992}

Bug: 779634
Change-Id: Iba3bed868177e7caa31714573c10eaae1a0571c1
Reviewed-on: https://chromium-review.googlesource.com/1012200Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Emily Hanley <eyaich@chromium.org>
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550991}

Bug: 833419
Change-Id: I9b1d6f3b7b5c9229443b71f41d422d78be40ba8d
Reviewed-on: https://chromium-review.googlesource.com/1014026Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550990}

https://chromium.googlesource.com/angle/angle.git/+log/152152618edf..20fa8d5cfe9e

$ git log 152152618..20fa8d5cf --date=short --no-merges --format='%ad %ae %s'
2018-04-15 jmadill Vulkan: Implement cube map texture sampling.
2018-04-12 jiawei.shao Store shader information in ShaderMap in class Program and Compiler
2018-03-19 oetuaho Store invariant declarations in variable metadata

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jmadill@chromium.org

Change-Id: Ided9c2c111013257fe41c34a7d74455f8c511a10
Reviewed-on: https://chromium-review.googlesource.com/1014007Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#550989}

The GetHandle function of RenderProcessHost returned a
base::ProcessHandle, which cannot be passed around to other
threads because the caller does not have ownership. This
lead to handle abuse problems on Windows if the RPH goes
away as the handle is being bounced around.
This CL replaces the GetHandle function of RPH with a
GetProcess function, which returns a const base::Process&.
This in turn allows callers to duplicate the underlying
base::Process, and the duplicate can then be safely bounced
around to other threads.

Bug: 821453
Change-Id: I7d9956c3ab92352d99ccea70fde3f2013aa66d33
Reviewed-on: https://chromium-review.googlesource.com/998213
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550988}

Before this patch, a payment handler page could be unsecure.

This patch checks for the following conditions:
- Unsecure origin.
- Non-cryptographic scheme.
- Invalid certificate.
- Flagged in safe browsing database.
If any of these conditions are hit, Chrome aborts payment by closing the
payment handler page and showing an error message.

After this patch, if a payment handler page is detected to be unsecure,
Chrome closes the payment handler page and shows an error message.

Bug: 828431
Change-Id: Ifdc5a3e3ebf9c511f21aa03dee2d8d3230ac8b88
Reviewed-on: https://chromium-review.googlesource.com/1012451Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550987}

Bug: 734095
Change-Id: I3a7e869ca908e53436ff3e78f43f13af1dccedce
Reviewed-on: https://chromium-review.googlesource.com/998032
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Xi Cheng <chengx@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550986}

Please note that this move changes ownership of the accessory which is
intended but not absolutely necessary.

This move/rename serves several purposes beyond that:
1) The accessory becomes an own component living in a separate package.
2) All currently public functions should be accessed through the
  controller of the component and therefore be package-visible soon.
3) It reduces size and confusion of the CL that wires the old view to
  the new controller.
4) The name maps to its new role in go/android-accessory-for-manual-ui

Bug: 828832
Change-Id: Id54ce3db25c7e37bd6572e28aa8625b0e6868b9d
Reviewed-on: https://chromium-review.googlesource.com/1012062
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550985}

Cause for breakage: Side effect in DCHECK() which wasn't exercised on trybots
(apparently they have all DCHECKs enabled)

Without persisting them, server-side provided intervals are less efficient on
platforms with relatively short app lifetime.

This also allows lower poll intervals for latency-sensitive use cases in cases
when our notifications are not reliable enough (yet).

Bug: 832019
Change-Id: Ifcd55edcbb9fb17583caac847f6c110024a83e19
Reviewed-on: https://chromium-review.googlesource.com/1013457Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Tim Schumann <tschumann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550984}

Removes unnecessary SetVariable method (can use constructor). Documents usage.

BUG=chromium:829279
TEST=Tryjobs

Change-Id: I44ac2f93cd65fcd2e36814c659956fbdb0dc8277
Reviewed-on: https://chromium-review.googlesource.com/1013937Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550983}

Setting a background page is a pretty common operation in test
extensions. Bake it into ExtensionBuilder.

Use it in a small smattering of places, and add a unittest.

Bug: 832958
Change-Id: Iaa3464dfa183f990fb579d289f99271983344983
Reviewed-on: https://chromium-review.googlesource.com/1013128Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550982}

[extensions] Make ManifestHandler::Keys return a span into static data instead of allocating a vector.

Shows up as a signficant fraction of time in content::ContentMainRunnerImpl::Initialize.

Change-Id: I56308465e0bd8c1e58018d21263f8e9710ca66dc
Reviewed-on: https://chromium-review.googlesource.com/1011367Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550981}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/05254515..a7328562

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I1caae9638c8b92541ef86cb9a619f760ebbf0b39
Reviewed-on: https://chromium-review.googlesource.com/1013752Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550980}