GitLab

This is a clean-up CL which moves all of the LocalInputMonitor
related classes into their own folder and provides a public header
and lib for usage by the rest of the host classes.

Change-Id: I0a9ced94750d0724f99dace24c991fd3194eebb4
Reviewed-on: https://chromium-review.googlesource.com/1185298
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585928}

Previously, ParentLocalSurfaceIdAllocator would default to an invalid
LocalSurfaceId. A new LSI had to be explicitly allocated before the
normal behavior could use it.

With ParentLocalSurfaceIdAllocator now default initializing a valid LSI,
the various call sites no longer need to explicitly check for the
uninitialized state.

services/ui/ has some of those call sites.

BUG=837030

Change-Id: I1b82b0133de0ecc3e8fa71f5a40f25762732ccf3
Reviewed-on: https://chromium-review.googlesource.com/1038144
Commit-Queue: Chris Blume <cblume@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585927}

Some tests in scrollTo-scrollBy-snaps.html are failing on wpt dashboard.
This is caused by the uncertainty of the window size for testharness
tests. If the window size becomes small enough that the snap area covers
the snapport, the expected snap position is ignored because any scroll
position is considered a valid snap position. This patch changes the
landing position of scrollTo and scrollBy for failing cases so that the
snap area does not cover ths snapport regardless of the window size.

More specifically, the snap area's vertical and horizontal dimensions
are 600px each thus covering the [1000, 1600] range with expected snap
position at 1000. Previously if the test vertically scrolled to 1200 and
the window's size is smaller than 400, the snap area will cover the
window. Now the test scrolls to 900 (100px before the snap position),
ensuring that the target snap area won't cover the window regardless of
the size.

Bug: 876052
Change-Id: I448ecb1e3cc2cc458d467472ca38d49bf01d2901
Reviewed-on: https://chromium-review.googlesource.com/1182299
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585926}

This CL adds versions of FirstContentfulPaint, FirstMeaningfulPaint,
and FirstInputDelay metrics that are bucketed by the number of live
tabs open in the browser.

The following metrics are added:
PageLoad.Experimental.PaintTiming.NavigationToFirstMeaningfulPaint.ByLiveTabCount.<BucketRangeSuffixText>
PageLoad.PaintTiming.NavigationToFirstContentfulPaint.ByLiveTabCount.<BucketRangeSuffixText>
PageLoad.InteractiveTiming.FirstInputDelay.ByLiveTabCount.<BucketRangeSuffixText>

<BucketRangeSuffixText> corresponds to the LiveTabCountMetrics
histogram_suffixes in histograms.xml, e.g. "1Tab", "2Tabs", etc.

Bug: 861796
Change-Id: I50a7b806f82b7284543a97ed5d2496213c9a5d62
Reviewed-on: https://chromium-review.googlesource.com/1168287
Commit-Queue: Scott Haseley <shaseley@google.com>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585925}

This also removes window_manager_constants as it was not used.

BUG=876924
TEST=covered by tests
TBR=msw@chromium.org,tsepez@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I32224509d1f7264088333c674544559a8759729a
Reviewed-on: https://chromium-review.googlesource.com/1188427Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585924}

Bug: 877109
Change-Id: I77918382df9e5ef5c14f3f55d2581bc58c5ccb3b
Reviewed-on: https://chromium-review.googlesource.com/1187656Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585923}

With this change, the script executor follows
AssistantActionProto.action_delay_ms, when it is set.

Bug: 806868
Change-Id: I4cb7ba2074f316cb27bffb61f9f14dc200639792
Reviewed-on: https://chromium-review.googlesource.com/1186737
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585922}

Fix overrides and remove a bunch of calls to new.

Change-Id: Icac6516cae60dfcde967540022262088dc230f74
Reviewed-on: https://chromium-review.googlesource.com/1188040Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585921}

Bug: 855186
Change-Id: I0f83e8c802f98b01f62447bc2515d7a5cb2dc133
Reviewed-on: https://chromium-review.googlesource.com/1187626Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Commit-Queue: Manas Verma <manasverma@google.com>
Cr-Commit-Position: refs/heads/master@{#585920}

This change extends the controller to include a ClientMemory struct,
that is data shared between all actions.

Bug: 806868
Change-Id: I32e43c2302b93cb6f8a6972789843b08df5d0750
Reviewed-on: https://chromium-review.googlesource.com/1186881Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585919}

[RenderProcessHost/Desktop] Update process priority on process launch and fix navigation priority inversion

This is a second take on
https://chromium-review.googlesource.com/c/chromium/src/+/754299

It's under an experiment to (1) be able to see the side-effects and (2)
make merge to M69 easier. Intentionally kept old (and buggy) behavior
intact under the non-experimental branch for comparison.

This fixes all aspects of crbug.com/560446:
 1) Fixes the OP better than r385608 did.
 2) Fixes the side-effect of r385608 which was to default all tabs
    created backgrounded to run at foreground priority until visiblity
    was toggle on/off again.
 3) Fixes a major priority inversion on foreground navigation which
    could cause them to background their associated renderer while
    navigation (which reintroduced the OP but worse since all background
    tabs were running foregrounded per r385608)...
    See https://crbug.com/560446#c74 for details.

Updated ChildProcessLauncherPriority::is_background() to consistently
reflect backgrounding decision to all callers and renamed
|ChildProcessLauncherPriority::foreground| to
|ChildProcessLauncherPriority::visible| to better reflect that it's a
property but not the resulting foreground/background state.

See in code comment on ShouldBoostPriorityForPendingViews() for more
details.

TBR=haraken@chromium.org (side-effect in third_party/blink)

Bug: 560446
Change-Id: I901b702506a44704b53c007bcdd498fb60824e94
Reviewed-on: https://chromium-review.googlesource.com/1142593
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585918}

This CL modify a few event listener, using keydown event instead of
keyup event making the arrow key interaction between tiles will not
propagate to the menu. With this CL, when hitting arrow key on the tile
will not move the scroll unless it has to eg. the next focus item located
outside the current viewpoint.

Screencast:
https://screencast.googleplex.com/cast/NDgzNTA4MjMwOTIwNjAxNnw5NjFlYmFkZC0zNA

Bug: 872601
Change-Id: I352a28dbc0a05779818ee27fd9df563114caf6c2
Reviewed-on: https://chromium-review.googlesource.com/1187236Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585917}

For issue 828317 we need an end to test for checking whether the correct
fonts have been selected for @font-face { src: local(<fontname>) }
rules. Since this cannot be reliable verified with web platform API, I
am using DevTools to connect to the content instance and retrieve
information about the selected fonts, just like in the style panel of
DevTools. The DevTools protocol communication is modeled after
content/browser/devtools/protocol/devtools_protocol_browsertest.cc

I appreciate feedback on whether I should duplicate this DevTools
communication code here, whether there is an easier way to achieve this,
or whether we should factor out the relevant parts of
content/browser/devtools/protocol/devtools_protocol_browsertest.cc into
a separate file that I can reuse here for the FontUniqueNameBrowserTest.

Bug: 874059
Change-Id: I4a2beeb81a3b5e4cec68cf196fcf0ebf29287d38
Reviewed-on: https://chromium-review.googlesource.com/1174540Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585916}

This change implements the RTCIceTransport.start() method and
associated methods/events: addRemoteCandidate(), getRemoteCandidates(),
role, onstatechange.

Bug: 864871
Change-Id: Ic6ac7ce4c9ba98b1dc2610ed7847e6b9714f6c8d
Reviewed-on: https://chromium-review.googlesource.com/1161605
Commit-Queue: Steve Anton <steveanton@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585915}

This work is to support the auto-hide disconnect window.  The idea is to
allow consumers of the Local*InputMonitor interfaces to choose which
Monitors they want to subscribe to.  This means breaking the current
impls up into Mouse and Hotkey variations.

Change-Id: Id38e37e23b0b4747a672d8f4b21fe9fd1656c680
Bug: 877176
Reviewed-on: https://chromium-review.googlesource.com/1185289
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585914}

Change-Id: I1df4e6a4275b70b409879104f6c39fb79be3b4d1
Reviewed-on: https://chromium-review.googlesource.com/1187061Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585913}

This test is failing on the MSan bot, so it's being temporarily
disabled:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/8307

TBR=lucmult@chromium.org

Bug: 877557
Change-Id: If5ed2948b2266591fd5d76aa3c305455d02ee9a5
Reviewed-on: https://chromium-review.googlesource.com/1188763Reviewed-by: Scott Little <sclittle@chromium.org>
Commit-Queue: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585912}

This adds a directory "Explore" in the profile directory
that contains the database files.  The DB is self-closing
after a period of time.

Bug: 867488

Change-Id: I8ede0072853617b4f0be0a14cc9101c868898713
Reviewed-on: https://chromium-review.googlesource.com/1182308
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585911}

We are currently field testing Viz, so tests on the CQ have it enabled by
default. This change removes the explicit viz_browser_tests and
viz_content_unittests from Linux and Windows configs, which are running the
trial.

TEST=viz_browser_tests, viz_content_unittests

Bug: 787097
Change-Id: I8a26abd1c0de1357560f6fc9e53b4d3b1157c68e
Reviewed-on: https://chromium-review.googlesource.com/1187559Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585910}

Missed when the initial string translations were hooked up.

Bug: 877234
Change-Id: Ie812d8ef1cf4719fd4a7d04923b2d212c1225332
Reviewed-on: https://chromium-review.googlesource.com/1187510
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585909}

This change also adds the deserializing logic to Entry, but the options
are not used anywhere yet.

Bug: 866967
Change-Id: Ibb66000a627ea8b4413e41bd2010a71f60db1dd4
Reviewed-on: https://chromium-review.googlesource.com/1180079Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585908}

This removes the last remaining use of WTF::Mutex::Locked, in favour of
the most base-like AssertAcquired.

Bug: 856641
Change-Id: I59e3a90ada3d6c27b2a958240e6863bc15cf1e0c
Reviewed-on: https://chromium-review.googlesource.com/1185636Reviewed-by: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585907}

This is the second part, the plumbing on the blink side.

Bug: 876691, 869918
Change-Id: I62fe4aaf37f41b5ebd341ce4731f7fda1d486feb
Reviewed-on: https://chromium-review.googlesource.com/1185015
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585906}

Fixes an issue with instrumentation tests that contained annotations
that returned arrays of primitives not being listed. This was being
caused by an unconditional cast to an Object array, which is not allowed
with arrays of primitives. The fix is to detect when we receive an array
of primitives and manually copy it over to an array of primitive
wrappers.

This seems to only have been hit for ints with the recent switch to
using IntDef for enums, but the fix works for any primitive type.

Bug: 875909
Change-Id: I465b1b7bd8c8ec67229e18be13e6da6295de3baa
Reviewed-on: https://chromium-review.googlesource.com/1185461
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585905}

AddressTrackerLinux::ReadMessage is invoked from the main thread.
It should not be possible to instantiate ScopedBlockingCall in
that case (adding AssertBlockingAllowed breaks browser_tests).
pauljensen@ pointed out that blocking does not happen when
|tracking_| is false. This CL is a short-term fix for bug 817151,
instantiating ScopedAllowBlocking only when |tracking_| is true.

Bug: 817151
Change-Id: Ic5970b4e1c4fefb5231a2d666948b8cc2b7cdf35
Reviewed-on: https://chromium-review.googlesource.com/1187388
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585904}

Removing TODO as it's not worth refactoring WebVR 1.1 specific files as
they are being replaced with the WebXR concepts.

Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I52e9f14e54c05e13d530cf952e1a9d7b573ff981
Reviewed-on: https://chromium-review.googlesource.com/1185221
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585903}

I'm making duplicates of the existing LocalInputMonitor classes
and checking them in prior to the refactoring.  This is make future
CLs easier to review as I've found that the way Git handles branching
of files isn't deterministic enough and so it is easy to lose history
and diff bases if too much of the files are changed.  Thus this CL.

My plan is to introduce specific listener classes for Mouse, Keyboard,
Touch, and 'Disconnect Hotkey'which will be passed to the
LocalInputMonitor which will then create the appropriate input monitor
for that input type.

BUG=877176

Change-Id: I8b259e416a15b4b4c6f082481800066d97317040
Reviewed-on: https://chromium-review.googlesource.com/1184250Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585902}

https://pdfium.googlesource.com/pdfium.git/+log/367ed462b517..284c5139836c


git log 367ed462b517..284c5139836c --date=short --no-merges --format='%ad %ae %s'
2018-08-24 thestig@chromium.org Fix a bug in make_expected.sh.


Created with:
  gclient setdep -r src/third_party/pdfium@284c5139836c

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Id50214a8ca68ca030399d3455acceef7f2b89b7a
Reviewed-on: https://chromium-review.googlesource.com/1188505Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#585901}

Bug: 877148
Change-Id: I757fa7363dd11f4c2db534fc7dbc3b46174a623f
Reviewed-on: https://chromium-review.googlesource.com/1188602Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585900}

Bug: boringssl:226
Change-Id: I335ff85b59021603ccbce63fa9b826cda0fbfaac
Reviewed-on: https://chromium-review.googlesource.com/1185207
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585899}

Change log level for logs that appear to be normal/expected behavior for
certain webcams in order to reduce log spam.

Bug: 743093
Change-Id: I4c0b4c05a84a9d17a9777b1310a1a741f729daf4
Reviewed-on: https://chromium-review.googlesource.com/1188435Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585898}

The builder is now on LUCI rather than the legacy buildbot master.

Change-Id: I5ccaaa9dc317211daee8348f61b9eda068018314
Reviewed-on: https://chromium-review.googlesource.com/1188616Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585897}

Subtract margin width from the preferred widths of the media remoting
and cloud services dialogs, so that they have the intended width.

Bug: 875102
Change-Id: I362dd2bbae7f533df3f9f51d851c7f7b5d136908
Reviewed-on: https://chromium-review.googlesource.com/1187577Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585896}

Adds support for running the existing VR instrumentation tests on
standalone VR devices, specifically the Lenovo Mirage Solo.

Main changes include:
1. Adding new restrictions to differentiate smartphone VR from
   standalone devices and only enable tests on standalone when they make
   sense to do so.
2. Work around tests starting in VR.
3. Fix various issues with running on standalone devices such as
   controller recentering behavior being slightly different.

Bug: 876946
Change-Id: Ibb357e765768c0db9d08a8c7504ee8d14e0d31f3
Reviewed-on: https://chromium-review.googlesource.com/1186114Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585895}

This test uses an OSDD URL that gives a 404, so allow http errors for
the SimpleURLLoader. It looks like this could flake if there was a delay
between OnReceiveResponse and OnComplete.

Bug: 870588
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I101894bba7c31fcc7a686ab79b6e6bb936c4c26c
Reviewed-on: https://chromium-review.googlesource.com/1187667Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585894}

Change-Id: Ie5bdc719778c41ef473ce977c8698966e9b47001
Reviewed-on: https://chromium-review.googlesource.com/1161181
Commit-Queue: Mathieu Guay-Paquet <mguaypaq@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585893}

The underlying cause of the flakes should be fixed in
crrev.com/98f6ea73.

TBR=wez@chromium.org

Bug: 876894
Change-Id: Ic3549ff80afc6e8041a1195ab71d39b300789e78
Reviewed-on: https://chromium-review.googlesource.com/1187897Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585892}

EasyResizeWindowTargeter only works if a targeter is not installed on the
children of the container. This makes EasyResizeWindowTargeter work by
explicitly checking the parent's WindowTargeter for
SubtreeShouldBeExploredForEvent().

BUG=877099
TEST=covered by test

Change-Id: If5de972623bfbffb87986958010f7c8c51d8b448
Reviewed-on: https://chromium-review.googlesource.com/1187625Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585891}

Adds highlight state to articles and most visited cells.

Bug: 865834, 865836
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I6b299b99767136cc6b0517d29f3c6e2aebc3bb05
Reviewed-on: https://chromium-review.googlesource.com/1183627Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585890}

Introduces some performance tests for ProtoDatabase, for writing
individual entries, writing in batches, and writing/reading a single
database containing all entries vs. separate databases. Reports time
taken and memory used where appropriate.

Bug:870813

Change-Id: I9c916f296afed63be4d414f4a2fe70541863d510
Reviewed-on: https://chromium-review.googlesource.com/1148889
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585889}