- 06 Dec, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f9c21a65e611..06f8a9063b3b Created with: gclient setdep -r src-internal@06f8a9063b3b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I5c2cc17ce732995d94f819e24793b3af10bc689f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955474Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722456}
-
Antonio Gomes authored
Note that the use of WebVector deliverately kept as part of this clean up, since doing it now would create a way bigger CL. BUG=787254 R=guidou@chromium.org Change-Id: Ie85cf379ae0b73902dfc30de3e4725c07e0cd290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950688 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#722455}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/eb8c4ca60848..c347585927b2 git log eb8c4ca60848..c347585927b2 --date=short --first-parent --format='%ad %ae %s' 2019-12-06 danilchap@webrtc.org Use RtpPacket instead of legacy RtpHeaderParser in video/ tests Created with: gclient setdep -r src/third_party/webrtc@c347585927b2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic5539d8ae81a1322f7318a08ddd82fbc3eee5256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955472Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722454}
-
Theodore Olsauskas-Warren authored
This reverts commit 51486136. Reason for revert: Assertions added in the Previous CL failed because of incorrect assumptions about the state of flags in tests. The state of this flag has been explicitly set in the two tests causing the failure. TBR=dpapad@chromium.org,msramek@chromium.org,jdoerrie@chromium.org, karandeepb@chromium.org Original change's description: > Revert "Move Password Leak detection setting from Google Services to Privacy" > > This reverts commit 83db5b46. > > Reason for revert: Suspected to break CrSettingsPrivacyPageTest.PrivacySettingsRedesignTests > CrSettingsPersonalizationOptionsTest.AllBuilds > browser_tests on linux-chromeos-google-rel > > Original change's description: > > Move Password Leak detection setting from Google Services to Privacy > > > > Along with the elevation of the Privacy card out of advanced, the toggle > > for enabling Password Leak detection is being moved from the Sync and > > Other Google services page into the privacy page. > > > > This aligns the location of the Passwork Leak detection toggle with the > > Safe Browsing settings already moved to the Privacy page. > > > > Every change in behavior is behind the privacySettingsRedesignEnabled > > finch flag. > > > > Bug: 1014143 > > Change-Id: Icd604d38729cdae113c116c77079cad9b874cd3f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946470 > > Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> > > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#722065} > > TBR=dpapad@chromium.org,msramek@chromium.org,jdoerrie@chromium.org,sauski@google.com > > Change-Id: If9b0c66e68aadc093ed4dbb0f367c4a05878eab4 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1014143, 1031237 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954003 > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Commit-Queue: Karan Bhatia <karandeepb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#722144} Change-Id: I20f4d205da0a76c6deefe858f4d71afee2edcb68 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1014143, 1031237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954397Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#722453}
-
Johannes Kron authored
This CL is part of fixing a bug where RTCRtpReceiver.getCapabilities() returns encoder capabilities instead of decoder capabilities. First step in fixing this bug is to implement RTCVideoDecoderFactory::GetSupportedFormats(). Bug: chromium:1029737 Change-Id: I7d3adf204bbe9e6867b2af66aefb3bf5db543249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947660 Commit-Queue: Johannes Kron <kron@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#722452}
-
Antonio Gomes authored
BUG=787254 R=guidou@chromium.org Change-Id: Ib0980958f53a1b8c108fc864a7a4bcdae4cc4eb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944367 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#722451}
-
jonross authored
We would like to measure the peak gpu-memory usage during page load. This will allow us to determine the correlation of memory usage to other performance statistics, such as frame times. This will also allow for Clustered Telemetry experiments of other features. For example running with Site Isolation both On/Off. TEST=telemetry rendering_mobile Bug: 1022036 Change-Id: Ib7609d6d1e98d1839ccf2325157fefd9b4893ef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867117Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#722450}
-
Antonio Gomes authored
Note that the use of WebVector deliverately kept as part of this clean up, since doing it now would create a way bigger CL. BUG=787254 R=guidou@chromium.org Change-Id: I604bba6b49952ee6a3b12132cc0a8707afd11514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950686 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#722449}
-
Antonio Gomes authored
BUG=704136 R=guidou@chromium.org Change-Id: Ic0acd94b796f18d40cc806ada0f33813d56d4331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949343Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#722448}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/b9f03f47d5f5..8701dc4489e9 git log b9f03f47d5f5..8701dc4489e9 --date=short --first-parent --format='%ad %ae %s' 2019-12-06 bclayton@google.com Reactor: Switch swizzles over to 16-bit hex codes Created with: gclient setdep -r src/third_party/swiftshader@8701dc4489e9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: If014a0c217b797e80c75943db3850dd4263ee77e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955465Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722447}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/651c01e838a0..f9c21a65e611 Created with: gclient setdep -r src-internal@f9c21a65e611 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I3ffe89ed73a2f63031f7def784f7bf6afde8a233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955469Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722446}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4b6d9afe2055..f9c33d61a661 git log 4b6d9afe2055..f9c33d61a661 --date=short --first-parent --format='%ad %ae %s' 2019-12-06 mathias@chromium.org Fix alignment for computed accessibility properties 2019-12-06 mathias@chromium.org Drop -webkit-user-select in favor of user-select Created with: gclient setdep -r src/third_party/devtools-frontend/src@f9c33d61a661 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1031441,chromium:1031475 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I823b001afc8ebc66edbb6498d9237c1d1538d24c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955466Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722445}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/cec2433c477f..eb8c4ca60848 git log cec2433c477f..eb8c4ca60848 --date=short --first-parent --format='%ad %ae %s' 2019-12-06 anderskl@microsoft.com Remove unnecessary checks from AudioDeviceWindowsCore::CoreAudioIsSupported Created with: gclient setdep -r src/third_party/webrtc@eb8c4ca60848 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If30e1f795ab1e9857a06fcb68608e20a098c91ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955468Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722444}
-
Pavol Marko authored
This reverts commit 8ad5f775 (and subsequent angle rolls). Reason for revert: Assuming that this has been causing angle_unittests failures. Example failures: https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/15815 https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/15817 Original change's description: > Roll src/third_party/angle 362168eb695d..11e6944ec5a8 (7 commits) > > https://chromium.googlesource.com/angle/angle.git/+log/362168eb695d..11e6944ec5a8 > > git log 362168eb695d..11e6944ec5a8 --date=short --first-parent --format='%ad %ae %s' > 2019-12-05 jonahr@google.com Linux AMD crash when src blit region outside framebuffer > 2019-12-05 ianelliott@google.com Vulkan: Implement multisample textures > 2019-12-05 syoussefi@chromium.org Fix image/sampler uniform range in presence of atomic counters > 2019-12-05 syoussefi@chromium.org Fix compute shared memory size validation > 2019-12-05 syoussefi@chromium.org Vulkan: EXT_gpu_shader5 support: precise > 2019-12-05 jmadill@chromium.org Re-land "Add new test runner harness." > 2019-12-05 syoussefi@chromium.org Fix tests checking for major version > 3 > > Created with: > gclient setdep -r src/third_party/angle@11e6944ec5a8 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/angle-chromium-autoroll > Please CC geofflang@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel > Bug: chromium:1014370 > Tbr: geofflang@google.com > Change-Id: I0290ab71c427661da38080ec0a640f2d2092a8c2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954531 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#722332} TBR=geofflang@chromium.org,chromium-autoroll@skia-public.iam.gserviceaccount.com Change-Id: Ic7a591b2751e716e46e28e9fb6cbbab7ec694619 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1014370,chromium:1030192 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954474 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#722443}
-
Antonio Gomes authored
BUG=704136 R=guidou@chromium.org Change-Id: I195032171c887cb82a3254a1b639a70feb67b71d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947987 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#722442}
-
Sven Zheng authored
The test suite was renamed. Bug: 1010568 Change-Id: I59eb7bd581d29fdf886009cc4e476712d4b8e1dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954928 Auto-Submit: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#722441}
-
Tim Schumann authored
We slice the metrics by minute to help with analyzing traffic peaks. Recording by minute is helpful as we see traffic spikes at certain minutes of the hour. Bug: 1031162 Change-Id: Idc45d1a9aedab8d4ed5171a26f944c6c39b06490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953604 Commit-Queue: Tim Schumann <tschumann@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#722440}
-
Mike West authored
This patch introduces a "same origin-domain" check, distinct from `SecurityOrigin::CanAccess()`, and uses it to implement the latter. This is a small step towards auditing the points at which we're calling `::CanAccess()` to decide whether we ought to be performing a "same origin", or "same origin-domain" check instead. Bug: 1027191 Change-Id: If6007367da7e044d008f056e3f816ac422551e7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951001 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#722439}
-
Antonio Gomes authored
BUG=787254 R=guidou@chromium.org Change-Id: I8f8a15ebe099c20ec56adf54a90a3562ee26ee69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950683 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#722438}
-
Oleg Davydov authored
This is an upgrade of UMA statistics related to force-installed extensions. Before this commit if download manifest has missing fetch URL or invalid one, we still report it as CRX_FETCH_FAILED, mixing with network-related error and failed HTTP requests. This commit adds two separate errors, URL_EMPTY and URL_INVALID, and provides them to the next generation of the ForceInstalledFailureReason histogram. Bug: 1030224 Change-Id: Iec0fa37d59945d3743f3d32bf5de11182c64b915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947737Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#722437}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1fce3f8e55a5..cec2433c477f git log 1fce3f8e55a5..cec2433c477f --date=short --first-parent --format='%ad %ae %s' 2019-12-06 srte@webrtc.org Exposing more features in the network emulation manager API. Created with: gclient setdep -r src/third_party/webrtc@cec2433c477f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I54cd78ad674638368c78f96d4336c7b9b1e86a71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955242Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722436}
-
Marian Fechete authored
This CL adds a unit test that checks the overwrite logic in the collect user data action, specifically checking that the proto of a subsequent action overwrites the values in the controller user data. Bug: b/140019232 Change-Id: I825bf670315629f14be26d095a8903ea11cbe959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953208 Commit-Queue: Marian Fechete <marianfe@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#722435}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/176b9884fdee..4b6d9afe2055 git log 176b9884fdee..4b6d9afe2055 --date=short --first-parent --format='%ad %ae %s' 2019-12-06 szuend@chromium.org Fix broken link to Omahaproxy in README.md Created with: gclient setdep -r src/third_party/devtools-frontend/src@4b6d9afe2055 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8dd4ac8feb0122f27c99329bc5058ab7c753355c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955243Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722434}
-
Mohamed Amir Yosef authored
Bug: 1012203 Change-Id: I91eb4f454cc899e444fda0f3983341c239ad6867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943233Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#722433}
-
Clemens Arbesser authored
This CL extends the java test service: - Test scripts can now contain more than one round trip, which will allow us to test complete flows. - Tests can now inspect and test the results of actions which would otherwise be sent to the backend. This CL includes a first proof-of-concept for how to use the new methods, but we should extend all our existing integration tests in the near future. Bug: b/144978160 Change-Id: I8188a50f0c600acecc687ad58cd4612d767a6dd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953109 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#722432}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/11e6944ec5a8..b2c2d667d540 git log 11e6944ec5a8..b2c2d667d540 --date=short --first-parent --format='%ad %ae %s' 2019-12-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src e72b61c7c20d..a3ee4384fb57 (2 commits) Created with: gclient setdep -r src/third_party/angle@b2c2d667d540 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: geofflang@google.com Change-Id: Ic83aa3a07064b309ed89dba3604aa473874be145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955234Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722431}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9cec36038932..15a09a9cfafc git log 9cec36038932..15a09a9cfafc --date=short --first-parent --format='%ad %ae %s' 2019-12-06 primiano@google.com Merge "Prevent warnings in amalgamated builds" Created with: gclient setdep -r src/third_party/perfetto@15a09a9cfafc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I5f6d72b80f5c0f4802b83757f8f0f8adbee97d12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955240Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722430}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/af5f9020e38b..651c01e838a0 Created with: gclient setdep -r src-internal@651c01e838a0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Iacff66ff9a49c0ee0bf3e21c1336289b42037bc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955239Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722429}
-
Ken Rockot authored
This is a reland of e8d24f73 Original change's description: > Reland "Move Audio Service off Service Manager" > > This is a reland of a4d27f51 > > The reland moves the TestingApi binder support into a component > library to avoid duplicate definitions that resulted in browser > test failures in component builds. > > Original change's description: > > Move Audio Service off Service Manager > > > > All the details around if/when a service instance is started and whether > > it's in- or out-of-process have been centralized into the implementation > > of a single GetAudioService() helper in Content. > > > > A few other helpers are added to ease the transition off the Service > > Manager, though they aren't necessarily ideal APIs. For example, > > client library APIs which once took a Service Manager Connector may now > > take a RepeatingCallback to bind a specific type of interface. > > > > In addition to GetAudioService(), Content provides helpers for > > AudioSystem construction and StreamFactory binding from any sequence. > > > > Because all timeout/lifetime management logic is now generically > > supported within Mojo and Content and requires no service implementation > > details to get right (and because unit tests launching service processes > > is no longer supported outside of Content), all Audio Service test > > coverage relevant to lifetime management is deemed superfluous and has > > been removed. > > > > Bug: 977637 > > Change-Id: I4c59948eafce2322547bf2b0479961e095b3edee > > Tbr: oshima@chromium.org > > Tbr: guidou@chromium.org > > Tbr: vollick@chromium.org > > Tbr: xiaohuic@chromium.org > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941280 > > Commit-Queue: Ken Rockot <rockot@google.com> > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Reviewed-by: Robert Sesek <rsesek@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#721832} > > Bug: 977637 > Change-Id: I183e79042c99458f2abf9423d8f9bbefedf5b374 > No-Presubmit: true > Tbr: oshima@chromium.org > Tbr: guidou@chromium.org > Tbr: vollick@chromium.org > Tbr: xiaohuic@chromium.org > Tbr: avi@chromium.org > Tbr: rsesek@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952601 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Commit-Queue: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#722373} Bug: 977637 Change-Id: I1b803e57632bd92f2b1e093c3d1c1731de8338f0 No-Presubmit: true Tbr: oshima@chromium.org Tbr: guidou@chromium.org Tbr: vollick@chromium.org Tbr: xiaohuic@chromium.org Tbr: avi@chromium.org Tbr: rsesek@chromium.org Tbr: dalecurtis@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954772Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#722428}
-
Hajime Hoshi authored
This CL adds new metrics for all websites, besides the existing metrics. The existing metrics are recorded only when the domain is allowed in the experiments, while the new metrics are recorded for all the websites. The new metrics are useful to see e.g., the tendency of the reasons why the page is not cached if we enable back-forward cache in all the sites, and such information will help us to prioritize our works to enable back-forward cache in all websites. Bug: 1004676 Change-Id: I30cf343bb685a0e462364bb2b6d6b03302032fe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950731 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#722427}
-
Bret Sepulveda authored
When ExtensionsToolbarMenu is enabled, the test was failing because it was expecting a "Hide in Chrome menu" label, rather than the new "Unpin" label. This patch fixes that expectation. Bug: 984654 Change-Id: I146d84522beaef09337799260f6e7dc051f5a70c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942344 Auto-Submit: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#722426}
-
Fredrik Söderquist authored
When producing Path objects, arcs are converted to conic segments, and when iterating those with Path::Apply(...) they are converted to quadratic beziers. So the arc semantics are lost when SVGMarkerDataBuilder gets the resulting segment. Thus it produces markers for each quadratic bezier, which is incorrect. Teach SVGMarkerDataBuilder to operate on the original path data too by accepting SVGPathByteStreams, and contort the arc segments into single (faux) beziers with matching properties (same start/end tangents). This allows reuse of the rest of the marker data builder machinery. Use the new code-path for the cases which can contain arc segments (<path> elements with 'd'). Bug: 583097 Change-Id: I20d772bb2ab67cd686160ab437d7d16fbc81e3c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950999 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#722425}
-
Anatoliy Potapchuk authored
This cl hides shelf during splash screen, so users can't crash chrome anymore :) Bug: 1026638,1015383 Change-Id: I005006d470429176e4bb7830b80149a54e5ac691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926481Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#722424}
-
Ricky Liang authored
Bug: 982201 Bug: b:144805331 Change-Id: I8c038c8912aaae48744d318398d85ce6c8fdfa16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954822Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#722423}
-
Omar Morsi authored
This CL adds an option for generating test certificates with custom subject alternative name (SAN). This is important e.g. for testing of SAN matching in isolation. Bug: 1030652 Test: Metadata of generated certificates has not changed (inspected manually). Change-Id: I95c5003b46e4a78fb176c4d330571e22fc2b5f2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949797 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#722422}
-
Oriol Brufau authored
In r720875 I changed the pseudo type of the style used for markers with 'content: normal' from kPseudoIdNone to kPseudoIdMarker. This had the side effect that they started to propagate style to its children, producing a 90.6%-99.9% performance regression in the flexbox_with_list_item test. This patch prevents that style propagationg for normal markers, fixing the perf regression. Markers with 'content' different than 'normal' are still propagated since it's necessary in that case. Bug: 1030884, 457718 Change-Id: Ia8341b605366ebdfd117cf569d030b38862348dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953723Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#722421}
-
Oriol Brufau authored
The spec has added 'white-space' to the list of properties that apply to ::marker pseudo-elements. Spec: https://drafts.csswg.org/css-pseudo-4/#marker-pseudo BUG=457718 TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties.html Change-Id: Iaf05bb568d0127b2aae4219715bb8839620101a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954384Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#722420}
-
Pavol Marko authored
It was only enabled recently and has been consistently failing across multiple bots. TBR=dcheng@chromium.org, etienneb@chromium.org, erikchen@chromium.org Bug: 843467 Test: browser_tests --gtest_filter=*MemlogBrowserTest* Change-Id: Iee8db1833b3e58013b5522d02dd6ca8b9ab579ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954006Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#722419}
-
Olivier Robin authored
With slim navigation, the navigation manager items are only restored when the tab is displayed. Before that point, use the session_storage to sync the tab. Bug: 1024750 Change-Id: Ie22d46065f28d172980175e3d8468712579a8ff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943241Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#722418}
-
Navid Zolghadr authored
This makes moving ComputedStyle to Oilpan in these classes that are referencing it in the future easier. Firstly it replaces a const & reference of ComputedStyle in BoxInfo with a cached value needed in that class. Secondly it makes a local FloatObject class public so that it can be stored in a HeapVector and have WTF_ALLOW_MOVE_INIT_AND_COMPARE_WITH_MEM_FUNCTIONS on it and later have a trace function for its CompuetedStyle reference. Bug: 1030176 Change-Id: Iff63d1fb385bbb5ac85fc5445caf7dfd775352ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946051Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#722417}
-