GitLab

|pending_login_managers_| is the list of all password form managers for forms on the current page. It is important when we detect a password to save -- it can only be saved if it correspondes to a pending login manager, which means to a form on the page the user is navigating from.

The list is currently updated on 2 occasions:
1) when the forms on the current page are parsed, and
2) when JavaScript adds a new form.

The exception to 2) is when the main frame loads -- we don't add forms added during that time, because they might be just confusing fragments.

It has been observed though, that there are still dynamically created forms which are not just fragments, but which fall prey to the above exception.

Those forms have been observed during the phase forms are actually rendered. So this CL adds a new place to update |pending_login_managers_|:
3) when the forms on the current page are rendered.

BUG=367768

Review URL: https://codereview.chromium.org/343663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278704 0039d316-1c4b-4281-b951-d872f2087c98

BUG=376562
TEST=gpu_unittests
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/338183005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278703 0039d316-1c4b-4281-b951-d872f2087c98

To stop depending on chrome::VersionInfo from TemplateURL.

BUG=386365
TEST=unit_tests

Review URL: https://codereview.chromium.org/345803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278702 0039d316-1c4b-4281-b951-d872f2087c98

BUG=356569
TEST=None

Review URL: https://codereview.chromium.org/345653004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278701 0039d316-1c4b-4281-b951-d872f2087c98

This is in preparation of me renaming the "webkit*" category to "blink*"
in the blink codebase. Once that change has rolled into chromium I'll do
another CL for chromium to remove the "webkit.console" entry.

BUG=386847

Review URL: https://codereview.chromium.org/342993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278700 0039d316-1c4b-4281-b951-d872f2087c98

This patch moves:
 * CursorFactoryOzone out of ui/base/cursor/ into ui/ozone/public
 * EventFactoryOzone out of ui/events/ into ui/ozone/public
 * SurfaceFactoryOzone, OverlayCandidatesOzone, SurfaceOzoneCanvas, and
   SurfaceOzoneEGL out of ui/gfx/ into ui/ozone/public
 * FileSurfaceFactory out of ui/gfx/ into ui/ozone/platform/test, since
   the test platform is the only one that uses it.

This patch also builds a separate ozone_base target that includes just the
factories.

BUG=361137
R=bsalomon@google.com, piman@chromium.org, rjkroege@chromium.org, sky@chromium.org, spang@chromium.org

Review URL: https://codereview.chromium.org/312393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278699 0039d316-1c4b-4281-b951-d872f2087c98

If a user blacklists a site with existing saved passwords, those
passwords will be deleted. In order to ensure that a user doesn't
accidentally lose data, we prompt them to inform them of the risk, and
ask for confirmation of the decision.

BUG=384155
NOTRY=true

Review URL: https://codereview.chromium.org/347033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278698 0039d316-1c4b-4281-b951-d872f2087c98

BUG=380215
R=jamescook@chromium.org, sky@chromium.org
TBR=pfeldman@ for content/shell changes

Review URL: https://codereview.chromium.org/345603003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278697 0039d316-1c4b-4281-b951-d872f2087c98

On 10.10, NSTextView alignment set before the object contains any text has no
effect.

TEST=In about:crash, all of the text should be centered horizontally.
BUG=386205
R=avi@chromium.org

Review URL: https://codereview.chromium.org/328303007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278696 0039d316-1c4b-4281-b951-d872f2087c98

The aura window's layer pointer is subject to change due to layer recreation,
so the cached pointer |desktop_layer_| may be invalid.

Always use aura::Window::layer() accessor instead.

BUG=385751
TEST=start desktop sharing and switch between windowed/immersive mode.

Review URL: https://codereview.chromium.org/348623005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278695 0039d316-1c4b-4281-b951-d872f2087c98

Based on work by dmazzoni@chromium.org in
https://codereview.chromium.org/339923002/
with the addition of support for including the English text messages in
tests and other minor fixes.

BUG=371692
R=dmazzoni@chromium.org

Review URL: https://codereview.chromium.org/342153003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278694 0039d316-1c4b-4281-b951-d872f2087c98

This CL is dependent on 292113008 and its dependencies.

BUG=371596, 355154

Review URL: https://codereview.chromium.org/322203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278693 0039d316-1c4b-4281-b951-d872f2087c98

Switch cros login host window back to ui::SHOW_STATE_FULLSCREEN since new layout manager handles that correctly even with virtual keyboard.
This way login window state will be consistent with screen lock state which is full screen.

BUG=384849

Review URL: https://codereview.chromium.org/330763005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278691 0039d316-1c4b-4281-b951-d872f2087c98

instead of pointers to MetadataDatabaseIndex to enable injections.

BUG=347425
TEST=./unit_tests --gtest_filter="MetadataDatabaseTest.*:MetadataDatabaseIndexTest.*"

Review URL: https://codereview.chromium.org/349543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278690 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278689 0039d316-1c4b-4281-b951-d872f2087c98

This makes the ARM64 and MIPS FFT available for use by WebAudio; however, this
is not enough to enable WebAudio on such devices.

See https://review.webrtc.org/14539004/ and https://webrtc-codereview.appspot.com/9539004/ for the changes.

BUG=354532,349422
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/340843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278688 0039d316-1c4b-4281-b951-d872f2087c98

The virtual keyboard used on Chrome OS (in ash) is provided by an
extension. For athena, we cannot yet use the extension version of the
keyboard. As a short-term workaround, this patch introduces a web-ui
version of the keyboard for initial use. This patch provides a
simplistic implementation of some of the virtualKeyboardPrivate API
(sendKeyEvent, hideKeyboard) over WebUI.

This patch installs a webui controller (VKWebUIController) for the
keyboard URL (chrome://keyboard), and a message-handler (VKMessageHandler)
to process the incoming messages from the keyboard. These are installed
in the browser process. In the renderer process, this patch installs a
RenderViewObserver implementation (VirtualKeyboardBindingsImpl) which
provides the necessary bindings for the virtualKeyboardPrivate API
(VKBindings), and generates the appropriate webui messages by calling
chrome.send(). This lets us use the same HTML/JS/Polymer version of the
keyboard as in Chrome OS under ash/chrome.

For the keyboard to be completely functional, an implementation of
onTextInputBoxFocused will also be necessary. That will be provided in a
follow up CL.

BUG=380125
R=ben@chromium.org, bshe@chromium.org, oshima@chromium.org

Review URL: https://codereview.chromium.org/335793005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278687 0039d316-1c4b-4281-b951-d872f2087c98

Now you can type, e.g., mojo://mojo_embedded_app/ffff00ff into the box
and get a purple square.

Review URL: https://codereview.chromium.org/345773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278686 0039d316-1c4b-4281-b951-d872f2087c98

BUG=386487

Review URL: https://codereview.chromium.org/344103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278685 0039d316-1c4b-4281-b951-d872f2087c98

Log a human readable message describing the reason why Chromium failed
to open a HID device node on Linux instead of the base::File error code.

BUG=

Review URL: https://codereview.chromium.org/339503007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278684 0039d316-1c4b-4281-b951-d872f2087c98

Turns on DSCP AF41 to give cast traffic a higher priority.

BUG=385768
TBR=miu

Review URL: https://codereview.chromium.org/344953003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278683 0039d316-1c4b-4281-b951-d872f2087c98

This implements:
- basic spoken and braille feedback on tabs and desktop trees.
- gives us a conceptual outline of the three entry points to interact with ChromeVox next:
1. keyboard (right now only possible by DOM events delivered through the content script)
2. through events received from the tabs automation tree
3.  through events received from the desktop automation tree
- test added against production ChromeVox for status tray.

Review URL: https://codereview.chromium.org/337843005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278682 0039d316-1c4b-4281-b951-d872f2087c98

This is happening as the tracing handler is not listening to the frontend close events.
When the front-end is closed, the tracing handler is unaware of it and it keeps collecting the data.
With the active frontend close, the tracing handler should invoke DisableRecording to stop processing further.

Review URL: https://codereview.chromium.org/337213005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278681 0039d316-1c4b-4281-b951-d872f2087c98

Main target of this test is communication between
SyncEngine in UI thread and SyncWorker in a worker thread.


BUG=378621
TEST=./unit_tests --gtest_filter="SyncEngineTest.*"

Review URL: https://codereview.chromium.org/335473004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278680 0039d316-1c4b-4281-b951-d872f2087c98

ShouldTransitionCrossSite is set to true in WebContents tests but no one ever
reads the value, as the authorative method is now in RenderFrameHostManager.

This patch removes the broken code.

BUG=None
R=avi@chromium.org, nasko@chromium.org

Review URL: https://codereview.chromium.org/348533004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278679 0039d316-1c4b-4281-b951-d872f2087c98

This will be used in the corruption recovery process.
The process try to shutdown ServiceWorkerCoordinator and abort pending jobs
retained by the coordinator to reject waiting promises.


BUG=371675
TEST=content_unittest --gtest_filter=ServiceWorkerJobTest.AbortAll_*

Review URL: https://codereview.chromium.org/345583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278677 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278676 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=176500:176538&mode=html
TBR=jamesr@chromium.org,senorblanco@chromium.org
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/330763006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278675 0039d316-1c4b-4281-b951-d872f2087c98

Removed hard-coded addition of start page and apps buttons in the
ContentsSwitcherView constructor. Instead, adding a page to ContentsView
automatically adds the appropriate button to ContentsSwitcherView.

ContentsView and ContentsSwitcherView now include pointers to one
another (so initialization of ContentsView is split into a separate Init
phase). ContentsView::AddLauncherPage now takes a resource ID.

BUG=386004

Review URL: https://codereview.chromium.org/336313010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278674 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
R=oshima@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/349493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278673 0039d316-1c4b-4281-b951-d872f2087c98

With r277082, raw touch locations are now exposed to the gesture detector.
Plumb these raw locations into the generated gesture events, in turn populating
the WebGestureEvent.global{X,Y} properties.

BUG=383690

Review URL: https://codereview.chromium.org/349463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278672 0039d316-1c4b-4281-b951-d872f2087c98

This CL breaks up single non-conflicting overwriting local-to-remote sync to two local-to-remote sync.
That happens when local file system has a locally modified file and has a not-modified remote folder at the same path.

BUG=344769
TEST=./unit_tests --gtest_filter=DriveBackendSyncTest.*:LocalToRemoteSyncerTest.*

Review URL: https://codereview.chromium.org/343883003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278671 0039d316-1c4b-4281-b951-d872f2087c98

MP4 codecs have profile parameter suffixed in them. Earlier chromium used
to strip away that parameter. After r277386, these parameters are considered
and handled differently. This patch adds some more browsertests for codecs
with profile parameter, for EMEs, so as to have robust testing framework.

BUG=53193
TEST=out/Release/browser_tests --gtest_filter=EncryptedMediaIsTypeSupported*

Review URL: https://codereview.chromium.org/342473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278670 0039d316-1c4b-4281-b951-d872f2087c98

This CL introduces the connect and disconnect methods to the bluetoothLowEnergy
API, which allow an app to initiate and hold on to the connection to a low
energy device. The API calls internally manage the allocation of an API
resource corresponding to a per app, per device device::BluetoothGattConnection
object.

BUG=381305
TEST=browser_tests --gtest_filter=BluetoothLowEnergyApiTest.*

Review URL: https://codereview.chromium.org/349433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278669 0039d316-1c4b-4281-b951-d872f2087c98

The SearchProvider may mark some suggestions to be prefetched based on
instructions from the suggest server. Currently we prefetch it only if such a
match ranks sufficiently highly. This cl allows to prefetch the suggestion
regardless of its autocomplete rank if allow_prefetch_non_default_match field
trial is enabled.

BUG=386203

Review URL: https://codereview.chromium.org/324273004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278668 0039d316-1c4b-4281-b951-d872f2087c98

- Consolidates FFmpegAudioDecoder and OpusAudioDecoder unittests
since they were identical anyways.
- Extends the AudioFileReader unittests to perform packet consistency
checks between seeks.
- Extends the new consolidated tests for WAV, FLAC, MP3, and AAC.
- Adds decoded output consistency checks using MD5 for all files.
- Removes old tests which end up duplicating efforts.
- Expands tests for bad decoder configs and buffers w/o timestamps.
- Expands tests to include AudioDiscardHelper usage.

BUG=381356
TEST=shiny new tests!

Review URL: https://codereview.chromium.org/311373004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278667 0039d316-1c4b-4281-b951-d872f2087c98

With this change, nested filesystems mounted onto isolated context
can remember its original filesystem id, that unblocks the issue 370782
of drag-and-drop support in chromeos::FileSystemBackend.

BUG=370782, 386062
TBR=kaznacheev, benwells, dmichael, sky

Review URL: https://codereview.chromium.org/341043008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278666 0039d316-1c4b-4281-b951-d872f2087c98

BUG=377636
TEST=manually test

Review URL: https://codereview.chromium.org/332973004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278665 0039d316-1c4b-4281-b951-d872f2087c98

- Finch field trial parameter
- Command-line flag to force the feature off
- OmniboxFieldTrial::EnableAnswersInSuggest(), which considers command-line flags and field trial settings.

BUG=386638

Review URL: https://codereview.chromium.org/348433009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278664 0039d316-1c4b-4281-b951-d872f2087c98

R=piman

Review URL: https://codereview.chromium.org/340863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278663 0039d316-1c4b-4281-b951-d872f2087c98