- 10 Jul, 2020 40 commits
-
-
danakj authored
Currently it can only be called from the main frame, but it just wants to set something on the frame's document loader. R=avi@chromium.org Bug: 1069111 Change-Id: I635fe2c0a23a9af1ae2842a477507218518d286f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292998 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#787382}
-
Moe Ahmadi authored
Also tested using the following command line argument: "--force-fieldtrials=AddToHomescreenMessaging/Enabled" "--force-fieldtrial-params=AddToHomescreenMessaging.Enabled:OmniboxLocalZeroSuggestAgeThreshold/10" "--enable-features=OmniboxLocalZeroSuggestAgeThreshold<AddToHomescreenMessaging" Bug: 1096615,1073606 Change-Id: I3955935ec417143123de8912620b15139c52d2bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290543 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#787381}
-
Rakib M. Hasan authored
Use TemporarilyReplaceBinaryManager in order to temporarily replace the global _binary_manager variable with None. Also refactors some some functions to replace try finally blocks with with blocks. Bug: 960833 Change-Id: I44bcb31f7b38c98d41443f6cb56dd1349b0cbb76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289192 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#787380}
-
Maxime Charland authored
The new look for empty state in Reading List will have: - Small title inside the navigation bar - New TableView background layout, implemented by TableViewIllustratedEmptyView (Googlers only links) Screenshot: https://drive.google.com/file/d/1dmqpokX6qkqkLMTWXHATHGbCjuadk1n0/view?usp=sharing Design Doc for Chrome Empties: https://docs.google.com/document/d/1JM2sKT4oghkol51U7_3xv9sfaB26C89CCGa2uwYBgsI/edit?usp=sharing Mocks of the new Chrome Empties look: https://docs.google.com/presentation/d/1x1lSTOSQ1zkJu87SoigiUhX2f9oHACglR22yYg-lSHo/edit?usp=sharing Bug: 1098328 Change-Id: I7f66c6de563eca08e1a08ec9dd352a1bf267c213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289398 Commit-Queue: Maxime Charland <mcharland@google.com> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#787379}
-
Reilly Grant authored
This change renames ErrorOnceCallback to ErrorCallback now that all interfaces using the original type have been converted. Bug: 834319 Change-Id: I82750d3f57db727b4964227bec14c76ebf8e78cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293154 Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#787378}
-
Meilin Wang authored
Please see demo of this fix in the linked bug. Bug: b/160917495 Test: manually. Change-Id: If62bc6039fb0c5f2144270b5b901dcb12cefec7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291752Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#787377}
-
Chris Sharp authored
Change-Id: Iadf6daa6c06f44512f003546c889b50c7c44322a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292117Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#787376}
-
Justin Miron authored
This change: 1. Calculates the existing viewport_offset field in local frame's from the main frame transform instead of a calculating it in a remote frame and propagating it to the remote frame. The field is removed from the propagated viewport intersection state. 2. Updates tests to propagate a main frame transform equivalent to propagating a viewport offset. Change-Id: I05e299d4c91125d4f3c5ac0f7e330d8c3a99530f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246554 Commit-Queue: Justin Miron <justinmiron@google.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#787375}
-
Stephanie Kim authored
Bug: 1072012 Change-Id: Iae7fbbe63a2c3a9c5dddbe98e4a5f2529369cbc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293001Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Stephanie Kim <kimstephanie@google.com> Cr-Commit-Position: refs/heads/master@{#787374}
-
Chris Sharp authored
Change-Id: I26ba59b2edde1f3d166362580f7f82604dd0b493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292106Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#787373}
-
Nico Weber authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/15f6cfec63d0..d2dd36c03501 $ git log 15f6cfec6..d2dd36c03 --date=short --no-merges --format='%ad %ae %s' 2020-07-10 thakis Use correct comment syntax for arm assembly. 2020-07-10 thakis Make sure arm assembly functions have hidden visibility. Created with: roll-dep src/third_party/ffmpeg Bug: 1103879 Change-Id: I4e8e180e61360dac928cd4793657ade259bb8445 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292797 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#787372}
-
Bettina authored
Safe Browsing has requested for MBB to be added to the password protection requests for better telemetry. Bug: 1102605 Change-Id: Ie63b3b82fed68c6fe541b48089cf6496265950c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284006 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#787371}
-
Gang Wu authored
MediaStore.Images.Media.getBitmap was deprecated in API level 29, https://developer.android.com/reference/android/provider/MediaStore.Images.Media#getBitmap(android.content.ContentResolver,%20android.net.Uri) Bug: 1065914 Change-Id: Id694c7fce0566896683d880a83d1f9a28ff22812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287274Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#787370}
-
Natalie Chouinard authored
Replace custom preference layout with material default. This correctly aligns icons under the action bar back arrow without the additional logic and fixed paddings previously used. This results in small UI shifts on settings screens with icons. See https://crbug.com/1095981 for screenshots and UX approval. Bug: 971791, 1095981 Change-Id: I1f150d76de78ae4551627ede43b44e14c5c6593c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258464 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#787369}
-
danakj authored
The TestRunner knows about all in-process main frames, so it can find the main frame for the main test window, if it is in process. Make this more explicit and add a helper to find the "main window main frame". R=avi@chromium.org Bug: 866140, 1069111 Change-Id: Iafa90bdb491bc4acaf93484e2355bfa86dc3af5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292863Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#787368}
-
Avi Drissman authored
It's more descriptive and more inclusive. Bug: 842296 Tbr: michaelbai@chromium.org Tbr: battre@chromium.org Change-Id: Icbc901c25c65cdfe5c1da70819d02f7b9f56e6a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292808Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#787367}
-
Lan Wei authored
In dom/shadow/resources/event-dispatching.js, there is a function that simulates mouse wheel scroll, it used eventSender.mouseScrollBy, now we change to use wheelTick which uses gpuBenchmarking.smoothScrollByXY, this will simulate wheel scroll from compositor. Bug: 1047176 Change-Id: Ic4aa5cd4b5d4ba97c99e7ea340c5760f4204f81d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181228Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#787366}
-
David Tseng authored
R=anastasi@google.com AX-Relnotes: n/a Change-Id: I3ffda2624b2d32d3cac663440981e648210b6199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291001Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#787365}
-
Alexei Svitkine authored
Bug: 1089167 Change-Id: Iff19c694ccf1a81bb2994ce4edb534d0416f02a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281162 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#787364}
-
Katie D authored
AX-Relnotes: N/A Bug: 1098642 Change-Id: I7d213fd96a518e77bce1ed133a32848498771e84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292861 Commit-Queue: Katie Dektar <katie@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Auto-Submit: Katie Dektar <katie@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#787363}
-
Angela Yoeurng authored
This is to fix the Switch to Tab button showing up twice when button row is on. Bug: 1103910 Change-Id: I20d85e634c3efaea2a32faea6999b6f0a2f8470f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290764 Commit-Queue: Angela Yoeurng <yoangela@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#787362}
-
Katie D authored
TBR=dtseng@chromium.org AX-Relnotes: N/A Bug: 1081563 Change-Id: I606e65c51dc50608452573090b4d992a09de253e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293155Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Auto-Submit: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#787361}
-
Lei Zhang authored
The 2-parameter version is deprecated. Use base::DeleteFile() and base::DeletePathRecursively() instead. Bug: 1009837 Change-Id: I94ee3561f0ab27997df750d1aab48377d5fcda72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288363Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#787360}
-
Dmitry Torokhov authored
Now that Chrome OS handles the additional "lang" argument when starting Parallels dispatcher process, we can remove code that tried to repeat attempt at staring it without "lang" argument if first attempt failed. Bug: 1072082 Change-Id: I7137a5764e64176e643ff38f5dc284273b9deb6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290569Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Dmitry Torokhov <dtor@chromium.org> Cr-Commit-Position: refs/heads/master@{#787359}
-
Yann Dago authored
Bug: 1103389 Change-Id: Ib705893bf6702a7167741a87bcae523328467dd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288386Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#787358}
-
Lei Zhang authored
Make targets in this GN file more consistent. Change-Id: I2aa80a737362a797b51338c039041d6059a5b4ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289190Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#787357}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ic2c44b1d39e48dc1b4dd69c7aeaef5ce9a54e7ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293115Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787356}
-
Jeffrey Kardatzke authored
This is in preparation for an upcoming change where we will select a CDM source in MediaInterfaceProxy based on the CDM config as well as provide a fallback in the case the CdmFactory is unavailable. The latter case requires us to have a PendingRemote returned from the call rather than have a PendingReceiver passed in so we can detect failure in that case. BUG=b:153111783,chromium:1010341 TEST=Unit tests pass, Widevine content plays back on Chrome OS Change-Id: I53d16d1bb319a99c191c54e73f29921cf33c09e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283296 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#787355}
-
zhaoyangli authored
Add this key with value `True` to any failed tests, so that LUCI UI can display failed test names in each swarming task for iOS builders. - Added the field when finalizing result in standard_json_util module. - Added and fixed broken tests. Bug: 1102920 Change-Id: Iaad9adabd704d289888fa0f2afee66298dd53900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289066Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#787354}
-
Etienne Pierre-doray authored
inspector-protocol/css/css-set-effective-property-value.js http/tests/devtools/bindings/inline-styles-binding.js TBR=tkent@chromium.org Bug: 1104333, 1104195 Change-Id: I769d4f62b71ac2db1c67a6d86bdafcea83125623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293076Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#787353}
-
danakj authored
This removes 2 dependencies on the |main_view_| which is a problematic pointer when the main frame can be swapped on navigation in the future. Instead we use the current frame pointer to determine what we want to do. R=avi@chromium.org Bug: 866140, 1069111 Change-Id: I4d41d3c3afaedc3d57424b8a4592037dc5aa9c44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291973 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#787352}
-
Mohamed Amir Yosef authored
This CL brings the moving bubble very close the mocks in the linked bug Screenshots: Favicon available: https://screenshot.googleplex.com/g1M17ZqWTbn Fallback: https://screenshot.googleplex.com/s5TMH5cZ3at Bug: 1100814 Change-Id: Icaa1e3998cc6e1c21edd79b9acd84751f45b0d03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283213 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#787351}
-
Alex Newcomer authored
This seems large, but a lot of this is boiler plate, moved files, or vector icons. This feature is a productivity experiment. The basics are: - Copy some things, per usual. - Press search + v to see a small menu showing previously copied things. - Select one of the previously copied things, the result will be that it is pasted into the active window. Known issues: - Some webapps render their text input in an IFrame, and we cannot know where the caret is. - https://crbug.com/1099930 Metrics and more tests will be in the next CL. Bug: 1095209, 1099309 Change-Id: Icb8a44cec5ad038ddfdb2889c71fa89065ac8138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274463 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#787350}
-
Yi Xu authored
The getImageDataColorManaged test uses the old createImageData method and cannot create any imageData. Removing the test. TBR=fserb@chromium.org Bug: 1087019 Change-Id: I037bc8ffb6a56af5181a521e1d8580eb0483b065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276808Reviewed-by:
Yi Xu <yiyix@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#787349}
-
Wei Li authored
Add "Example: Theme-Aware UI" in UI documentation. Bug: none Change-Id: I7928065379550a76cba719e14e9fd90c1a29729c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292858 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#787348}
-
Kevin Ellis authored
Step 1 in a multi-part update to the README. This patch primarily focuses on the types of animations, where the code lives for each, and where detailed documentation can be found. The patch also contains a few minor edits to the contacts and specs, which were both 2 years out of date. Finally a small section referring to a deprecated class was removed. Follow up patches will expand the documentation to cover the full web-animations API, and to provide more comprehensive coverage of animation/keyframe effects, timing functions, and composite modes. These edits are likely to be spread across multiple markup files. Previewed using go/MarkEd. Change-Id: Iba0f2b35dfbeb10e70b4d9049fad59423da766b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289920Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#787347}
-
Mike Wasserman authored
Bug: 1104169 TBR: apotapchuk@chromium.org, anqing@chromium.org, rsorokin@chromium.org Change-Id: If3bba0dd1c688036048ff2776cb153da362ee8e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292996Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#787346}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7a4f98e04091..27d352134c59 2020-07-10 kimanh@chromium.org Reland: Add E2E tests for Breakpoint test cases If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I87e6e8e12f0c3fabf8e1f9dc2734c8649cf5d848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292917Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787345}
-
Karandeep Bhatia authored
Both literal strings and char arrays are accepted by StringPiece constructor. Simplify the generated code using these constructors. So the generated code will be: static const struct { base::StringPiece name; base::StringPiece schema; } kSchemas[] = { {"alarms", kAlarms}, ... }; instead of static const struct { base::StringPiece name; base::StringPiece schema; } kSchemas[] = { {{"alarms", 6}, {kAlarms, sizeof(kAlarms) - 1}}, ... }; BUG=None Change-Id: I2a70df40d221ff069446fab6a6fed530bdb5706b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291312Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#787344}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a2b2d37f953e..6ef441ecad8e 2020-07-10 treehugger-gerrit@google.com Merge "tp: move completition of dangling sched events from C++ to SQL" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ic2a6647f7859dc3eda030c6da502dd2b59f4736d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292662Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787343}
-