GitLab

The comments on both methods I'm checking point out that they need to
be NULL checked. Hopefully, adding the NULL checks fixes the crashes.

BUG=107015
TEST=push to M17, see if it fixes crash in wild.


Review URL: http://codereview.chromium.org/8893010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113890 0039d316-1c4b-4281-b951-d872f2087c98

Properly handle dependencies for installing the ppd
Register for uninstall


BUG=106094
TEST=Copy port monitor dlls, virtual_driver_setup.exe, and gcp-driver.ppd into a single folder and launch the setup as admin.  The driver should be installed.  Run it again with --uninstall (or choose the cloud print driver in add/remove programs) and the driver should be uninstalled and the containing folder removed.


Review URL: http://codereview.chromium.org/8770019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113889 0039d316-1c4b-4281-b951-d872f2087c98

If the PasswordStore is asked to add an entry that already exists it
will overwrite the existing entry.  When this happens, it will report a
PasswordStoreChange::ADD event, much like it would had the original
entry not existed.  This confuses the PasswordChangeProcessor which
assumes that an ADD event implies that the added item did not previously
exist.

This change works around the issue by allowing the password change
processor to try to update an existing node in the event that the
creation of a new node fails.  This allows it to handle the case where a
it receives an ADD event for an existing node.

A better solution would be to have the PasswordStore to always return an
UPDATE event in cases where the node being updated already exists.  If
that solution were implemented the PasswordChangeProcessor would be
right to report an UnrecoverableError if it is unable to create a new
sync node in response to an ADD event.

BUG=87855
TEST=See repro steps in crbug.com/87855, crbug.com/103455


Review URL: http://codereview.chromium.org/8862005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113888 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106384
TEST=Reproduced the bug. Applied my patched and verified that the GAIA picture came back again after re-logging in.


Review URL: http://codereview.chromium.org/8879036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113887 0039d316-1c4b-4281-b951-d872f2087c98

3 fewer files with static initializers on linux & mac:
http://build.chromium.org/f/chromium/perf/linux-release/sizes/report.html?history=150&rev=-1&graph=chrome-si
http://build.chromium.org/f/chromium/perf/linux-release-64/sizes/report.html?history=150&rev=-1&graph=chrome-si
http://build.chromium.org/f/chromium/perf/mac-release/sizes/report.html?history=150&rev=-1&graph=chrome-si

Much better t on Mac 10.5 Intl1:
http://build.chromium.org/f/chromium/perf/mac-release-10.5/intl1/report.html?history=150&rev=-1

TBR=cmp
Review URL: http://codereview.chromium.org/8897020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113886 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105811
TEST=Verify checkboxes render correctly in options window with any font size selected.
Review URL: http://codereview.chromium.org/8879035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113885 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8892017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113884 0039d316-1c4b-4281-b951-d872f2087c98

original CL:
Updated update_manifest.py to push manifest files to server
http://codereview.chromium.org/8566045 (r1387, not this CL)

BUG=None
TEST=None
TBR=bradnelson

Review URL: http://codereview.chromium.org/8889029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113883 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106860
TEST=Manual

Review URL: http://codereview.chromium.org/8897017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113882 0039d316-1c4b-4281-b951-d872f2087c98

 I'm not familiar with this code so I'm disabling this for now.

BUG=107026,104359
TEST=none


Review URL: http://codereview.chromium.org/8892009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113881 0039d316-1c4b-4281-b951-d872f2087c98

evaluated at compile time in extension.cc.

Removes 1 static initializer on both linux and mac.

BUG=94925
TEST=none

Review URL: http://codereview.chromium.org/8892012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113880 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94925
TEST=none

Review URL: http://codereview.chromium.org/8895010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113879 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113878 0039d316-1c4b-4281-b951-d872f2087c98

75: [OTS] sanitizer incorrectly rejects fonts with optical size feature ('size')
76: Remove all 51 static initializers from ots.cc.

BUG=94925
TEST=none
TBR=agl

Review URL: http://codereview.chromium.org/8894011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113877 0039d316-1c4b-4281-b951-d872f2087c98

The GAIA profile downloader code was causing log spew for tests.

I tried to disable the logging for test code but I couldn't figure out how to do it so I'm just lowering the log level instead.

BUG=106783
TEST=


Review URL: http://codereview.chromium.org/8873028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113876 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8888021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113875 0039d316-1c4b-4281-b951-d872f2087c98

base/task.h is going away and being replaced by base/bind.h and base/callback.h.
This CL was automatically generated by sed.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8885018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113874 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8869003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113873 0039d316-1c4b-4281-b951-d872f2087c98

scripts.
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8892015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113872 0039d316-1c4b-4281-b951-d872f2087c98

DownloadsTest.testBigZip to be specific

BUG=107050
TEST=tree gets a little bit greener

Review URL: http://codereview.chromium.org/8901001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113871 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8879039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113869 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106208

Review URL: http://codereview.chromium.org/8865005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113868 0039d316-1c4b-4281-b951-d872f2087c98

These ones are slightly darker

BUG=100775
TEST=

Review URL: http://codereview.chromium.org/8893011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113867 0039d316-1c4b-4281-b951-d872f2087c98

Giving it more time to bake.

BUG=none
TEST=tests updated


Review URL: http://codereview.chromium.org/8863011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113866 0039d316-1c4b-4281-b951-d872f2087c98

inherited from the base class.

Manual changes only to spdy_protocol.h, the rest of the CL generated by
running and then manually fixing the one 80 col violation:

 perl -pi -e "s/SpdyControlFrame::size\(\)/SpdyControlFrame::kHeaderSize/"  $(git grep -l SpdyControlFrame::size)

This is the same as the google-internal CL 25980588

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8898003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113865 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8487002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113864 0039d316-1c4b-4281-b951-d872f2087c98

out correct button state in mouse moves.

BUG=none
TEST=none
R=oshima@chromium.org


Review URL: http://codereview.chromium.org/8872057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113863 0039d316-1c4b-4281-b951-d872f2087c98

BUG=102685
TEST=NONE
R= estade@chromium.org, sail@chromium.org, jeffreyc@chromium.org

Review URL: http://codereview.chromium.org/8822024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113862 0039d316-1c4b-4281-b951-d872f2087c98

This is also removing the UpdateRect ack in the accelerated compositing case,
because it is not needed (and adds scheduling constraints that reduce
throughput).

This also sends a "dummy" message to the browser to unblock the UI thread if it's waiting on an UpdateRect when the transition from non-accelerated to accelerated happens: the GPU process may need to round trip to the browser UI thread before sending the SwapBuffers callback.

BUG=58782
TEST=reduced jankiness on aura builds when resizing.


Review URL: http://codereview.chromium.org/8498036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113861 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nkostylev@chromium.org
BUG=106473
TEST=Lock screen, observe that launcher icons are no longer visible.

Review URL: http://codereview.chromium.org/8899001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113860 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104248
TEST=chrome: about:gpu and webgl pages (both aura and gtk), compositor_unittests, views_unittests


Review URL: http://codereview.chromium.org/8890042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113858 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=self


Review URL: http://codereview.chromium.org/8873038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113857 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:23931
TEST=import incorrect and correctly formatted ONC files


Review URL: http://codereview.chromium.org/8879029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113856 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky@chromium.org
BUG=106897
TEST=cursor appears in a textfield on focus.

Review URL: http://codereview.chromium.org/8879049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113855 0039d316-1c4b-4281-b951-d872f2087c98

- Fix the memory leak in PluginImageData.
- Fix the out-of-bound memory access in mouselock NaCl example.

BUG=106779
TEST=mouselock NaCl example won't crash after a while (~30 seconds).

Review URL: http://codereview.chromium.org/8872045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113854 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106725
TEST=RTLTest.WrapPathWithLTRFormatting on Aura/Linux.

Review URL: http://codereview.chromium.org/8894007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113853 0039d316-1c4b-4281-b951-d872f2087c98

Fix issue where a crash in the cloud print connector on shutdown will prevent the enable pref change from being persisted.
Moves the write of the pref to earlier in the shutdown process so that if a crash occurs the pref will still be recorded.

BUG=106919
TEST=Verify 106919


Review URL: http://codereview.chromium.org/8879040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113852 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8888037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113851 0039d316-1c4b-4281-b951-d872f2087c98

When defined USE_XI2_MT, slot id of TouchEvent is maintained
by a map of tracking id to slot id. Because tracking id will
always keep increasing. The item should be released by TouchRelease
to free the slot id for future use.

BUG=106673
TEST=Manually Tested


Review URL: http://codereview.chromium.org/8839004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113850 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107024
TEST=sync data

Review URL: http://codereview.chromium.org/8897015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113849 0039d316-1c4b-4281-b951-d872f2087c98