GitLab

This is a follow-up CL for
https://codereview.chromium.org/2577183002/
to fix an if statement at //content/browser/bluetooth/bluetooth_metrics.cc
It should be "if (!accept_all_devices)" instead of "if (accept_all_devices)"

TBR=scheib@chromium.org

BUG=674195

Review-Url: https://codereview.chromium.org/2590333002
Cr-Commit-Position: refs/heads/master@{#439876}

This CL is the preparation to split ArcSession running parts
from ArcBridgeService.
- Rename ArcBridgeService::State names to be consistent with
  terms used in other ARC modules.
- Remove unused CONNECTED from State.
- Migrate PrerequisitesChanged() and StopInstance() into
  RequestStart() and RequestStop().
- Rename some fields of ArcBridgeServiceImpl for consistency.
- Cleaned up include directives.

BUG=657687
BUG=b/31079732
TEST=Ran bots.

Review-Url: https://codereview.chromium.org/2577373002
Cr-Commit-Position: refs/heads/master@{#439875}

Revert of Mojo JS bindings: switch most usage of "connection"/"router" module to "bindings". (patchset #9 id:160001 of https://codereview.chromium.org/2571903003/ )

Reason for revert:
Possibly caused flakiness of WebUIMojoTest.EndToEndPing

https://bugs.chromium.org/p/chromium/issues/detail?id=676071

Original issue's description:
> Mojo JS bindings: switch most usage of "connection"/"router" module to "bindings".
>
> BUG=579646
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Committed: https://crrev.com/f3725926982fb61cb4163ee5a0af6d99160f8553
> Cr-Commit-Position: refs/heads/master@{#439615}

TBR=rockot@chromium.org,eugenebut@chromium.org,jam@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=579646

Review-Url: https://codereview.chromium.org/2590393002
Cr-Commit-Position: refs/heads/master@{#439874}

Running out of array levels can cause the VP9 MFT to hang waiting for
some picture buffers to be released. This shouldn't be able to happen
(pending_output_samples_ should have at most one element), but save
information so we can be sure.

BUG=636158, 613701
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2590723002
Cr-Commit-Position: refs/heads/master@{#439873}

Revert of Roll ANGLE f047097..71168a0 (patchset #1 id:1 of https://codereview.chromium.org/2597443002/ )

Reason for revert:
https://build.chromium.org/p/chromium/builders/Win%20x64/builds/6994/steps/compile/logs/stdio

ninja -t msvc -e environment.x64 -- C:\b\c\cipd\goma/gomacc.exe "C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\bin\amd64/cl.exe" /nologo /showIncludes /FC @obj/third_party/angle/src/tests/angle_perftests/UniformsPerf.obj.rsp /c ../../third_party/angle/src/tests/perf_tests/UniformsPerf.cpp /Foobj/third_party/angle/src/tests/angle_perftests/UniformsPerf.obj /Fd"obj/third_party/angle/src/tests/angle_perftests_cc.pdb"
c:\b\c\b\win_x64_archive\src\third_party\angle\src\tests\perf_tests\uniformsperf.cpp(148): error C2220: warning treated as error - no 'object' file generated
c:\b\c\b\win_x64_archive\src\third_party\angle\src\tests\perf_tests\uniformsperf.cpp(148): warning C4267: 'initializing': conversion from 'size_t' to 'GLint', possible loss of data
c:\b\c\b\win_x64_archive\src\third_party\angle\src\tests\perf_tests\uniformsperf.cpp(149): warning C4267: 'initializing': conversion from 'size_t' to 'GLint', possible loss of data

Original issue's description:
> Roll ANGLE f047097..71168a0
>
> https://chromium.googlesource.com/angle/angle.git/+log/f047097..71168a0
>
> BUG=chromium:674143
>
> TBR=cwallez@chromium.org
>
> TEST=bots
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
>
> Committed: https://crrev.com/47cd7960532e2a1bd4e7a987b69c66f632f7f6c9
> Cr-Commit-Position: refs/heads/master@{#439866}

TBR=cwallez@chromium.org,jmadill@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:674143

Review-Url: https://codereview.chromium.org/2587413003
Cr-Commit-Position: refs/heads/master@{#439872}

This CL lands server change 141612065 by bnouri.

BUG=488484

Review-Url: https://codereview.chromium.org/2589053002
Cr-Commit-Position: refs/heads/master@{#439871}

As we turn the feature EnableSyncUSSDeviceInfo to handle DeviceInfo
with a USS approach instead of via Directory, we want to have the bots
testing the new code paths.

There were several issues that were fixed before this patch. Here we're
only making two changes to fix failing tests.

1. Python sync server implementation is relaxing its restrictions about
progress marker. It seemed arbitrarily and pedantic for it to treat
empty tokens and non-present tokens differently, so now starts both as
first time syncs. This more accurately reflects how the real server
handles this case.

2. EnableDisableSingleClientTest no longer tests USS types. As we add
more USS  types we'll unfortunately have to update this code to exclude
those types as well. There isn't a good USS equivalent to checking for
top level nodes to see if a type has actual sync data. There is no
directory and there are no top level nodes. When USS is completely
rolled out we may just want to remove this test class.

BUG=650725

Review-Url: https://codereview.chromium.org/2568543004
Cr-Commit-Position: refs/heads/master@{#439870}

Differentiate between loading and non-loading internal blink tasks and
post them to appropriate task queues.

BUG=624696

R=skyostil@chromium.org,haraken@chromium.org

Review-Url: https://codereview.chromium.org/2556993005
Cr-Commit-Position: refs/heads/master@{#439869}

This CL removes an unused property to make the code cleaner.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2593453002
Cr-Commit-Position: refs/heads/master@{#439868}

This reverts commit 4fa2d926.

Broken msan, see

https://build.chromium.org/p/chromium.memory.full/builders/Chromium%20Linux%20MSan%20Builder/builds/3718

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20MSAN/builds/228

Lots of

WARNING: MemorySanitizer: use-of-uninitialized-value

errors, i.e.

FAILED: gen/chrome/browser/profile_resetter/profile_reset_report.pb.h gen/chrome/browser/profile_resetter/profile_reset_report.pb.cc pyproto/chrome/browser/profile_resetter/profile_reset_report_pb2.py

python ../../tools/protoc_wrapper/protoc_wrapper.py profile_reset_report.proto --protoc ./protoc --proto-in-dir ../../chrome/browser/profile_resetter --cc-out-dir gen/chrome/browser/profile_resetter --py-out-dir pyproto/chrome/browser/profile_resetter

==13798==WARNING: MemorySanitizer: use-of-uninitialized-value

    #0 0x8b50eb  (/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x8b50eb)

    #1 0x728c3a  (/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x728c3a)

    #2 0x6007b3  (/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x6007b3)

    #3 0x4d56dc  (/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x4d56dc)

    #4 0x48e2a6  (/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x48e2a6)

    #5 0x4a8805  (/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x4a8805)

    #6 0x49d4c1  (/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x49d4c1)

    #7 0x48de96  (/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x48de96)

    #8 0x7f9f29a7576c  (/lib/x86_64-linux-gnu/libc.so.6+0x2176c)

    #9 0x420a68  (/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x420a68)

  Uninitialized value was created by a heap allocation

    #0 0x48c8d2  (/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x48c8d2)

    #1 0x6129be  (/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x6129be)

    #2 0x5f7d54  (/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x5f7d54)

    #3 0x4d4657  (/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x4d4657)

    #4 0x48e2a6  (/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x48e2a6)

    #5 0x4a8805  (/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x4a8805)

    #6 0x49d4c1  (/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x49d4c1)

    #7 0x48de96  (/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x48de96)

    #8 0x7f9f29a7576c  (/lib/x86_64-linux-gnu/libc.so.6+0x2176c)

SUMMARY: MemorySanitizer: use-of-uninitialized-value (/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x8b50eb)

Exiting

Protoc has returned non-zero status: 77 .

R=pkasting@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2590803003 .
Cr-Commit-Position: refs/heads/master@{#439867}

https://chromium.googlesource.com/angle/angle.git/+log/f047097..71168a0

BUG=chromium:674143

TBR=cwallez@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2597443002
Cr-Commit-Position: refs/heads/master@{#439866}

BUG=chromium:468240
TBR=jochen@chromium.org,haraken@chromium.org,hlopko@chromium.org

Review-Url: https://codereview.chromium.org/2592713002
Cr-Commit-Position: refs/heads/master@{#439865}

R=dpapad@chromium.org
BUG=673825
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2594763002
Cr-Commit-Position: refs/heads/master@{#439864}

This moves setting of the skip service worker flag on CORS preflighted requests
to happen earlier so that even non-simple requests for which we don't end up
sending a preflight request still skip any service workers.

BUG=674370

Review-Url: https://codereview.chromium.org/2582833002
Cr-Commit-Position: refs/heads/master@{#439863}

The correct order should be (expected, actual) as per macro definitions in
gtest.h.

BUG=661608

Review-Url: https://codereview.chromium.org/2585303002
Cr-Commit-Position: refs/heads/master@{#439862}

This prevents showing a dotted outline around a user row
(in addition to the grey bg hover effect) when you click and hold.

The only reason these were all explicitly set to request focus on
press is because the default value for that bit was flipped back in
May and most existing buttons were mechanically updated to stick with
the old default.

The focus effect should probably also be updated to something more MD-
looking for when you do tab to a row, but that's left as an exercise for
the future.

BUG=none

Review-Url: https://codereview.chromium.org/2589863002
Cr-Commit-Position: refs/heads/master@{#439861}

This matches what was done in RELEASE_ASSERT in blink. No perf
bots noticed this being missing (it does nothing on windows which
is where perf bots noticed anything) but it won't hurt right.

R=dcheng@chromium.org
BUG=672699

Review-Url: https://codereview.chromium.org/2589943002
Cr-Commit-Position: refs/heads/master@{#439860}

serialize-nested-array.html in blink_perf.bindings was failing
because of too much of nest level in test code, which was
causing stack overflow in V8.  The failure was triggered with
https://crrev.com/2517813002 .

Discussed with the test owner peria@ and reached to a conclusion
that we don't need such a huge nest level for this test.  Thus,
this CL reduces the nest level of the test.

BUG=670069
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2553993002
Cr-Commit-Position: refs/heads/master@{#439859}

Also remove unused forward declaration of AXObject.

Review-Url: https://codereview.chromium.org/2589263002
Cr-Commit-Position: refs/heads/master@{#439858}

Move ongot/lostpointercapture handlers from
Element.idl to GlobalEventHandlers as per latest
spec change:
https://github.com/w3c/pointerevents/pull/158

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/?hl=en#!topic/blink-dev/T_amUSoAzHA

BUG=674290

Review-Url: https://codereview.chromium.org/2584723004
Cr-Commit-Position: refs/heads/master@{#439857}

BUG=666773

Review-Url: https://codereview.chromium.org/2591553002
Cr-Commit-Position: refs/heads/master@{#439856}

Before we can convert from a visual point to a flow thread point, we need the
input point to be exactly relative to the flow thread, or we might end up
mapping it to the wrong column.

In other words, we need to add the flow thread object's location before
converting into the flow thread coordinate space. While the flow thread indeed
is at 0,0 (or at least close enough to 0,0) relatively to the multicol
container in very many cases, this isn't true when the multicol container is in
rtl writing-mode, or when it's scrollable, or even when the multicol container
has borders and/or padding.

BUG=663062

Review-Url: https://codereview.chromium.org/2593633002
Cr-Commit-Position: refs/heads/master@{#439855}

MenuItemView was using ButtonDisabledColor for coloring menuitem
subtext (usually used for accelerator shortcuts).  However, Adwaita on
Gtk3.0 uses the same color for disabled button text as for menu
backgrounds, meaning menuitem subtext appeared invisible.  This CL
adds MenuItemSubtitleColor to fix this issue.

BUG=132847
R=sky@chromium.org,erg@chromium.org

Review-Url: https://codereview.chromium.org/2575343005
Cr-Commit-Position: refs/heads/master@{#439854}

https://skia.googlesource.com/skia.git/+log/22f4a1fd4859..86cedfc31588

$ git log 22f4a1fd4..86cedfc31 --date=short --no-merges --format='%ad %ae %s'
2016-12-20 robertphillips Fix iOS build
2016-12-20 brianosman Tag string bitmaps (for GMs) as sRGB
2016-12-20 robertphillips Restore getDevice_just_for_deprecated_compatibility_testing
2016-12-20 brianosman Do color space conversion in XfermodeImageFilter
2016-12-20 jvanverth Floor to scalar for SDF paths.
2016-12-20 scroggo Update libwebp to v0.5.2-rc2

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=rmistry@google.com

Review-Url: https://codereview.chromium.org/2590783004
Cr-Commit-Position: refs/heads/master@{#439853}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/8bf02eb7..95ddaea4

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2590983002
Cr-Commit-Position: refs/heads/master@{#439852}

R=brettw@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2595503003
Cr-Commit-Position: refs/heads/master@{#439851}

This CL refactors ArcBridgeServiceImpl focusing on the
retry mechanism.
- With this CL, it starts to use OneShotTimer, which supports
cancel operation.
- Rename "reconnect" to "restart" for wording consistency.
- Introduce restart_delay_ for testing, instead of special
  bool flag. Also, for restarting of testing, get rid of
  synchronous PrerequisitesChanged() call, instead PostTask always.
- Extract StartArcSession() for sharing PrerequisitesChanged()
  and restarting.
- Added more DCHECKs.

BUG=657687
BUG=b/31079732
TEST=Ran bots.

Review-Url: https://codereview.chromium.org/2582003002
Cr-Commit-Position: refs/heads/master@{#439850}

In particular this fixes:
- loading data from leveldb should strip the prefix from the keys
- writing data to leveldb should preprend the prefix to the keys
- CommitChanges should actually commit changes

BUG=586194

Review-Url: https://codereview.chromium.org/2583253002
Cr-Commit-Position: refs/heads/master@{#439849}

Not needed at the Image interface level.

R=junov@chromium.org

Review-Url: https://codereview.chromium.org/2590573002
Cr-Commit-Position: refs/heads/master@{#439848}

BUG=602666

Review-Url: https://codereview.chromium.org/2590943002
Cr-Commit-Position: refs/heads/master@{#439847}

BUG=675266

Review-Url: https://codereview.chromium.org/2578323006
Cr-Commit-Position: refs/heads/master@{#439846}

Previously chrome --mash would always create the shelf on startup, even at
the login screen. Now it waits until login is complete, like classic ash.

Ash watches for SessionState::ACTIVE via a SessionStateObserver to create the
shelf, rather than NOTIFICATION_LOGIN_USER_PROFILE_PREPARED. For most login
flows this doesn't matter, but for supervised user creation it means that the
shelf is not created until the flow is completed. This is an improvement
because in the old code the shelf would be created too early and had to be
explicitly hidden.

Always create a SessionControllerClient in chrome, even in classic ash. This
allows classic ash to use the mojo pathway via ash::SessionController.

Remove WmShell::ShowShelf(), which was introduced in crrev.com/10693003 to
delay showing the shelf until post-login OOBE (like avatar picture select)
was complete. It does not seem to be needed anymore, either in production or
in tests.

Change AshTestImplMus to simulate a user logging in which is required to
create the shelf on the primary display and also to have a non-zero user
count to create the shelf on additional displays.

Remove some unnecessary OS_CHROMEOS ifdefs in //c/b/ui/ash.

BUG=666021
TEST=ash_unittests and chrome browser_tests

Review-Url: https://codereview.chromium.org/2573703003
Cr-Commit-Position: refs/heads/master@{#439845}

Test test reads body right after receiving a response, but it leads to some
flakiness. It is not guaranteed that the response body is available at the
moment.

This change fixes the problem by reading response body after the loading
finishes.

BUG=675924
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2592663002
Cr-Commit-Position: refs/heads/master@{#439844}

The update icon in the system tray was small and blurry on 1x displays.

BUG=643401

Review-Url: https://codereview.chromium.org/2595623002
Cr-Commit-Position: refs/heads/master@{#439843}

Pass the URL instead of the VirtualURL to the native providers and the
webUI.

BUG=671964

Review-Url: https://codereview.chromium.org/2590803002
Cr-Commit-Position: refs/heads/master@{#439842}

Currently, we activate the time source as soon as one observer becomes
pending. If that observer is removed, the time source may currently do
an unneccessary tick, because we only deactivate the time source if
all observers were removed.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2591773002
Cr-Commit-Position: refs/heads/master@{#439841}

Disable WebViewClientTest testShouldOverrideUrlLoadingOnCreateWindow,
which has been flaky on L and N bot, and ServiceWorkerClientTest
testServiceWorkerClientInterceptCallback, which has been failing on N bot

BUG=659077, 675809

Review-Url: https://codereview.chromium.org/2590053002
Cr-Commit-Position: refs/heads/master@{#439840}

This CL makes use of the resetting function VariationParamsManager.
This should work now and therefore it is sufficient to hold the manager
as a simple member.

BUG=672010

Review-Url: https://codereview.chromium.org/2592663003
Cr-Commit-Position: refs/heads/master@{#439839}

Controlled by the NTPPreferAmpUrls feature, enabled by default.

BUG=668095
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2593573003
Cr-Commit-Position: refs/heads/master@{#439838}

Per the specs at go/fns-ui-spec, the "Login not secure" warning should
show up in username fields as well as password fields. Which makes sense
because usernames are sensitive information too. Thus, this CL populates
the "Login not secure" warning in the suggestions dropdown of a password
form regardless of whether the field is a password field or not.

BUG=675696
TEST=Enable #enable-http-form-warning in chrome://flags and relaunch
Chrome. Save a username/password in the Name/Password form in
http://rsolomakhin.github.io/autofill/. Focus the "Name" field and
observe a "Login not secure" warning in the autofill dropdown.

Review-Url: https://codereview.chromium.org/2585173006
Cr-Commit-Position: refs/heads/master@{#439837}