- 01 Feb, 2019 5 commits
-
-
Wez authored
FDIO will implement BSD socket APIs using the new SocketProvider service rather than the old LegacySocketProvider, so add the new service to our sandbox policies. LegacySocketProvider will be removed after the Fuchsia SDK is rolled to pick up the new FDIO implementation. Bug: 927469 Change-Id: Ib662e052272a60dc1ee7d3d50553df89efa266df Reviewed-on: https://chromium-review.googlesource.com/c/1448985Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#628159}
-
Brian Salomon authored
Bug: skia:8736 Change-Id: If4d8eb548b8b8ec55ea93f8db82a72b3330e71aa Reviewed-on: https://chromium-review.googlesource.com/c/1448749 Commit-Queue: Brian Salomon <bsalomon@google.com> Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Brian Salomon <bsalomon@google.com> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#628158}
-
Xiaocheng Hu authored
Explainer: http://bit.ly/2QVAwGq#heading=h.i9ha0k20utmo This patch: 1. Adds line information into NGCaretNavigator. Each line is represented as a [start_offset, end_offset) range on |text_|. Also marks the role of each character in the line using newly introduced |CharacterFlag|. 2. Make visual caret left and right movements aware of the lines, so that it correctly moves across line boundaries even when bidi is involved. Bug: 894651 Change-Id: Ic0354feb6abf5de859dacb785e48493d355e3bfc Reviewed-on: https://chromium-review.googlesource.com/c/1407182 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#628157}
-
Bence Béky authored
In qpack_encoder_stream_sender_fuzzer.cc, use NoopEncoderStreamSenderDelegate from qpack_encoder_test_utils.h instead of redefining it. Move MockEncoderStreamSenderDelegate from qpack_encoder_stream_sender_test.cc to qpack_encoder_test_utils.h so that it can be easily found and reused if needed in the future. This CL lands internal change 231643834 by bnc. Change-Id: I9d4b16cc045171554ab0a2165a3d1fa59f643f48 Reviewed-on: https://chromium-review.googlesource.com/c/1446472Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#628156}
-
Thomas Guilbert authored
The flag was turned on via an experiment in M72, and turned on by default in M73. The old path is being removed in M74. Bug: 790766 Change-Id: I55ec170b0debc3e600c5974dfd824fcc6cfb3a4d Reviewed-on: https://chromium-review.googlesource.com/c/1447113 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#628155}
-
- 31 Jan, 2019 35 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/04bdd8103515..232527952597 Created with: gclient setdep -r src-internal@232527952597 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:926053 TBR=mmoss@chromium.org Change-Id: I6548942ae12e0eef9661dfc604b6aeb114055150 Reviewed-on: https://chromium-review.googlesource.com/c/1448677Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628154}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/a2e2d7f291cf..8926f0f331d8 git log a2e2d7f291cf..8926f0f331d8 --date=short --no-merges --format='%ad %ae %s' 2019-01-31 tsepez@chromium.org Remove some cross-component include directives. Created with: gclient setdep -r src/third_party/pdfium@8926f0f331d8 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ifc796c98aee72465021db56197377fb1ab893965 Reviewed-on: https://chromium-review.googlesource.com/c/1448675Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628153}
-
Kenneth Russell authored
The Vulkan driver isn't correctly installed yet. Bug: 927459 Tbr: cwallez@chromium.org No-Try: True Change-Id: I10d3f69ab527cda141b1f0d24ea3ed6ca8567619 Reviewed-on: https://chromium-review.googlesource.com/c/1448558 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#628152}
-
Mike Wasserman authored
TBR=lanwei@chromium.org Bug: 927454 Change-Id: I57c80d1124b6b3de96eb17626f4182c6776be749 Reviewed-on: https://chromium-review.googlesource.com/c/1448748Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#628151}
-
Dave Tapuska authored
Replace the identifier with the base value. sed -i "s/ThreadIdentifier/base::PlatformThreadId/g" ie: Change-Id: Ic3ae82468c6432c65c7f34b5788879d44bdf9b64 Reviewed-on: https://chromium-review.googlesource.com/c/1448705 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#628150}
-
David Benjamin authored
Bug: 927022 Change-Id: I6f982752b35fbe3117e10128a5c8b50e02deb697 Reviewed-on: https://chromium-review.googlesource.com/c/1446815 Commit-Queue: David Benjamin <davidben@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#628149}
-
Bo Liu authored
So don't use package, and just hard code the string. It's actually an activity-alias, I believe. TBR: tedchoc@chromium.org Change-Id: Ib75fc55fbcbf3ea3ba674c2ac7940bfeff21dcb4 Reviewed-on: https://chromium-review.googlesource.com/c/1449091Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#628148}
-
Nikita Podguzov authored
Bug: 814364 Change-Id: I3741e1fbe9193cb563ce2c9670219f9d651b9b52 Reviewed-on: https://chromium-review.googlesource.com/c/1406813Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Cr-Commit-Position: refs/heads/master@{#628147}
-
Henrique Ferreiro authored
This include is not used. Bug: 927247 Change-Id: I9cc12a5de471250d6bae6ecff3c85ecf72d50b2b Reviewed-on: https://chromium-review.googlesource.com/c/1447735Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#628146}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6e669b46b479..67957c299322 git log 6e669b46b479..67957c299322 --date=short --no-merges --format='%ad %ae %s' 2019-01-31 smbarber@chromium.org usergroup_baseline: add cicerone-client group Created with: gclient setdep -r src/third_party/chromite@67957c299322 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Id688703fdaa61a2634d4edd07824221ae64009fa Reviewed-on: https://chromium-review.googlesource.com/c/1449013Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628145}
-
Gyuyoung Kim authored
signin_manager() has not been used by anywhere. So it's not necessary now. This CL removes the function and related to a member variable and header includes. Bug: 927252 Change-Id: Ib05e73367f72a0dc0b752f6402ac2a19e9dd0ffc Reviewed-on: https://chromium-review.googlesource.com/c/1447994Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#628144}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 186c9384. With Chromium commits locally applied on WPT: c64e59c2 "Deflake RTCPeerConnection-track-stats.https.html." 2376792a "Enable analyser tests to run with Chrome" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: domenic@chromium.org, ricea@chromium.org: external/wpt/streams NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I804b84ade1c2de1f22d174c4141aa11cde46412b Reviewed-on: https://chromium-review.googlesource.com/c/1448792Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628143}
-
Henrique Ferreiro authored
This include is not used. Bug: 927250 Change-Id: I6aeb3993b7b2656bf7d136ce1706703e8627a49b Reviewed-on: https://chromium-review.googlesource.com/c/1448157Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#628142}
-
Moe Ahmadi authored
Adds unit tests for the TranslateInfobarMediator for: - whether it installs UI handlers on ChromeIOSTranslateClient as expected. - whether it returns the expected menu items for the translate infobar. Bug: 910994 Change-Id: I90b9aa4a466a659afea37f0ca3e5a3e4535df84d Reviewed-on: https://chromium-review.googlesource.com/c/1436943 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#628141}
-
Quan Nguyen authored
On repeat shows, the "remove user" confirmation message gets reset to hidden. If user menu goes out of bounds on the right, shift left. If it goes out of bounds on the bottom, shift right of the anchor and up. Bug: 917308 Change-Id: I2a8cefd7eb1fd68087408999822def1c80b51762 Reviewed-on: https://chromium-review.googlesource.com/c/1448080Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#628140}
-
Jay Harris authored
- Updates Windows and Mac to run through the badge manager so that the last badge value is stored. - Threshes out the concept of a badge_manager_delegate, as it was too tightly coupled to Chrome OS to be used for Windows and Mac. - Checks the app is in scope before calling the badge manager, so as to not regress Windows/Mac. - Moves Windows and Mac specific badging code from badge_service_delegate_impl to specific badge_manager_delegates. Bug: 719176 Change-Id: I01289830d3d1f1d34fec846785f0fd60deed6e97 Reviewed-on: https://chromium-review.googlesource.com/c/1429324Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#628139}
-
Findit authored
This reverts commit ee0a6c8d. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 628053 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZWUwYTZjOGQzYzhmY2NkMThiNGMzZTNiNDhhMzM3ZWE5YzRmMGRiNAw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/75505 Sample Failed Step: webkit_layout_tests Sample Flaky Test: virtual/feature-policy-for-sandbox/http/tests/navigation/start-load-during-provisional-loader-detach.html Original change's description: > Create a virtual test suite for FeaturePolicyForSandbox > > Adds test expectations (marked with bugs) for the tests which are > currently identified as failing. > > Bug: 812381 > Change-Id: I768074cbb4dfb8447b8b809915732e2f7ce8e06c > Reviewed-on: https://chromium-review.googlesource.com/c/1440266 > Reviewed-by: Ehsan Karamad <ekaramad@chromium.org> > Commit-Queue: Ian Clelland <iclelland@chromium.org> > Cr-Commit-Position: refs/heads/master@{#628053} Change-Id: I308fc8ca3528deacd3f4539520dec5984a279e4c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 812381 Reviewed-on: https://chromium-review.googlesource.com/c/1449098 Cr-Commit-Position: refs/heads/master@{#628138}
-
Kenneth Russell authored
Specify each if a value is supplied, even if it's zero. Fix the passthrough of the --isolated-script-test-launcher-retry-limit flag. Bug: 922808 Change-Id: I8a2137bee8395208c5194e7cbf7a5609723cfb93 Reviewed-on: https://chromium-review.googlesource.com/c/1448555 Commit-Queue: Kenneth Russell <kbr@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Auto-Submit: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#628137}
-
Fredrik Söderquist authored
Folds the "background-image version" of GraphicsContext::DrawTiledImage into BoxPainter(Base). Mostly a verbatim move of said method and Image::DrawTiledBackground (the real "meat") an the associated helpers. This also introduces the intended replacement (for versions of this method): GraphicsContext::DrawImageTiled. Calls to StartAnimation are moved into the implementations of Image::DrawPattern as needed. Bug: 614125 Change-Id: Ib04daa5abce9c61c12f4a8297920ea25760557cf Reviewed-on: https://chromium-review.googlesource.com/c/1448458 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#628136}
-
Robbie McElrath authored
Most unit tests don't currently work with the network service enabled. This CL forces the network service off at the beginning of all unit tests to make sure they work when run when the network service is on by default, or run with --enable-features=NetworkService. Bug: 920038 Change-Id: I6f53296ba3ce149669e0361342cf131920a30ed9 Reviewed-on: https://chromium-review.googlesource.com/c/1448323Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#628135}
-
Weidong Guo authored
Description: Track TODO to change 'kSetUpdateOverCellularTarget' to 'kSetUpdateOverCellularOneTimePermission' with a new bug since the original one is archived. Bug: 927439 Change-Id: I152196d2d66fb8512e8f18d63617c6e5187cfa39 Reviewed-on: https://chromium-review.googlesource.com/c/1448704Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#628134}
-
Michael Wasserman authored
This reverts commit a692ce8d. Reason for revert: http://crbug.com/927488 Original change's description: > GWP-ASan: Pack stack traces to save space > > Make use of the stack trace packing from https://crrev.com/627865 to > reduce memory usage to store stacks on 64-bit systems by ~60% percent. A > GWP-ASan microbenchmark did not show this change to noticably regress > performance. > > Bug: 896019, 921237 > Change-Id: Iad6e803f18ff12e5fd3079b9821d11bc0918bead > Reviewed-on: https://chromium-review.googlesource.com/c/1448522 > Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> > Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> > Reviewed-by: Vitaly Buka <vitalybuka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#628034} TBR=vtsyrklevich@chromium.org,vitalybuka@chromium.org Change-Id: I51707427c3f7c736ef6483aa48b1daab1f7b5f59 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 896019, 921237 Reviewed-on: https://chromium-review.googlesource.com/c/1449094Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#628133}
-
Dave Tapuska authored
This will allow the browser to be the source of freezing/resuming individual iframes under certain situations. BUG=907125 Change-Id: Ib1e3af74ba818c1532daec90266f12fc08306ef0 Reviewed-on: https://chromium-review.googlesource.com/c/1444213Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#628132}
-
Victor Costan authored
Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=garykac@chromium.org Bug: 925652 Change-Id: Ic09f1c443991fd259754fa103644f764db2d34bd Reviewed-on: https://chromium-review.googlesource.com/c/1438266Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#628131}
-
Rouslan Solomakhin authored
Before this patch, after a payment handler would send the payment information response to the browser, the browser would continue showing the payment handler page. This patch shows a "Processing..." spinner when the browser receives the payment response and sends it to the merchant website, if one is not already showing (which could happen for non-interactive payment handlers). After this patch, the browser shows a "Processing..." spinner after the payment handler responds with the payment information. Bug: 922206 Change-Id: Ie38fd2e2b258af8d90975cc4570776930812f98a Reviewed-on: https://chromium-review.googlesource.com/c/1447027 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#628130}
-
Bret Sepulveda authored
This patch adds the skeleton of a new View for tab group headers. The View draws as a blue rectangle, with a placeholder title and a button that does nothing. Usage and polish will be added in later patches. Bug: 905491 Change-Id: I0cd56ea2e4205d5b7730f632f8f85ca4162d56b5 Reviewed-on: https://chromium-review.googlesource.com/c/1448740 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#628129}
-
Wenzhao Zang authored
I believe these were added by accident. Please let me know otherwise. TBR=alexclarke@chromium.org Bug: None Change-Id: I83b63870f35b243a1658011a81a106485d968928 Reviewed-on: https://chromium-review.googlesource.com/c/1449001Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#628128}
-
Wez authored
- Migrate frequently-hit not-yet-implemented code paths to use the NOTIMPLEMENTED_LOG_ONCE() macro, to reduce logspam. - Replaced NOTIMPLEMENTED() with NOTREACHED() where particular methods will _never_ be implemented, and should never be called. - Filed distinct bugs for thread & process priorities, and metrics, to be implemented for Fuchsia. Bug: 926581, 926583, 750938, 707031 Change-Id: Iff534f8f7a51fa2a60fdebc0a9349a13f025553c Reviewed-on: https://chromium-review.googlesource.com/c/1444056 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#628127}
-
Kevin Bailey authored
Simply adds a flag for the existing feature. Bug: 883901 Change-Id: I13076b469f55f14ef0cc52f573fc2648736c6684 Reviewed-on: https://chromium-review.googlesource.com/c/1440183Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#628126}
-
Ehsan Karamad authored
The |query_index| was not defined and the test was not actually navigating the test page to the desired URL. TBR=wjmaclean@chromium.org Bug: 659750 Change-Id: I8f9658ac80adaa20f3cdceb0c19f799b59f96987 Reviewed-on: https://chromium-review.googlesource.com/c/1448776Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#628125}
-
Jun Mukai authored
As I checked with DesktopWindowTreeHostX11, it computes the max and min sizes on SizeConstraintsChanged(), BoundsChanged(), and the initial Show(). With this CL, now OverlayWindowViews does not have to set those properties. This will also fix some app window's resizing. Bug: none Test: manually Change-Id: I41ff2baba7807b3311d098d6a1ff050f271903ec Reviewed-on: https://chromium-review.googlesource.com/c/1447047 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#628124}
-
Ayu Ishii authored
Bug: 867008 Change-Id: I71a943d4a88e2f0e5e23d3a72ea6c6ec67eecfa0 Reviewed-on: https://chromium-review.googlesource.com/c/1443957Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#628123}
-
Nicolas Pena authored
This CL aligns PerformanceObserverInit with the latest changes in https://w3c.github.io/performance-timeline/ except for the buffered flag which is still unsupported. This changed in https://github.com/w3c/performance-timeline/pull/112. Intent to Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/IPl_CSXhMbw Bug: 922622 Change-Id: I39f510f302713c3f12f8f80ada1052fdeedc97a3 Reviewed-on: https://chromium-review.googlesource.com/c/1431194 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#628122}
-
Greg Thompson authored
This should be helpful when trying to understand why it sometimes fails. Users can launch Chrome with something like: "%ProgramFiles(x86)%\Google\Chrome\Application\chrome.exe" --enable-logging=stderr or perhaps: "%LOCALAPPDATA%\Google\Chrome\Application\chrome.exe" --enable-logging=stderr to see log messages on the console along the lines of: [14512:3284:0130/153142.365:ERROR:upgrade_util_win.cc(70)] IProcessLauncher::LaunchCmdElevated failed; hr = 80040e01 BUG=926816 Change-Id: Ic3110e3c547c9e3ce51d0c37aba640ff563c6062 Reviewed-on: https://chromium-review.googlesource.com/c/1445895 Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#628121}
-
Brian White authored
Bug: 923083 Change-Id: Iab165268ee17b5aeb36200fdb4de9e4c18a10952 Reviewed-on: https://chromium-review.googlesource.com/c/1447843 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#628120}
-