GitLab

The bunch of if-clauses are hard to read. Reorganize them for better
readability.

Unify the multiple checks on IsExternalRequest.

Early return for IsExternalRequest().

Don't check CORS-safelisted-ness when either of the external request or
forced preflight condition is already met.

Clarify where the ServiceWorkerMode configuration is required and its
reason for each place.

Bug: 695808, 604084
Change-Id: I2a056afeebea4d6472e60c52cc72fd58c6bef703
Reviewed-on: https://chromium-review.googlesource.com/542676Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481846}

 * external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-baseline-multi-item-vert-001b.html
 * external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/writing-modes-3/text-combine-upright-compression-001.html
 * external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/writing-modes-3/text-combine-upright-compression-004.html

BUG=736255
TBR=jsbell@chromium.org,dpranke@chromium.org,mcgreevy@chromium.org,qyearsley@chromium.org,jeffcarp@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2954103002
Cr-Commit-Position: refs/heads/master@{#481845}

This sets up Custom Tabs for hidden tab benchmarking:
- Force the prerendering mode
- Force prerendering on cellular
- Optionally set a different speculated URL and launched URL

Also removes support for no state prefetch and speculative prefetch testing.

Review-Url: https://codereview.chromium.org/2946913002
Cr-Commit-Position: refs/heads/master@{#481844}

BUG=689520
R=primiano@chromium.org

Change-Id: Id7a87939f7df7b86e6b8e6a02ce0ea226e02a573
Reviewed-on: https://chromium-review.googlesource.com/544864Reviewed-by: Primiano Tucci <primiano@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481843}

Add some more code from ServiceWorkerContextRequestHandler to
ScriptURLLoaderFactory.  Also added small cleanup around IsInstalled.

BUG=715640

patch from issue 2953763002 at patchset 1 (http://crrev.com/2953763002#ps1)

Change-Id: Ib0b578378a957e911bf7a36b2929d2723e0b35f7
Reviewed-on: https://chromium-review.googlesource.com/544720Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481842}

TBR=machenbach@chromium.org

Bug: 736215
Change-Id: I30b49f478c8c6ba9a6507092924a6f05a5f6ea8e
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/544867Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481841}

This reverts commit 0a2e609c.

Reason for revert: typo && not useful any more.

Original change's description:
> Temporary remove android_arm64_dbg_recipe from CQ.
> 
> TBR=jochen@chromium.org,mgiuca@chromium.org
> 
> Bug: 736215
> Change-Id: I10fe5c623fdedd51ab0039132a07b8a413a06978
> No-Try: True
> Reviewed-on: https://chromium-review.googlesource.com/544885
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#481837}

TBR=mgiuca@chromium.org,tandrii@chromium.org,jochen@chromium.org

Change-Id: Ie58bf3ed01bc35899ec73a63dd1db90ec797becd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 736215
Reviewed-on: https://chromium-review.googlesource.com/544826Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481840}

Revert of Roll buildtools 7f2cacbbe2..38477c2e10 (patchset #1 id:1 of https://codereview.chromium.org/2953643004/ )

Reason for revert:
Probably broke incremental builds on trybots.

BUG=736215

Original issue's description:
> Roll buildtools 7f2cacbbe2..38477c2e10
>
>   In order to roll GN 7c9bd5f0..bedb4b20 (r465654:r481731) and pick up
>   the following changes:
>
>   a104997e Allow overriding script executable in .gn file
>   18697c83 Move if, else, true, false into a keyword category
>   d4a5e982 [tracing] Switch to new heap dump format.
>   8480d866 tools/gn: Implement Windows SDK version command line switch
>   3e0d5228 Use ContainsValue() instead of std::find() in tools/
>   e4a28698 Fix GN bootstrap
>   11857736 [spelling] existance to existence
>   21886543 Fix a bug in `gn analyze` for host-only file mods.
>   f8bf5083 Fix gn get_label_info comment
>   05f56d41 allocator: remove ENABLE_MEMORY_TASK_PROFILER and use only USE_ALLOCATOR_SHIM
>   e329e9ec Fix GN bootstrap
>   2928b5dc Add information on the requirements for a new Chromium port.
>   73228cd4 allocator: rename use_experimental_allocator_shim to use_allocator_shim
>   797723cd Fix GN bootstrap
>   84fa8b08 Replace sanitizers:deps with exe_and_shlib_deps (Chromium repo only)
>   d77555bc GN: Fix single-file compilations in VS2017 projects
>   cbbd560a gn: get rid of GetRealPath() function
>   cf2a4bf9 gn: convert WrapUnique calls to MakeUnique where possible
>   dfb837a9 gn: fix bootstrap on windows
>   777e1cd5 Fix gn bootstrap after https://codereview.chromium.org/2872503003
>   25e10941 gn: Document gen's --check flag.
>   14525201 Add a GUID to base::SharedMemoryHandle.
>   b154afcb memory-infra: Move dump level check to observer and rename session state
>   9b718c79 Fix GN bootstrap
>   643d6bc9 gn: fix bootstrap.py after https://codereview.chromium.org/2846893003
>   dd1ae15f gn docs: Add a missing closing paren.
>   0088ee50 GN: aix port along with linux_s390x, linux_ppc64 and linux_ppc64le support.
>   4a4589fc memory-infra: Start disentangling tracing from memory-infra
>   7fd3f671 Add curly brackets to list of characters that gn needs to escape
>   ca2ec763 Improvements to uses of base::SmallMap
>   ddb3babc Use $root:default as a "default" rule
>
> TBR=brettw@chromium.org
>
> Review-Url: https://codereview.chromium.org/2953643004
> Cr-Commit-Position: refs/heads/master@{#481774}
> Committed: https://chromium.googlesource.com/chromium/src/+/3391d2ce4059ebe801dd8310d13d8dc59293600e

TBR=brettw@chromium.org,dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2956623002
Cr-Commit-Position: refs/heads/master@{#481839}

This adds UMA to track the peak number of outstanding requests in
ResourceDispatcherHostImpl. The "MultiTabLoading" variant is logged
only when there are outstanding requests from multiple processes.
These metrics are logged periodically every 60 seconds.

BUG=729951

Review-Url: https://codereview.chromium.org/2951643003
Cr-Commit-Position: refs/heads/master@{#481838}

TBR=jochen@chromium.org,mgiuca@chromium.org

Bug: 736215
Change-Id: I10fe5c623fdedd51ab0039132a07b8a413a06978
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/544885Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481837}

After the deprecation of Native App Launcher, this code is no longer
accessible.

BUG=721921

Review-Url: https://codereview.chromium.org/2899213002
Cr-Commit-Position: refs/heads/master@{#481836}

These tests fail on Mac 10.9 in different ways. To get LayoutTests on
Swarming working for Mac 10.9 we need to disable them.

BUG=736257
TBR=dpranke@chromium.org,mcgreevy@chromium.org,qyearsley@chromium.org,jeffcarp@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2958493002
Cr-Commit-Position: refs/heads/master@{#481835}

This never launched and has long been abandoned.
This CL removes the code. Followups will remove all the wiring and
indirection in ThumbnailTabHelper and ThumbnailService.

Bug: 735905
Change-Id: Ic6d125ea5c5020dcf3f484487257f9a221e59868
Reviewed-on: https://chromium-review.googlesource.com/544960
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481834}

On Android, we currently report many tiles of type NONE. On iOS we even
do not report tiles at all because the type is unknown.

This CL allows to delay the reporting of tile impressions until we get
result from FaviconService. The actual delay will be implemented in
further CLs.

Bug: 695806
Change-Id: Ia1fba47b270e42d597edab3f82bfa25b40cec37c
Reviewed-on: https://chromium-review.googlesource.com/542856
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481833}

Bug: 733243
Change-Id: I99f5fa3906cbdfa542382396a402b07f5275b2ed
Reviewed-on: https://chromium-review.googlesource.com/535542Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481832}

BUG=736255
TBR=jsbell@chromium.org,dpranke@chromium.org,mcgreevy@chromium.org,qyearsley@chromium.org,jeffcarp@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2953213002
Cr-Commit-Position: refs/heads/master@{#481831}

This test appears to be flaky everywhere.

BUG=724027
TBR=jochen@chromium.org,dpranke@chromium.org,mcgreevy@chromium.org,qyearsley@chromium.org,jeffcarp@chromium.org,mkwst@chromium.org,machenbach@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2948373002
Cr-Commit-Position: refs/heads/master@{#481830}

Unfortunately, Blink currently relies on the embedder to make sure these
objects don't leak.

Bug: 735860
Change-Id: Ia213d4360c5f95627de70a1dfe343880144f9ff6
Reviewed-on: https://chromium-review.googlesource.com/544367Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481829}

This test appears to be flaky everywhere and randomly passes, fails,
crashes and has timeouts.

BUG=404597
TBR=eae@chromium.org,dpranke@chromium.org,mcgreevy@chromium.org,qyearsley@chromium.org,jeffcarp@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2954083002
Cr-Commit-Position: refs/heads/master@{#481828}

Revert of Move navigation-induced hiding of form-validation-bubble to the browser process. (patchset #2 id:20001 of https://codereview.chromium.org/2949593003/ )

Reason for revert:
Causing failures on WebKit Linux Trusty Leak.

({"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,62],"numberOfLiveResources":[0,2],"numberOfLiveSuspendableObjects":[2,3]})

Original issue's description:
> Move navigation-induced hiding of form-validation-bubble to the browser process.
>
> Moving hiding of the form validation bubble to the browser process has
> the following benefits:
> - It allows simplifying/removing code from Blink (in particular it
>   allows removing some of the code added in r459701).
> - It makes the hiding immune against compromised renderers.
> - It makes the hiding work even if ViewHostMsg_HideValidationMessage IPC
>   gets filtered out (i.e. see CanSendWhileSwappedOut method in
>   content::SwappedOutMessages).  This in turn will allow relanding
>   of r479538.
>
> BUG=733940
> TEST=Manually verified that bugs 733940, 704560, 673163 are still fixed.
>
> Review-Url: https://codereview.chromium.org/2949593003
> Cr-Commit-Position: refs/heads/master@{#481681}
> Committed: https://chromium.googlesource.com/chromium/src/+/15399f887a0e8498253dc4496446eee83158e96a

TBR=tkent@chromium.org,alexmos@chromium.org,estade@chromium.org,avi@chromium.org,lukasza@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=733940

Review-Url: https://codereview.chromium.org/2956593003
Cr-Commit-Position: refs/heads/master@{#481827}

This test fails on Mac 10.11 Debug since it was added in
https://codereview.chromium.org/2950713002

TBR=dgozman@chromium.org
BUG=734762

Review-Url: https://codereview.chromium.org/2952373002
Cr-Commit-Position: refs/heads/master@{#481826}

A followup patch will move lifetime management of WebFrame /
WebFrameWidget into Blink. Using a common cleanup path will make things
simpler.

Bug: 727166
Change-Id: I2f0a583ec47542e2d355d93db1cf79d651b04d3f
Reviewed-on: https://chromium-review.googlesource.com/544585Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481825}

This is a generated CL by a clang refactoring tool at //tools/clang/base_bind_rewriters.
It rewrites base::Bind to base::BindOnce where the resulting Callback is converted to
OnceCallback immediately.
E.g.:
  base::PostTask(FROM_HERE, base::Bind(&Foo));
is rewritten to:
  base::PostTask(FROM_HERE, base::BindOnce(&Foo));

In terms of the behavior change after the rewrite, the OnceCallback
implementation moves out the bound argument to the target function, unlike
Callback.

Bug: 554299
Change-Id: I99ec9889c1fb967f6bed75df0b358dd68ba7f917
Reviewed-on: https://chromium-review.googlesource.com/517467
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481824}

WorkerScriptLoader doesn't need to store it. The setter is always called
right before kicking the loader. We should just pass it via the
argument of the Load.* method.

As a bonus, inlined CreateResourceRequest(). It reduces copy and makes
the code simpler given that after removing SetRequestContext() call from
it, it's small enough to be inlined.

Bug: 
Change-Id: I8fe423921cad2d2a40f213e7310e8e991ae52825
Reviewed-on: https://chromium-review.googlesource.com/544418Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481823}

Moved some tests from web/ to core/ where the target location is clear.

Bug: 353585
Change-Id: Icf29bbe1f7b9a52306c7b17d7f34df76edfba19f
Reviewed-on: https://chromium-review.googlesource.com/542556
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481822}

This CL updates Browser to subclass base::SupportsUserData, and adds
BrowserUserData, which includes functionality analogous to
WebStateUserData.

BUG=none

Review-Url: https://codereview.chromium.org/2945713002
Cr-Commit-Position: refs/heads/master@{#481821}

Network traffic annotation in HotwordAudioHistorySearch is only used in
ChromeOS and is not called on other platforms. It is marked so that it would
not be caught by network traffic annotation tests.

BUG=656607

Change-Id: I7640f25711ff2f2194c7846c89c33e508493bfd8
Reviewed-on: https://chromium-review.googlesource.com/535559Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481820}

This is a temporary measure to allow Layout Tests on Swarming to be
deployed on Mac while a solution to the problem is investigated.

This should also prevent developers from hitting this on their machine
locally.

BUG=736177
TBR=kbr@chromium.org,qyearsley@chromium.org,jeffcarp@chromium.org,ericrk@chromium.org,enne@chromium.org,dpranke@chromium.org,ccameron@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2951323003
Cr-Commit-Position: refs/heads/master@{#481819}

This CL changes RemoteSuggestionsProviderImpl to keep at most 5
published not more than 36 hours ago the most recent prefecthed content
suggestions when a new batch of suggestions is fetched. They are mixed
in in the new batch by their score.

Bug: 734584
Change-Id: I71c9a33daae82c193093bfe3f34d5fe182198d64
Reviewed-on: https://chromium-review.googlesource.com/543078
Commit-Queue: vitaliii <vitaliii@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481818}

TBR=horo

Bug: 735883
Change-Id: Ia974a3c566c677d3f5bfdaedee5ef5a53397f6fb
Reviewed-on: https://chromium-review.googlesource.com/544728Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Tim 'mithro' Ansell <tansell@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481817}

* Remove some older language about trust anchors, and consistently refer
  to "root certificate" instead

* Omit trivia about the chain (like count of certificates), and focus
  description on what makes it special

* Don't refer to expected validation success/failure in the chain
  descriptions. Instead this logically belongs in the .test file (I didn't
  add comments to the .test files... however the error messages should be
  self-descriptive).

Review-Url: https://codereview.chromium.org/2951403002
Cr-Commit-Position: refs/heads/master@{#481816}

Bug: 
Change-Id: Ica61e6cd7a1932124296f00aea1b8e73400f74d0
Reviewed-on: https://chromium-review.googlesource.com/544451Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481815}

Previous attempt: https://codereview.chromium.org/2891843002

This attempt includes a fix for //chrome/test/data/nacl/BUILD.gn
in official builds.

R=thakis@chromium.org
TBR=mseaborn@chromium.org
BUG=607968

Review-Url: https://codereview.chromium.org/2957523002
Cr-Commit-Position: refs/heads/master@{#481814}

It will be used from:
https://chromium-review.googlesource.com/c/527016/

BUG=729905
TEST=it builds.

Change-Id: I7344ed4f86705a7f46b7f6b5791f340fabb94157
Reviewed-on: https://chromium-review.googlesource.com/544453Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Kazuhiro Inaba <kinaba@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481813}

Mojo CDM is still in development and some tests are not working. Filed new bugs
and disable those failing tests for now. We'll gradually fix the implementation
and reenable those tests.

BUG=403462

Change-Id: I5af5a1b2a3c64077bc109a51ec019d1f7b6de8ea
Reviewed-on: https://chromium-review.googlesource.com/527654
Commit-Queue: Xiaohan Wang (OOO June 21-22) <xhwang@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481812}

BUG=520170
TBR=skyostil@chromium.org,dpranke@chromium.org,mcgreevy@chromium.org,qyearsley@chromium.org,jeffcarp@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2956573002
Cr-Commit-Position: refs/heads/master@{#481811}

This patch makes |Position::FirstPositionInNode()| to take |const Node&| instead
of |Node*| since |Node| parameter can not be nullptr for improving code health.

This patch is a preparation of make |Position| to hold |const Node&|[1] and
similar to the patch[2] which change |BeforeNode()|.

[1] http://crbug.com/735327 Position should hold const Node instead of Node
[2] http://crbug.com/2950053002: Make Position::BeforeNode() to take const Node&
instead of Node*

BUG=734849
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2952983002
Cr-Commit-Position: refs/heads/master@{#481810}

For auxillary threads that rarely need to gain access to another
thread's GC heap, we have to ensure that this happens while the
heap-owning thread isn't concurrently GCing the heap. Otherwise there
is the possibility that heap objects might be relocated or mutated
while the auxillary thread tries to access.

A CrossThreadPersistent<T> (CTP) ensures reference liveness across
threads, but isn't sufficient to handle the wanted exclusive access
after a non-attached thread has deref'ed the persistent. So, for
this to happen, keep the global CTP lock while accessing a heap
object during offline audio rendering -- it specifically accessing
heap objects while a GC runs. As all GCs hold the lock on the global
CTP region while they run, this ensures exclusion.

It is clearly desirable to have all heap access be under the control
of the heap-owning thread, and threaded code should try hard to avoid
accessing another thread's heap objects. The CTP global lock is the
mechanism to use when that isn't practically feasible -- feel free to
add a "TODO(foo): avoid using" next to any instances that you end up
introducing.

As regards audio thread cross-thread usage, the code needs auditing to
check if there are other places where setting up this CTP lock is
required.

R=haraken,rtoy,hongchan
BUG=732511

Review-Url: https://codereview.chromium.org/2951903003
Cr-Commit-Position: refs/heads/master@{#481809}

This patch adds an Observer interface to WebFrameScheduler so that
platform/loader can implement Blink scheduler backed throttling scheme.

Observer will be notified when scheduler's throttling state is changed.
Internally, this means the page visibility is changed to which the frame
belongs.

BUG=729953

Change-Id: I851b153fef2e0c6ada748bee997bc1e69292e08d
Reviewed-on: https://chromium-review.googlesource.com/525198Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481808}

These tests are flaky on Mac and likely flaky everywhere.

TBR=dpranke@chromium.org,mcgreevy@chromium.org,qyearsley@chromium.org,jeffcarp@chromium.org,horo@chromium.org
BUG=595993
NOTRY=true

Review-Url: https://codereview.chromium.org/2950253003
Cr-Commit-Position: refs/heads/master@{#481807}