GitLab

BUG=433728
TEST=GYP_GENERATORS=ninja tools/gyp/gyp --depth . ui/file_manager/gallery/js/compiled_resources.gyp && ninja -C out/Default

Review URL: https://codereview.chromium.org/797553004

Cr-Commit-Position: refs/heads/master@{#309395}

The test is failing consistently on the MSAN bots.

TBR=ranj@chromium.org
NOTRY=true
BUG=444477

Review URL: https://codereview.chromium.org/819833002

Cr-Commit-Position: refs/heads/master@{#309394}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/caad676..c6e6ddb

TBR=

Review URL: https://codereview.chromium.org/815183003

Cr-Commit-Position: refs/heads/master@{#309393}

The cause of this bug was that class name of Ribbon element was mistakenly deleted in http://crrev.com/815053003 and CSS to hide this element becomes not applied.

BUG=444474
TEST=Manually tested.

Review URL: https://codereview.chromium.org/815853003

Cr-Commit-Position: refs/heads/master@{#309392}

I forgot removing these when doing:
https://chromium.googlesource.com/chromium/src/+/13f5f5e58cf2b2bf9a5ad9918a37294d38bb2c4c

BUG=338338
TEST=compiles
TBR=piman@chromium.org

Review URL: https://codereview.chromium.org/791903004

Cr-Commit-Position: refs/heads/master@{#309391}

r307806 introduced a bug where a user was unable to create shortcuts
from the chrome://extensions page on Windows/Linux. This patch fixes it
by searching for all extensions, rather than just enabled ones.

BUG=443882

Review URL: https://codereview.chromium.org/819823002

Cr-Commit-Position: refs/heads/master@{#309390}

The GFX (GEN 7) in Intel BayTrail has poor performance with MSAA, due to
some hardware architectural limitation. We tend to think this GFX is not
suitable for MSAA, so this CL would disable it. See more details in related
issue.

BUG=443517

Review URL: https://codereview.chromium.org/788143005

Cr-Commit-Position: refs/heads/master@{#309389}

Gallery instantiates EntryListWatcher to delete gallery items at the time when
the corresponding entry is removed on the files app.

The CL also fixes the 'splice' event handling of UI classes in Gallery, which is
called when the Gallery.Item is removed from ArrayDataList by EntryListWatcher.

BUG=436350
TEST=None

Review URL: https://codereview.chromium.org/813263002

Cr-Commit-Position: refs/heads/master@{#309388}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/cc7a400..caad676

TBR=

Review URL: https://codereview.chromium.org/823513002

Cr-Commit-Position: refs/heads/master@{#309387}

Revert of Fix crash after Launcher drag/drop (take 2) (patchset #1 id:1 of https://codereview.chromium.org/792883006/)

Reason for revert:
The new test is still causing problems. See http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%282%29/builds/44030.

The test appears to be flaky. It has failed on that bot on 4 of the 6 runs since this change landed.

BTW I'd add calamity@ to any reviews of dragging in the launcher as he has fixed many bugs there and is aware of many subtleties in the code.

Original issue's description:
> Fix crash after Launcher drag/drop (take 2)
>
> BUG=439055
> TEST=In Launcher, drag app to solitary folder on second page
>
> This is a retry of https://codereview.chromium.org/780023002/ ,
> which was reverted after commit due to a failed valgrind test.
>
> Committed: https://crrev.com/62e30ca368387d4edbbbf5c721f30881586b2387
> Cr-Commit-Position: refs/heads/master@{#309235}

TBR=jennyz@chromium.org,glevin@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=439055

Review URL: https://codereview.chromium.org/820943003

Cr-Commit-Position: refs/heads/master@{#309386}

Basically SkFontHost is deprecated and SkPixelGeometry should be used
when possible, but since nothing in ImageOperations is using it, removed
this unused include.

BUG=None
TEST=compiles
TBR=reed@google.com

Review URL: https://codereview.chromium.org/817913003

Cr-Commit-Position: refs/heads/master@{#309385}

Test is FlashFullscreenInteractiveBrowserTest.FullscreenWithinTab_...
FocusWhenSwitchingTabs

TBR=miu@chromium.org
NOTRY=true
BUG=444476

Review URL: https://codereview.chromium.org/820683004

Cr-Commit-Position: refs/heads/master@{#309384}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/f65f0b9..3b40ee6

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=bungeman@google.com

Review URL: https://codereview.chromium.org/805773007

Cr-Commit-Position: refs/heads/master@{#309383}

These tests check that opening the app will start the shim and vice
versa. Similarly, quitting the shim will close the app windows and
closing the app windows will quit the shim.

BUG=437137

Review URL: https://codereview.chromium.org/816893002

Cr-Commit-Position: refs/heads/master@{#309382}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/c8a2131..f65f0b9

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=bungeman@google.com

Review URL: https://codereview.chromium.org/822633002

Cr-Commit-Position: refs/heads/master@{#309381}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/ea735d1..c8a2131

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=bungeman@google.com

Review URL: https://codereview.chromium.org/817973002

Cr-Commit-Position: refs/heads/master@{#309380}

It has been failing on most bots since it was enabled in 309340. Example:
http://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%283%29/builds/7078/steps/memory.top_7_stress/logs/stdio

TBR=hashimoto@chromium.org
BUG=

Review URL: https://codereview.chromium.org/810333004

Cr-Commit-Position: refs/heads/master@{#309379}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ce0a34c..cc7a400

TBR=

Review URL: https://codereview.chromium.org/817963002

Cr-Commit-Position: refs/heads/master@{#309378}

Review URL: https://codereview.chromium.org/815993002

Cr-Commit-Position: refs/heads/master@{#309377}

Cr-Commit-Position: refs/heads/master@{#309376}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/5e8b168..ea735d1

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=bungeman@google.com

Review URL: https://codereview.chromium.org/812673005

Cr-Commit-Position: refs/heads/master@{#309375}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3dc6163..ce0a34c

TBR=

Review URL: https://codereview.chromium.org/819783003

Cr-Commit-Position: refs/heads/master@{#309374}

Cr-Commit-Position: refs/heads/master@{#309373}

The geometry headers were moved from /ui/gfx/ to ui/gfx/geometry, so
we are updating the include paths to fix this.

BUG=395370
TEST=ui_base_unittests && gfx_unittests
TBR=sky@chromium.org,danakj@chromium.org

Review URL: https://codereview.chromium.org/820913002

Cr-Commit-Position: refs/heads/master@{#309372}

This was checked with the following command line:

$ out/Debug/gn check out_gn/Debug //tools/gn/*

And cleaned until it reported "Header dependency check OK".

BUG=367595,376000
TEST=see above
TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/806873003

Cr-Commit-Position: refs/heads/master@{#309371}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c0d2f9f..3dc6163

TBR=

Review URL: https://codereview.chromium.org/809903007

Cr-Commit-Position: refs/heads/master@{#309370}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/f53ff62..5e8b168

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=bensong@google.com

Review URL: https://codereview.chromium.org/821573002

Cr-Commit-Position: refs/heads/master@{#309369}

BUG=none
TEST=none
TBR=ben@chromium.org
NOTRY=TRUE

Review URL: https://codereview.chromium.org/817153002

Cr-Commit-Position: refs/heads/master@{#309368}

Revert of Fix crash when the source browser window is deleted during a drag (patchset #3 id:160001 of https://codereview.chromium.org/795303002/)

Reason for revert:
Since landing this, Linux ChromiumOS Ozone Tests (1) is failing three DND tests.

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Tests%20%281%29/builds/7685/steps/interactive_ui_tests/logs/stdio

@@@STEP_LOG_LINE@DND@BookmarkBarViewTest5.DND (run #1):@@@
@@@STEP_LOG_LINE@DND@[ RUN      ] BookmarkBarViewTest5.DND@@@
@@@STEP_LOG_LINE@DND@@@@
@@@STEP_LOG_LINE@DND@BookmarkBarViewTest5.DND (run #2):@@@
@@@STEP_LOG_LINE@DND@[ RUN      ] BookmarkBarViewTest5.DND@@@
@@@STEP_LOG_LINE@DND@@@@
@@@STEP_LOG_LINE@DND@BookmarkBarViewTest5.DND (run #3):@@@
@@@STEP_LOG_LINE@DND@[ RUN      ] BookmarkBarViewTest5.DND@@@
@@@STEP_LOG_LINE@DND@@@@
@@@STEP_LOG_LINE@DND@BookmarkBarViewTest5.DND (run #4):@@@
@@@STEP_LOG_LINE@DND@[ RUN      ] BookmarkBarViewTest5.DND@@@
@@@STEP_LOG_LINE@DND@@@@
@@@STEP_LOG_END@DND@@@
@@@STEP_LOG_LINE@DNDToDifferentMenu@BookmarkBarViewTest7.DNDToDifferentMenu (run #1):@@@
@@@STEP_LOG_LINE@DNDToDifferentMenu@[ RUN      ] BookmarkBarViewTest7.DNDToDifferentMenu@@@
@@@STEP_LOG_LINE@DNDToDifferentMenu@@@@
@@@STEP_LOG_LINE@DNDToDifferentMenu@BookmarkBarViewTest7.DNDToDifferentMenu (run #2):@@@
@@@STEP_LOG_LINE@DNDToDifferentMenu@[ RUN      ] BookmarkBarViewTest7.DNDToDifferentMenu@@@
@@@STEP_LOG_LINE@DNDToDifferentMenu@@@@
@@@STEP_LOG_LINE@DNDToDifferentMenu@BookmarkBarViewTest7.DNDToDifferentMenu (run #3):@@@
@@@STEP_LOG_LINE@DNDToDifferentMenu@[ RUN      ] BookmarkBarViewTest7.DNDToDifferentMenu@@@
@@@STEP_LOG_LINE@DNDToDifferentMenu@@@@
@@@STEP_LOG_LINE@DNDToDifferentMenu@BookmarkBarViewTest7.DNDToDifferentMenu (run #4):@@@
@@@STEP_LOG_LINE@DNDToDifferentMenu@[ RUN      ] BookmarkBarViewTest7.DNDToDifferentMenu@@@
@@@STEP_LOG_LINE@DNDToDifferentMenu@@@@
@@@STEP_LOG_END@DNDToDifferentMenu@@@
@@@STEP_LOG_LINE@DNDBackToOriginatingMenu@BookmarkBarViewTest8.DNDBackToOriginatingMenu (run #1):@@@
@@@STEP_LOG_LINE@DNDBackToOriginatingMenu@[ RUN      ] BookmarkBarViewTest8.DNDBackToOriginatingMenu@@@
@@@STEP_LOG_LINE@DNDBackToOriginatingMenu@@@@
@@@STEP_LOG_LINE@DNDBackToOriginatingMenu@BookmarkBarViewTest8.DNDBackToOriginatingMenu (run #2):@@@
@@@STEP_LOG_LINE@DNDBackToOriginatingMenu@[ RUN      ] BookmarkBarViewTest8.DNDBackToOriginatingMenu@@@
@@@STEP_LOG_LINE@DNDBackToOriginatingMenu@@@@
@@@STEP_LOG_LINE@DNDBackToOriginatingMenu@BookmarkBarViewTest8.DNDBackToOriginatingMenu (run #3):@@@
@@@STEP_LOG_LINE@DNDBackToOriginatingMenu@[ RUN      ] BookmarkBarViewTest8.DNDBackToOriginatingMenu@@@
@@@STEP_LOG_LINE@DNDBackToOriginatingMenu@@@@
@@@STEP_LOG_LINE@DNDBackToOriginatingMenu@BookmarkBarViewTest8.DNDBackToOriginatingMenu (run #4):@@@
@@@STEP_LOG_LINE@DNDBackToOriginatingMenu@[ RUN      ] BookmarkBarViewTest8.DNDBackToOriginatingMenu@@@
@@@STEP_LOG_LINE@DNDBackToOriginatingMenu@@@@
@@@STEP_LOG_END@DNDBackToOriginatingMenu@@@

Original issue's description:
> Fix crash when the source browser window is deleted during a drag
>
> This CL makes Widget::RunShellDrag() and DesktopDragDropClientWin not crash if
> the browser window is deleted during a drag-drop operation. An extension can
> delete the browser window during the drag-drop operation.
>
> BUG=440534
> TEST=BookmarkBarViewTest22.*
>
> Committed: https://crrev.com/460bdd69c6f96191a4293da61e9e4999acd0f5ff
> Cr-Commit-Position: refs/heads/master@{#309360}

TBR=sky@chromium.org,pkotwicz@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=440534

Review URL: https://codereview.chromium.org/818983002

Cr-Commit-Position: refs/heads/master@{#309367}

It's not feasible to reference ANGLE's test targets directly because
Chromium must use base's test launcher and ANGLE may not refer to it.

This new target and angle_unittests have been refactored in terms of
.gypi files provided by the ANGLE workspace, allowing both workspaces
to build these targets, though their main.cpp files differ.

BUG=435726

Review URL: https://codereview.chromium.org/807753002

Cr-Commit-Position: refs/heads/master@{#309366}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/aae274e..c0d2f9f

TBR=

Review URL: https://codereview.chromium.org/822573002

Cr-Commit-Position: refs/heads/master@{#309365}

This CL sets capture to the window being dragged when dragging a window on
Ash. This allows state to be reset when a user opens the Ctrl+Alt+Delete dialog
on Windows Ash.

As a side effect, this CL fixes dragging windows from one screen to another on
ChromeOS ozone. Dragging windows from one screen to another
worked on X11 because X11 does an implicit grab when the mouse is pressed. This
implicit grab guarantees that events are sent to WindowTreeHost where the drag
started for the duration of the drag.

BUG=439703, 423383
TEST=None

Review URL: https://codereview.chromium.org/778043004

Cr-Commit-Position: refs/heads/master@{#309364}

This patch removes cc uses of auto with smart pointers. This ensures
that it's explicit and clear what type of smart pointer is being
used.

I think it's better to do this now before this is used as a precedent
for propagating this type of auto use.

R=danakj

Review URL: https://codereview.chromium.org/816193002

Cr-Commit-Position: refs/heads/master@{#309363}

WebRTC 7927:7972
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/f1982eb..c2c971d

Libjingle 7925:7972
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/642135c..1aaae71

TBR=kjellander@chromium.org

Review URL: https://codereview.chromium.org/815043004

Cr-Commit-Position: refs/heads/master@{#309362}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/637cec4..aae274e

TBR=

Review URL: https://codereview.chromium.org/817553003

Cr-Commit-Position: refs/heads/master@{#309361}

This CL makes Widget::RunShellDrag() and DesktopDragDropClientWin not crash if
the browser window is deleted during a drag-drop operation. An extension can
delete the browser window during the drag-drop operation.

BUG=440534
TEST=BookmarkBarViewTest22.*

Review URL: https://codereview.chromium.org/795303002

Cr-Commit-Position: refs/heads/master@{#309360}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/752e7eb..f53ff62

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=bensong@google.com

Review URL: https://codereview.chromium.org/820883002

Cr-Commit-Position: refs/heads/master@{#309359}

BUG=3268

Review URL: https://codereview.chromium.org/802533005

Cr-Commit-Position: refs/heads/master@{#309358}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/8be1d7e..637cec4

TBR=

Review URL: https://codereview.chromium.org/813073003

Cr-Commit-Position: refs/heads/master@{#309357}

Revert of Refactor Vaapi video decoder/encoder in preparation of Freon support (patchset #6 id:100001 of https://codereview.chromium.org/807853005/)

Reason for revert:
Caused build failure on Linux ChromiumOS GN:
ninja: error: '../../content/common/content/common/gpu/media/va_x11.sigs',
needed by 'obj/content/common/libva_generate_stubs.inputdeps.stamp', missing
and no known rule to make it

Original issue's description:
> Refactor Vaapi video decoder/encoder in preparation of Freon support
>
> This introduces VaapiPicture which abstracts the output picture for the VaapiVideoDecodeAccelerator.
> This also splits out the x11 specific functions of LibVA into their own signature file.
> And finally this adds back GLImageGLX to match the code path that will be used on Freon, using GLImageLinuxDMABuffer.
>
> BUG=403058
> TEST=video_decode_accelerator_unittest and video_encode_accelerator_unittest
>
> Committed: https://crrev.com/289e96375e75be0d9158b86df2bd4faf2d7b2a64
> Cr-Commit-Position: refs/heads/master@{#309355}

TBR=reveman@chromium.org,posciak@chromium.org,scherkus@chromium.org,piman@chromium.org,lionel.g.landwerlin@intel.com
NOTREECHECKS=true
NOTRY=true
BUG=403058

Review URL: https://codereview.chromium.org/804353003

Cr-Commit-Position: refs/heads/master@{#309356}