GitLab

BUG=285440

Review URL: https://chromiumcodereview.appspot.com/23534051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222179 0039d316-1c4b-4281-b951-d872f2087c98

error code in addition to the error message. This turned out to be a
surprisingly invasive yak shave and is accompanied by a few very small fixes
to inefficient and overly complex code I noticed along the way.

This is the first stage in making the chrome.storage extension/app API able to
gracefully recover from leveldb corruption.

BUG=261623
R=mpcomplete@chromium.org
TBR=tim@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/24021002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222178 0039d316-1c4b-4281-b951-d872f2087c98

what happens is that we use vector_as_array(&data) which returns null if data is empty, but we don't check |size| whichcan be 0 so data.resize(size) still an empty vector.

This is currently happening for browser_tests.exe in the waterfall.

There might be a better fix but lots of tests are having exceptions so I want to stop that.

TBR=mnissler
BUG=none
TEST=logs are clean

Review URL: https://codereview.chromium.org/23961004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222177 0039d316-1c4b-4281-b951-d872f2087c98

This patch is almost a revert of crrev.com/219997.

CommandUtil.getCommandPath() is no longer necessary because the patch for M30 has been merged successfully and the unavailable shortcut would been automatically removed.

BUG=287597, 284921
TEST=manually tested
R=hirono@chromium.org

Review URL: https://codereview.chromium.org/23944007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222176 0039d316-1c4b-4281-b951-d872f2087c98

source address tokens in ServerHello messages.

Merge internal CL: 51981820

List output parameters after input parameters.

Merge internal CL: 52069947

R=rch@chromium.org,rtenneti@chromium.org
BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/23766019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222175 0039d316-1c4b-4281-b951-d872f2087c98

r220909 has fixed the share dialog. This patch fixes not oly the share dialog, but also the suggest app dialog and default task pick dialog.

And this patch also introduces FileManagerDialogBase, which manages the dialog in file manager not to have the multiple dialogs visible simultaneously.

BUG=279214
TEST=manually tested
R=hirono@chromium.org

Review URL: https://codereview.chromium.org/23483029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222174 0039d316-1c4b-4281-b951-d872f2087c98

There is no change allowed to the shelf when the enterprise mode 'locks down' the shelf.

BUG=285056
TEST=none

Review URL: https://chromiumcodereview.appspot.com/24076002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222173 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE

Review URL: https://chromiumcodereview.appspot.com/24079002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222172 0039d316-1c4b-4281-b951-d872f2087c98

Need to pass the CONFIGURATION_NAME through to the push python libs.

BUG=

Review URL: https://chromiumcodereview.appspot.com/23936004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222171 0039d316-1c4b-4281-b951-d872f2087c98

R=estade@chromium.org
BUG=286022

Review URL: https://chromiumcodereview.appspot.com/23726024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222170 0039d316-1c4b-4281-b951-d872f2087c98

Delegated frames may contain an offscreen filter. If they do, then the
LayerTreeHost needs to know about it so it can create an offscreen
context.

R=piman
BUG=287870

Review URL: https://chromiumcodereview.appspot.com/23451023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222169 0039d316-1c4b-4281-b951-d872f2087c98

Also add a SimulateKeyPress helper for browser_tests that takes both a UIEvent |code| and a ui::KeyboardCode.

issue=284754

Review URL: https://chromiumcodereview.appspot.com/23542008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222168 0039d316-1c4b-4281-b951-d872f2087c98

It's possible for the NativeView (aura::RootWindow*) in this case to
be destroyed by the time we end up processing the events.

BUG=288086
TEST=none
R=ananta@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23619025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222167 0039d316-1c4b-4281-b951-d872f2087c98

We have a histogram reporting 'entry age on Open of an existing entry' by
looking at individual files on the filesystem. Change to report once for each
entry.

BUG=none

Review URL: https://chromiumcodereview.appspot.com/23717040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222166 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222165 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=157458:157479&mode=html
TBR=
BUG=

Review URL: https://chromiumcodereview.appspot.com/24081002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222164 0039d316-1c4b-4281-b951-d872f2087c98

We are moving away from using the prefixless constructor in
Chrome for Android code. We need to make sure that both
versions of the constructor respect kRemoteDebuggingSocketName flag.

BUG=263735
R=bulach@chromium.org

Review URL: https://codereview.chromium.org/23458029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222163 0039d316-1c4b-4281-b951-d872f2087c98

This CL switches DaemonController to the same model that is used by PairingRegistry. DaemonController becomes a ref-counted object responsible for dispatching calls between threads. Platform-specific logic is implemented in non thread-safe delegate class. Most of the delegate's methods are synchronous and are running on a backgorund thread.

BUG=173509

Review URL: https://chromiumcodereview.appspot.com/23606019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222162 0039d316-1c4b-4281-b951-d872f2087c98

This allows us to address one of the top user-reported problems with
Chrome Remote Desktop on Linux; namely that when users run Chrome
inside their virtual desktop, it simply opens a new window in their
existing Chrome instance (or, worse, if the first run of Chrome is in
their virtual session, then it prevents them running Chrome on the
console).

Once this change hits Stable, we will be able to update our
virtual session start-up scripts to set the environment variable,
letting the user run Chrome on both their console and virtual
desktops. They can then use Chrome Sync to keep bookmarks etc.
synchronized.

BUG=253614

Review URL: https://chromiumcodereview.appspot.com/23651006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222160 0039d316-1c4b-4281-b951-d872f2087c98

Linux/GTK only.

BUG=282509
TEST=ln -s fake.com-123 SingletonLock, then run Chromium, then check that [ Quit ] and [ Unlock and Relaunch ] work.

Review URL: https://chromiumcodereview.appspot.com/23506011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222159 0039d316-1c4b-4281-b951-d872f2087c98

Sets the mapped memory reclaim limit for the renderer compositor on Android. Also moves the max_bytes_pending_upload limit of the PixelBufferRasterWorkerPool to the RenderWidgetCompositor since the mapped memory reclaim limit depends on it.

BUG=272591

Review URL: https://chromiumcodereview.appspot.com/22900018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222158 0039d316-1c4b-4281-b951-d872f2087c98

Per latest designs from UX, move to the 3 line format provided by the
Notification Center, remove all multi-line notification data, and always
use the first profile image photo instead of the app icon for multiple
senders.

BUG=281520

Review URL: https://chromiumcodereview.appspot.com/23981004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222157 0039d316-1c4b-4281-b951-d872f2087c98

This CL implements DesktopMediaPicker for the Mac used by the Desktop Capture API to present the user with a list of sources (including live thumbnails) to use.

BUG=237907

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221874

Review URL: https://chromiumcodereview.appspot.com/23944003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222156 0039d316-1c4b-4281-b951-d872f2087c98

Redo the code for handling the tabs API and tab ID translation to make
it more generic.  Make it table driven: there is now a table of API
calls that can contain URL arguments, so it is easy to add additional
API calls that we want to have URLs extracted from.  Add a couple of
others I've come across in testing.

BUG=253368, 275701

Review URL: https://chromiumcodereview.appspot.com/23545012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222155 0039d316-1c4b-4281-b951-d872f2087c98

Introduce a new object to communicate cross-thread cancellation signals.
This new object, the CancellationSignal, is protected by a lock.  It
allows the receiving thread to query whether or not a stop has been
requested.  It also allows the receiving thread to safely register a
cross-thread callback to be invoked immediately when a stop is
requested.

This class is used to reimplement the UI thread to sync thread early
shutdown signal.  Previously, the UI thread would try to call in to
objects owned by the sync thread.  This required a workaround if the
signal arrived very early, since we couldn't guarantee the sync thread
had actually created those objects until later.  The CancellationSignal
is owned by the UI thread, so it is safe to call its RequestStop() at
any point during sync initialization.  The sync thread will receive the
signal when it's ready.

The new scheme has a few advantages over the old:
- Thread ownership is simpler.  The SyncBackendHost::Core, SyncManager,
  ServerConnectionManager, SyncScheduler and Syncer can now claim that
  all their member functions run on the sync thread.
- We no longer need to implement special case logic for when a shutdown
  is requested before the SyncManager has initialized.
- In a future CL, we can take advantage of the fact that we no longer
  require the special case to reduce inter-thread communication during
  sync startup.  This will make startup simpler and, in some cases,
  improve sync startup time by as much as a few hundred milliseconds.
- This will make it easier to address crbug.com/236451.

BUG=236451

Review URL: https://chromiumcodereview.appspot.com/23189021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222154 0039d316-1c4b-4281-b951-d872f2087c98

ActivityLogPrerenderTest.TestScriptInjected browser test failed on win xp.
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%28dbg%29%283%29/builds/39433

> Remove unsafe access hacks from ScopedPersistent.
> 
> BUG=236290
> 
> Review URL: https://chromiumcodereview.appspot.com/23636015

TBR=marja@chromium.org

Review URL: https://codereview.chromium.org/23724028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222151 0039d316-1c4b-4281-b951-d872f2087c98

Rather than throwing a generic LookupError exception when the timeline marker
cannot be found in the trace, throw a MissingTimelineMarker which is a subclass
of page_measurement.MeasurementFailure. These exceptios get caught by the page
runner.

Stop catching LookupError exeptions in _RunPage.

BUG=238864

Review URL: https://chromiumcodereview.appspot.com/23766009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222150 0039d316-1c4b-4281-b951-d872f2087c98

can be identified in stack traces, and filtered out when showing to developers.

BUG=21734

Review URL: https://chromiumcodereview.appspot.com/23604050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222149 0039d316-1c4b-4281-b951-d872f2087c98

When window caption buttons are placed on the right side of the window,
they now look identical to the GTK port.

BUG=281788

Review URL: https://chromiumcodereview.appspot.com/23447015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222148 0039d316-1c4b-4281-b951-d872f2087c98

Original patch from dgwallinga@chromium.org at
https://codereview.chromium.org/23505003.

TBR=estade
BUG=258626,258649

Review URL: https://codereview.chromium.org/23454019

Patch from Dane Wallinga <dgwallinga@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222147 0039d316-1c4b-4281-b951-d872f2087c98

BUG=280512
BUG=278899
TEST=See bug for repro steps.

Review URL: https://chromiumcodereview.appspot.com/23978003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222146 0039d316-1c4b-4281-b951-d872f2087c98

keep_test_server_ports to BrowserOptions (this should probably go into AndroidBrowserOptions). android_rndis is a new ctor arg to AndroidBrowserBackend.

BUG=269131
TEST=trybot

Review URL: https://chromiumcodereview.appspot.com/23619022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222145 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://chromiumcodereview.appspot.com/23467008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222144 0039d316-1c4b-4281-b951-d872f2087c98

Per vandebo's suggestion, this is a minimal fix to the security-hole meant
for backporting/merging.

https://codereview.chromium.org/23760004/ is the long-term fix.

BUG=284792

Review URL: https://chromiumcodereview.appspot.com/23461031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222143 0039d316-1c4b-4281-b951-d872f2087c98

* Added getting_started/ parallel to examples/
* Added getting_started/part1/ which is a quick port of hello_tutorial from the
  NaCl SDK documentation page.
* Added support for examples not using auto-generated Makefiles
* Disbled testing of getting_started/part1 (it doesn't have the test hooks)
* Moved examples/getting_started/simple_hello_world =>
        examples/tutorial/using_ppapi_simple

BUG=none
R=eliben@chromium.org

Review URL: https://codereview.chromium.org/23661005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222142 0039d316-1c4b-4281-b951-d872f2087c98

Failed unit tests on chromeos-asan:
  ChromeLauncherControllerTest.UnpinWithUninstall
  ChromeLauncherControllerTest.PendingInsertionOrder
  ChromeLauncherControllerTest.PersistLauncherItemPositions

http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASAN%20Tests%20%283%29/builds/9780

> Makes BrowserStatusMonitor remove observers in destructor
> 
> I'm seeing a crash where we have a dangling TabStripModelObserver,
> this is one possible place. At the same time I'm making the class only
> look for HOST_DESKTOP_TYPE_ASH browsers.
> 
> BUG=286162
> TEST=none
> R=skuhne@chromium.org
> 
> Review URL: https://chromiumcodereview.appspot.com/23455037

TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/23538010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222138 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222135 0039d316-1c4b-4281-b951-d872f2087c98

BUG=286468
TEST=tree

Review URL: https://chromiumcodereview.appspot.com/23513025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222134 0039d316-1c4b-4281-b951-d872f2087c98

BUG=286029

Review URL: https://chromiumcodereview.appspot.com/23819034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222133 0039d316-1c4b-4281-b951-d872f2087c98

Update UIResource tests to obey the restriction that ScopedUIResource
create and destroy calls may only be made on the main thread.

BUG=279438

Review URL: https://chromiumcodereview.appspot.com/23804004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222132 0039d316-1c4b-4281-b951-d872f2087c98