GitLab

Initializing |v8::Context| is a heavy operation, and should be avoided if necessary. This is meant to be delayed until first time |toV8Context| is called, but |ScriptController::updateDocument| was forcing creation.

This patch fixes the if branch so that it would not create a |v8::Context| if it does not exist.

BUG=368548, 368555

Review URL: https://codereview.chromium.org/263583002

git-svn-id: svn://svn.chromium.org/blink/trunk@173044 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=366136,359788

Review URL: https://codereview.chromium.org/257273002

git-svn-id: svn://svn.chromium.org/blink/trunk@173043 bbb929c8-8fbe-4397-9dbb-9b2b20218538

FastTextAutosizer::enabled() is hot on profiles as it's called multiple
times per block. The places where the text autosizing setting can
change are well defined and all go through updatePageInfo() so this
patch removes enabled() entirely, replacing it with a check of
m_pageInfo.m_settingEnabled which is updated in updatePageInfo().

This patch is a followup to
https://src.chromium.org/viewvc/blink?view=rev&revision=173020

No new tests as this is just a refactoring.

BUG=367864

Review URL: https://codereview.chromium.org/265713002

git-svn-id: svn://svn.chromium.org/blink/trunk@173042 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There's also a Gecko bug and a spec bug on this:
https://bugzilla.mozilla.org/show_bug.cgi?id=725646
https://www.w3.org/Bugs/Public/show_bug.cgi?id=23039

BUG=277080

Review URL: https://codereview.chromium.org/260713002

git-svn-id: svn://svn.chromium.org/blink/trunk@173041 bbb929c8-8fbe-4397-9dbb-9b2b20218538

A previous patch (https://codereview.chromium.org/252353002) tried to
make all text-based-repaint tests use FCM, but caused flakiness reported
in http://crbug.com/367195 and http://crbug.com/367201.

It seems like the issue is that FCM wasn't being enabled soon enough. It
was turned on post-onload, after which some repaints may have been
generated. (This may no longer be true with repaint-after-layout.)

The fix is to enable FCM with the script include, rather than in
runRepaintTest.

Rather than causing churn on the entire tree, land an FCM version of
text-based-repaint.js and use it in two previous flaky tests. This
should indicate whether or not this was actually the problem.

BUG=368518

Review URL: https://codereview.chromium.org/267553002

git-svn-id: svn://svn.chromium.org/blink/trunk@173040 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The HTML spec says "attribute long width":
http://whatwg.org/html#HTMLPreElement-partial

In Gecko this IDL attribute is also a number, but in IE11 it's a string.

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/264713002

git-svn-id: svn://svn.chromium.org/blink/trunk@173039 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ShapeInterval now distinguishes between x1==x2 - isEmpty() and x1,x2 haven't been
set yet - isUndefined(). Removed the ShapeInterval setX1() and setX2() methods, since
they're no longer used.

The polygon algorithm for computing excluded intervals now ignores horizontal
edges. It also ignores edges whose lower vertex matches the top of the line, if
the edge's Y direction is upwards (away from the top of the line). The rationale
for this was explained here:
http://hansmuller-webkit.blogspot.com/2012/11/revised-horizontal-box-algorithm.html

This is a merge of http://trac.webkit.org/changeset/167931 by Hans Muller <hmuller@adobe.com>.

BUG=368686

Review URL: https://codereview.chromium.org/264453009

git-svn-id: svn://svn.chromium.org/blink/trunk@173038 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL protects MediaValuesCached creation with a frame which document doesn't have a render view.

BUG=367210

Review URL: https://codereview.chromium.org/252683007

git-svn-id: svn://svn.chromium.org/blink/trunk@173037 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=172994

TBR=fmalita@chromium.org

Review URL: https://codereview.chromium.org/263753002

git-svn-id: svn://svn.chromium.org/blink/trunk@173036 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=172887

BUG=320139
TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/260833004

git-svn-id: svn://svn.chromium.org/blink/trunk@173035 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=172887

BUG=320139
TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/269553002

git-svn-id: svn://svn.chromium.org/blink/trunk@173034 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Per the discussion at https://groups.google.com/a/chromium.org/d/msg/blink-dev/LKKoAVKcqYo/3FuTOErjjZgJ add back support for prefixed AudioContext and OfflineAudioContext.

BUG=

Review URL: https://codereview.chromium.org/259103002

git-svn-id: svn://svn.chromium.org/blink/trunk@173032 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The ED suggests now to be able to clamp the number of repetitions when
using the repeat() function, taking precautions about excessive memory
usage.

BUG=79180

Review URL: https://codereview.chromium.org/251643002

git-svn-id: svn://svn.chromium.org/blink/trunk@173031 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This was originally added in r63452 (*), as an optimization to avoid really large composited layers that
extend offscreen. This is no longer necessary, since Chrome uses a tiling architecture for all layers
(Safari, at least at the time, used a single texture for the entire layer).

(*) http://src.chromium.org/viewvc/blink?view=revision&revision=63452

BUG=

Review URL: https://codereview.chromium.org/266453008

git-svn-id: svn://svn.chromium.org/blink/trunk@173030 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=172887

BUG=320139
TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/269523002

git-svn-id: svn://svn.chromium.org/blink/trunk@173027 bbb929c8-8fbe-4397-9dbb-9b2b20218538

No need to go via the parent block to get the flow thread.

Review URL: https://codereview.chromium.org/254883003

git-svn-id: svn://svn.chromium.org/blink/trunk@173025 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If support for unprefixed animations is disabled and a custom event happens
to have the same type name then we should dispatch them no matter.

As inside blink we dispatch unprefixed events (no matter if the support is on
or off), we had a piece of code which was retargeting the name to unprefixed when
the support was off. This was not working in the case of custom events as they were
being retargeted to prefixed. I'm glad we can get rid of this condition when the
support of unprefixed animations ships.

I've added a set of tests in the stable/ directory to specifically covers the fact
that the unprefixed animations support is off. These two tests can be removed when
unprefixed animations are default. The other tests in the regular animations/ directory
are for regression testing.

BUG=367537

Review URL: https://codereview.chromium.org/263553010

git-svn-id: svn://svn.chromium.org/blink/trunk@173024 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Step 1 and 2 replaced StyleDifference enum with StyleDifference class
but still didn't change any functionality.

This change allows multiple types of flags set in StyleDifference, in
the following cases:

1. Both needsRepaint and needsPositionedMovement: This was a full layout
   when StyleDifference enum couldn't express the exact needs of the
   case. Now we can do a repaint and positioned movement without full
   layout.

2. Both needsRepaintLayer and needsFullLayout: Previously, the needs of
   repainting layer must be checked again (about clip, transform,
   opacity etc.) in RenderLayerModelObject::styleWillChange() if layout
   is also needed. Now we can go through the normal needsRepaintLayer
   path.

3. Both needsRepaint and needsFullLayout: Previously as the repaint
   needs couldn't be explicitly expressed, we have to do a full repaint.
   In this change we still keep the original behavior unchanged.
   Will optimize in later changes.

4. Both contextSensitiveProperties and needsLayout: Now this is
   resolved by RenderObject::adjustStyleDifference() to layout only
   or case 1, 2 or 3.

Only case 2 changes the visible behavior. All rebaselined layout tests
are in this case. The extra repaint rects are because now the code
schedules both direct repaints and repaints caused by layer position
change.

BUG=358460
TEST=existing layout tests, several rebaselined.

Review URL: https://codereview.chromium.org/247713003

git-svn-id: svn://svn.chromium.org/blink/trunk@173023 bbb929c8-8fbe-4397-9dbb-9b2b20218538

A few NYI things are commented out.

Also removes [NoInterfaceObject] from ServiceWorkerContainer since
script should be able to see the type.

Review URL: https://codereview.chromium.org/238993003

git-svn-id: svn://svn.chromium.org/blink/trunk@173022 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is first of two patches to refactor our enabled() code for
understandability. This patch removes the document->printing() check
from enabled() and refactors updatePageInfo to reduce duplicated code.
When printing is enabled / disabled, updatePageInfo is always called
which is what enables this refactoring. Printing doesn't change often so
there's no reason to check it multiple times for each block :)

Cleanups:
1) enabled() has been merged into shouldHandleLayout() since all callers
always checked both.
2) We had duplicated logic for the two cases when we should reset
multipliers in updatePageInfo. These have been combined and changing
"m_hasAutosized" has been moved out of resetMultipliers and into
updatePageInfo so almost no PageInfo-related state is modified outside
updatePageInfo.
3) Unnecessary calls to m_document->page()->mainFrame() have been
removed in updatePageInfo.

This change is a little messy but I hope it's clear how much of this
will be cleaned up once enabled() goes away. Slimming down enabled()
will be a perf win as well.

BUG=367864

Review URL: https://codereview.chromium.org/263563006

git-svn-id: svn://svn.chromium.org/blink/trunk@173020 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=172887

BUG=320139
TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/269493002

git-svn-id: svn://svn.chromium.org/blink/trunk@173019 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://dom.spec.whatwg.org/#document

Update tests to reflect this change. It matches Firefox behavior.

Review URL: https://codereview.chromium.org/252713004

git-svn-id: svn://svn.chromium.org/blink/trunk@173018 bbb929c8-8fbe-4397-9dbb-9b2b20218538

describe what it actually does.

BUG=

Review URL: https://codereview.chromium.org/266473009

git-svn-id: svn://svn.chromium.org/blink/trunk@173017 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This makes text-based-repaint.js the only repaintRectsAsText caller,
which will make it easier to convert from FrameView to GraphicsLayer
repaint rects.

BUG=368518

Review URL: https://codereview.chromium.org/263553005

git-svn-id: svn://svn.chromium.org/blink/trunk@173016 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=172887

BUG=320139
TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/261673003

git-svn-id: svn://svn.chromium.org/blink/trunk@173015 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The regression happened in r172651. This patch returns missed class.

BUG=368362

Review URL: https://codereview.chromium.org/253193004

git-svn-id: svn://svn.chromium.org/blink/trunk@173013 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Non-blocking stylesheets like alternate stylesheets cause a synchronous style
recalc when finished loading. This is quite the opposite of what one would
expect as these stylesheets should not contribute to the style at all. We use
deferred style recalc to batch up the style recalcs instead.

It might be possible to further improve this by not doing a style recalc at
all, but that requires that we detect when a non-blocking stylesheet becomes
relevant by another link element setting the preferred stylesheet set to the
same name as that of an alternate stylesheet already added as non-blocking.

R=dglazkov@chromium.org
BUG=368659

Review URL: https://codereview.chromium.org/260713005

git-svn-id: svn://svn.chromium.org/blink/trunk@173012 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=366788

Review URL: https://codereview.chromium.org/265543003

git-svn-id: svn://svn.chromium.org/blink/trunk@173011 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Make Range.detach() a no-op as per DOM4:
http://dom.spec.whatwg.org/#dom-range-detach

This makes the code a lot simpler, as it avoids a lot of null checks and
exception throwing. Also add a UseCounter and a deprecation message to see
if this can be removed entirely from the specification.

Firefox already does this since version 15:
https://bugzilla.mozilla.org/show_bug.cgi?id=702948

However, detach() is not a no-op in IE11.

R=arv@chromium.org, tkent@chromium.org
BUG=367322
TEST=fast/dom/Range/detach-no-op.html

Review URL: https://codereview.chromium.org/252783002

git-svn-id: svn://svn.chromium.org/blink/trunk@173010 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=172887

BUG=320139
TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/261653004

git-svn-id: svn://svn.chromium.org/blink/trunk@173009 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Valgrind complained of use before initialization so initializing
InlineFlowBox's m_lineBreakBidiStatusEor, m_lineBreakBidiStatusLastStrong,
and m_lineBreakBidiStatusLast to LeftToRight.

BUG=368303

Review URL: https://codereview.chromium.org/252263002

git-svn-id: svn://svn.chromium.org/blink/trunk@173008 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/255363003

git-svn-id: svn://svn.chromium.org/blink/trunk@173006 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=172887

BUG=320139
TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/254333004

git-svn-id: svn://svn.chromium.org/blink/trunk@173005 bbb929c8-8fbe-4397-9dbb-9b2b20218538

While this is a relatively new property, it does require a synchronous IPC
to the browser process in order to get the permission status, and thus would
be better as a Notification.hasPermission() method returning a Promise (or
similar).

Since we will need a similar construct for Push Messaging, and potentially
other APIs, let's get some data on whether developers use this to see if
we can get a more common, asynchronous approach.

BUG=

Review URL: https://codereview.chromium.org/254023002

git-svn-id: svn://svn.chromium.org/blink/trunk@173004 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This updates the viewport trigger for GPU rasterization to
<meta name="viewport" content="width=device-width, minimum-scale=1.0,
  initial-scale=1.0, user-scalable=yes">

BUG=367202

Review URL: https://codereview.chromium.org/268453003

git-svn-id: svn://svn.chromium.org/blink/trunk@173003 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It's no longer set to be anything but true.

Depends on: https://codereview.chromium.org/239973005/

R=abarth@chromium.org, vollick@chromium.org
BUG=365853

Review URL: https://codereview.chromium.org/247673005

git-svn-id: svn://svn.chromium.org/blink/trunk@173002 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=172823

BUG=366438
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/267503002

git-svn-id: svn://svn.chromium.org/blink/trunk@173001 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL enabled calc parsing in the sizes attribute, and adds tests for that.

BUG=357586
Depends on http://crrev.com/252743004

Review URL: https://codereview.chromium.org/259193004

git-svn-id: svn://svn.chromium.org/blink/trunk@173000 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Functioins in there files have been rewritten in
components/autofill/content/renderer/password_form_conversion_utils.
This is to refact old Blink code on WebPasswordFormData and utils files.

R=gcasto@chromium.org, tkent
BUG=None

Review URL: https://codereview.chromium.org/246233005

git-svn-id: svn://svn.chromium.org/blink/trunk@172999 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This adds a target for blink_common, and starts a rough skeleton of blink_platform. There are a lot of dependencies for the platform pat (like V8) so I thought it best to checkpoint that before I start worrying about those.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/257733002

git-svn-id: svn://svn.chromium.org/blink/trunk@172998 bbb929c8-8fbe-4397-9dbb-9b2b20218538