GitLab

This reverts commit 4154e5e3.

Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1061936

Original change's description:
> Fix combining characters for c with acute accent
> 
> The table had ´c map to ç instead of ć, imitating GTK from circa 2008.
> This was overlooked in the conversion, and left no way for users to
> type ć (used in Polish for example).
> 
> I speculate that GTK was imitating the Windows ‘US International’ layout,
> which has that mapping. We have a separate section of the combining table
> for the Windows-like ‘US International PC’ that does map ´c map to ç,
> but this should not still happen for other layouts.
> 
> Bug: 1061753
> Change-Id: I113b3d6c3fda6b93f7f27296b1a30dae6aa0b668
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102776
> Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
> Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#750545}

TBR=kpschoedel@chromium.org,yhanada@chromium.org

Change-Id: I9c78d16522887c691e3e6e4cdd7d4979410c5845
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1061753
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105419Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750566}

base::ThreadPool:: (API as a destination) is the new desired paradigm.

worker_pool:: was already API-as-destination; can remove redundant
ThreadPool() trait with new API.

R=haraken@chromium.org

Bug: 1026641
Change-Id: Ida08feab710143da2308ef1361550a9aced39d2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105454
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750565}

See https://chromium.googlesource.com/chromium/src/+/master/styleguide/inclusive_code.md

TBR=agrieve  # Mechanical renames

Change-Id: I1298f139e15919ec1597510ef3a556a67ee2acc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103040
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750564}

As part of the DialogDelegate close refactor I changed the default
behavior of dialogs that have both cancel and accept callbacks to
require opting in to receiving a callback on close as well. This dialog
is one of the few that were both depending on this behavior and had no
test coverage for that dependency.

This change:
1) Opts that dialog into receiving a callback on close, using the
   pattern called "pattern 2" from r743269
2) Adds test coverage for the behavior here

Bug: 1056116
Change-Id: I3b4a30c6015bf76534b6b083586a13fdc55bac2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100727Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750563}

https://skia.googlesource.com/skia.git/+log/7bb74c4299b8..f94815068d75

git log 7bb74c4299b8..f94815068d75 --date=short --first-parent --format='%ad %ae %s'
2020-03-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 18daa81e3d3d..3a50a43df988 (14 commits)
2020-03-16 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version
2020-03-15 mtklein@google.com rearrange to emphasize most salient params
2020-03-15 reed@google.com add programs to compose, lerp and luma colorfilters
2020-03-15 reed@google.com colorfilter's program returns a color
2020-03-15 reed@google.com change onProgram to return its color, or an invalid-color if failed
2020-03-14 reed@google.com skvm for compose shaders
2020-03-13 djsollen@google.com Remove mips workarounds for Android.
2020-03-13 jvanverth@google.com Reland "Clear out atlases if they haven't been used in a while."
2020-03-13 sgilhuly@chromium.org SkiaDawn: Early out in recordProgramInfo
2020-03-13 fmalita@chromium.org [svgdevice] Handle text path effects
2020-03-13 jvanverth@google.com Revert "Clear out atlases if they haven't been used in a while."
2020-03-13 csmartdalton@google.com Remove instanced draws and simplify GrMesh
2020-03-13 reed@google.com remove legacy virtual from enforcer
2020-03-13 jvanverth@google.com Clear out atlases if they haven't been used in a while.
2020-03-13 bryct@amazon.com Implement support for path effects in SkSVGDevice backend.
2020-03-13 robertphillips@google.com Make AAFlatteningConvexPathOp surface its programInfos at record time
2020-03-13 reed@google.com hide getters so we can change the internals of SkVertices
2020-03-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 2e5bd9b1e658..6963f58c7678 (14 commits)
2020-03-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 5309fd86..907b992f (527 commits)
2020-03-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 7e857092052e..18daa81e3d3d (9 commits)
2020-03-13 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version
2020-03-12 mtklein@google.com dot for JIT
2020-03-12 mtklein@google.com restore Op::round
2020-03-12 csmartdalton@google.com Migrate GrMeshTest to the new bind/draw API
2020-03-12 reed@google.com remove LerpRed shader
2020-03-12 reed@google.com add draw-via-serialize mode to viewer
2020-03-12 robertphillips@google.com More programInfo cleanup
2020-03-12 reed@google.com add gm for clipShader in a layer
2020-03-12 brianosman@google.com More GrDrawVerticesOp cleanup, to reduce redundant state
2020-03-12 robertphillips@google.com Update three GrMeshDrawOps to surface their programInfos at record time
2020-03-12 fmalita@chromium.org [skottie] Cleanup VectorValue use
2020-03-12 michaelludwig@google.com Remove drawBitmap et al. from SkDevice
2020-03-12 mtklein@google.com make switching skvm-on-llvm easier
2020-03-12 fmalita@chromium.org [skottie] Effects cleanup pass
2020-03-12 brianosman@google.com Remove (unused) shader caps from default GP factory functions
2020-03-12 brianosman@google.com Simplify and optimize GrDrawVerticesOp vertex writing loop
2020-03-12 robertphillips@google.com Clean up programInfo creation in GrMeshDrawOp-derived Ops
2020-03-12 borenet@google.com Update Skia milestone to 83

Created with:
  gclient setdep -r src/third_party/skia@f94815068d75

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC egdaniel@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1058905,chromium:1059890,chromium:1059939
Tbr: egdaniel@google.com
Change-Id: I22963250cdbbec26d2c3740f05971dc59bd28e96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105413Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#750562}

There were a few remaining references to OOP-D in the code that are no
longer relevant since the feature is launched.

Bug: 936425
Change-Id: I32930a85684007068303d1b8083a3b4a00227e02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101189Reviewed-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750561}

Some targets want to copy files from $ios_sdk_platform_abs_path.
Since those points to sub-directory of $root_build_dir when goma
RBE is enabled, this causes failure at "gn gen" time since there
are no target creating those files according to gn.

To fix this, add a new target that pretends to create those files.

Bug: 1061487, webrtc:11429
Change-Id: I9d2330c4c6e041e59f24c459e50fe787602abde6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102544
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750560}

Profile#getLastUsedProfile| is deprecated and replaced with
|Profile#getLastUsedRegularProfile|. This CL updates
PaymentRequestHeader class.

Note: This change is only code clean-up, does not change any behavior.

Bug: 1041781
Change-Id: Icd95cb4f4b2af2faef88a4043a8f6e6153eff468
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105153Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Sahel Sharify <sahel@chromium.org>
Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750559}

Add tests designed to reveal more issues in Vectors and Deques.

Bug: 986235
Change-Id: Ifd2808ba926d6cc6232f2762058fe0e8978756a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102657
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750558}

- Clarifies the difference between unified consent add account and reauth.
Add account and reauthentication methods in identity differ in that
one provides the user with a screen to enter their account details
and the other automatically prefills these details.

- Implements sign-in completion for reauth.

Bug: 971989
Change-Id: I2b0d2d2cc830f7e989480d7444002144d26a38ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095118
Commit-Queue: Nohemi Fernandez <fernandex@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750557}

And enable authentication of downstream trybot results.

Bug: 1048299
Change-Id: Id24c9ee400171c709c87bfb0fd4c58112cfd154e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103387
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750556}

Tackling the set of calls that avoided the automated refactor (for
various reasons). There are about 50 in total, split up into a few CLs
to make reviewing it easier.

Bug: 1051932
Change-Id: I3d51fe842f2858e9528b9012cb9da9d29e300c9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083736Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Dan Elphick <delphick@chromium.org>
Reviewed-by: Jens Widell <jl@opera.com>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750555}

Display output from SkiaRenderer Dawn is upside-down on Windows. Pass
a SurfaceOrigin parameter when constructing SkiaOutputDeviceDawn so that
the origin can be set per platform.

Bug: 1021566
Change-Id: Ic8fbf30cc21bfab2f7c10c63118d4730216172e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103265Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750554}

This CL replaces .mojom.h includes with .mojom-forward.h in some
sub-directories of chrome/browser to reduce the pre-processed size
of header files and shorter build time. The sub-directories are
following,

  - chrome/browser/usb
  - chrome/browser/vr
  - chrome/browser/web_applications

This CL has no behavior changes.

Bug: 1001360
Change-Id: I05e70b987ed0a571aff1680704afeb03e1bab090
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103827Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#750553}

Fixes webrtcerror:
https://bugs.chromium.org/p/webrtc/issues/detail?id=11418

Bug: 1061741, webrtc:11418
Change-Id: Iff441bd878b74e50486b59f5753265eca38fcce8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104096Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750552}

Enable it on Android, disable it on WebView.
Intent-to-Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/XBKAGb2_7uAi.

Bug: 1061841, 887967
Change-Id: Ie9f6392f8b3ec59165dbc3295eb196555e68e313
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104739Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Auto-Submit: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750551}

This should be a mechanical change in a unit test. I refactored
some odd looking code due to unique_ptr<base::RunLoop>.

This CL gets rid of unique_ptr and confusing ownership semantics.

Change-Id: I90386d09ffed6de242acb47d35ba2156a43c0da9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104451Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750550}

Bug: 346399
Change-Id: Iec2bb9ce58f3a5dcc2e0b5f2ba55ad6448b3203c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104552
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750549}

Bug: 346399
Change-Id: I5ce7f48a5cab3785f8d8c44cbb3292d1a6eb59df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103349Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Auto-Submit: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750548}

Deployment script now uploads to firebase rather than google cloud
storage. This also adds a README.md for instructions on how to deploy a
new version.

Bug: 1048299
Change-Id: I2ed0625b4d62aab3c192123941b343d1f948a39f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092551
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750547}

Bug: 346399
Change-Id: I6459029b5e103e90b7936eca47225b99c360f2fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105274
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750546}

The table had ´c map to ç instead of ć, imitating GTK from circa 2008.
This was overlooked in the conversion, and left no way for users to
type ć (used in Polish for example).

I speculate that GTK was imitating the Windows ‘US International’ layout,
which has that mapping. We have a separate section of the combining table
for the Windows-like ‘US International PC’ that does map ´c map to ç,
but this should not still happen for other layouts.

Bug: 1061753
Change-Id: I113b3d6c3fda6b93f7f27296b1a30dae6aa0b668
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102776Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750545}

This is a mechanical change over files in the update_client,
component_updater, and the extension updater.

Change-Id: I2a5b682299cbb04bdfa9f5691329dfa97e869d2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104396Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750544}

Linker tests have been removed. Remove the build rules as well.

Bug: 1059707
Change-Id: If5e4d004026c2a86f79036a8457577e8104eadc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104472Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750543}

This CL implements the Java side integration for the TabService.

Bug: 1058093
Change-Id: Iaa8f007a2a16ac10f87466eb7d5d49f05e112576
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090298
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750542}

Bug: 1005076
Change-Id: I16e45e91ee3d6ac3dcb92f6967ea786b1b0f7840
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097301
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750541}

This change:
1) Adds a new function, chrome::ShowDeviceChooserDialog, that displays a
   device chooser bypassing the BubbleUi framework
2) Has Browser use this new function rather than BubbleUi to show the
   bluetooth device choosers

Note that ShowDeviceChooserDialog returns a OnceClosure, which the client
can call to close the dialog. It does not return a pointer to the dialog
since the dialog is self-owning. Previously, this code dealt with that
by passing around BubbleReferences, which have weak pointer semantics;
returning a OnceClosure (which internally has a WeakPtr to the UI)
allows the client code to close the bubble when it wants to without adding
new lifetime issues.

Remaining uses of ChooserBubbleDelegate directly:
* Web USB chooser
* HID chooser
* Serial chooser

These use similar design patterns, and will be migrated in follow-up
changes.

Bug: 496955
Change-Id: I1b45c1cfdba6e0eaee57ef61d91da294832a0888
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102947
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750540}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/22594b8b0acd..496706c9672e

git log 22594b8b0acd..496706c9672e --date=short --first-parent --format='%ad %ae %s'
2020-03-16 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.
2020-03-16 sigurds@chromium.org Only display 100 inline breakpoints
2020-03-16 szuend@chromium.org Initialize Linkifier link texts with 'zero width space'
2020-03-16 tvanderlippe@chromium.org Extract tsconfig.base.json to obtain VSCode compatible tsconfig.json
2020-03-16 jacktfranklin@chromium.org TypeScriptify `sdk/CookieParser`

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@496706c9672e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1011811,chromium:1032016,chromium:1057021,chromium:1060105
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I79d993f3bdc484a7f69af59056b8535cfa57fa5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105193Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#750539}

Implemented |erase|, |RemoveFirst|, |pop_back|, |clear| in NewLinkedHashSet.
Also added tests for those functions.

Change-Id: I434409a3f1ad0a6bffd60ddfbd79f4cdeaf22d94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103994Reviewed-by: Bartek Nowierski <bartekn@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Kei Nakashima <keinakashima@google.com>
Cr-Commit-Position: refs/heads/master@{#750538}

When the flag kClearSyncedData is enabled, the current code attempts to
add the new dialog option to the managed account alert. We only expect
the change to affect non-managed accounts, and so the app crashes.

Adds regression test for the case where a managed user signs out from
Chrome.

Bug: 1058662
Change-Id: Iaad9a13655a45653aa2e09e1428c03a37e412325
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101008
Commit-Queue: Nohemi Fernandez <fernandex@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750537}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f4a3e7498a60..18f1a2797005


Created with:
  gclient setdep -r src-internal@18f1a2797005

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:974751
Tbr: jbudorick@google.com
Change-Id: I8d7da36e2abeb7dfbab2c218e496c2a6a81a7bd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104949Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#750536}

Bug: 346399
Change-Id: I038233ae521749c4168f08bb9450309da4a04e4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102492Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Auto-Submit: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#750535}

https://swiftshader.googlesource.com/SwiftShader.git/+log/3a50a43df988..440fc9959f06

git log 3a50a43df988..440fc9959f06 --date=short --first-parent --format='%ad %ae %s'
2020-03-16 swiftshader.regress@gmail.com Regres: Update test lists @ 3a50a43d

Created with:
  gclient setdep -r src/third_party/swiftshader@440fc9959f06

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: Ia77d4e0d7d0fd5513a005e4bcf1cd7c8db18e29b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104951Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#750534}

Bug: 1041472
Change-Id: I6435d239ddb90b0b5ffed600d0e5d2e51d4b8270
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096962Reviewed-by: Monica Basta <msalama@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750533}

Test: N/A
Bug: internal b/151449774
Change-Id: I9e66ebef8c96e9d3cf2708efdfdf95139d9d2b61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104663
Auto-Submit: Maxim Novikov <csbubbles@chromium.org>
Commit-Queue: Luke Halliwell (slow) <halliwell@chromium.org>
Reviewed-by: Luke Halliwell (slow) <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750532}

Metric is still use to reduce the crash report
unfinished report upload.


Change-Id: Ia3e4b4a5de2a5a86ddb7e172a47e2a7599949ea2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093605
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750531}

Tracing on-heap objects should treat everything as const and not change
anything. This CL makes all visitor tracing/visitation methods and
TraceTraits expect const objects.

The guideline this CL tries to establish is that from the perspective
of tracing everything is const, including data that will later be used
for compaction. Everything the visitors records is const.
If and when needed, const_cast is used to  get mutable versions (e.g.
in weak callbacks and compaction).

This CL also updates the collection Trace methods to const as these
are highly intertwined with the TraceTraits.

Bug: 1058387
Change-Id: Icd26693e029d5c1d03ba50e54390b1d9aa350620
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095720Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Anton Bikineev <bikineev@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750530}

We added some new histograms for find-in-page in
https://chromium-review.googlesource.com/c/chromium/src/+/2096795, and
three of them should be marked as base histograms as we are only
tracking their subhistograms.
The base histograms are:
- WebCore.FindInPage.NumberOfTasksPerRequest
- WebCore.FindInPage.RequestDuration
- WebCore.FindInPage.TotalTaskDuration

Bug: 1057917
Change-Id: Ifcf79e1d93334a9ac062f1d9cab79349e2d35e24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104810Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750529}

Clicking on the inspect/close button too quickly in succession or right-
clicking the button would cause the whole div containing both buttons
to be highlighted which was annoying.

Before: https://imgur.com/a/OgdmeE7
After: https://imgur.com/a/nfjOrb4

Bug: chromium:1036789
Change-Id: I51328de5d1fa2ab232913770cc1cf594b019d660
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102581Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Auto-Submit: Peter Marshall <petermarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750528}

New simpler two-step api.

Bug: 1049638
Change-Id: I8490144f181e140a909d3a740be9035ef0be1465
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095056
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750527}