- 07 Jan, 2021 40 commits
-
-
Jesse Schettler authored
The histogram records the time between sending a request for scanners and receiving capabilities for the selected scanner (i.e. the time that passes before being able to perform a scan). Bug: 1059779 Change-Id: I8be9453945054848d1b534bf43ba29e2653731da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597656Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#841078}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/875b30eb4cdf..d4e0f040446f 2021-01-07 morg@google.com Mark grunt-arc-r as non-experimental for PFQ 2021-01-07 lamontjones@chromium.org api: Update python bindings. 2021-01-07 isaaclee@google.com zork: add factory branch builder 2021-01-07 sbelmon@google.com licensing: add "tainted" signal 2021-01-06 tcwang@google.com toolchain_util: Add function to modify kernel afdo metadata 2021-01-06 jhorwich@google.com Remove unittests from grunt-arc64 builders 2021-01-06 kimjae@chromium.org xbuddy: Handle chromiumos_base_image.bin 2021-01-06 chrome-bot@chromium.org Update config settings by config-updater. 2021-01-06 chrome-bot@chromium.org Update config settings by config-updater. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Id5831227ac12c7d02005ffa82a932974d8a4bec2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614766Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841077}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f39e76846d7f..be0b3b7363a9 2021-01-07 brianosman@google.com Strip down SkSL::ExternalValues, limit them to functions If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: Ibd7e11265ff4cb2d8d6699ec37254e6e68786d9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614764Reviewed-by:
-
Alex Ilin authored
AutofillAssistantTriggerScriptIntegrationTest#dontShowOnboardingIfAcceptedInDifferentTab is failing on builder "android-pie-x86-rel". Bug: 1163913 Change-Id: I93af1fee346650a370b28810111cbce51e860918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614782 Auto-Submit: Alex Ilin <alexilin@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#841075}
-
chromium-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/c493c6112021..5820c040a91a 2021-01-07 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from aa005e8bd435 to ad77ed7a8d52 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com,enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com,enga@google.com Change-Id: Ia1b761c7fc44cb39e69ee70be8ddd170cf89fbef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614761Reviewed-by:
-
Brian Ho authored
When SkiaRenderer is enabled on Chrome OS, we see a spike of crash reports [1] in SkiaOutputDeviceBufferQueue from |current_image| and |submitted_image| both being null [2]. One way this can manifest is when an overlay promoted via the fullscreen strategy becomes unpromoted without any change in damage (e.g. through a test page flip failing). At a high level, the order of operations for rendering a frame in SkiaOutputDeviceBufferQueue is: BeginPaint/EndPaint -> SchedulePrimaryPlane -> PostSubBuffer. If the only quad displayed is promoted to a fullscreen overlay, |PostSubBuffer| will clear both |submitted_image_| and |current_image_| [3]. Normally, the next frame will invoke |BeginPaint| which in turn sets a new |current_image_| [4], but if there's no damage, this won't get called. As a result, in |SchedulePrimaryPlane|, Chrome crashes. This CL fixes this error by disabling the fullscreen overlay strategy when SkiaRenderer is enabled. Since this crash is difficut to repro deterministically, this is just a quick fix to see if the fullscreen strategy is actually the culprit we see in canary/dev. I expect to implement a full fix later. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=1156182 [2] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/service/display_embedder/skia_output_device_buffer_queue.cc;l=209;drc=cb3ff30296f61e6f66de70fa33bd9f5169a1ff88 [3] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/service/display_embedder/skia_output_device_buffer_queue.cc;l=343;drc=cb3ff30296f61e6f66de70fa33bd9f5169a1ff88 [4] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/service/display_embedder/skia_output_device_buffer_queue.cc;l=514;drc=cb3ff30296f61e6f66de70fa33bd9f5169a1ff88 Bug: 1156182 Change-Id: I3db7cf64cae0f5adadba160defb4c3353ef4a6fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613685Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org> Cr-Commit-Position: refs/heads/master@{#841073}
-
Philip Rogers authored
This has fully launched and the experiment can be removed. Bug: 1079418 Change-Id: Ic06e85939829cce8ecf80fb0692b0b0d5e0595ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613129Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#841072}
-
Justin Cohen authored
There is some speculation that local state is not persisting properly in some cases. Add a histogram to also set the value in NSUserDefaults and to compare those two values. Bug: 1161529 Change-Id: I67f4caf8060f037151dcc6653825ec17b556dee6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611966Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#841071}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/61a89564cea2..ac4d756a6626 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC clamy@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: clamy@google.com Change-Id: Id0507e9b1a58eaaf83af42d2639af62ecbdf28ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614762Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841070}
-
Rune Lillesveen authored
Fix lint failure. Change-Id: I89aa665a7d6b375abd8cba0a2768cb6be767d8f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614818Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#841069}
-
Joey Arhar authored
Clusterfuzz found an interesting case where if a match is disconnected from the document, and there is another display locked element in the document, and the match is in shadowdom, an enclosing block for the match cannot be created because the tree has no layout objects. Fixed: 1160283 Change-Id: I1a2c9003b99d2dbe20344bd39b629c7427f11da9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613952Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#841068}
-
Wenyu Fu authored
Remove HomepagePromoController and related flags & resources. Change-Id: I5f7183c8d93eded7cf9cb0ebbe10c32f0f70208e Bug: 1162522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613384Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#841067}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202101070600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/mqExY_CKGV64CkBK6pxd74QrlY0Ui90tdf5wIZPeB38C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138961540 Tbr: media-app@grotations.appspotmail.com Change-Id: Ic990ccda8d305951aa0089868c18f94dc848dacf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614763Reviewed-by:
-
David Jean authored
Another step towards ios12 deprecation. Bug: 1086521 Change-Id: I0bae084d19ee0f4673e59791a91c02d47823ff9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610093Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#841065}
-
Owen Min authored
The profile list returned by the GetAllProfilesAttributes() is not sorted in any particular order and might be different in different test runs. Update the test case to make sure this can be handled. Bug: 1153593 Change-Id: Idf6b9c5f720a8285112dc17c1da7b31ddbd7978d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612526Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#841064}
-
Devlin Cronin authored
The old server and all its content have been removed. Clean up the directory as a final step. Bug: 1161364 Change-Id: Ice2ee9a6be566072575367e0598f4e884dd12807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613559 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#841063}
-
Egor Pasko authored
This avoids jumping back and forth between the two classes in order to understand when each linker is used, at what time it can be overridden etc. It is better for readability to make the choice only in one place. Since Linker can totally avoid knowing about LibraryLoader, and not vice versa, putting the choice in LibraryLoader seems better. Consequences for this change that look like a general health improvement: * less static fields; * less packageprivate methods. Fun fact: After this change getLinker() implementation becomes protected by another lock. Currently since the method is called very early, such locking is not needed. There is also no plan to postpone initialization such that lock would be needed. On the other hand, this lock is taken only a handful of times, and makes the class more self-contained. Perhaps the other fields that are initialized early would benefit from a cleaner @GuardedBy look, in a later change. Voting is accepted. Bug: 1154224 Change-Id: I7fa96a23e02a3bc7c28b1c3310e7facf6de0218b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610028 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#841062}
-
Scott Violet authored
DataObserver adds itself as an observer to HistoryService, but never removes itself. This also converts to using ScopedObservation. BUG=1158388 TEST=none Change-Id: Ia438428ce0ecd7b8207be5bdc38bd448817300a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612125Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#841061}
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 88.0.4324.79. R=rmhasan@google.com, sky@chromium.org Bug: 1041619 Change-Id: I76daaa16c4f12593be62fa5e11760f2b9712641c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613329 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#841060}
-
chrome://flagsVictor Hugo Vianna Silva authored
Add an entry to chrome://flags to make testing easier. Bug: 956722 Change-Id: If91fdcbecc4293e844585babfdf51b3e2022dc3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613053 Commit-Queue: Victor Vianna <victorvianna@google.com> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Victor Vianna <victorvianna@google.com> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#841059}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ca94d1da8597..d0a38010a14c 2021-01-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from cbab637962d0 to c493c6112021 (10 revisions) 2021-01-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from b9e179f1f239 to 7b2f93895418 (1 revision) 2021-01-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 38610c88 to 730c6584 (444 revisions) 2021-01-07 syoussefi@chromium.org Vulkan: Move xfb emulation offset calculation to translator 2021-01-07 syoussefi@chromium.org Vulkan: Fix missing xfb buffer rebind on new command buffer 2021-01-07 syoussefi@chromium.org Move RegenerateStructNames AST transformation to gl/ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1161513 Tbr: ianelliott@google.com Change-Id: I4391dd536b8dd15ab03d9c5b242c16968655e10a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611223 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Luca Hunkeler authored
Moved a test to a more appropriate class and added a comment. Bug: b/176071036 Change-Id: I569842e3403cddf000d4b44ceefa8ca77ec2e253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611256Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Luca Hunkeler <hluca@google.com> Cr-Commit-Position: refs/heads/master@{#841057}
-
Sergei Glazunov authored
|PartitionAllocGetSlotOffset| currently returns the offset from the beginning of the user data area rather than the actual slot start. Remove unnecessary pointer adjustments to make the implementation match the name. Similarly, update |PartitionAllocGetSlotStart|. Bug: 1073933 Change-Id: I82bcd3a397ab01f1a25ae98b0b768b9bd81315a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613050 Commit-Queue: Sergei Glazunov <glazunov@google.com> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#841056}
-
Dave Tapuska authored
If the UpdateBrowserControlsState is sent before the view (and main frame) are created then it won't go anywhere. Ensure the disabling of browser controls state occurs after the main is created by adding a WebContentsObserver. BUG=1158712 Change-Id: I96dca9b47381291769a6727ad973656559a6701d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613151Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#841055}
-
Stephen McGruer authored
This rolls up to WPT SHA e04f27b9946175edab6c09421ab5ceaa14b84539 This drops the cherry-pick of 0dd83ea7, as the upstream version of that change has now landed. Bug: 1160108 Change-Id: I6fdbb8f1453d3b6d70743614e60eaf26f9e2d29a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611551Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Commit-Queue: Jason Chase <chasej@chromium.org> Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#841054}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/fac169113df7..06aa1af28a72 2021-01-07 cwallez@chromium.org Roll third_party/vulkan-deps/ b08eace32..c493c6112 (27 commits; 1 trivial rolls) 2021-01-07 jpnurmi@gmail.com Fix typo: vulkan_deps vs. vulkan-deps If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: I459139ac9bed876823512c08227f711596ee1fe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614462Reviewed-by:
-
Mohamed Heikal authored
Bug: 1159961 Change-Id: Iccf5d8edf1b28480883397057b7dce3052bdbe70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613425 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#841052}
-
Morten Stenshorne authored
Fixed by https://chromium-review.googlesource.com/c/chromium/src/+/2597957 Bug: 1156250 Change-Id: Ibc8ee183af4e599470dac463e3dd70c7eb830c19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611259Reviewed-by:
Benjamin Beaudry <benjamin.beaudry@microsoft.com> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#841051}
-
Tanmoy Mollik authored
This cl removes onPrimaryAccountSet/Changed methods from the java IdentityManger. All of the usages of these methods has been replaced by onPrimaryAccountChanged on the java side. Bug: 1158855 Change-Id: I4e0deeaa0e127f65e4e43c429dec26963111f736 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608148Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#841050}
-
Scott Violet authored
Prior to this patch sessions code could attempt to use a file that did not have the complete initial state written. This could happen in two scenarios: . chrome crashes while writing state. . there was an error in writing to the file. To address this the backend now writes a special command after the initial commands has been written. The meaning of truncation changes to mean start a new file. Only files that have the command are considered valid. If there is an error writing, the current file is closed. This logic is opt-in at the moment, but will be made the default after consuming code is updated. CommandStorageManager/Backend get a boolean indicating if the new functionality should be used. This is temporary and will eventually be the default with no way to get the old behavior. The new behavior gives the following logic: . AppendCommands() gets a callback that is called if there is an error writing commands. . If there is an error writing commands, the current file is closed. . After there is an error writing commands consuming code must call AppendCommands() with truncate set to true. Any calls to AppendCommands() after a failure with truncate false are ignored. The code can't DCHECK because of thread hops. . Once AppendCommands() writes the initial set of commands (truncate is true) an extra command is written. . When determining the last file to use, files without the marker are skipped (because they didn't have the initial state written). For compat, if the file was not written with support for marker, it will still be used. The meaning of truncate is changed (and will be later renamed) to recreate_file. Other minor changes: . On chromeos flush() was called on the file after writing commands. I removed the ifdef, so this is done on all platforms. This patch does not enable the new logic, it merely adds the logic. My plan is to enable this for tabrestore first, let it bake, then the reset of the code. BUG=648266 TEST=covered by tests Change-Id: I107a5cc58e9359b37cd330079b0d801e7c693286 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606791 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#841049}
-
Alex Ilin authored
AutofillAssistantKeyboardIntegrationTest#keyboardDoesNotShowOnElementClickInIFrame is failing on builder "android-marshmallow-x86-rel-non-cq" Bug: 1131717 Change-Id: I14df97017da3c96622137a801d1c359e2a1f3ea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612971 Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by:
-
Viktor Semeniuk authored
Bug: 1108279 Change-Id: Ie2abff9ef6c12b925471f97c21217c132007de02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602422Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Viktor Semeniuk <vsemeniuk@google.com> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#841047}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1609999114-921ab7abd39e739e3d7a532c01a17e7e41151562.profdata to chrome-linux-master-1610019930-98b4330725909b282b32db0e07c7a238a41191db.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iffc913c585424a453109bad158623a6a14cc56ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614461Reviewed-by:
-
Tanmoy Mollik authored
Method OnPrimaryAccountSet/Cleared is deprecated. So this cl changes these calls to OnPrimaryAccountChanged. Bug: 1158855 Change-Id: I2321624081eca7fea760c22189bb0524fd849d63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599807Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Tanmoy Mollik authored
Methods OnPrimaryAccountSet/Cleared are deprecated. So this cl changes these calls to OnPrimaryAccountChanged(). Bug: 1158855 Change-Id: Ie5a7880c7805f7a047345ee06111e78999db58ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612891Reviewed-by:
-
Tanmoy Mollik authored
Replace IdentityManager.Observer.(onPrimaryAccountSet/Cleared) call with onPrimaryAccountChanged call. Thse cl also replaces these calls in SigninManagerTest Bug: 1158855 Change-Id: I7ffac4a907c34fb22b0ff07ffc27e09a4465a563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606347Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#841043}
-
Kim-Anh Tran authored
This disables tests that check the linkify output of the DevTools' Linkifier. Temporarily disabling it to make changes in the Linkifier. Bug: chromium:1132260 Change-Id: Ic0668709b2e8ee9e02c2f2624e073131556e918d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611029Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Auto-Submit: Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/master@{#841042}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8978b61a6b13..61a89564cea2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC clamy@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: clamy@google.com Change-Id: I2ecdf2562fded8c151d49db3dd199525cf83d2a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614698Reviewed-by:
-
Sathya Gunasekaran authored
Change-Id: I9252a3dbf1d3d5906cfe5379090d2a06750eddfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612722 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#841040}
-
Xiaocheng Hu authored
Currently, TimerBase cannot correctly track the lifetime of objects embedded in GC-ed objects, like FontPreloadManager which is embedded in Document. This causes some memory safety issues. This patch moves FontPreloadManager to Oilpan to avoid the issue. Bug: 1154965 Change-Id: I490b416abc6a997034baaa7994cd3a50bca7e055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611755Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#841039}
-
