- 23 Jan, 2019 40 commits
-
-
Mario Sanchez Prada authored
Add a new static SigninManagerFactory::RegisterPrefs() method to the relevant factory for //ios/web_view, have it call SigninManagerBase::RegisterPrefs() instead and call that static method from ios_web_view::ApplicationContext, similar to what's already done in //chrome and //ios//chrome. Bug: 920191 Change-Id: If8f1c86b4f0dc069fe66aa013235d9e695543a2b Reviewed-on: https://chromium-review.googlesource.com/c/1425733 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#625176}
-
Simon Que authored
Bug: 922354 Change-Id: I0d168efeea407409ab234bdcb1ebf307a9c7b551 Reviewed-on: https://chromium-review.googlesource.com/c/1426248Reviewed-by:
Shinya Kawanaka <shinyak@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#625175}
-
Zakhar Voit authored
[Managed Session] Force managed sessions mode when network certificates are set via ONC device policy The same way as force-installed extensions, forced network certificates are considered "risky" should activate "Managed Session" mode (i.e. show warning about admin capabilities on the login page). Bug: 910218 Change-Id: Ic34898ed255f51b48b948b00ae4563bcd7939347 Reviewed-on: https://chromium-review.googlesource.com/c/1391590 Commit-Queue: Zakhar Voit <voit@google.com> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#625174}
-
Julie Jeongeun Kim authored
This Cl removes unused headers, account_tracker_service_factory.h and account_tracker_service.h. Bug: 922783 Change-Id: Ibfc8379b0aa4d8ed2e49bf00bcaa9651121b051f Reviewed-on: https://chromium-review.googlesource.com/c/1428507Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#625173}
-
Mirko Bonadei authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/455dc17ba1..0b1e6d417b Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/455dc17ba1..0b1e6d417b Bug: None Change-Id: I8faff7205ec2f433a4bed90b58df788d4fcc3063 Reviewed-on: https://chromium-review.googlesource.com/c/1429642Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#625172}
-
Jordan Demeulenaere authored
Change-Id: I9b12db58728f9e18b54dc270d300005219ea2d77 Reviewed-on: https://chromium-review.googlesource.com/c/1426780 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#625171}
-
Andreas Haas authored
Though I am not much of a blink bindings expert, I am the main author of v8_wasm_response_extensions.*. R=haraken@chromium.org, mlippautz@chromium.org Change-Id: I9558e14879d3a22a28b34e8f5e389910853fe087 Reviewed-on: https://chromium-review.googlesource.com/c/1429121Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#625170}
-
Henrik Boström authored
In Unified Plan, offerToReceive[Audio/Video] are legacy configuration extensions that may create transceivers or change the direction of existing transceivers. https://w3c.github.io/webrtc-pc/#legacy-configuration-extensions This was previously supported by the webrtc layer, but until this CL the state changes were not surfaced properly, and offerToReceive-transceivers would not become visible in JavaScript until surfaced as a side-effect of some other operation that surfaces transceivers such as setLocalDescription() or setRemoteDescription(). With this CL we pass 14 more WPTs. Bug: 911090 Change-Id: I5d9a5c15c6ac4e0dc328e589ba129925a65e404e Reviewed-on: https://chromium-review.googlesource.com/c/1427541Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#625169}
-
Takashi Toyoshima authored
Currently, MidiHost caches sysex authority on the session start, that means when the first client connects. But the second or later clients share the same session, and may have different authority. This patch changes to update the cached authority when permission checks fail. Bug: 912501 Change-Id: I6fc4ebe456c7a62c4f9bc96f8332a1e78d522cb0 Reviewed-on: https://chromium-review.googlesource.com/c/1390891 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#625168}
-
Antonio Gomes authored
CL is an incremental step to get away from PO2TS from AboutSigninInternals. BUG=809539 Change-Id: Id8e8baea53c76eedee1bb3ac83f2ccb347909210 Reviewed-on: https://chromium-review.googlesource.com/c/1426760Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#625167}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f6d33d43..f6929d6c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7caa8ba19a56af8e34f696c1a52f7e05b14775e0 Reviewed-on: https://chromium-review.googlesource.com/c/1429248Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625166}
-
Hitoshi Yoshida authored
Serializer was deprecated in spec, and we no longer have it in other than test IDLs. This CL drops support of it from our IDL compiler. Change-Id: I7734e10f76283e387156f79f4e518dc158d0c265 Reviewed-on: https://chromium-review.googlesource.com/c/1429364Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#625165}
-
Abhijeet Kandalkar authored
This CL replace use of AccountTrackerService{GetAccountInfo/ GetMigrationState} by IdentityManager{FindAccountInfoForAccountWithRefreshTokenByAccountId/ GetAccountIdMigrationState} and removes unused headers. Bug: 922775 Change-Id: Idb1b33ccb478808ab2b3be2792e647e1ae983362 Reviewed-on: https://chromium-review.googlesource.com/c/1426249Reviewed-by:Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#625164}
-
David Roger authored
This class was unused, but was built and had ChromeOS-specific code. This CL removes the dead ChromeOS code, and stops building the class entirely. Bug: None Change-Id: I02b3c5f1777d071d606ff39b00dd4ce68c98aea7 Reviewed-on: https://chromium-review.googlesource.com/c/1417452 Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#625163}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fc4ab925. With Chromium commits locally applied on WPT: 1c633d48 "Snap the snapped_dest_rect for backgrounds" 1061788d "Reland "Add quota usage details tests for all other storage backends."" bcd3934d "Add a test for ServiceWorker and AppCache interaction with claim()" 33a49f0d "[WebLocks]: Modifying weblocks algos to be O(1)" 8e4e5d72 "Fix preload tests failing on wpt.fyi dashboard" f643497e "[resource-timing] Modify is_secure_context_ based on resource" 20defaa4 "[LayoutNG] ComputeReplacedSize min/max width/height fix" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org: external/wpt/compat rego@igalia.com: external/wpt/css/css-ui NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I4a3ca5f1659c123326b27bed237c26e46a3a45dd Reviewed-on: https://chromium-review.googlesource.com/c/1429245Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625162}
-
Anatoliy Potapchuk authored
Bug: 919962 Change-Id: I333e3679f1ca7c3a51095a471f97a073d97a5aba Reviewed-on: https://chromium-review.googlesource.com/c/1422438 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#625161}
-
Kent Tamura authored
We have bunch of "Trace(blink::Visitor*" in Blink though their classes are also in blink namespace. This CL removes a part of such unnecessary blink::. This CL has no behavior changes. This CL was produced by the following command on zsh: % for i in **/*.{h,cc}; sed -i "" -e "s/Trace(blink::/Trace(/g" $i Change-Id: Ia7cc19c2b26ffee332dc2e66b2cb65f6895e9b51 Reviewed-on: https://chromium-review.googlesource.com/c/1428506Reviewed-by:Keishi Hattori <keishi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#625160}
-
Zakhar Voit authored
Managed session mode now is only activated when any "risky" extensions are force-installed. Right now an extension is considered "risky" if it's force-installed, but not whitelisted. Bug: 910218 Change-Id: I42cc76e3723513b23f827c99505a096e3832a94d Reviewed-on: https://chromium-review.googlesource.com/c/1391589 Commit-Queue: Zakhar Voit <voit@google.com> Reviewed-by:
-
Alex Clarke authored
All those default values made TestBrowserThreadBundle's constructor (and ChromeRenderViewHostTestHarness and BrowserWithTestWindowTest) awkward to use and maintain (imagine if we added another trait to ScopedTaskEnvironment). This patch changes TestBrowserThreadBundle's main constructor to take zero or more traits to configure the TestBrowserThreadBundle and the underlying ScopedTaskEnvironment. Note there is a 20kb test binary size hit which we are happy to take in favour of readability for tests but that this paradigm should be used with care on non-constexpr types in prod. A number of clients of TestBrowserThreadBundle are also refactored to take advantage of this. Change-Id: I2bdb3b8c382f1389058508f870815eddb500726d Bug: 881041 Reviewed-on: https://chromium-review.googlesource.com/c/1394377 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#625158}
-
Keishi Hattori authored
CrashMemoryMetricsReporterImpl, OomInterventionImpl, and the "additional critical memory pressure generator" we plan to implement, all require access to periodic memory usage data. This CL introduces a MemoryUsageMonitor class that periodically checks the memory usage and notifies its observers. Bug=920922 Change-Id: I1243ffa43369b6accedf3a0eb000230438c34883 Reviewed-on: https://chromium-review.googlesource.com/c/1404903 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#625157}
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: I61904bdd8b32af26509ef2f78cfb3b51361fa891 Reviewed-on: https://chromium-review.googlesource.com/c/1417175Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#625156}
-
Pavel Shmakov authored
SnackbarManager removes all snackbars when Chrome goes to background, so we must restore TWA snackbar when coming back to foreground Bug: 923861 Change-Id: I9480fb6e4aace42890abad19433ff612fabece19 Reviewed-on: https://chromium-review.googlesource.com/c/1426706Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#625155}
-
Antonio Gomes authored
This is a follow up of [1], when the IdentityManager::LegacyLoadCredentials API was added. [1] https://chromium-review.googlesource.com/c/1412775 BUG=910581 Change-Id: If6faf0d242149ec57d2560c2c6d4d6295907c2cd Reviewed-on: https://chromium-review.googlesource.com/c/1425659 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
-
Yi Su authored
This CL replaces the custom search bar item in PasswordsTableViewController with UISearchController. New UI: https://drive.google.com/file/d/15vKcxrdl96QHyqqKfXpjDQHWkDGaa55Q/view?usp=sharing https://drive.google.com/file/d/1Ll4WhgUq41mcLJSPszT43MuMIr0BHOc-/view?usp=sharing https://drive.google.com/file/d/1pnQTGaVVRSDn0Pno_ykAk-nTHMC3IgNr/view?usp=sharing Bug: 894791 Change-Id: Icb4975ac554c302797f5f01fe06b16f9f39d69f8 Reviewed-on: https://chromium-review.googlesource.com/c/1422002Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#625153}
-
Jordan Demeulenaere authored
Change-Id: I9e66727766422a18bc4e4c5618c49e332c548087 Reviewed-on: https://chromium-review.googlesource.com/c/1426685 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
-
jdoerrie authored
This change adds logic to record a user action whenever the "Manage your Google Account" link gets clicked. Bug: 907035 Change-Id: I081886ea84b9c748d8402aafc6b64bdd768378e9 Reviewed-on: https://chromium-review.googlesource.com/c/1426785 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#625151}
-
David Roger authored
The lock can now outlive the AccountReconcilor. Bug: 923094 Change-Id: I92443549d50354eb1418fe8495dddea5bf310d5d Reviewed-on: https://chromium-review.googlesource.com/c/1425499Reviewed-by:
-
Gyuyoung Kim authored
AccountTrackerService will be deprecated for the servicification. So this CL replaces all uses of ATS with IdentityManager's ones in dice_browsertest.cc Bug: 922769 Change-Id: If17b69fac2b15a9d4afa987081def495bd19b24a Reviewed-on: https://chromium-review.googlesource.com/c/1429312Reviewed-by:
-
Hitoshi Yoshida authored
Serializer is a deprecated feature in WebIDL, but we still have it on several IDL files. This CL replaces it with toJSON() operation, which is a replacement for serializer, but does not change user facing behaviors. For DetectedBarcode, DetectedText, and DetectedFace, toJSON() is not defined in spec, but this CL defines it to keep their backward compatibility. Bug: 736332 Change-Id: Iff420493f7d41a78452cef5a203330dba6333bca Reviewed-on: https://chromium-review.googlesource.com/c/1429310Reviewed-by:
-
Daniel Bratell authored
In jumbo builds, many files are compiled in the same translation unit and then they also share the same anonymous namespace. Then it becomes a problem (does not compile) if several constants/ symbols are named the same. This follows earlier patterns of giving shared generic names prefixes. Bug: 918788 Change-Id: If45d63b9bfe77119735c67fca491a6227dded045 Reviewed-on: https://chromium-review.googlesource.com/c/1424842Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#625147}
-
Kinuko Yasuda authored
TBR=chrishtr@chromium.org Bug: 921242 Change-Id: Ifa915bc86e5148d5df71a744ef6f41c00881115f Reviewed-on: https://chromium-review.googlesource.com/c/1429881Reviewed-by:
-
Alexander Potapenko authored
TBR=kmilka@chromium.org Bug: 923953 Change-Id: I45d42b9c1f4f7afb417300d352176d8bb86dec6f Reviewed-on: https://chromium-review.googlesource.com/c/1429042Reviewed-by:
Alexander Potapenko <glider@chromium.org> Commit-Queue: Alexander Potapenko <glider@chromium.org> Auto-Submit: Alexander Potapenko <glider@chromium.org> Cr-Commit-Position: refs/heads/master@{#625145}
-
Marek Haranczyk authored
Bug: 556939, 914453 Change-Id: Ibd8757967a051507e0fc2a9ae93ac789e51b005b Reviewed-on: https://chromium-review.googlesource.com/c/1425708Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Marek Haranczyk <mharanczyk@opera.com> Cr-Commit-Position: refs/heads/master@{#625144}
-
Mirko Bonadei authored
Constant Labels was only used by //third_party/libjingle_xmpp. In CL [1] I removed this error handling mechanism from libjingle_xmpp so it is possible to remove this code and simplify //third_party/webrtc_overrides. [1] - https://chromium-review.googlesource.com/c/chromium/src/+/1397607 Bug: 896154 Change-Id: I3b4d8869d7813c789b7b12f8cad0fdc079796491 Reviewed-on: https://chromium-review.googlesource.com/c/1397982Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#625143}
-
Matt Falkenhagen authored
This fixes a race because both main thread and worker threads parse CSP which uses blink::CSPDirectiveList which uses blink::SpaceSplitString. Bug: 807838 Change-Id: Id1eafe17daf3d37f9c1b6fc64aaa18ea964c57bc Reviewed-on: https://chromium-review.googlesource.com/c/1429819Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#625142}
-
rbpotter authored
Simplifying destinations dialog: - Remove recent destinations list - Remove total destinations count - Remove headers - Move "Manage" link to a button - Show location or description with no search query, since this information is no longer shown when the destination is selected. Bug: 923174 Change-Id: I614949c826f2d23705f1b1829eb705e1c32c483c Reviewed-on: https://chromium-review.googlesource.com/c/1413716 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#625141}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4c6aafc4. With Chromium commits locally applied on WPT: 1c633d48 "Snap the snapped_dest_rect for backgrounds" 1061788d "Reland "Add quota usage details tests for all other storage backends."" bcd3934d "Add a test for ServiceWorker and AppCache interaction with claim()" 33a49f0d "[WebLocks]: Modifying weblocks algos to be O(1)" 8e4e5d72 "Fix preload tests failing on wpt.fyi dashboard" f643497e "[resource-timing] Modify is_secure_context_ based on resource" 20defaa4 "[LayoutNG] ComputeReplacedSize min/max width/height fix" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I21fecc27184e8c06caf4ba9cb1998c877c6141d6 Reviewed-on: https://chromium-review.googlesource.com/c/1429663Reviewed-by:
-
edchin authored
Cleanup imports in TabGrid. Bug: 923973 Change-Id: I148ea89bf77b7a32ee141c80bb1fb30a556852b8 Reviewed-on: https://chromium-review.googlesource.com/c/1426402 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
-
Yi Su authored
Thic CL changes the event type of scrim views for search bar in history and bookmarks from UIControlEventAllTouchEvents to UIControlEventTouchUpInside. Bug: 894791 Change-Id: Ie15e1708dae03c4ca3ebec68bd6b8905b2b3a73a Reviewed-on: https://chromium-review.googlesource.com/c/1426777Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2307cc4b..f6d33d43 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2a92a8abcc727c1a83ff3bf2f11266067d3ccd2c Reviewed-on: https://chromium-review.googlesource.com/c/1429225Reviewed-by:
-
