- 27 Aug, 2018 40 commits
-
-
Francois Doray authored
This updates field_trial_testing_config.json with the parameters that we plan to use to experiment with proactive freeze and discard on beta. PageAlmostIdle feature is independant from ProactiveTabFreezeAndDiscard. SiteCharacteristicsDatabase feature is required to enable ProactiveTabFreezeAndDiscard, so they need to be enabled by the same study. stop-non-timers-in-background defines the effect of freezing a tab, so it needs to be in the same study as ProactiveTabFreezeAndDiscard. Bug: 775644 Change-Id: I8ef64a716585a6284e9744c93cf5dfc58a22f77f Reviewed-on: https://chromium-review.googlesource.com/1188862 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#586299}
-
spirv-chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/47ee776a2c56..d94a2077d68c git log 47ee776a2c56..d94a2077d68c --date=short --no-merges --format='%ad %ae %s' 2018-08-27 33432579+alan-baker@users.noreply.github.com Remove idUsage 2018-08-27 31666470+s-perron@users.noreply.github.com Have the constant manager take ownership of constants. (#1866) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@d94a2077d68c The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I5bc5a2ef5245af5cbaa7d41c2abd6633f16b8184 Reviewed-on: https://chromium-review.googlesource.com/1190683Reviewed-by:
spirv-chromium-autoroll <spirv-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: spirv-chromium-autoroll <spirv-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586298}
-
Etienne Pierre-doray authored
This CL adds assertions in ScopedBlockingCall. To distinguish between blocking and sync primitive assertions, a new class was added, ScopedBlockingCallWithBaseSyncPrimitives. Usages of ScopedBlockingCall were replaced by ScopedBlockingCallWithBaseSyncPrimitives when appropriate. Corresponding assertions were added (AssertBlockingAllowed and AssertBaseSyncPrimitivesAllowed) in both ScopedBlockingCall and ScopedBlockingCallWithBaseSyncPrimitives. In the future, either ScopedBlockingCall or ScopedBlockingCallWithBaseSyncPrimitives will be used to mark all blocking tasks. Bug: 874080 Change-Id: I8277436d4dd25dedb47d6fcdacc45f3905397647 Reviewed-on: https://chromium-review.googlesource.com/1178326Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#586297}
-
Becca Hughes authored
Fix an issue with duplicate AudioFocusType typedef that breaks Jumbo builds. BUG=876227 Change-Id: Ic10ecb871d8d1e63093505f63d29bf0b499e6626 Reviewed-on: https://chromium-review.googlesource.com/1183885Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#586296}
-
yusukes authored
The new mojo method allows the Android container to tell Chrome OS that an Android IME has been disabled. This will be used for implementing the cancel button on the enable-IME confirmation dialog. BUG=b:74499980 TEST=unit_tests TEST=Install Gboard, try to enable it via chrome://settings, press CANCEL on the confirmation dialog, verify that the checkbox for Gboard is automatically unchecked. Change-Id: I29320ff6ae8c610a3e3db13330672f3fc68db7d3 Reviewed-on: https://chromium-review.googlesource.com/1179471 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#586295}
-
Yue Li authored
Bug: 867919 Test: Local Compile Change-Id: I4500ed2ceb047fb5557717b038f4a057ec251ce6 Reviewed-on: https://chromium-review.googlesource.com/1186125 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Cr-Commit-Position: refs/heads/master@{#586294}
-
Manu Cornet authored
This makes sure that the size of the highlight (which is also the 'small' part of the ripple animation) corresponds to the shelf size. This results in no behavior change in the old UI, and fixes a glitch in the new one. Bug: 877563 Change-Id: I93c0fa90e22ded53e77b2b099e852851821f62a1 Reviewed-on: https://chromium-review.googlesource.com/1189186Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#586293}
-
Michael Spang authored
The shape and location of the window is independent of rendering method, so move those resources to ScenicWindow where they can be used for both software & vulkan rendering paths. Bug: 861853 Test: ozone_demo --ozone-platform=scenic --enable-vulkan (with full series) Change-Id: I728d9d6fc173dd629b319a5de14072c60156d695 Reviewed-on: https://chromium-review.googlesource.com/1188970Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#586292}
-
Mason Freed authored
This patch implements selection rects on the renderer side for display compositor pixel dumps (when using OOPIF). Bug: 875963, 876064 Change-Id: Ie1bc94d94dd290fce13198c63ce3ae8f3fd4b6bd Reviewed-on: https://chromium-review.googlesource.com/1185915Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#586291}
-
Etienne Bergeron authored
This CL is adding a tracing filter to only keep browser process events. For that scenario, we only care about browser process. There is no need to collect renderers/GPU events. R=ssid@chromium.org, oysteine@chromium.org Change-Id: Ifd0538df42c8f237da23ebc6a082e57dbfab9056 Reviewed-on: https://chromium-review.googlesource.com/1187505Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#586290}
-
Xiaocheng Hu authored
After crrev.com/c/1187555, IdleSpellCheckCallback class is no longer used as a callback, but only a state machine controlling the checking progress at idle time. Hence, this patch renames it, which is mostly mechanical string replacement. Bug: 877154 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I54127f84620d45a9d533a5091cd628054d80567c Reviewed-on: https://chromium-review.googlesource.com/1188773Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#586289}
-
John Budorick authored
Bug: 866032 Change-Id: I0f88b10009042901a11adfff40302f830854cad9 Reviewed-on: https://chromium-review.googlesource.com/1189132Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#586288}
-
Victor Costan authored
Change-Id: Id77e608825b627ffd389d4a476594592083283e1 Reviewed-on: https://chromium-review.googlesource.com/1189342 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#586287}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8707af516c46..89664843c656 git log 8707af516c46..89664843c656 --date=short --no-merges --format='%ad %ae %s' 2018-08-27 oetuaho@nvidia.com Add glTexStorage3DMultisampleANGLE entry point Created with: gclient setdep -r src/third_party/angle@89664843c656 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I10b93e3cb9d572b64960bbee3db70347a8732885 Reviewed-on: https://chromium-review.googlesource.com/1190562Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586286}
-
David Davidović authored
Add a field to NigoriSpecifics (part of the Sync protocol) to signify the derivation method used to derive the key from a user's custom passphrase. Add accompanying enum which enumerates the possible options. Currently, only one such method is available. Also enable detection of the case when the method is not known, e.g. when an old client tries to access data committed and encrypted by a new client using a new key derivation method. TBRing dschuyler@ for chrome/browser/webui/settings/people_handler.cc because the change is a trivial file rename change. TBR=dschuyler@chromium.org Bug: 876297 Change-Id: I7b603664a152f4999c8e0a3e1453b3edf611649a Reviewed-on: https://chromium-review.googlesource.com/1183667 Commit-Queue: David Davidović <davidovic@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#586285}
-
Weidong Guo authored
Specs: https://screenshot.googleplex.com/LWLhd6tngR8 Bug: 877569 Change-Id: Idc7982d92865bace10e69127b7f2fa6b86fd284e Reviewed-on: https://chromium-review.googlesource.com/1189023 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#586284}
-
Nicolas Ouellet-Payeur authored
This CL creates the directory for the BrowserSwitcher project with some code, and adds pastarmovj@, the TL, to its OWNERS file. BrowserSwitcher is building the Legacy Browser Support extension's [1][2][3] functionalities into Chrome, to simplify deployment. It is intended for enterprise environments, as a way to switch to an alternative browser for websites that are incompatible with Chrome. BrowserSwitcherSitelist determines whether a navigation should open Internet Explorer, based on prefs (which will later be set by enterprise policies). [1] https://chrome.google.com/webstore/detail/legacy-browser-support/heildphpnddilhkemkielfhnkaagiabh [2] https://support.google.com/chrome/a/answer/3019558 [3] https://github.com/LegacyBrowserSupport/legacy-browser-support Bug: 874971 Change-Id: I688a8481fa0b830ad3646501ccc911084713babc Reviewed-on: https://chromium-review.googlesource.com/1178313 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#586283}
-
Valeriya Sinevich authored
Send request o gaia Multilogin endpoint to receive cookies for chrome accounts. Store them in OauthMultiloginResult class. Change-Id: I7e7ed46b8a21369b95176522b58ea3de8a305048 Reviewed-on: https://chromium-review.googlesource.com/1172426 Commit-Queue: Valeriya Sinevich <valeriyas@google.com> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#586282}
-
Victor Costan authored
This CL only handles the files in //net. The files outside of //net are tackled separately, in https://crrev.com/c/1189548. net::IOBuffer is (thread-safe) ref-counted. Asides from improving the ability to reason about instance ownership locally, creating instances via base::MakeRefCounted makes it possible to use 1-based ref-counting in the future (see base/memory/ref_counted.h). This CL is mechanical, to avoid introducing any behavior changes. The difficult cases will be tackled by follow-up CLs. The following transformations were performed. * new IOBufferType(args) => base::MakeRefCounted<IOBufferType>(args) * new IOBufferType => base::MakeRefCounted<IOBufferType>() * scoped_refptr x(base::MakeRefCounted<IOBufferType>(args)) => scoped_refptr x = base::MakeRefCounted<IOBufferType>(args) * scoped_refptr<IOBufferType>(base::MakeRefCounted<IOBufferType>(args)) => base::MakeRefCounted<IOBufferType>(args) * In comments: creates a new IOBufferType => creates an IOBufferType (so it wouldn't trigger future searches for "new BufferType") * Instantiated static members in HttpResponseBodyDrainer, HttpNetworkTransaction, HttpProxyClientSocket, WritersTest, UDPSocketTest, TestDelegate, UDPSocketPerfTest (needed to fix linker errors) * arraysize -> base::size (where needed to pass presubmit checks) * git cl format Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_cronet_tester Change-Id: Ic2cf8eb4dccfa4a97be893aff9a6053eaaf7d7af Reviewed-on: https://chromium-review.googlesource.com/1188959Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#586281}
-
Alexander Hendrich authored
This CL is part of a larger clean-up operation. The schema validation from json_schema_validator.h/cc is only used in schema.h/cc and will be merged there in a follow-up CL. The value validation in json_schema_validator.h/cc is unused since we use the value validation from schema.h/cc instead. Bug: 873641 Change-Id: Ibe45ac4b4c5911dfb852c6f24fbd7023ebe10ce6 Reviewed-on: https://chromium-review.googlesource.com/1181137Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#586280}
-
Dominik Inführ authored
Load locations from the snapshot file and do not call into V8 for it. Requires V8 to store locations in the snapshot. This speeds up location access. It should also enable us to show locations for snapshots loaded from file in the future. Bug: chromium:854097 Change-Id: Ia35978a63fc30687e5fd9a711023384d9875a9a7 Reviewed-on: https://chromium-review.googlesource.com/1174254 Commit-Queue: Dominik Inführ <dinfuehr@google.com> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#586279}
-
Tim Schumann authored
This verified GC directives are properly implemented. In a subsequent CL, we should add a test that verifies empty updates are interpreted correctly. In particular in cases where the client state should not change, e.g. because the server decided to not fetch updates from the backend and signal a "no change" instead. Bug: 876308 Change-Id: I94420353b8aa63f6ec3799d4a44a9c8c89835a97 Reviewed-on: https://chromium-review.googlesource.com/1190202 Commit-Queue: Tim Schumann <tschumann@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#586278}
-
Clark DuVall authored
I ran this a few hundred times with the ToTLinux build config, and couldn't reproduce the flake. I'll monitor ToTLinux after this goes in to see if the flake still happens. Bug: 873792 Change-Id: Ibe427a800d0c3eaea5b887ffda140c0f556c92bb Reviewed-on: https://chromium-review.googlesource.com/1188590Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#586277}
-
James Cook authored
Pull initialize_webui_hidden_ computation into a utility function. This simplifies various IsUsingWindowService() checks for mash. Bug: 143298, 756071 Change-Id: I538ea8597f2fd970dbd246a9ee184144a76462ca Reviewed-on: https://chromium-review.googlesource.com/1189052Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#586276}
-
David Bertoni authored
Bug: 695711 Change-Id: Ic286b58b0d9a9984428e1db62ce82bd6f9c0ec0e Reviewed-on: https://chromium-review.googlesource.com/1187826Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#586275}
-
Charlie Harrison authored
Bug: 873316 Change-Id: Ifddbd91938e0bede3e68fc681009bafcd69e5882 Reviewed-on: https://chromium-review.googlesource.com/1188843Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#586274}
-
Michael Lippautz authored
Bug: chromium:843903 Change-Id: I2b2cd2efac7119945a32ba74435b4d443f2396f7 Reviewed-on: https://chromium-review.googlesource.com/1190003 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#586273}
-
Michael Lippautz authored
Move roots marking into ThreadState as most necessary data structures do not live in ThreadHeap but ThreadState. Bug: chromium:843903 Change-Id: I5e4f56f594911ebc0d9a17dcdfb4834c6befa555 Reviewed-on: https://chromium-review.googlesource.com/1189864 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#586272}
-
spirv-chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ef678672fb04..47ee776a2c56 git log ef678672fb04..47ee776a2c56 --date=short --no-merges --format='%ad %ae %s' 2018-08-24 stevenperron@google.com Revert "Have the constant manager take ownership of constants." 2018-08-24 stevenperron@google.com Have the constant manager take ownership of constants. 2018-08-24 31666470+s-perron@users.noreply.github.com Copy decorations when creating new ids. (#1843) 2018-08-23 alanbaker@google.com Fixing instances of iteration over unordered containers 2018-08-23 31666470+s-perron@users.noreply.github.com Don't "break" from selection constructs. (#1862) 2018-08-23 31666470+s-perron@users.noreply.github.com Update the order when predicating blocks. (#1859) 2018-08-22 karl@lunarg.com spirv-as: Fix error in help text. 2018-08-21 alanbaker@google.com Moving constant opcode validation into a new file 2018-08-21 ehsann@google.com [kokoro] Stop building and running tests for VS2013 (#1852) 2018-08-21 31666470+s-perron@users.noreply.github.com Fix VS2013 build break. (#1853) 2018-08-21 31666470+s-perron@users.noreply.github.com Have PredicateBlocks jump the existing merge blocks. (#1849) 2018-08-21 alanbaker@google.com Fix EvalInt32IfConst to fail on type instructions. 2018-08-21 31666470+s-perron@users.noreply.github.com Handle breaks from structured-ifs in DCE. (#1848) 2018-08-21 31666470+s-perron@users.noreply.github.com Have dead-branch-elim handle conditional exits from selections. (#1850) 2018-08-20 dnovillo@google.com Ignore *.pyc files in git commands. 2018-08-17 dnovillo@google.com Add testing framework for tools. 2018-08-15 dj2@everburning.com Add GN rules to build spriv-as (#1842) 2018-08-15 31666470+s-perron@users.noreply.github.com Change when instruction is registered in validator. (#1840) 2018-08-15 31666470+s-perron@users.noreply.github.com Keep decorations when replacing loads in access-chain-convert. (#1829) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@47ee776a2c56 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I8a33db138f16b119e375ac66058517f926896568 Reviewed-on: https://chromium-review.googlesource.com/1190103Reviewed-by:
spirv-chromium-autoroll <spirv-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: spirv-chromium-autoroll <spirv-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586271}
-
Marc Treib authored
There are multiple reports of these DCHECKs triggering. To unblock other developers, let's disable them for now, and also add some logging to help debug what causes this. Bug: 872360 Change-Id: I3cc0898adab9e3e81bb56c3deeeeeb4e1629669c Reviewed-on: https://chromium-review.googlesource.com/1189923Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#586270}
-
Etienne Bergeron authored
This CL is adding the average disk usage (bytes transfered by seconds) to base::process_metrics. This metric is sampled by the performance monitor every 2 minutes and an UMA metric (e.g. PerformanceMonitor.AverageDisk.BrowserProcess) is produced. The current implementation is only working for windows. Other platforms need to implement |GetCumulativeDiskUsage|. The purpose of this metric is to allow adding slow-report triggers based on disk usage. R=fdoray, gab, oysteine Bug: 872900 Change-Id: I168a066cf5ebb3b0e879f8bbc5cc73740de1e938 Reviewed-on: https://chromium-review.googlesource.com/1174904 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#586269}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e00fe30b8fe7..adb4bfef0cd8 git log e00fe30b8fe7..adb4bfef0cd8 --date=short --no-merges --format='%ad %ae %s' 2018-08-27 egdaniel@google.com A bunch of fixes for calling abandon on vulkan context. Created with: gclient setdep -r src/third_party/skia@adb4bfef0cd8 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: If132ff66acd9758675b99d61121819626c04eac0 Reviewed-on: https://chromium-review.googlesource.com/1190104Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586268}
-
Anders Hartvoll Ruud authored
It is not spec'ed anywhere that <image> values interpolate in this way. They should however interpolate as gradients, but we don't have an InterpolationType for that yet. R=flackr@chromium.org Bug: 641877 Change-Id: I1a554d578c505f228f728ad7e09c3d5b4e5117e7 Reviewed-on: https://chromium-review.googlesource.com/1186416Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#586267}
-
manuk authored
This cl removes horizontal white-space between adjacent page actions' hover circles. White-space will remain between the icons visually, as the icons are smaller than their hover circles. Padding between the page actions and the location bar remains unchanged. This only affects material refresh and touchable material refresh. Bug: 866191 Change-Id: I8b48256a068fc5078c6c4bcb558ab9cd68763e91 Reviewed-on: https://chromium-review.googlesource.com/1185531 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#586266}
-
Markus Heintz authored
This reverts commit caf38a10. Reason for revert: Finit identified this CL as reason for breaking cronet_tests: - cronet_tests failing on chromium.mac/Mac10.13 Tests (dbg) - cronet_tests failing on chromium.linux/Linux Tests (dbg)(1) - cronet_tests failing on chromium.linux/Linux Tests (dbg)(1)(32) e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/74010 Original change's description: > cronet: Add ScopedTaskEnvironment to native tests. > > This is needed to fix cronet_unittests_android on the > android_cronet_tester bot after https://crrev.com/c/1187783. > > TBR=mef > > Bug: 877868, 875486 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester > Change-Id: If59e993e3e6b19cb54f04c2259014c34d6ad4592 > Reviewed-on: https://chromium-review.googlesource.com/1189712 > Reviewed-by: Victor Costan <pwnall@chromium.org> > Commit-Queue: Victor Costan <pwnall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#586221} TBR=wez@chromium.org,mef@chromium.org,pwnall@chromium.org Change-Id: Id1975c8bec0d0c863bbc36c23516e0c1cdc47ace No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 877868, 875486 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester Reviewed-on: https://chromium-review.googlesource.com/1190622Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Commit-Queue: Markus Heintz <markusheintz@chromium.org> Cr-Commit-Position: refs/heads/master@{#586265}
-
Koji Ishii authored
As we found SkPaint::getTextWidths has rather high entry cost, HarfBuzz has added a function to batch the call in [1]. This patch supports the batch function in HarfBuzzFace. blink_perf.layout (Legacy): 3-25% improvements in 10 tests. https://pinpoint-dot-chromeperf.appspot.com/job/137a7165640000 blink_perf.layout (LayoutNG): 3-40% improvements in 20 tests. https://pinpoint-dot-chromeperf.appspot.com/job/111903c5640000 [1] https://github.com/harfbuzz/harfbuzz/commit/79e21984b13bdb879f3007ba9a97fde47df340d3 Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I04f839526cd35876996b679971d49a99e47ae46c Reviewed-on: https://chromium-review.googlesource.com/1158671Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#586264}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 45ff1e77. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23500 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org: external/wpt/compat rego@igalia.com: external/wpt/css/selectors NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: Ic7b6110dd9c9bc9d872e048ffb2c9ebbc5ece47c Reviewed-on: https://chromium-review.googlesource.com/1190123 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#586263}
-
David Benjamin authored
The spec says the body is a NULL, so we should enforce it. Otherwise implementations may accidentally produce certificates that get this wrong, and then other consumers will need to mimic our laxness. https://tools.ietf.org/html/draft-iab-protocol-maintenance-00 Bug: 851778 Change-Id: I0bcfd076d94743ab285ce0a6938182b9a32b0e36 Reviewed-on: https://chromium-review.googlesource.com/1189061 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#586262}
-
Koji Ishii authored
fast/table/column-in-inline.html says it tests "a table-column with a table-cell sibling are wrapped inside an inline-table when the parent is inline" but it also tests: 1. Anonymous inline box inherits non-inherited properties, which contradicts with the spec (crbug.com/877946). 2. If the above was fixed, it tests baseline alignment of inline tables. LayoutNG fails because it does not have crbug.com/877946. This patch changes the test to focus on what it says, and creates a separate test for crbug.com/869877. Bug: 869877, 877946 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I0b53ec68d5ea59a93010d49891d6bfe3a6688158 Reviewed-on: https://chromium-review.googlesource.com/1179736Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#586261}
-
Steven Valdez authored
Bug: boringssl:226 Change-Id: I9541ae612322776a7ccddd8e163ab3025dba1e7a Reviewed-on: https://chromium-review.googlesource.com/1188849Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#586260}
-