- 16 Apr, 2018 40 commits
-
-
Francois Doray authored
TaskPriority::BACKGROUND tasks can take "an arbitrarily long time to complete". https://cs.chromium.org/chromium/src/base/task_scheduler/task_traits.h?l=26&rcl=19a69a1389844f51c474efa446e3f22dd1fb36a8 We have plan to restrict more aggressively when they can run. To make sure that this doesn't introduce unwanted performance regressions, we need to make sure that there is no need to run TaskPriority::BACKGROUND tasks to respond to user actions. This CL adds a browser test to verify that the first non-empty paint can happen when no TaskPriority::BACKGROUND tasks are allowed to run. Bug: 831835 Change-Id: I4c5d4f1056d823a6c36aa1504e2508d1bc1c58b6 Reviewed-on: https://chromium-review.googlesource.com/1008640Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#550973}
-
Roman Sorokin authored
We will use for Active Directory machine names. Admins would be able to set regex that machine names should match. BUG=chromium:829361 TEST=manual Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie51ec988639ebcb2bee2dad5a117babe5f2bda84 Reviewed-on: https://chromium-review.googlesource.com/1004588Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550972}
-
Maxim Kolosovskiy authored
The masks will be used for better credentials filling and password generation classifiers Before this CL, properties mask were uploading only in Dev and Canary. Bug: 552420 Change-Id: Ia382ef21146b2aeb22ccd15859700f9b74a91602 Reviewed-on: https://chromium-review.googlesource.com/1012072Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#550971}
-
Boris Sazonov authored
This CL updates the animation that is shown at the top of the sign-in screen: 1. The drawable is no longer scaled to match the screen width. 2. All clouds are animated now. 3. Existing animations have been changed to have a shorter time period. 4. android:strokeLineJoin and android:strokeLineCap are removed from most paths. 5. Background fill is removed from the vector drawable and specified as background color for the ImageView that displays the drawable. Bug: 814728 Change-Id: I893fae85c81c024fee44eb850813306af754886d Reviewed-on: https://chromium-review.googlesource.com/1012107Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#550970}
-
Julian Pastarmov authored
BUG=808359 Change-Id: Ia95a6f90086f0aa8ea62e81838f1ae95c7c6496c Reviewed-on: https://chromium-review.googlesource.com/1012065Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#550969}
-
Ramin Halavati authored
Bug: 833185 Change-Id: Ic8afceca1239bc3b6f696765dcb0b93b806973da TBR: kenrb@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1013565Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#550968}
-
Ramin Halavati authored
Bug: 819696 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I155d56db5f80d08ab15e836ef08d08b5ead0932e TBR: dtseng@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1014084Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#550967}
-
Ramin Halavati authored
BUG=775534 NOTRY=true TBR=steimel@chromium.org Change-Id: I394ae0de8d4701e34baac9b4e643558935bd6efb Reviewed-on: https://chromium-review.googlesource.com/1014104 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#550966}
-
Ramin Halavati authored
TBR=aboxhall@chromium.org Bug: 833318 Change-Id: Ib29dc8185241c394bb6e7f6f4dea7d0f9f7beea9 Reviewed-on: https://chromium-review.googlesource.com/1014080Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#550965}
-
Andrew Grieve authored
"Address" column was changed to VMA / LMA. TBR=huangs NOTRY=true NOPRESUBMIT=true Bug: 833343 Change-Id: I2bacc49626794ae07fd9d02258e87a5620618cb1 Reviewed-on: https://chromium-review.googlesource.com/1014001 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#550964}
-
Ramin Halavati authored
Bug: 833028 Change-Id: Ie4d60d122f5403f735d8f5a0d9fe45f35f1e13c5 TBR: chrisha@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1014100Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#550963}
-
yoshiki iguchi authored
Bug: 826612 Change-Id: Ie2c5cf4266cf38fcfa12c3cb6ec432fc73a841e2 Reviewed-on: https://chromium-review.googlesource.com/992254 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#550962}
-
Marc Treib authored
This removes features::kSupervisedUserCreation and a bunch of now-dead code. There's lots more, but this is plenty for one CL. Bug: 828890 Change-Id: I2793654046a71104b153e5808fe97a2c4151ad12 Reviewed-on: https://chromium-review.googlesource.com/996072 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#550961}
-
Marc Treib authored
- Use BindOnce/BindRepeating instead of plain Bind - Remove unused enum entries - Use range-based for loops Bug: none Change-Id: Ife423c425d2c6f3fff05869536af67042b9c8809 Reviewed-on: https://chromium-review.googlesource.com/998353 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#550960}
-
Andrew Grieve authored
This allows the optimization to be enabled when using custom proguard versions. With our current version of ProGuard (5.2.1), it can cause VerifyErrors at runtime (see PS1 trybot failures). Note that when the pass is enabled, I'm seeing: Shrinks monochrome_apk dex by 53kb uncompressed, 17kb compressed. Shrinks method_count by 1400. Bug: 620323, 825995 Change-Id: I08146a8a84d4f466ed91834728914aa116bca7a5 Reviewed-on: https://chromium-review.googlesource.com/986532Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#550959}
-
Matt Falkenhagen authored
SharedWorkerHost was calling WorkedDestroyed at three callsites using two flags to determine when to do so. Use a RAII helper class to manage the state instead. One motiviation is fixing 830288 which is going to add more state to SharedWorkerHost (creating a host before calling start), so when to call WorkerDestroyed would get more complicated. Bug: 830288 Change-Id: Ie3f135d925091518b172a4afcd8c475656aa9db4 Reviewed-on: https://chromium-review.googlesource.com/1013360Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#550958}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ddfc6de6..05254515 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I428a80d5d01a39be3356c01d28bf1f3ba8f9925a Reviewed-on: https://chromium-review.googlesource.com/1013744Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#550957}
-
Christopher Lam authored
See go/closure-compile-gn for details. This CL converts the Closure Compilation from GYP to GN for the following: - cryptotoken - download_internals - md_downloads - md_extensions - md_history - md_user_manager - offline_pages - signin - webapks - welcome A local closure compile can be run by setting closure_compile = true in args.gn, and then running ninja -C out/Default webui_closure_compile. Individual projects can be compiled via, for example, ninja -C out/Default chrome/browser/resources/md_extensions:closure_compile Bug: 632206 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I401fc54ee6c5202bd27855ba28d886677e52210e Reviewed-on: https://chromium-review.googlesource.com/954772 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#550956}
-
Friedrich Horschig authored
Right now, clicking the X button in the search will close it. To start a new search, you have to open a new search. That experience isn't very discoverable, so UX developed an improved workflow - details in the bug. The new flow needs these changes: - the X button _only_ clears the query text field now - the X button is _only_ available when a query was entered - closing the search happens only via the "navigate up" button in the action bar. - the three-dots overflow menu is hidden while a search is active (already the case on small screens - now large screens do the same) Tests cover all of these cases. Bug: 821755 Change-Id: Ieb2e16c096750d66874aa4c4999759629332491b Reviewed-on: https://chromium-review.googlesource.com/966070Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#550955}
-
jdoerrie authored
This change fixes a subtle bug in TestCallbackReceiver, renames StatusCallbackReceiver to ValueCallbackReceiver and adds usages where appropriate. Bug: 785955, 799044 Change-Id: Iac686ec59c48e33d75155e67d615a6bdb4c042a0 Reviewed-on: https://chromium-review.googlesource.com/1009744 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#550954}
-
Gauthier Ambard authored
This CL fixes the navigation using the popup menu. The navigation was crashing because the command protocol is only implemented by the legacy class. Bug: 833120 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I31268facd31c035a4bb0ff72d6d235f9789a8d14 Reviewed-on: https://chromium-review.googlesource.com/1013977Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#550953}
-
Marc Treib authored
Bug: 825190 Change-Id: I166418dc7691b572abdee1f337c938528142efca Reviewed-on: https://chromium-review.googlesource.com/1007236 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#550952}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1f02393d. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15649 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley No-Export: true Change-Id: Ifee54a7711ff1d23672c801c7fbd8ca5894ea642 Reviewed-on: https://chromium-review.googlesource.com/1013742 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#550951}
-
Joone Hur authored
When the build flag enable_native_notifications = false, a build error happens. This CL adds ENABLE_NATIVE_NOTIFICATIONS guard to fix this problem. Bug: None Change-Id: I2ab67b9f41898404eb3096f25c6dbd9ac31b7255 Reviewed-on: https://chromium-review.googlesource.com/1012728Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Joone Hur <joone.hur@intel.com> Cr-Commit-Position: refs/heads/master@{#550950}
-
Matt Falkenhagen authored
The strings just get converted to URLs. Simpler to just use URLs directly. More cleanup for the linked bug in preparation for more unit tests. Bug: 830288 Change-Id: Ie467b841ee8c07a2bf22c26d4151c1711943f69f Reviewed-on: https://chromium-review.googlesource.com/1013022Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#550949}
-
Alan Cutter authored
This CL cleans up the LocationBar interface. LocationBar::ShowPageInfoDialog() was only ever used with the LocationBarView implementation of LocationBar and can be removed from the higher level interface. There are no behavioural changes in this CL. Bug: 828278 Change-Id: Ied8af6849f16bda72bb89c7f5fcffdfd599adcbe Reviewed-on: https://chromium-review.googlesource.com/1011884 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#550948}
-
Hiroki Nakagawa authored
This test was fixed by https://chromium-review.googlesource.com/c/chromium/src/+/985334 Bug: 825740 Change-Id: I5c732d2aa828ccecbe1f39ea79f168ee798521bb TBR: nhiroki@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1013818 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#550947}
-
Philipp Hancke authored
and remove the class from any past ones. Re-land of https://chromium-review.googlesource.com/c/chromium/src/+/615500 (with JS error fixed) BUG=678292 Change-Id: Icedc03ed30e2f4c0d36341db371ef3d12a679a94 Reviewed-on: https://chromium-review.googlesource.com/986139Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#550946}
-
Fergal Daly authored
Looks like there is no way to set the title explicitly, it just comes from the first section name. Change-Id: Ie7b451aeb212576df09f1e2da77b9f5e1141dc9d Reviewed-on: https://chromium-review.googlesource.com/1013667Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#550945}
-
Blake O'Hare authored
This reverts commit 4204e85d. Reason for revert: Multiple people are noticing the following fatal error on startup. It's preventing Chrome OS from starting (noticed on an Eve and a Cyan). Testing with and without this change indicates that this CL is the cause: [5643:5757:0416/141408.095095:ERROR:bus.cc(551)] Failed to get the ownership of org.chromium.UrlHandlerService: Connection ":1.102" is not allowed to own the service "org.chromium.UrlHandlerService" due to security policies in the configuration file [5643:5643:0416/141408.181175:FATAL:cros_dbus_service.cc(77)] Failed to own: org.chromium.UrlHandlerService Original change's description: > Add ash D-Bus framework & service for opening URLs with Chrome > > This adds a small D-Bus service framework to ash and then adds an > initial service that has one call "OpenUrl" which will then > open a new tab in Chrome with that URL. This is intended to be used by > Chrome OS clients that want to open a URL with Chrome; initial usage > will be from VMs. > > Bug: 822496 > Bug: 831333 > Test: Verified with dbus-send that links open properly > Change-Id: I648af624817cd387f30aba751c7f465e0dcc60e0 > Reviewed-on: https://chromium-review.googlesource.com/998081 > Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> > Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> > Reviewed-by: Dan Erat <derat@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550900} TBR=derat@chromium.org,xiyuan@chromium.org,hashimoto@chromium.org,stevenjb@chromium.org,sky@chromium.org,jorgelo@chromium.org,benwells@chromium.org,mnissler@chromium.org,dominickn@chromium.org,jkardatzke@google.com,mkwst@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 822496, 831333 Change-Id: Ie7ea0e469116c7b1968cf929c378d9bceaeb9e1d Reviewed-on: https://chromium-review.googlesource.com/1013799Reviewed-by:
Blake O'Hare <blakeo@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Blake O'Hare <blakeo@chromium.org> Cr-Commit-Position: refs/heads/master@{#550944}
-
Luciano Pacheco authored
This fixes a "ghost" focus, where the tab puts the focus on the content panel/div and there isn't any visual clue about it. I tested screen reader/Chromevox and it wasn't reading anything when content panel/div was focused, also it doesn't seem necessary for any keyboard event handling, so it seems safe to remove and not have focus on this element. Bug: 779044 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0453792d1aa33918773f982944fc7358bece8587 Reviewed-on: https://chromium-review.googlesource.com/1004889Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#550943}
-
https://pdfium.googlesource.com/pdfium.git/+log/b71d24c1affe..d5624a47bcaa $ git log b71d24c1a..d5624a47b --date=short --no-merges --format='%ad %ae %s' 2018-04-16 stackexploit Fix UAF in CFGAS_FontMgr::FindFont Created with: roll-dep src/third_party/pdfium BUG=chromium:832589 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ia438998e67a9a01581120da381761354ad454962 Reviewed-on: https://chromium-review.googlesource.com/1012725 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550942}
-
Matt Falkenhagen authored
These will be useful for planned unit tests for SharedWorkerHost which will be in its own test file. Also: * Add missing EXPECT_TRUE for some Check*() calls, which return a bool. * Remove calls to deprecated RunAllPendingInMessageLoop(). * Change some CHECK to DCHECK and rm unneeded includes. Bug: 830288 Change-Id: I3f7ed117fdde4d859047f6e95b5080119857daec Reviewed-on: https://chromium-review.googlesource.com/1013817 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#550941}
-
Hajime Hoshi authored
This is a remaining task from https://chromium-review.googlesource.com/c/chromium/src/+/1009448 We plan to eliminate kUnthrottled, kUnspecedTimer and kUnspecedLoading and replace them with appropriate kInternal* task types. Bug: 830489 Change-Id: Iefa7d73db427177eab41481a396be7aa42fbf230 Reviewed-on: https://chromium-review.googlesource.com/1012042Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#550940}
-
Hajime Hoshi authored
We plan to eliminate kUnthrottled, kUnspecedTimer and kUnspecedLoading and replace them with appropriate kInternal* task types. Bug: 830489 Change-Id: Ib390ab3a726e1a825aa81d0c76e972f455c31ca4 Reviewed-on: https://chromium-review.googlesource.com/1013499 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#550939}
-
Alan Cutter authored
This CL fixes undesirably large insets on the hosted app menu button that get set when command line flags "--top-chrome-md=material-touch-optimized --enable-features=SecondaryUiMd" are used on chromeOS causing the menu icon to get cropped. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=334387&signed_aid=zaosvDPanfssI1aE7ljaww==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=334388&signed_aid=sVoIaJthm75DLZgxqr06fA==&inline=1 Bug: 831968 Change-Id: I20bcc33aef41a0e0872170e7751502936c63ded4 Reviewed-on: https://chromium-review.googlesource.com/1011922 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#550938}
-
Noel Gordon authored
One part of solving the issue at hand was to examine the call order of the browser test setup routines. Moreover setup routines should prefer CHECK (fail fast with a stack trace). SetUpCommandLine happens just after SetUp: move them together, and put them in call-order. SetUpOnMainThread happens just before StartTest, so move them together similarly. SetUpOnMainThread needs a Profile to work at all. Add CHECK (to make that need somewhat clearer), and prefer CHECK in this routine body in general (it's a setup routine). StartTest is called right after SetUpOnMainThread: every test resource needed for testing is (or should be) ready at that time. Add LOG(INFO) here to show when StartTest is called, relative all other LOG tracing, since any test-related output that appears before this point indicates that "things have gone horribly wrong". Bug: 831074 Change-Id: I725413ad53592cb430ecf669e7ad2c50fdddead4 Reviewed-on: https://chromium-review.googlesource.com/1013838 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Tomasz Mikolajewski <mtomasz@chromium.org> Cr-Commit-Position: refs/heads/master@{#550937}
-
yoshiki iguchi authored
Bug: none Test: none Change-Id: I82e9024750d40c520f8ff468454dc4a9b001b027 Reviewed-on: https://chromium-review.googlesource.com/1004976Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#550936}
-
Patti authored
This patch removes the 1px outline on LocationBarView and switches to using a views::FocusRing in touch mode. See screenshots - https://drive.google.com/file/d/1g4O_mh4oPb8PJIAb7pjDq0rK32KIUUvP/view?usp=sharing Bug: 801583, 829574 Change-Id: I6498ff15d3b1be6a03cab92e9aae8971b54c358e Reviewed-on: https://chromium-review.googlesource.com/1002716 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#550935}
-
https://chromium.googlesource.com/catapult.git/+log/f718fb12b8cf..ac39bc379194 $ git log f718fb12b..ac39bc379 --date=short --no-merges --format='%ad %ae %s' 2018-04-11 dtu [pinpoint] Add `isolate_server` argument. 2018-04-11 dtu [pinpoint] Add `swarming_server` argument. 2018-04-10 dtu [pinpoint] Include error message in bug comment. Created with: roll-dep src/third_party/catapult BUG=chromium:822008,chromium:822008 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I0203fc0ce59468f36ac6f5ef29258985aa74d47c Reviewed-on: https://chromium-review.googlesource.com/1013232Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550934}
-