- 14 Apr, 2019 30 commits
-
-
Yi Gu authored
The test used to be a ref test but upon upstreaming to wpt it was updated to a non-ref test. Change-Id: I9a7d793698e7abae540ecbc92e3c293ac7195e45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557855Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#650657}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7f0bc5198bc4..4a25289fb7d8 Created with: gclient setdep -r src-internal@4a25289fb7d8 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@chromium.org,andypaicu@chromium.org,aboxhall@chromium.org,caseq@chromium.org Change-Id: Ie2ed7602e3eb094010904f3cf968c75d20eb147d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567106Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#650656}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b4de6148cce5..7f0bc5198bc4 Created with: gclient setdep -r src-internal@7f0bc5198bc4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@chromium.org,andypaicu@chromium.org,aboxhall@chromium.org,caseq@chromium.org Change-Id: Ib176600d53caab69404ad8294d70f878bc6e59f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567213Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I4457bcad81ea89746d152462637544127f20f324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567211Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#650654}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b9da3297a28a..b4de6148cce5 Created with: gclient setdep -r src-internal@b4de6148cce5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@chromium.org,andypaicu@chromium.org,aboxhall@chromium.org,caseq@chromium.org Change-Id: Iab2c1eec2ef6f2ee6941c4c871c7f5f99ccc2cb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567212Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5f2392adbfad..b9da3297a28a Created with: gclient setdep -r src-internal@b9da3297a28a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@chromium.org,andypaicu@chromium.org,aboxhall@chromium.org,caseq@chromium.org Change-Id: I2f5c933d876a468b2e930f1d29eb5d210a1212a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567210Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5c6b565bdfb9..b5e57e9a3d0f git log 5c6b565bdfb9..b5e57e9a3d0f --date=short --no-merges --format='%ad %ae %s' 2019-04-14 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version Created with: gclient setdep -r src/third_party/skia@b5e57e9a3d0f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: I45c3b4cba5848437e7bbad8400bd2803a00c41ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565369Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/62fa8eebd035..5f2392adbfad Created with: gclient setdep -r src-internal@5f2392adbfad The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@chromium.org,andypaicu@chromium.org,aboxhall@chromium.org,caseq@chromium.org Change-Id: I9ea78eaf34dc55f7ec389b63f423910b7150d027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565368Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/386dad2493cf..62fa8eebd035 Created with: gclient setdep -r src-internal@62fa8eebd035 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@chromium.org,andypaicu@chromium.org,aboxhall@chromium.org,caseq@chromium.org Change-Id: Iff6e67afa21f6cde03b4ec75d1d42c5beb6e8a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565367Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/12cf258193dc..5c6b565bdfb9 git log 12cf258193dc..5c6b565bdfb9 --date=short --no-merges --format='%ad %ae %s' 2019-04-14 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@5c6b565bdfb9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: I69e35c1612fb9df3977b6fe68b8d57ff4a327b2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565366Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d7ba750e8dd8..0d4500b93834 git log d7ba750e8dd8..0d4500b93834 --date=short --no-merges --format='%ad %ae %s' 2019-04-14 dhanyaganesh@chromium.org auth.py: Stop printing the command every time 2019-04-14 dhanyaganesh@chromium.org buildbucket_v2: Retry on SSLError Created with: gclient setdep -r src/third_party/chromite@0d4500b93834 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I36e4db7c4af9872d5a31d6ab22205eda9d754831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565365Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/79e9f4b9c128..30f36af455fa git log 79e9f4b9c128..30f36af455fa --date=short --no-merges --format='%ad %ae %s' 2019-04-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 8b06d91a..1a9381db (650536:650638) Created with: gclient setdep -r src/third_party/webrtc@30f36af455fa The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ief0b9f30b2c904084f71f3c29693200ef3c1a234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565364Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4f62e7ac6bde..386dad2493cf Created with: gclient setdep -r src-internal@386dad2493cf The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@chromium.org,andypaicu@chromium.org,aboxhall@chromium.org,caseq@chromium.org Change-Id: I72256c095fd98fd32e22a199a9dff47a4d68688a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565363Reviewed-by:
-
Mei Liang authored
This CL fixes some closing tab behavior: 1. Reset strip/grid sheet when closing a group 2. Update the tab grid sheet title after tab is removed in TabGroupModelFilter 2. Close app when closing the very last tab in Chrome when using the TabGroup UI. Bug: 948527 Change-Id: Ic112475baf6cd718901d0c06019af134573d8cd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564883 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#650644}
-
Mei Liang authored
Bug: 951436 Change-Id: I88aaa98ddb82103eea0920adc830bdbe6f06e551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564351Reviewed-by:
-
Robert Ogden authored
GetNewPageId() is only called in one place now, GetOrCreateSLPInfo, and this value is used for all restarted navigations, persisted by the Info. Bug: 952523 Change-Id: Id9cdc8aead427c6cfefabd195db10ed251c6f787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567101Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#650642}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2221eb4885ad..4f62e7ac6bde Created with: gclient setdep -r src-internal@4f62e7ac6bde The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@chromium.org,andypaicu@chromium.org,aboxhall@chromium.org,caseq@chromium.org Change-Id: Ib9f045be36109d0bf752fb1b52400a8683631066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566484Reviewed-by:
-
Adam Langley authored
This change causes the human-readable form of the CBOR errors to be included in log messages and also logs messages from parse errors in GetInfo requests (which are handled differently). This would have been helpful when figuring out why the Solo Key wasn't working as a CTAP2 device. Change-Id: I11f241a740a50a4f0b1edb45e4d535a193561a93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565088 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#650640}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Id6df0fc1f882b0c27b553836538e6856618e8e61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566483Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d3b72ea43c8a..2221eb4885ad Created with: gclient setdep -r src-internal@2221eb4885ad The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@chromium.org,andypaicu@chromium.org,aboxhall@chromium.org,caseq@chromium.org Change-Id: I83b7065ed311befae1f6ed948bc56d727808c340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566979Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I1c2979a8ea0945b9d392fd3d1a3d6512c056f790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566814Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#650637}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1f05aec37ff8..d7ba750e8dd8 git log 1f05aec37ff8..d7ba750e8dd8 --date=short --no-merges --format='%ad %ae %s' 2019-04-14 dhanyaganesh@chromium.org Migrate from CIDB to Buildbucket for read ops Created with: gclient setdep -r src/third_party/chromite@d7ba750e8dd8 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I5447c51a5127334d19b0575eeae2be955d84425c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567066Reviewed-by:
-
Robert Ogden authored
This test is long overdue. There's a couple of early returns which I'll remove as the bugs are fixed. Bug: 952523 Change-Id: I81d945c168e25a12b661191435300436fdcd2154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567096Reviewed-by:
-
Adam Langley authored
In addition to canceling operations at the device level, we also need to ensure that higher-level tasks stop creating new requests once canceled. This change is most evident when a Webauthn request results in an error (for example, because a credential isn't recognised). Previously, U2F authenticators would still flash. Now they'll stop within a few seconds. Also, in the request handlers, ensure that state changes are performed before cancelations in case the act of canceling triggers immediate callbacks. This is a preventative measure. Change-Id: I950ea9e705126d6ef1ea340000fe34090661c951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560512 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3fd871d1fa0a..d3b72ea43c8a Created with: gclient setdep -r src-internal@d3b72ea43c8a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@chromium.org,andypaicu@chromium.org,aboxhall@chromium.org,caseq@chromium.org Change-Id: I6617de58444e194d81de8b21a17e782bcf320246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565785Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b9d6ee1fce0c..1f05aec37ff8 git log b9d6ee1fce0c..1f05aec37ff8 --date=short --no-merges --format='%ad %ae %s' 2019-04-14 dhanyaganesh@chromium.org BuildStore: Separate the values in StageFailure initialization Created with: gclient setdep -r src/third_party/chromite@1f05aec37ff8 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Ib3c438bf1e92a70c67f100c6b8cacab7aa5f858a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567064Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/33233a09fef8..12cf258193dc git log 33233a09fef8..12cf258193dc --date=short --no-merges --format='%ad %ae %s' 2019-04-14 herb@google.com Revert "Convert the CPU mask case to use prepareForDrawing" Created with: gclient setdep -r src/third_party/skia@12cf258193dc The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: I7fa9f0225d4b4270ff30813e7c1eb10c5e3d9615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565786Reviewed-by:
-
John Williams authored
Change-Id: I6dd462281b83f0935b8e6af3a9b9a8d2605d5e44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554249 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#650630}
-
Adam Langley authored
Change-Id: Ibf22af9d53824ecc1762492543ed505898dc0e28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560511 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/24fcaccc2247..3fd871d1fa0a Created with: gclient setdep -r src-internal@3fd871d1fa0a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@chromium.org,andypaicu@chromium.org,aboxhall@chromium.org,caseq@chromium.org Change-Id: Idde2d1920a22b8b33d1998c9b0e45372b905fbaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565784Reviewed-by:
-
- 13 Apr, 2019 10 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/beea825f7b47..24fcaccc2247 Created with: gclient setdep -r src-internal@24fcaccc2247 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@chromium.org,andypaicu@chromium.org,aboxhall@chromium.org,caseq@chromium.org Change-Id: Idc8f3b90754d5d338f9d363f2c51e9e484665ed3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565640Reviewed-by:
-
Matthew Mourgos authored
AddPreTargetHandler() is called every time the app list is opened from closed state, but RemovePreTargetHandler() is called in the destructor which is not called when the app list is closed. This change properly calls RemovePreTargetHandler() when the app list is closed. Change-Id: Ic6f2556a3dabab43a7a7d2b63e81814b31058d60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566478 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#650626}
-
Adam Langley authored
Add warning message to UI when creating resident credentials as these credentials may have privacy implications. Also fix the oddity (and todo) that the RP ID for a request was passed via the transport observer, and didn't come from |AuthenticatorImpl|. Bug: 941120 Change-Id: Ib1d370d56c70dabdf69a94e4e472ed3addcfa900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559769 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
This reverts commit cbdaf211. Reason for revert: Crash data already collected in 3763 and 3764 Original change's description: > Reland "[LayoutNG] Turn AssertLaidOut into a CHECK for LayoutNG" round 3 > > This reverts commit 33b5c673. > > Reason for revert: Adding production CHECKs to collect LayoutNG failures > for the 3rd time. > > Original change's description: > > Revert "Reland "[LayoutNG] Turn AssertLaidOut into a CHECK for LayoutNG"" > > > > This reverts commit 26ca019a. > > > > Reason for revert: Crash data already collected > > > > Original change's description: > > > Reland "[LayoutNG] Turn AssertLaidOut into a CHECK for LayoutNG" > > > > > > This reverts commit ec11fe81. > > > > > > Reason for revert: Try to catch more crashes in the wild after > > > a fix (crrev.com/c/1546713) has been landed. > > > > > > Original change's description: > > > > Revert "[LayoutNG] Turn AssertLaidOut into a CHECK for LayoutNG" > > > > > > > > This reverts commit bade42c5. > > > > > > > > Reason for revert: New crashes already caught. Reverting CHECKs > > > > back into DCHECKs to reduce noises. > > > > > > > > Original change's description: > > > > > [LayoutNG] Turn AssertLaidOut into a CHECK for LayoutNG > > > > > > > > > > Bug: 946004 > > > > > Change-Id: I9e2aa69a32f7a0373196d57e629256dbc7d78d2a > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540305 > > > > > Reviewed-by: Koji Ishii <kojii@chromium.org> > > > > > Reviewed-by: Emil A Eklund <eae@chromium.org> > > > > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > > > > > Cr-Commit-Position: refs/heads/master@{#644907} > > > > > > > > TBR=eae@chromium.org,kojii@chromium.org,xiaochengh@chromium.org > > > > > > > > Change-Id: I15fb43370f58757e09e7b7abc7c40d4af4a6101a > > > > No-Presubmit: true > > > > No-Tree-Checks: true > > > > No-Try: true > > > > Bug: 946004 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544156 > > > > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > > > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#645407} > > > > > > TBR=eae@chromium.org,kojii@chromium.org,xiaochengh@chromium.org > > > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > > > Bug: 946004 > > > Change-Id: Iccb8c2b998d28f659381c3f89a1686614600860c > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548248 > > > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#646516} > > > > TBR=eae@chromium.org,kojii@chromium.org,xiaochengh@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 946004 > > Change-Id: I9794539b39bc6a0053a7229b03bce7db402ecb5b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551440 > > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#647418} > > TBR=eae@chromium.org,kojii@chromium.org,xiaochengh@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 946004 > Change-Id: I973ccf65be78d4632f67b945614f1a4ee091134d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562500 > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#649773} TBR=eae@chromium.org,kojii@chromium.org,xiaochengh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 946004 Change-Id: If61d1cbfaeb6a445b8ceee193dba198978d2719c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567130Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#650624}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/869ed03f2b53..beea825f7b47 Created with: gclient setdep -r src-internal@beea825f7b47 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@chromium.org,andypaicu@chromium.org,aboxhall@chromium.org,caseq@chromium.org Change-Id: Iaddc44e30d8ccf9da8607eaf98875d806d20d2f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566554Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I2dc4b5ffe2d87a9e02fd0171ff73087302f213a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565639Reviewed-by:
-
Findit authored
This reverts commit d4a2bb57. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 650550 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZDRhMmJiNTc1N2YyMTNlNjhiMDFkMDMwYjEwOTM1YjFkNjQ3MzRhMAw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/32724 Sample Failed Step: browser_tests Sample Flaky Test: LoginTest.GaiaAuthOffline Original change's description: > Chrome OS: Fix and re-enable LoginTest.GaiaAuthOffline test. > > Bug: 692364 > > Change-Id: Ib42c71c66094088d4c0644ba3b151700e110351f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565710 > Commit-Queue: Alexander Alekseev <alemate@chromium.org> > Reviewed-by: Toni Baržić <tbarzic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#650550} Change-Id: I61dc50f4cc301438970d66f41555ed81e0cdf7b0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 692364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567093 Cr-Commit-Position: refs/heads/master@{#650621}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aad76fe386c5..869ed03f2b53 Created with: gclient setdep -r src-internal@869ed03f2b53 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@chromium.org,andypaicu@chromium.org,aboxhall@chromium.org,caseq@chromium.org Change-Id: Iffcc0f4198a7bcd49a2df8b301d703f60b87c0a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565638Reviewed-by:
-
Charlie Reis authored
CL adapted from clamy@'s https://crrev.com/c/1565876. This is a partial revert of r638122 and r642275, plus a new test. This CL fixes a process leak that happens in navigations where the current renderer process is not live (crashed process or NTP). The mechanism is the following: 1) We want to navigate to a page in a FrameTreeNode where the current RFH is not live. This RFH has a SiteInstance with id 1, and a process with id 1. 2) We create a NavigationRequest, which takes as its starting SiteInstance the SiteInstance with id 1. 3) We call into RenderFrameHostManager::GetFrameHostForNavigation. It creates a speculative RFH, with a new SiteInstance with id 2, and a process with id 2. It commits this RFH immediately, since the current one is not live. This has the side effect of deleting process 1, however it does not delete SiteInstance 1 since it is referenced by the NavigationRequest. So SiteInstance 1 ends up associated with no RFH, and has no process either. 4) We create the NavigationHandle and call DidStartNavigation. One of the WebContentsObservers accesses NavigationHandle::GetStartingSiteInstance (which is SiteInstance 1), and asks it for its process (https://cs.chromium.org/chromium/src/chrome/browser/safe_browsing/safe_browsing_navigation_observer.cc?type=cs&q=safe_browsing::SafeBrowsingNavigationObserver::DidStartNavigation&g=0&l=185). Because the SiteInstance no longer has a process, we re-create a process with id 3 due to this call. 5) We finish the navigation and delete the last reference to SiteInstance 1. However, this does not delete process 3, which is not referenced anymore, and we leak the process. To fix the issue, this CL makes sure that the starting SiteInstance is captured just before creating the NavigationHandle, which is after a new RFH has been committed to replace the non-live current RFH. This way, the SiteInstance is properly linked to a RFH and it has a RenderProcessHost. Separately, we can ensure that unused processes will be cleaned up if GetProcess() is called unexpectedly. TBR=clamy@chromium.org TBR=jbudorick@chromium.org Bug: 949977 Change-Id: Ia84e238af0036822dd8c4cd47be5b497d0e7be3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566643 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#650619}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3af5c4c3547b..79e9f4b9c128 git log 3af5c4c3547b..79e9f4b9c128 --date=short --no-merges --format='%ad %ae %s' 2019-04-13 yvesg@webrtc.org Replace test::Statistics by webrtc::RunningStatistics. 2019-04-13 benwright@webrtc.org Remove HKDF implementation from WebRTC. 2019-04-13 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9ba7465f..8b06d91a (650428:650536) Created with: gclient setdep -r src/third_party/webrtc@79e9f4b9c128 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2c47a1c8bbc975e1f9ca06aeeccebe81de4f0d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565637Reviewed-by:
-
