- 02 Sep, 2020 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/26983dc7..52fe4c46 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I693c709beb7bd92ea71b4010be6e9db0572e9cb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388483Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803783}
-
Darren Shen authored
We currently uses a special key event struct designed for rule-based. However, we'll be adding a new input engine soon, which requires a more generic physical key event struct. To avoid duplicate code, share the same key event struct for both rule-based and the new input engine. Bug: 146314796 Change-Id: I995e14f9b497fdf52141fbcc9e5bcab0013bf831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371143Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#803782}
-
wutao authored
The new behaviors are: 1. When going to ambient mode page, keep user previous selection or auto-select Art if no album or selected album is deleted. 2. Click Art row will always select Art row. 3. Click any place of `Google Photos' (GP) row, will not change the selection status yet, but goes to the GP album-selection page. When user makes any change on GP album-selection page, we will either select GP row, or fall back to select Art row based on if any albums is available or un/selected. 4. Any actives on the album-selection page without first going to the ambient mode page, will trigger same behaviors as 2 & 3. 5. Click the topic source row and right arrow in that row will behave the same. Bug: b/161928422 Test: modified handler and js tests Change-Id: Id5b33ca9a7cd712c899091796cbab461e9970141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364167 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#803781}
-
Devlin Cronin authored
The feature launched. Remove the flag. Bug: 1100412 Change-Id: I1aebaaae2cfd0fce078075d7ad771810b2f61df8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386846Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#803780}
-
Devlin Cronin authored
A number of tests were running with both the legacy toolbar UI and the new extensions menu UI via test parameters. De-parameterize these, since the new UI has been launched for awhile. Bug: 1100412 Change-Id: Ie74b76b99ebcc553545b18907b2c1adb124e1048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387438 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I3ee09f723d34635a9baa46fe1f5f8ce7c585b276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389057Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803778}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I08656e92d07d07fea18f84f8c28c975068a7c1c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389462Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/05ce2817f2a0..fbcc21f83e83 2020-09-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 0b89b27263b1 to 880013579381 (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: I7e1c902fd120e9ac8a9ba56cff7c58fd55b9d0a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389460Reviewed-by:
-
Peter Kotwicz authored
This CL: Adds to android_apk_or_module() template: - enforce_resource_overlays parameter to indicate that strict resource override checking is desired. The purpose is to enable landing this CL without breaking downstream. Adds to android_resources(): - resource_overlay parameter to indicate that the target overrides another target's resources BUG=1093825 Change-Id: I4229b343654f873c22c3e58bbbfd01209d9c880c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367352 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
benjamin joyce <bjoyce@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#803775}
-
Minoru Chikamune authored
Recent CL (https://crrev.com/c/2383406) made WakeLockTest.LossOfDocumentActivity test flaky. This CL will partially revert the change by using kForceWithoutContextObserver. Bug: 1123879, 1049056 Change-Id: I62fe7d185b857dbfda5b6a8edb5962661dc8c13e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389301Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#803774}
-
Joel Hockey authored
Terminal updated in crrev.com/c/2384669. Bug: 1114542 Change-Id: I467dec67e76d77f956352e8ce2299bfde599f5cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384689Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#803773}
-
Chloe Pelling authored
(Does not apply to ARC++.) Maximizing a window typically resizes it, and resizing a non-resizable window can have undesirable results. This especially affects gaming. For many games, maximizing their "non-resizable" window causes them to render into the lower-left corner of the window but interpret mouse events relative to the top-left corner. This is bad enough on its own. It becomes especially confusing when a game allows the window size to become greater than or equal to the screen size, triggering XdgShellSurface's auto-maximize feature. Fix by disabling the maximize feature for non-resizable windows. BUG=b:163758346 Change-Id: If3e1c514f5c15094a284a518d18e4bbd6658cfb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377834 Commit-Queue: Chloe Pelling <cpelling@google.com> Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#803772}
-
Jacques Newman authored
Adds histogram tracking time spent in the APIs tracked by the following enums: UMA_API_ELEMENT_PROVIDER_FROM_POINT UMA_API_GET_BOUNDINGRECTANGLE UMA_API_GET_PATTERN_PROVIDER UMA_API_GET_PROPERTY_VALUE UMA_API_NAVIGATE UMA_API_TEXT_RANGEFROMPOINT UMA_API_TEXTRANGE_COMPARE UMA_API_TEXTRANGE_COMPAREENDPOINTS UMA_API_TEXTRANGE_EXPANDTOENCLOSINGUNIT UMA_API_TEXTRANGE_FINDATTRIBUTE UMA_API_TEXTRANGE_FINDTEXT UMA_API_TEXTRANGE_GETATTRIBUTEVALUE UMA_API_TEXTRANGE_GETBOUNDINGRECTANGLES UMA_API_TEXTRANGE_GETCHILDREN UMA_API_TEXTRANGE_GETENCLOSINGELEMENT UMA_API_TEXTRANGE_GETTEXT UMA_API_TEXTRANGE_MOVE UMA_API_TEXTRANGE_MOVEENDPOINTBYUNIT UMA_API_TEXTRANGE_MOVEENPOINTBYRANGE AX-Relnotes: n/a Bug: 1118211 Change-Id: I9d1b7d552c2505490185917429c2e127078c49f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363722 Commit-Queue: Jacques Newman <janewman@microsoft.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#803771}
-
Meredith Lane authored
This change moves the state attribute serialization from BlinkAXTreeSource to AXObject to remove extra interfaces from WebAXObject. This patch should have no functional difference, it just a refactor. Bug: 1068668 AX-Relnotes: N/A Change-Id: I657d4bcf63523d6fe042893737c5ea8717f70d81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336099Reviewed-by:
-
Emily Stark authored
Bug: 1097644 Change-Id: I913ad49ca0c9916a835cf2ee7df35330c78c6ced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386097Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#803769}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/156bfc1f22a0..4e51400c4f05 2020-09-02 namhyung@google.com [systrace] Show absolute timestamp for selected slices If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1122488 Tbr: sadrul@google.com Change-Id: Ic562419a327f7aa62e500e784006a28898859973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389054Reviewed-by:
-
David Black authored
HoldingSpaceImage will make use of the resolver to asynchronously fetch and cache a bitmap for the desired scale. This resolver is wired up to the HoldingSpaceThumbnailLoader to fetch thumbnails for HoldingSpaceItem file path. Bug: 1113772 Change-Id: I2a3a73b46f728f28fec955fd655f833f6c8e66c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388341 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#803767}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/816506e1c600..000948ecdba8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ic523e4a4a508164499f37eafa82134c369bb41b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389222Reviewed-by:
-
Bo Majewski authored
Exposes PDF thumbnailer to misc API. Uses it to fetch PNG bytes for a local PDF file. Alters MakeThumbnailDataUrlOnThreadPool to accept base::StringPiece. This allows the existing code path for drivefs thumbnails and the new code path to re-use it. Bug: 903742 Change-Id: I561d734a4d168c0ed96118decddab992d67889e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291914 Commit-Queue: Bo Majewski <majewski@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#803765}
-
chrome-untrusted://media-app/*Patti authored
dark_cros_styles.css, which contains the EA semantic colors for dark mode, was being shipped with the media app SWA package without being linked in the HTML. The fix for this was to dynamically link the CSS in index.ts instead, but this violates the existing SWA CSP. Fix by updating the CSP to allow styles sourced from the 'self' source, which should allow everything from chrome-untrusted://media-app/*. Bug: b/166688012 Change-Id: I1a141b324470586e02418c6aa872ca3800403a88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379440 Commit-Queue: Patti <patricialor@chromium.org> Auto-Submit: Patti <patricialor@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#803764}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: If466a4da23bb909262cab41db006e6a1ca6bc0df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389056Reviewed-by:
-
Josiah K authored
Change-Id: I699fc12cdd59c3a813d3e0daa3730a4a631b6102 NOTRY=true Change-Id: I699fc12cdd59c3a813d3e0daa3730a4a631b6102 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387342 Commit-Queue: Josiah Krutz <josiahk@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Auto-Submit: Josiah Krutz <josiahk@google.com> Cr-Commit-Position: refs/heads/master@{#803762}
-
My Nguyen authored
Add feature flag to input and languages_v2 tests. Bug: 1123964 Change-Id: I069b2d4f8648a36ab03bfc77c91dbc6737aac988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389140Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: If138eae1955828d6801527d17f0f2d8553066c2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389055Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2597a1b22c0a..3f94fc53d493 2020-09-01 mheikal@chromium.org Migrate android_resources targets to not create R.java files If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1073476 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I18efcd7f2f472648ff961ee382944fda21f87ce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388968Reviewed-by:
-
Lijin Shen authored
Add an interface of a handler to show, hide or dismiss the message Bug: 1123947 Change-Id: I14cf876e41b15d060a400d1ca395f11225c60f4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388717Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#803758}
-
Asami Doi authored
This CL adds params (timeout_second) and updates Enabled to Enabled4. Bug: 965802 Change-Id: I00bbd188bf87584da9ee78ee87dbe784776e1077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385136 Commit-Queue: Asami Doi <asamidoi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
Zhuoyu Qian authored
This CL renames Web IDL |LenientSetter| to |LegacyLenientSetter| to make its usage more clear. Bug: 1072773 Change-Id: I99d2fb483df2243d4d3796a358da997d4e3b81fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386682Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#803756}
-
Xianzhu Wang authored
Previously when a text shifted, we assumed the whole area below the text in the containing block shifted, which might report too big shifted area, e.g. if the text shift was just in one line. Now pass the logical height of the shifted text and calculate the shifted area for the text only. Shifts of other texts below are checked separately. Bug: 1121405 Change-Id: I029c5dfcf6d0537a9be4f8c33cac9d63bd4b4f1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386842 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#803755}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ed15af5c4eed..2886c86eeb44 2020-09-02 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: If63c8072e13d3b589b8b39c5bf1b6404d9170012 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389242Reviewed-by:
-
Daniel Hosseinian authored
The class is move-only and carries raw thumbnail image data, as well as the intended device to pixel ratio. The default constructor is deleted, and the constructor tries allocating pixels in the bitmap to enforce the use of image info appropriate for thumbnails to be drawn on an HTML <canvas> element. Bug: 652400 Change-Id: I16bf97d9b0c06fa64bc0cf891f2fdccf0dbd8058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376877 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#803753}
-
Asami Doi authored
This CL is related to the Finch experiment (CheckOfflineCapability). The default value of the timeout is 300 secs (no change for now) and I will add a CL to set the timeout to 10 secs. Bug: 965802 Change-Id: I368bf4ee5ca0e980e51688210a43c85396d9dbf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370686 Commit-Queue: Asami Doi <asamidoi@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#803752}
-
Glen Robertson authored
These interfaces were hidden within //content but depended upon from //chrome/browser. This clarifies the layering issues present but does not completely fix them (see additions to DEPS). It does also resolve `gn check` errors in //chrome/browser. Specifically, profile_provider_chromeos.h includes jank_monitor.h (holds a pointer and is an observer) and chrome_metrics_service_client.cc includes accessibility_metrics_provider.h (only to create one). Let me know if there's a better way to layer this. Split out from crrev.com/c/2383400 Bug: 898837 Change-Id: I4786b903e52164841d91b431d3bcd2cabc2df54e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383515 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#803751}
-
Ce Chen authored
suffix rather than overwriting the locale. Bug: 925072 Change-Id: I6214a91a3ef631098984eaf8b4c6b37ed339ce76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384453 Commit-Queue: Ce Chen <cch@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#803750}
-
Malay Keshav authored
Modifies the HatsDialog to use trigger ID instead of site ID to load the surveys. It also modifies loading the survey as a dialog instead of a window with frame buttons, since the HTML survey already includes a close button. NOTE: This is a reupload of a previously abandoned CL. This approach may have possible points of failure: - Survey may not load, leaving user with a blank window. - Allowed survey localizations may not match the device locale. - HaTS backend may choose to not load the survey. Subsequent work will fix this issues. See go/cros-hats-next follow-up work section. Bug: 1087034 Test: Tested manually on linux chrome and atlas Change-Id: I1453617284fcf1e30c8107643a763b7880fa3c73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386418 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Xiyuan Slow <xiyuan@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#803749}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/fe980adabf55..11cb4f444271 2020-09-02 tsepez@chromium.org Make CFXA_DocumentBuilder a stack-only type. 2020-09-01 tsepez@chromium.org Use fxgc::ContainerTrace<> in XFA. 2020-09-01 tsepez@chromium.org Convert CXFA_ContentLayoutProcessor::m_PendingNodes to Member<>. 2020-09-01 tsepez@chromium.org Convert more FWL objects over to Oilpan GC. 2020-09-01 tsepez@chromium.org Add specialized templates to help tracing stl containers. 2020-09-01 dhoss@chromium.org Roll build/ 0eaf1510a..23dc5c578 (224 commits) 2020-09-01 dhoss@chromium.org Roll buildtools/ 613921787..ff93f3ea1 (3 commits) 2020-09-01 dhoss@chromium.org Roll tools/clang/ 1078c4141..03bacc323 (23 commits) 2020-09-01 dhoss@chromium.org Roll third_party/zlib/ 7492de9a5..d53accfbd (2 commits) 2020-09-01 dhoss@chromium.org Roll v8/ df143e8bd..63911905f (181 commits) 2020-09-01 dhoss@chromium.org Roll tools/memory/ 89552acb6..ee1e24481 (2 commits) 2020-09-01 dhoss@chromium.org Roll third_party/skia/ 994ce8cf2..d20e8e933 (616 commits) 2020-09-01 dhoss@chromium.org Roll third_party/nasm/ 4fa54ca5f..19f3fad68 (626 commits) 2020-09-01 dhoss@chromium.org Roll third_party/instrumented_libraries/ bb3f1802c..3c52ccdd3 (2 commits) 2020-09-01 dhoss@chromium.org Roll third_party/freetype/src/ 986a340dd..16ee2a22a (7 commits) 2020-09-01 dhoss@chromium.org Roll third_party/depot_tools/ 9949ab7a4..ed15af5c4 (84 commits; 18 trivial rolls) 2020-08-31 tsepez@chromium.org Keep rgCurLineLayoutItems alive in CalculateRowChildPosition(). 2020-08-31 tsepez@chromium.org unowned_ptr.h: Don't include what you don't use. 2020-08-31 tsepez@chromium.org retain_ptr.h: Don't include what you don't use. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I04d974d2e393582dd82fc46e455bb83a9d8b7994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388979Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/2d5bbdc4d9de..e1051cbaad46 2020-09-01 capn@google.com Fix undefined behavior in minifloat conversion 2020-09-01 capn@google.com Add unit test for 11/10-bit minifloat denormal underflow If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1117433 Tbr: swiftshader-team+autoroll@google.com Change-Id: If3d79464c386b2550da29750a10775103f645b68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388970Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I1beb38e8601490f7bc7699036320090370da9807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389233Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803746}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/964006ef..26983dc7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7dc306f9385e47b4614a2d536deb2b5954c586e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388563Reviewed-by:
-
chrome://multidevice-internalsRegan Hsu authored
Users can now change the following fields: * Mobile Status * Signal Strength * Mobile Provider * Charging State * Battery Saver State * Battery Percentage Screenshot: https://screenshot.googleplex.com/5ZXpUhSXGr737cg Change-Id: I63ac854c97273354d62c1a3f2b21ab3409cfa23f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388984 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
