GitLab

- Don't look for common title prefixes between pages from different hosts.

- Bring down the minimal width of a tab title area from 10 to 6 chars.

- Don't elide last 4 chars of the common prefix, and also don't elide if there is less than 7 common characters.

BUG=None
TEST=Try it!
Review URL: http://codereview.chromium.org/6783015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80492 0039d316-1c4b-4281-b951-d872f2087c98

Add ability to swap out the TestTabContents in RenderViewHostTestHarness/TabContentsWrapperTestHarness.

BUG=71097
TEST=no visible change

Review URL: http://codereview.chromium.org/6720050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80491 0039d316-1c4b-4281-b951-d872f2087c98

BUG=76644, 77042
TEST=Build under valgrind.

Review URL: http://codereview.chromium.org/6693075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80490 0039d316-1c4b-4281-b951-d872f2087c98

 - testNoAutofillForReadOnlyField
 - read_only_field_test.html

Fixed incorrect permissions for html file from 775 to 640.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6792035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80489 0039d316-1c4b-4281-b951-d872f2087c98

Revert 80472 - GTTF: Detect browser crashes on shutdown in UI tests.Previously the automation framework could miss a browsercrash during shutdown on POSIX (on Windows there iscrash_service.exe that should catch all crashes).This change makes the automation framework avoid losinginformation about the browser process' exit status(CrashAwareSleep), and fixes a bug in base::WaitForExitCodeWithTimeout(which on POSIX never reported the process has been signaled).Finally, it makes the automation framework use WaitForExitCodeWithTimeoutinstead of WaitForSingleProcess. This way we can get the exit statusinformation in an accurate and cross-platform way.To avoid trying to close the same process handle twice (it's only an issue on Windows) I've changed WaitForExitCodeWithTimeout not to close the passed handle. It's only used in few places and I think this CL fixes all of them.I've tested this change locally on Mac with a UI test that SIGKILLs the browser.Before this change the test passed (it shouldn't), and after this changethe test failed with an information that the browser has not exited cleanly.BUG=56644Review URL: http://codereview.chromium.org/6689014
TBR=phajdan.jr@chromium.org

[----------] 1 test from MultipartResponseUITest
[ RUN      ] MultipartResponseUITest.SingleVisit
[3538:3538:0405/104633:11326126024137:ERROR:process_util_posix.cc(108)] Received signal 11
	base::debug::StackTrace::StackTrace() [0xcd194a]
	base::(anonymous namespace)::StackDumpSignalHandler() [0xcb0e5a]
	0x2b835e391100
	AutomationProxy::GetBrowserWindowCount() [0x2055e86]
	ProxyLauncher::IsBrowserRunning() [0xc3f1a2]
	ProxyLauncher::QuitBrowser() [0xc454b3]
	ProxyLauncher::CloseBrowserAndServer() [0xc472d6]
	UITestBase::TearDown() [0xc50d54]
	UITest::TearDown() [0xc51260]
	testing::TestInfo::Run() [0xe8de78]
	testing::TestCase::Run() [0xe8df35]
	testing::internal::UnitTestImpl::RunAllTests() [0xe8f6e7]
	testing::internal::HandleSehExceptionsInMethodIfSupported<>() [0xe804d5]
	testing::internal::HandleExceptionsInMethodIfSupported<>() [0xe8ba92]
	testing::UnitTest::Run() [0xe8badb]
	base::TestSuite::Run() [0x212c26d]
	main [0xc48e41]
	0x2b835e37d1c4
	0x42fec9
Review URL: http://codereview.chromium.org/6794056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80488 0039d316-1c4b-4281-b951-d872f2087c98

We used to initialize NSS without DB in single process mode. This caused going
to https site faile in single process mode. This patch fixes it.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/6670133

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80487 0039d316-1c4b-4281-b951-d872f2087c98

Define RunningAverage, TimedRunningAverage and use that to record
video bandwidth.

This doesn't account for overhead of protobuf envelop. However the number
should be small that can be ignored.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/6736009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80486 0039d316-1c4b-4281-b951-d872f2087c98

protocol.

BUG=none
TEST=10.6 SDK build
Review URL: http://codereview.chromium.org/6735062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80485 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70659
TEST=none
Review URL: http://codereview.chromium.org/6735061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80484 0039d316-1c4b-4281-b951-d872f2087c98

tabView:didSelectTabViewItem:] without declaring that this selector was
implemented by adding it to an @interface, adopting a @protocol or inheriting
from another @interface that declares it. -tabView:didSelectTabViewItem: is
an NSTabViewDelegate @protocol selector. Declare
CollectedCookiesWindowController as adopting this @protocol.

BUG=none
TEST=10.6 SDK build
Review URL: http://codereview.chromium.org/6693098

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80482 0039d316-1c4b-4281-b951-d872f2087c98

scoped_nsobject<> when using the 10.6 SDK.

TEST=Compile with 10.6 SDK
BUG=35569, 35578 (sort of)
Review URL: http://codereview.chromium.org/6735060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80481 0039d316-1c4b-4281-b951-d872f2087c98

Use task_info(..., TASK_DYLD_INFO, ...) on 10.6 and later in preference to
looking up the _dyld_all_image_infos symbol in /usr/lib/dyld.
Review URL: http://codereview.chromium.org/6693096

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80480 0039d316-1c4b-4281-b951-d872f2087c98

R=brettw@chromium.org
BUG=61038
TEST=compile


Review URL: http://codereview.chromium.org/6759068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80477 0039d316-1c4b-4281-b951-d872f2087c98

nib changes: Duplicated the "paste and match style" menu and put it
below the existing item. Change the upper item's shortcut to
cmd-shift-v, marked the lower item to "alternate".

BUG=41472
TEST=Copy some html text, then go to a rich text editor, e.g. http://developer.yahoo.com/yui/examples/editor/simple_editor.html . Paste the text with cmd-v, it should look styled. Undo, paste with cmd-shift-v, it shouldn't. Undo, paste with cmd-shift-opt-v (the system default shortcut for this), it still shouldn't be styled. All three shortcuts should blink the "Edit" menu.

Review URL: http://codereview.chromium.org/6735045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80476 0039d316-1c4b-4281-b951-d872f2087c98

BUG=77914
TEST=none, trybots remain green

Review URL: http://codereview.chromium.org/6735032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80475 0039d316-1c4b-4281-b951-d872f2087c98

This takes a step toward unifying the platform device interface between Windows and Linux and helps to make VectorPlatformDeviceSkia have less ifdefs.

BUG=NONE
TEST=NONE

Review URL: http://codereview.chromium.org/6677142

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80474 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80473 0039d316-1c4b-4281-b951-d872f2087c98

Previously the automation framework could miss a browser
crash during shutdown on POSIX (on Windows there is
crash_service.exe that should catch all crashes).

This change makes the automation framework avoid losing
information about the browser process' exit status
(CrashAwareSleep), and fixes a bug in base::WaitForExitCodeWithTimeout
(which on POSIX never reported the process has been signaled).

Finally, it makes the automation framework use WaitForExitCodeWithTimeout
instead of WaitForSingleProcess. This way we can get the exit status
information in an accurate and cross-platform way.

To avoid trying to close the same process handle twice (it's only an issue on Windows) I've changed WaitForExitCodeWithTimeout not to close the passed handle. It's only used in few places and I think this CL fixes all of them.

I've tested this change locally on Mac with a UI test that SIGKILLs the browser.
Before this change the test passed (it shouldn't), and after this change
the test failed with an information that the browser has not exited cleanly.

BUG=56644
Review URL: http://codereview.chromium.org/6689014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80472 0039d316-1c4b-4281-b951-d872f2087c98

BUG=78165
TEST=

Review URL: http://codereview.chromium.org/6764024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80471 0039d316-1c4b-4281-b951-d872f2087c98

to help with locating the error in the .grd file.


BUG=none
TEST=none


Review URL: http://codereview.chromium.org/6760030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80470 0039d316-1c4b-4281-b951-d872f2087c98

BUG=77914
TEST=none, trybots remain green

Review URL: http://codereview.chromium.org/6720016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80469 0039d316-1c4b-4281-b951-d872f2087c98

Move dispatching and sending of the last extension specific messages out of TabContents and RenderView.I added a TabContents::Registrar helper class for allowing classing to temporarily observe a TabContents.  This allows them to easily and safetly filter IPC messages.  I used this for ExecuteCodeInTabFunction.
Review URL: http://codereview.chromium.org/6794035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80468 0039d316-1c4b-4281-b951-d872f2087c98

This test was crashing, so marking it as flaky will not stop the tests from terminating early due to the crash.

BUG=78440
TEST=CloudPrintURLFetcherOverloadTest.Protect
TBR=joi@chromium.org
Review URL: http://codereview.chromium.org/6693092

TBR=twiz@chromium.org
Review URL: http://codereview.chromium.org/6792052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80467 0039d316-1c4b-4281-b951-d872f2087c98

Repurpose CleanupBadExtensionKeys (which deals with a long-fixed problem) to
remap extension prefs if the generated ID (based on the persisted path) does not
match the persisted ID.

BUG=75945
TEST=ExtensionPrefsIdChange
R=asargent@chromium.org

Review URL: http://codereview.chromium.org/6677147

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80466 0039d316-1c4b-4281-b951-d872f2087c98

This patch implements the logic necessary to respect the preload attribute
when it is set to MetaData.  This also refactors the BufferedResourceLoader
to determine its buffering techniques based on a DeferStrategy value.

BUG=16482,76555
TEST=media/video-preload.html, test_shell_tests

Review URL: http://codereview.chromium.org/6625059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80465 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=about:gpu page displays the SRL version.
Review URL: http://codereview.chromium.org/6677149

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80464 0039d316-1c4b-4281-b951-d872f2087c98

BUG=78111
TEST=see bug
R=ben@chromium.org

Review URL: http://codereview.chromium.org/6792036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80463 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80462 0039d316-1c4b-4281-b951-d872f2087c98

The name used in the histogram is apparently allocated,
and then passed in (probably due to compiler optimizations).
This supresses that leak, as the owning histogram is
deliberately leaked per revision 80412.

tbr=rvargas
Review URL: http://codereview.chromium.org/6677156

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80461 0039d316-1c4b-4281-b951-d872f2087c98

- Currently this only affects AutofillTable and KeywordTable.
- Delete autofill_util as those functions can go back into an anonymous
namespace within autofill_table.cc
- Add helper functions for the migration code to reduce code duplication.
- This is the final refactor CL for WebDatabase.

R=dhollowa@chromium.org
BUG=none
TEST=anything WebDatabase/Migration/Table related.

Review URL: http://codereview.chromium.org/6677124

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80460 0039d316-1c4b-4281-b951-d872f2087c98

BUG=78440
TEST=CloudPrintURLFetcherOverloadTest.Protect
TBR=joi@chromium.org
Review URL: http://codereview.chromium.org/6693092

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80459 0039d316-1c4b-4281-b951-d872f2087c98

BUG=69341
TEST=ran try

Review URL: http://codereview.chromium.org/6691039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80458 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Ran watchlist.py, seemed to work, world failed to end.
Review URL: http://codereview.chromium.org/6720033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80457 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6794030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80456 0039d316-1c4b-4281-b951-d872f2087c98

BUG=77914
TEST=none, trybots remain green

Review URL: http://codereview.chromium.org/6794021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80455 0039d316-1c4b-4281-b951-d872f2087c98

TBR=pfeldman@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80451 0039d316-1c4b-4281-b951-d872f2087c98

BUG=56375

Review URL: http://codereview.chromium.org/6792049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80450 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80449 0039d316-1c4b-4281-b951-d872f2087c98

debugging of renderer process issues.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6691040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80448 0039d316-1c4b-4281-b951-d872f2087c98

Result of revision 80412.

tbr=rtenneti
Review URL: http://codereview.chromium.org/6735057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80447 0039d316-1c4b-4281-b951-d872f2087c98