GitLab

Previously, this class would fail gracefully if given a nullptr. Now it
has undefined behaviour. Dealing with null isn't necessary as no caller
passes nullptr here, and in general, pass-by-result style functions do
not expect null pointers. Dealing with nullptr makes my follow-up work
messy, so I am just removing it.

Also, moved constructor implementation to .cc file, and properly
documented the lifetime constraints on |json_string|.

BUG=455068

Review URL: https://codereview.chromium.org/889303004

Cr-Commit-Position: refs/heads/master@{#314703}

Add UMA stats to record the memory pressure level periodically (once per second) in ChromeOS. This is used to show the relative frequency of the system being in a critical vs relaxed memory pressure state

BUG=442829

Review URL: https://codereview.chromium.org/874483008

Cr-Commit-Position: refs/heads/master@{#314702}

Before this CL, component installers were leaked in almost all cases. If we allow uninstalling components (see https://codereview.chromium.org/879993005/), we need to fix those leaks.

BUG=436459

Review URL: https://codereview.chromium.org/897873002

Cr-Commit-Position: refs/heads/master@{#314701}

This pulls in the following Native Client changes:

ab93269: (phosek@chromium.org) Removes the now-unused kernel service from the service runtime
9e3dac8: (sbc@chromium.org) Implement pthread_rwlock functions for NaCl newlib.

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_compile,linux_nacl_sdk_build

Review URL: https://codereview.chromium.org/896533005

Cr-Commit-Position: refs/heads/master@{#314700}

This change allows MediaSourcePlayer to skip browser seek if a key frame is found in cache.
Key frames can be identified by an empty data buffer, a config change or is_key_frame field.

BUG=304234

Review URL: https://codereview.chromium.org/898843002

Cr-Commit-Position: refs/heads/master@{#314699}

The ipc_perftests and mojo_message_pipe_perftests results appeared
designed to be compared against each other, and the ipc_perftests
appear to be designed to take about a second each. Therefore it is
presumably a bug that the final ipc_perftests test executes only 100
times (versus 1,000 times for mojo_message_pipe_perftests) and that it
executes in ~50 ms.

This change increases the iteration count from 100 to 1,000.

Review URL: https://codereview.chromium.org/903513002

Cr-Commit-Position: refs/heads/master@{#314698}

It is sending the request from the render process to the browser process
which then opens the URL using ContentBrowserClient::OpenURL().

This is going to be used by sw.client.openWindow(), see Blink CL:
https://codereview.chromium.org/850413002

BUG=437151

Review URL: https://codereview.chromium.org/843583005

Cr-Commit-Position: refs/heads/master@{#314697}

BUG=455409

Review URL: https://codereview.chromium.org/901733002

Cr-Commit-Position: refs/heads/master@{#314696}

This is not longer needed after we have a generic gcm channel state.

BUG=447016
TEST=none
TBR=kalman@chromium.org

Review URL: https://codereview.chromium.org/897793002

Cr-Commit-Position: refs/heads/master@{#314695}

BUG=449357

Review URL: https://codereview.chromium.org/888093005

Cr-Commit-Position: refs/heads/master@{#314694}

Review URL: https://codereview.chromium.org/896463005

Cr-Commit-Position: refs/heads/master@{#314693}

This reverts commit cc6a8bfe.
From review: https://codereview.chromium.org/899973002/

Original issue's description:
> Device Orientation API on Chrome OS
>
> Implement DataFetcherSharedMemory on Chrome OS to provide Device Orientation support. Create SensorManagerChromeOS to observe accelerometer events, and to generate updates to the Device Orientation API.
>
> This is a follow up to: https://codereview.chromium.org/680383007/
>
> With the accelerometer on Chrome OS now exposed to content/ from chromeos/accelerometer, no ash/ implementation is required. No public api in content/public/browser is needed either.
>
> TEST=SensorManagerTest.OrientationBuffer, SensorManagerTest.NeutralOrientation, SensorManagerTest.UpsideDown, SensorManagerTest.BeforeUpsideDownBoundary, SensorManagerTest.LeftEdge, SensorManagerTest.RightEdge, SensorManagerTest.BeforeRightEdgeBoundary
> BUG=342908

TBR=timvolodine@chromium.org,jam@chromium.org
BUG=342908

Review URL: https://codereview.chromium.org/880083005

Cr-Commit-Position: refs/heads/master@{#314692}

Instead of parsing the whole proc stats just to extract two values, we
skim through it just to extract the two values we're interested in.

BUG=453871
TEST=base_unittests --gtest_filter=ProcessMetricsTest.*

Review URL: https://codereview.chromium.org/888193002

Cr-Commit-Position: refs/heads/master@{#314691}

There is a bug where the "Close Window" shortcut for hosted/packaged
apps would disappear after focusing the File menu in a Chrome browser.
This is because the shortcuts had the same key equivalent, and OS X was
choosing to only display one of them. This CL fixes this by keeping a
reference to the conflicting menu items and enabling/disabling the
shortcuts on focus.

BUG=455067

Review URL: https://codereview.chromium.org/898543008

Cr-Commit-Position: refs/heads/master@{#314690}

testGetUpdatedInspectableContexts should only run when tab control is supported.

BUG=452277

Review URL: https://codereview.chromium.org/893233003

Cr-Commit-Position: refs/heads/master@{#314689}

- ! allowed by a tts property will annotate the output with that property
- $descendants(args...) where args... is a comma delimited list of roles, will compute output for the node's descendants that are in the set of roles.
- apply these two new functions to compute utterances for alerts.

TEST=navigate to a page with an alert like
html5demos.com/geo.
BUG=382650

Review URL: https://codereview.chromium.org/816093002

Cr-Commit-Position: refs/heads/master@{#314688}

This removes the need to compare a raw handle against
a predefined value from the caller's code.

BUG=none
TEST=base_unittests

Review URL: https://codereview.chromium.org/868143004

Cr-Commit-Position: refs/heads/master@{#314687}

- Switch to using expand and collapse icons from internal repo
- Start using TintedDrawable for WebsitePreferences.

BUG=454859

Review URL: https://codereview.chromium.org/900743003

Cr-Commit-Position: refs/heads/master@{#314686}

Add a basic settings page with a Polymer paper element which loads at chrome://md-settings (if the enable-md-settings flag is enabled).

BUG=454961

Review URL: https://codereview.chromium.org/893323002

Cr-Commit-Position: refs/heads/master@{#314685}

Long live cc.

R=enne, vmpstr

Review URL: https://codereview.chromium.org/897873005

Cr-Commit-Position: refs/heads/master@{#314684}

BrowserGpuChannelHostFactory::GetGpuChannel() can
return NULL. In particular it already checks
IsLost() and returns NULL if that is the case.

BUG=445945

Review URL: https://codereview.chromium.org/867093004

Cr-Commit-Position: refs/heads/master@{#314683}

  - Fail if VideoToolbox returns a null pointer, instead of crashing.
  - Stop processing as soon as an error occurs.

BUG=453050

Review URL: https://codereview.chromium.org/900053002

Cr-Commit-Position: refs/heads/master@{#314682}

Review URL: https://codereview.chromium.org/873923004

Cr-Commit-Position: refs/heads/master@{#314681}

Replaces the use of MultiChannelResampler with AudioConverter in
FakeMediaSource to allow the cast_sender_app and cast_simulator to
re-mix any-number-of-channels audio into the 2-channel audio for Cast
sending.

Review URL: https://codereview.chromium.org/900913004

Cr-Commit-Position: refs/heads/master@{#314680}

BUG=455349

Review URL: https://codereview.chromium.org/866913006

Cr-Commit-Position: refs/heads/master@{#314679}

On android versions before 5.0, EGL sync objects are
incorrectly destroyed when the associated EGL context is
destroyed. The EGL sync objects error handling is tight to
prevent driver regressions from known issues. This combined
with this triggers DCHECk failures and crashes.

So add another workaround to ignore errors from EGL sync
object calls.

BUG=453857

Review URL: https://codereview.chromium.org/892323002

Cr-Commit-Position: refs/heads/master@{#314678}

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with an OS=android build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463
R=caitkp@chromium.org

Review URL: https://codereview.chromium.org/893303003

Cr-Commit-Position: refs/heads/master@{#314677}

CaptivePortalBrowserTest.InterstitialTimerNavigateAwayWhileLoading was
disabled a few days ago, this one has the same issue.

BUG=453875
TBR=thestig@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/902583005

Cr-Commit-Position: refs/heads/master@{#314676}

Sets list item selection and focus correctly when edit is committed in
name/phone/email lists on chrome://settings/autofillEditAddress page.

"Correctly" means the just-edited list item remains the selected item in
the list, and the next focusable element after the list gets focus. The
list no longer has focus, but if the user gives focus back to the list
using tab/shift+tab then the just-edited list item will receive focus.

This is different than the default InlineEditableItemList behavior
because most addresses will have only a single name/phone/email, so it's
better to move to the next field type rather than to the "Add another"
placeholder of the same field type. I tried to keep the changes
contained to autofill_options_list.js because that's the only page that
needs this focus behavior. Generalizing the code into
inline_editable_list.js might result in more regressions to fix
elsewhere.

The fix implementation is to disable list events during list operations
in autofillOptions.ValuesListItem.onEditCommitted_, so that focus is not
returned back to the list that was just tabbed away from. Then
onEditCommitted_ calls the new
InlineEditableItemList.SelectIndexWithoutFocusing method to set the
selected list item without setting focus back to the list.

Same fix for both regressions.

https://crbug.com/440760 was caused by me.
https://crbug.com/443491 was from a CL by hcarmona@, but we agreed I
should take it because I'm more familiar with this code.

BUG=440760,443491

Review URL: https://codereview.chromium.org/819193003

Cr-Commit-Position: refs/heads/master@{#314675}

This fixes a bunch of small nits:
* JSCompile is now enabled for this app.
* No need to manually focus the PNaCl plugin.
* Distinguishes between left and right modifiers for PNaCl events.
* Debug log is hidden by default, and selectable when shown.
* Minor CSS tweaks and code clean-up.

Review URL: https://codereview.chromium.org/900983003

Cr-Commit-Position: refs/heads/master@{#314674}

BUG=454940

Review URL: https://codereview.chromium.org/902443002

Cr-Commit-Position: refs/heads/master@{#314673}

This includes a fix for Python 2.7.7, which removed the
HTTPSConnection._set_hostport function.

BUG=410545
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/904513005

Cr-Commit-Position: refs/heads/master@{#314672}

Review URL: https://codereview.chromium.org/892203004

Cr-Commit-Position: refs/heads/master@{#314671}

Currently in the webapp, we didin't disconnect the native messaging port
after a share and therefore keeping the remote-assistance process alive.

Summary of changes:
1. Disconnect the native message port when the host status changes to
   DISCONNECTED or ERROR.
2. Remove remoting.hostSession global and wrap host_screen.js in an
   anonymous function.

BUG=416676

Review URL: https://codereview.chromium.org/895723006

Cr-Commit-Position: refs/heads/master@{#314670}

Follow-up to crrev.com/895523004/

BUG=

Review URL: https://codereview.chromium.org/896853002

Cr-Commit-Position: refs/heads/master@{#314669}

setIgnoreViewportTagScaleLimits copies the default limits into the UA
constraints. This was happening before the defualt limits were set during
initialization so it was clamping page scale at [1,1].

BUG=453377

Review URL: https://codereview.chromium.org/860283005

Cr-Commit-Position: refs/heads/master@{#314668}

TBR=bruening@google.com
BUG=455417
NOTRY=true

Review URL: https://codereview.chromium.org/896333002

Cr-Commit-Position: refs/heads/master@{#314667}

Trying base_unittests first to check that isolation works correctly.

BUG=454828
TBR=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/897023002

Cr-Commit-Position: refs/heads/master@{#314666}

When in using single thread with browser compositor, make reflector use
main thread MessageLoop instead.

Test with forced SW mirrored display on both Linux-cros build and Pixel.
BUG=453732

Review URL: https://codereview.chromium.org/899073003

Cr-Commit-Position: refs/heads/master@{#314665}

At this point, "--run-layout-test" is the flag that is actually functional, and using "--dump-render-tree" simply causes the "--run-layout-test" to be appended to the command line.

A subsequent Blink patch will change the scripts in Blink to use "--run-layout-test" instead of "--dump-render-tree".

BUG=453252

Review URL: https://codereview.chromium.org/899103002

Cr-Commit-Position: refs/heads/master@{#314664}