GitLab

This enables x86_64 Chrome to run under Rosetta binary translation on
arm64 macOS systems.

The system page size is no longer considered a compile-time constant on
macOS. It may be determined dynamically at run time through the
vm_page_size variable. The related vm_page_shift and vm_page_mask
variables are also available.

On arm64, the system page size is currently 16kB. On x86_64, it’s 4kB.
x86 code running translated on currently available arm64 systems (the
Apple Developer Transition Kit) is subjected to the arm64 system’s
native 16kB page size, meaning that code built with an expectation of
4kB pages, previously correct for native x86_64, will not work correctly
in the translated environment. This is significant because the DTK is
the only mac-arm64 system available for testing now, and it’s become
important to test x86_64 Chrome under Rosetta translation on arm64.

To overcome this limitation, the system page size and related constants
are, on macOS, made to be determined at run time on the basis of the
variables provided for this purpose by the system.

In order to make this change without violating Google’s and Chrome’s
prohibition against load-time initializers, the variables that had been
used to convey page size information need to become functions. On all
platforms except for macOS, the functions remain constexpr, are marked
to be always inlined, and continue to return the same compile
time-determined value they had in the past, so while it appears
invasive, this change is in fact physically a no-op on these platforms.
On macOS, it is a functional no-op change, except when running x86_64
code on arm64 under Rosetta translation, where it causes correct values
to be used for the run-time environment.

Adopting a compile-time 16kB page size on mac-x86_64 was considered but
rejected due to the potential for memory footprint and performance
impact. That approach would result in a behavior change for native
x86_64 users, which constitute the vast majority of consumers of the
x86_64 build, for the benefit of the comparatively small number of arm64
users running x86_64 Chrome under translation. This is undesirable,
particularly for a change that may need to be merged to more stable
branches.

Apple documentation links:

https://download.developer.apple.com/Documentation/Universal_App_Quick_Start_Program_Resources/DTK_Release_notes.pdf

“Rosetta 2 Behaviors…Applications that depend on a 4K memory page size
will not run. Examples of this may include some web browsers and
language runtimes.”

Also:

https://developer.apple.com/documentation/apple_silicon/addressing_architectural_differences_in_your_macos_code#3616877
https://developer.apple.com/videos/play/wwdc2020/10214/?time=544 (9:04)

Bug: 1102194
Code-Word: disaster
CQ-Include-Trybots: luci.chromium.try:mac-arm64-rel
Change-Id: I143f38f06444f96eb8a82ede34f2a44ea48318fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361202
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808610}

This configuration solely controls the ThreadProfiler, so rename it
to be consistent with the naming of that class and with future code
in support of enabling the ThreadProfiler on a per-thread basis.

Bug: 1129939
Change-Id: I20d19abe579cabaf7a355182f164898c12861c92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418675
Commit-Queue: Mike Wittman <wittman@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808609}

- Mention that we now have a tester bot and link to it
- Put actual build instructions to top of the "Building" section
- Add some text about copying files to the DTK, and mention
  quarantine error messages, so that search engines can index them

Bug: none
Change-Id: I5b5f042280b6077ad89e217e4bf907f4b4c12fde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418984
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808608}

Bug: b/150034512
Test: Manual Test
Change-Id: I87a02b3d0ef65a2e6a26c663fe2ee66d43331423
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419263
Commit-Queue: Yue Li <updowndota@chromium.org>
Auto-Submit: Yue Li <updowndota@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808607}

A "raw" test type in MB was a test executable that didn't conform to
one of the other supported test harness APIs (like the chromium
gtest api or the test executable API), and which we would
handle by simply running the executable and returning the status
code.

There was no real need to support this directly; it turns out
that every raw test that we current run should've either actually
been a gtest-based test or was handled by a generated wrapper
(for the ChromeOS Tast-based tests).

Fixing this and removing support for "raw" test types allows us
to simplify MB a bit but more importantly gets us one step
closer to having only one supported API for tests.

Bug: 816629
Change-Id: I831efa949614719a8aa5106c5ab5c1c0c48b5059
Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380439
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808606}

Most of these methods forward to |model_| and then return *this.
Inlining these reduces boilerplate.

Bug: 1106422
Change-Id: I19724548e73e117f32c38c88fae5c5beaf3f6741
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419142
Auto-Submit: Peter Boström <pbos@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808605}

Bug: 1110766
Change-Id: I832431d2c500080143bb2b470553764d7262097e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417653
Commit-Queue: Yulun Wu <yulunwu@chromium.org>
Reviewed-by: Yulun Wu <yulunwu@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808604}

This change moves the Restrictions struct (public in the declaration
of PpdProvider) into the PPD metadata parsing code. This is not the
change where we cut away the v2 PpdProvider, though, so we retain the
old struct definition as PpdProvider::LegacyRestrictions.

In addition, this change modifies the semantics of Restrictions;
metadata that can be restricted now always contains Restrictions
structs, but the struct's members (max and min milestones) are now
optional.

Bug: chromium:888189
Test: chromeos_unittests
Change-Id: I03a3825ec2150e8db93a2187d11285afcd44b07a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393615
Commit-Queue: Kalvin Lee <kdlee@chromium.org>
Reviewed-by: Luum Habtemariam <luum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808603}

https://skia.googlesource.com/skia.git/+log/be0a9ca63d9d..ca4d074d54ab

2020-09-18 johnstiles@google.com Fix unit test for InlinerWrapsEarlyReturnsWithDoWhileBlock.
2020-09-18 johnstiles@google.com Add unit test for a dead do-while loop.
2020-09-18 bsalomon@google.com Expand SkYUVAInfo::PlanarConfig/SkYUVAPixmapInfo::DataType values.
2020-09-18 csmartdalton@google.com Fix CanvasKit warnings compiling on Mac with emsdk 2.0.0
2020-09-18 johnstiles@google.com Add program-settings flag to disable the inliner.
2020-09-18 mtklein@google.com quad-pump avx2 and up
2020-09-18 robertphillips@google.com Switch the thread-safe proxy cache over to using an arena for its entries

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: chromium:1108408
Tbr: scroggo@google.com
Change-Id: Ie69b9281937728bea0132439962ae326e110610d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419625Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#808602}

* Use LocalDOMWindow rather than LocalFrame/Document for most things.
* Change probe::WindowOpen() to take a KURL rather than a url String,
  to avoid an unnecessary CompleteURL() call.
* Remove an obsolete TODO, which refers to a Frame being remote when
  at a point where it is known to be local.

Change-Id: I0860485758fa1ff12843bf965e03c9816e5f2390
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414277
Commit-Queue: Nate Chapin <japhet@chromium.org>
Auto-Submit: Nate Chapin <japhet@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808601}

This flag is still WIP, but in the meantime it doesn't need to part of
about:flags as we don't expect users to toggle it.

R=kschmi@microsoft.com

Bug: 1110626
Change-Id: I849bd807b609ad39d384177ba081a1109749c90d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417637
Commit-Queue: Daniel Libby <dlibby@microsoft.com>
Auto-Submit: Daniel Libby <dlibby@microsoft.com>
Reviewed-by: Adam Ettenberger <Adam.Ettenberger@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#808600}

Prepares the GPU pixel tests for the upcoming migration from a dedicated
GPU Gold instance to the general Chrome instance by:

1. Including a combined hardware identifier that will allow us to make
   forwarding rules more precise.
2. Performing a duplicate, FYI version of the comparison in the Chrome
   instance in addition to the existing comparison in the GPU instance.

Bug: 1113308, skia:10723
Change-Id: Ie6e9abb5e8b7edaec11bde63ece81a45d47792b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415089
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808599}

Update the string per design doc (see Bug).

Also check ShouldShow() which was missed in the last CL due to
rebase error.

See screenshot at: https://photos.app.goo.gl/Ho4rr76RK4nnckJe7

Tbr: dcheng@chromium.org
Bug: 1126568
Change-Id: I775715eba04f3ff243e3db8b73bba04a42771a33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419578
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808598}

This change adds support to Browser and BrowserWindow for a
user-configured window title, and has that data persist across session
restores. There is no UI for this feature (yet) so this code is only
exercised by its own tests.

Change-Id: I8235b1b73cea4d32d3c4c6e883c5815f10995ffc
Bug: 1096586
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204677Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808597}

1. Avoid LOG(ERROR) in paint related logging
We used LOG(ERROR) (guarded by VLOG_IS_ON() and DCHECK_IS_ON())
for convenience when running chrome without --enable-logging=stderr
to show the logs when they are enabled. However, the 'ERROR'
tag was confusing to users. Now use DVLOG, VLOG or LOG(INFO).

2. Move graphics_layer_tree_as_text.* back to platform/graphics
We moved it to core/paint/compositing when we added a dependency to
core code. Now the dependency no longer exists.

3. Remove the change detection code for layer tree/list dump, to
make them the same as other dumps, so that we can see complete dumps
in verbose log for document lifecycle updates.

Bug: 1107874
Change-Id: I2c1b9727bb3f46b87033855b2bf89302ced67428
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419143Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808596}

Bug: 1130093
TBR: wychen
Change-Id: I685977da702ea612918002a923dc978866e5eb95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419554Reviewed-by: Michael Bai <michaelbai@chromium.org>
Commit-Queue: Michael Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808595}

This reverts commit efbdaef4.

Reason for revert: Causes a crash with parameter names with colons in it. See the bug.

Bug: 1130035

Original change's description:
> flags: Add support for FEATURE_WITH_PARAMS_VALUE_TYPE feature in switches
> 
> Fixed:805766
> Test:autoninja -C out/mychrome components_tests && ./out/mychrome
> components_tests
> TESTED=autoninja -C out_hatch/Release chrome && deploy_chrome
> --build-dir=out_hatch/Release --device=$DUT
> 
> Verified by setting a feature with param in chrome://flags on hatch
> 
> Change-Id: I83f8c81237c3db50a4f23bf5b17e73363bf10504
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401336
> Commit-Queue: Weilun Shi <sweilun@chromium.org>
> Reviewed-by: Weilun Shi <sweilun@chromium.org>
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#806278}

TBR=ellyjones@chromium.org,sweilun@chromium.org,joonbug@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ie50328d7c07c815f04157fd11103cd5393a03534
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419591Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Weilun Shi <sweilun@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808594}

AX-Relnotes: n/a.
Bug: None.
Change-Id: I5bb22367303e0a84ce68ad6b4d083ec311d2b36c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391596
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: Abigail Klein <abigailbklein@google.com>
Cr-Commit-Position: refs/heads/master@{#808593}

R=inferno@chromium.org

Bug: 974462
Change-Id: I0e9a5201abaf1a6ee3a614c770f09789dc8b190f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417113
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808592}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/eed20333dd52..862107080d58

2020-09-18 aerotwist@chromium.org Revert "Reland "Remove support for remote modules""
2020-09-18 tvanderlippe@chromium.org Reland "Remove support for remote modules"
2020-09-18 andoli@chromium.org [ts] Typecheck components/ImagePreview.js with TypeScript
2020-09-18 aerotwist@chromium.org Adds remote base helper
2020-09-18 tvanderlippe@chromium.org Typecheck mobile_throttling/ThrottlingSettingsTab.js with TypeScript

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I9a900e51864e44892aaf27c22a13caf8b36c304d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419623Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#808591}

AX-Relnotes: n/a.
Bug: None.
Change-Id: Ibd14ecb887cdb6c59885292890d336966692ff7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389225
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: Abigail Klein <abigailbklein@google.com>
Cr-Commit-Position: refs/heads/master@{#808590}

These defaults are misleading, since those of them that were different
from 'false' were ignored everywhere.
According to code search, the code in Chrome and ChromeOs always looks
like:

if (proto.has_PROPERTY()) {
  ... = proto.PROPERTY();
}

or

if (!proto.has_PROPERTY()) {
  return;
}
... = proto.PROPERTY();

Bug: b:168328072
Bug: 1058092
Change-Id: I2b68ddf4316b3fb10ccccb749cbd4cb915df641a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418989Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Leonid Baraz <lbaraz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808589}

Test manually, the persisted log loaded at next startup.

Bug: 1076549
Change-Id: Ibfc273431b8ccd313435b55bdb1889b7c5913045
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2173960Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Michael Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808588}

The runtime is no longer considered by default, as we prefer to use
OpenXr. Thus, this runtime is now dead code, and should be removed

Bug: 1100622
Change-Id: I4727186c63655848f0ae189e7aa13e9b42d0f73a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415308Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808587}

* testRenderGrid_10WebTabs
* testRenderGrid_10WebTabs_InitialScroll

They become flaky after the emulator runs on n1-stardard-4 machines

Also remove chrome_public_test_apk from the MM-x86-rel-non-cq builder since
it already runs on MM-x86-rel

Bug: 1077552, 1127110
Change-Id: I05d1b86e491cbd2bcd7d2b0fb7cec0c5672d2a11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419651Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Auto-Submit: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#808586}

ClearSettingsForOneTypeWithPredicate iterates over all settings, which
makes the cleanup O(N^2). To make it O(N), call
SetWebsiteSettingDefaultScope with a nullptr as value instead.

To make sure the cleanup doesn't cause the jank, add a cap to the number
of removed verdicts in a single cleanup.

Currently expired cache is cleaned up during shutdown. However, shutdown
may not be performed on Android. To make sure the cache is not growing
without limits, also start a task to cleanup periodically.

stored_verdict_count_real_time_url_check_ is calculated per session. To
include the verdicts that are stored on disk, count the verdict directly
from HostContentSettingsMap.

Bug: 1128669
Change-Id: I6a01060104b4773e276e9472a05aa2c9ab8267db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406150
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808585}

Adds a util function to determine if Multidevice stubs should be used.
Will be used in future CLs that add in the stubs.

Bug: None
Change-Id: I67bd7695a5b71b749d6447116da5dba9cd565499
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406594
Commit-Queue: Daniel Classon <dclasson@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808584}

Make the 'learn' section on the index page consistent with the nav bar
tab. Prompt 'views' doc up a bit, and use an image(credit to @ellyjones)
instead of ASCII diagram for better understanding.

Bug: none
Change-Id: Iac2c59e3c28a0f5021bc398ffad80929435a797c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417072Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808583}

Launch bug: crbug/1069807

Bug: 1069807
Change-Id: Ie9d551109f9e4188b48bdb89ffb7923f9cf7e6d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407061
Commit-Queue: Yue Li <updowndota@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Auto-Submit: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808582}

-Implemented the first method getSystemInfo()

Bug: 1125150
Test: browser_tests --gtest_filter=DiagnosticsApp*
Change-Id: I57ec7aedb0dbc990e9d62f4dbd18ec26a469e542
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417509
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808581}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll
Please CC chonggu@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: chonggu@google.com
Change-Id: Ie20993fb5377fc518adce80debdf8e55edb7e5bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419622Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#808580}

Currently if Tab Scrolling is enabled the TabStrip is allowed to grow
beyond the visible bounds of the TabStripRegionView with the help of
a ScrollView.

Existing caption hit testing uses the TabStrip view to determine
whether a rect or point belongs to the caption area. This results in
a bug where areas of the browser window are no longer recognized as
part of the caption area.

This is due to the non-visible parts of the TabStrip continuing to
contribute to the hit testing logic as it overflows.

This patch updates the TabStripRegionView to support the necessary
hit testing logic and ensure that only the visible portion of the
TabStrip is used.

Bug: 1129703

Change-Id: I49ccf9ba573afba84921a66249ef38723787cbba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411704
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808579}

They've been stable for the last 2 weeks. The latest gold images I
approved PageInfoBubbleViewBrowserTest should be actual ui changes.
I also went through 10 recent changes with skia-gold@ commentby.
I don't see pixel_browser_tests caused any comments. So I think
existing tests plus these tests on FYI should be stable enough.

Bug: 1102894
Change-Id: I541877dfee293c427af3fd102cba8a3985f088ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418807Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808578}

Switching from a single i3-8100 machine to 3 Xeon E-2288G machines.

Also drop driver and OS versions for Linux GTX 1660 bot
to simplify upgrades.

TBR=kbr

Bug: 1042292
Change-Id: I9630d921ae8044ba5ad60e78b8f298a8369d365b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419127
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808577}

This test produced different output every time it failed since a
randomly generated string was being passed to assert_equals. This patch
does the same check but prevents the generated string from getting into
the error message so we can include it in our failing test expectations.

Fixed: 1129420
Change-Id: I5cffb6c3dfbe7bb551a626780273291d732f6e1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416727
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808576}

Based on some recent problems with the Client Side Phishing system, we
could use a few more high-level metrics. This CL adds three such
metrics:
- Whether the local model identifies phishing or not, on every
  classification
- Whether the server-side models identify phishing or not, every time
  we contact Safe Browsing. This can also be used to determine total
  pings sent to Safe Browsing.
- What the current model version is. While this is indirectly
  controlled by the Finch config, measuring it directly can detect
  mistakes made in the config or on the server-side.

Fixed: 1128205
Change-Id: Ia3e3036c7ce2dc9e3e6814bd626897ca0d055698
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416063Reviewed-by: Bettina Dea <bdea@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808575}

Add the isRegexSupported extension function which provides extension
developers with a way to check that a given regular expression can be
used as a regexFilter rule condition.

Skipping presubmit since this seems to be hitting crbug.com/956368.

R=karandeepb@chromium.org, kelvinjiang@chromium.org

Bug: 1088457
No-Presubmit: True
Change-Id: Ic51df5dd096806472f25e4053a020c0a08368179
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372465
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808574}

BPF sandbox policies normal use this code sequence if they are using a
broker:
  auto* broker_process = SandboxLinux::GetInstance()->broker_process();
  if (broker_process->IsSyscallAllowed(sysno)) {
    return Trap(BrokerProcess::SIGSYS_Handler, broker_process);
  }

Switch this to:
  auto* sandbox_linux = SandboxLinux::GetInstance();
  if (sandbox_linux->ShouldBrokerHandleSyscall(sysno))
    return sandbox_linux->HandleViaBroker();

...which has the advantage of being clearer.

This also makes it easier to land SECCOMP_RET_USER_NOTIF support, as
if USER_NOTIF is supported we will use bpf_dsl::UserNotif instead of
bpf_dsl::Trap, and users of the sandbox shouldn't have to care which
one is used.

Bug: 1117351
Change-Id: I809fdb4118fef39d8b142fdd571743c49e0812a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377422
Commit-Queue: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808573}

BUG=1121162

Change-Id: If2ec2a9c3a5c1f76373a8cdddc920267c64b13eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418618
Commit-Queue: Chris Sharp <csharp@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808572}

Resharding to reduce long poles on shard runtime, which on some platforms are ~3 times as average.

Bug: chromium: 1129958
Change-Id: I8c865769bb88f6b28a2398c2ac148cc7e7766ebb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418801Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Wenbin Zhang <wenbinzhang@google.com>
Cr-Commit-Position: refs/heads/master@{#808571}