- 13 Jul, 2017 40 commits
-
-
Mohamad Ahmadi authored
Uses the id property of the PaymentDetails provided to PaymentRequest's constructor or generate a UUID to uniquely identify the PaymentRequest in order to allow multiple PaymentRequest objects to coexist. BUG=602666 Change-Id: I420e9fba0314cc9683b274fea71e0118b31e572e Reviewed-on: https://chromium-review.googlesource.com/565056 Commit-Queue: mahmadi <mahmadi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#486265}
-
Tom Anderson authored
This CL fixes the Linux official builder [1] after something added a new libc dependency. [1] https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/19153 TBR=thestig@chromium.org CC=alancutter@chromium.org NOTRY=true NOTREECHECKS=true Change-Id: I01c3f721f36b0475aeeba7b4da47d257379a24fb Reviewed-on: https://chromium-review.googlesource.com/569410Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#486264}
-
ikilpatrick authored
After inline+float patches these now pass. BUG=635619 TBR=eae@chromium.org Review-Url: https://codereview.chromium.org/2979913002 Cr-Commit-Position: refs/heads/master@{#486263}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/1286055c7baf..e4d806cd4821 $ git log 1286055c7..e4d806cd4 --date=short --no-merges --format='%ad %ae %s' 2017-07-12 sullivan Migrate /api/bugs to new api_request_handler. 2017-07-12 martiniss Log trace processing time 2017-07-12 eakuefner [Dashboard] Switch api_request_handler's BadRequestError to 400 instead of 500 2017-07-12 eakuefner [Tracing] Move histogram.Diagnostic to diagnostic.Diagnostic Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ia450f22c595ed4422a9a94f9486c7cc6d719d064 Reviewed-on: https://chromium-review.googlesource.com/569460 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#486262}
-
oka@chromium.org authored
Bug: 739988 Change-Id: Ic484a862e25700611581989f6e660267a01a2cbe Reviewed-on: https://chromium-review.googlesource.com/562844 Commit-Queue: Keigo Oka <oka@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#486261}
-
ikilpatrick authored
This moves a bunch of code around and some additional comments. Before the code for handling an inflow element was a little difficult to follow. Now most of the code and complexities are inside HandleInflow. Functions which this calls are now relatively simple. BUG=635619 Review-Url: https://codereview.chromium.org/2975973002 Cr-Commit-Position: refs/heads/master@{#486260}
-
Eric Roman authored
It is no longer needed as consumers of WriteToFileNetLogObserver have been switched over to FileNetLogObserver. Bug: 716570 Change-Id: Ia70e04aebc8560f2799a84c8c691538c5beb5db5 Reviewed-on: https://chromium-review.googlesource.com/565450 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#486259}
-
Suchit Agrawal authored
Create new BUILD.gn file for media/muxers and moved respective media component changes from media/filters/BUILD.gn file to new BUILD.gn file. BUG=613033 Signed-off-by:
Suchit Agrawal <a.suchit@samsung.com> Change-Id: I7fd8a2cc3573efc81f3bb75409bed2860c0a3d46 Reviewed-on: https://chromium-review.googlesource.com/561236Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: SUCHIT AGRAWAL <a.suchit@chromium.org> Cr-Commit-Position: refs/heads/master@{#486258}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/d425a1d013b6..27b3d272a8fc $ git log d425a1d01..27b3d272a --date=short --no-merges --format='%ad %ae %s' 2017-07-13 reed Revert "Experimental blur code with 32 bit fix." 2017-07-11 bsalomon Make RegionOp a non-legacy GrMeshDrawOp Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I94eff3008f737779b0872387271c5f9093864d5c Reviewed-on: https://chromium-review.googlesource.com/569313Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#486257}
-
Toni Barzic authored
BUG=741974 Change-Id: I45e157a0ef6f060fe458fec1df481237c6a01c1f Reviewed-on: https://chromium-review.googlesource.com/569443Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#486256}
-
btolsch authored
In particular, /c/b/m/r/discovery cannot be built by itself because of the missing mojo generator dependency. This is useful for minimizing what needs to be built for testing, especially on Windows where building is much slower. Bug: 740319 Change-Id: I1b6aee574afac121b07d20936ff1a4717712fa3e Reviewed-on: https://chromium-review.googlesource.com/566997Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#486255}
-
btolsch authored
This also replaces some uses of small_map::insert with emplace. Bug: None Change-Id: I857ca36847eefe7dcc4a7f90d12c0d99ccf2afd8 Reviewed-on: https://chromium-review.googlesource.com/567599 Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#486254}
-
sczs authored
Showcase is intended to be a standalone UI app and as such should not reference //ios/web or //ios/chrome. This CL eliminates the Showcase app creating an IOSChromeMain instance and thus implicitly being an //ios/web embedder, instead directly inlining the minimal parts of that startup that are needed (initializing base::CommandLine and loading resources). As part of that change, this CL eliminates Showcase bundling //ios/web resources. Bug: 738880 Change-Id: Idcd7849927e1d56fa1958de34e145beb362f4c3a Reviewed-on: https://chromium-review.googlesource.com/568243 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#486253}
-
Kent Tamura authored
Bug: 739091 Change-Id: Iff2e9afd1b472bd5acd3259651733ffe7878f542 Reviewed-on: https://chromium-review.googlesource.com/566747Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#486252}
-
Dale Curtis authored
Previously this was only enabled on Android, but we've continued to see issues with sites in the wild wasting power with a silent audio context that they never suspend. BUG=707462,732450 TEST=none Change-Id: I3ceba194be8f98b7b0a7078476fb5f000d262198 Reviewed-on: https://chromium-review.googlesource.com/568817Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#486251}
-
stanisc authored
This changes most of Extensions Store/Policy code to use a dedicated SequencedTaskRunner to post tasks rather than posting on the browser FILE thread. Initially I tried to keep the change limited to the sync related part of the Extensions code. The problem that I ran into is that different types of storage are handled in a generic way on the storage frontend (for example, all them were deleted on FILE thread). So once I migrated the sync storage, I had to modify other storage types as well. Because of that I had to access backend task runner singleton from extensions component so in order to satisfy dependencies I had to move GetBackendTaskRunner() to extensions/browser/api/storage. Some of the tests relied on TestBrowserThreadBundle making all browser threads map to the same physical thread which allowed the test code to satisfy DCHECK_CURRENTLY_ON(BrowserThread::FILE) check while running on the main test thread. With this migration that didn't work anymore so I had to modify ExtensionSettingSyncTest and PolicyValueStoreTest tests to actually post API calls on the right sequence. That was the most difficult part of this change. Other than that the rest of the changes should be straightforward. BUG=689520 Review-Url: https://codereview.chromium.org/2965153002 Cr-Commit-Position: refs/heads/master@{#486250}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a51d9227..1e323b4a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I63a1bd780da7aa81e25d7275df3ee206420938a3 Reviewed-on: https://chromium-review.googlesource.com/569262Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#486249}
-
rdsmith authored
Given that for now the call must remain present but the precise semantics of the call aren't important (see https://codereview.chromium.org/2882063002/#msg64), it's worthwhile having as clean and simple an implementation of reasonable semantics as possible. BUG=None R=mmenke@chromium.org Review-Url: https://codereview.chromium.org/2974363002 Cr-Commit-Position: refs/heads/master@{#486248}
-
yhanada authored
- Added missing data_deps to ui_test.pak. Bug: 737433 Change-Id: I4cb4ad39b8baebeb40ef2bc081741182e2ff2b5b Reviewed-on: https://chromium-review.googlesource.com/567785Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#486247}
-
smut authored
Also rename Chromium Win 10 GCE Tests to Chromium Win 10 GCE Tests (Win 7 Build). Bug: 738255 Change-Id: I526e1be2530e56176fcc6e6ef9b1884ad481b579 Reviewed-on: https://chromium-review.googlesource.com/569310Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: smut <smut@google.com> Cr-Commit-Position: refs/heads/master@{#486246}
-
Kenneth Russell authored
deqp/functional/gles3/shaderstruct.html is still failing on Win7/NVIDIA. BUG=668223 TBR=geofflang@chromium.org NOTRY=true Change-Id: Ib689a88c08e94114d947c4ca8e3890bc71508f56 Reviewed-on: https://chromium-review.googlesource.com/569456 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#486245}
-
chrome-release-bot authored
TBR=dimu@chromium.org Change-Id: I1282f598472bd4a462a91202abc9058cdb779c2b Reviewed-on: https://chromium-review.googlesource.com/569405Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#486244}
-
Matthew Halpern authored
This is a reland of b3c9a824 Original change's description: > [GRC] Add Tab-level CPU Usage Attribution Tests > > This CL adds tab-level CPU usage attribution tests for GRC. Tab-level CPU usage attribution is tested under a variety of different coordination unit graph topologies. > > A set of mock coordination unit graph topologies has also been added to the code base as a common set of coordination unit graph topologies has emerged across the coordination unit unittests. > > Bug: 691886 > Change-Id: I2e9178ca5454846320add15f9f004ba0d9df2a9f > Reviewed-on: https://chromium-review.googlesource.com/562549 > Commit-Queue: Matthew Halpern <matthalp@google.com> > Reviewed-by: Zhen Wang <zhenw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#485024} Bug: 691886 Change-Id: I91b5a898c4a9a6cf016a851c3637bebff17962ff Reviewed-on: https://chromium-review.googlesource.com/567239 Commit-Queue: Matthew Halpern <matthalp@google.com> Reviewed-by:
Zhen Wang <zhenw@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#486243}
-
Toni Barzic authored
Adds api tests for launching lock screen note taking action. Verifies that: * app_launch test * requesting new (lock screen) note action launches the app with action launch event indicating the action is launched from lock screen * the app can create lock screen enabled app window * the created window is maximized by default (and the window can accedd window.current API) * the app background page can observe the app window closure * the app cannot access identity API in lock screen context (even though the app has identity permission) * the app cannot create more than one window per launched action * non_lock_screen_context: * attempt to create lock screen enabled app window fails if called in a context different than lock screen context The cl enables following APIs in lock screen context: * chrome.runtime * to expose onInstalled event - without it the tests hit NOTREACHED when the event is dispatched on the app install. This event is also required in production to instigate initial app's event page (and registration of event listeners). * apps should have access to getManifest, getURL, messaging API (so it can communicate with the event page), getPlatformInfo * chrome.test - to expose testing APIs (needed by API tests) BUG=715781 Change-Id: I850319e98091506204d9e467bd46507b9f4863a8 Reviewed-on: https://chromium-review.googlesource.com/563543 Commit-Queue: Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Cr-Commit-Position: refs/heads/master@{#486242}
-
Kevin Marshall authored
Update Clang static analysis Markdown doc. This CL adds additional information pertaining to the proper use and maintenance of the Clang static analyzer in Chrome. R=wez@chromium.org Bug: Change-Id: Ie421d79440051d9285d6ead0f42eb2c4d0a69326 Reviewed-on: https://chromium-review.googlesource.com/535305 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#486241}
-
Erik Chen authored
Move mac_sdk_min into build/config/overrides.gni and assert that it is used. This prevents unused arg warnings from subprojects that override it. Bug: 740693 Change-Id: Ib40a52c59c852aab46781a0d44812b07b0e5061c Reviewed-on: https://chromium-review.googlesource.com/566595Reviewed-by:
Brett Wilson <brettw@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#486240}
-
dpapad authored
Bug: 739631 Change-Id: Iecabaae34cd2e20124a5721d65bb8ab92460acf5 Reviewed-on: https://chromium-review.googlesource.com/569181Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#486239}
-
Etienne Pierre-Doray authored
Cursors with convenient read and write methods to ease manipulation of raw data. Bug: 729154 Change-Id: I8a7303964b02b9df7ef033de8756b09716a91eae Reviewed-on: https://chromium-review.googlesource.com/560657 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#486238}
-
luoe authored
BUG=none Review-Url: https://codereview.chromium.org/2979653004 Cr-Commit-Position: refs/heads/master@{#486237}
-
Kevin Marshall authored
Remove unsupported perm, symlink calls for Fuchsia. Fuchsia's POSIX support does not extend to file permission bit or symbolic links. This CL conditionally removes the relevant calls from file_util and disables affected tests under Fuchsia builds. R: thakis@chromium.org Bug: 706592 Change-Id: Id6b68fd9a440f37debe50feb7ce3f457bbee3e4f Reviewed-on: https://chromium-review.googlesource.com/562901Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#486236}
-
Matt Giuca authored
Four strings from android_chrome_strings were copied into generated_resources in r478708 for use in Chrome OS. This CL moves the original strings from android_chrome_strings into generated_resources and deletes the duplicates. Now those strings are available to both Android and Chrome OS. Note that IDS_INTENT_PICKER_BUBBLE_VIEW_INCOGNITO_* are now found under the different name of IDS_EXTERNAL_APP_LEAVE_INCOGNITO_*. Bug: 678141 Change-Id: I14fb5fbca40e172bcb895afc31c5cf57359b001a Reviewed-on: https://chromium-review.googlesource.com/564741Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#486235}
-
mfomitchev authored
All of that code is UI Service specific. There's no reason GPU Service should depend on it. Before this change, services/ui/common was getting pulled into Mac and Android builds. BUG=NONE Review-Url: https://codereview.chromium.org/2976923002 Cr-Commit-Position: refs/heads/master@{#486234}
-
Yuki Awano authored
- Note that AES is still NOT supported. password protected zip. Bug: 359837 Test: Enable --enable-zip-archiver-on-file-manager flag. Try to open a Change-Id: I52435d7cf027a14a0c95b84a6f3f81116d528f85 Reviewed-on: https://chromium-review.googlesource.com/569321Reviewed-by:
Tomasz Mikolajewski <mtomasz@chromium.org> Commit-Queue: Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#486233}
-
Alok Priyadarshi authored
This reverts commit aa273aed. Reason for revert: I have disabled the test on Android and filed crbug.com/741925 to track data dependency issue on Android test bots. TBR=jbroman,dpranke,yzshen Bug: 699569 Change-Id: Ic007cf56937c586b90fc3b68a76369cd489aff53 Reviewed-on: https://chromium-review.googlesource.com/568272Reviewed-by:
Alok Priyadarshi <alokp@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Commit-Queue: Alok Priyadarshi <alokp@chromium.org> Cr-Commit-Position: refs/heads/master@{#486232}
-
Brian Salomon authored
GrBackendTextureDesc is being phased out. Change-Id: I0c2d00b0a80c63037ecc937021ef8bf978f4c359 Reviewed-on: https://chromium-review.googlesource.com/563119Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Brian Salomon <bsalomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#486231}
-
Qiang Xu authored
changes: Set all apps indicator negative transition offset limit to the place of initial suggested apps indicator. This will make: (1) when scrolling up, all apps indicator will stop at 21px padding away from search box, while all apps tiles scrolling underneath it. (2) all apps indicator will be shown on non-first page due to (1). Bug: 741009 TEST: tested with fullscreen app list enabled Change-Id: I7fa71f041f81b0939c507fb246589cfdb6dbc06a Reviewed-on: https://chromium-review.googlesource.com/569378Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Cr-Commit-Position: refs/heads/master@{#486230}
-
thomasanderson authored
This CL moves //buildtools/third_party/libc++:no_libstdcpp and part of /buildtools/third_party/libc++:config into //build/config/c++/c++. This has several advantages: * Users can remove libc++ config if they want since it's added in BUILDCONFIG.gn * Allows removal of libcxx_proxy * libc++-specific configs are in buildtools and non-libc++ configs are in build/config * Allows changing c++ flags without having to roll buildtools * Removes a bit of duplicated build configuration buildtools change: https://codereview.chromium.org/2962423002 BUG=593874 R=thakis@chromium.org TBR=dpranke@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_ng Review-Url: https://codereview.chromium.org/2964243002 Cr-Commit-Position: refs/heads/master@{#486229}
-
tapted authored
The button defaults to FocusBehavior::ACCESSIBLE_ONLY which (apart from on Mac) only affects buttons in AccessiblePaneViews (which the close button is not). Make it FocusBehavior::NEVER so the behaviour is consistent across platforms. Note this does not affect screen readers' ability to focus the element. Keyboard access to this element when not using a screen reader is done via the ESC key handler in DialogClientView. BUG=741251 Review-Url: https://codereview.chromium.org/2982533002 Cr-Commit-Position: refs/heads/master@{#486228}
-
Shimi Zhang authored
Bug: 287726 Change-Id: I521fad3c7ca7b77aff23b4b4d1a609b8efefcd40 Reviewed-on: https://chromium-review.googlesource.com/568793 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Selim Gurun <sgurun@chromium.org> Cr-Commit-Position: refs/heads/master@{#486227}
-
Ramya Sharma authored
This cl moves folderSelector, folderEditor and editViewController to a common super class from bookmark handset and table view controllers. Bug: 705339 Change-Id: I0ed26a3a6dac8d89ff8498f2753995e4772e4a8d Reviewed-on: https://chromium-review.googlesource.com/566778 Commit-Queue: Ramya Sharma <ramyasharma@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#486226}
-