- 20 Sep, 2018 18 commits
-
-
Byoungkown authored
The spec[1] states that XRCoordinateSystem inherits EventTarget. This patch implements the inheritance. [1]: https://immersive-web.github.io/webxr/#xrcoordinatesystem-interface Bug: None Change-Id: I509ff04c8bbe76a499655fa48a726ac10f444716 Reviewed-on: https://chromium-review.googlesource.com/1189503 Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#592632}
-
rbpotter authored
Ensure scale and copies have aria-labels (aria-labelledby no longer works when using cr-input instead of input). Add an aria-label for the custom pages radio button. Bug: None Change-Id: I564a31a0e9501becd2200c7c881d526772f731c6 Reviewed-on: https://chromium-review.googlesource.com/1233119 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#592631}
-
Xiaohan Wang authored
These includes are already removed on desktop platforms. Also remove it on Android. This is in preparation for replacing WIDEVINE_CDM_AVAILABLE with a buildflag. TBR=jrummell@chromium.org Bug: 349182 Test: No functionality change Change-Id: I7f873247a3c986549caf4864fcb2efcc82918bc5 Reviewed-on: https://chromium-review.googlesource.com/1231925Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#592630}
-
rbpotter authored
(1) Make errors expand/contract rather than pre-allocating space (2) Adjust padding so that padding is always 16px regardless of error state (3) Fix an issue with pages error not appearing when radio button is reselected (4) Make error line-height correct. (5) Other changes to ensure labels stay correctly aligned with controls regardless of control height. (6) No hand pointer on error text. Bug: 884752, 884729, 884603, 884640, 885039 Change-Id: I9ff4e0bbc536b0890687b678cf52640c01e5a2ef Reviewed-on: https://chromium-review.googlesource.com/1229618 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#592629}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7f2ef8dd8ad7..0086f7aa8400 git log 7f2ef8dd8ad7..0086f7aa8400 --date=short --no-merges --format='%ad %ae %s' 2018-09-19 tbrindus@chromium.org cros_generate_stateful_update_payload: Convert to chromite 2018-09-19 zamorzaev@chromium.org test_stages: use chromite VM script instead of ctest for VMTest 2018-09-19 vapier@chromium.org cros_set_lsb_release: write out new CHROMEOS_RELEASE_KEYSET field 2018-09-19 dgarrett@google.com commands: Remove overlay args to UprevPackages and UprevPush. 2018-09-19 dgarrett@google.com PublishUprevChangesStage: Use overlay_type for UprevPush. 2018-09-19 chrome-bot@chromium.org Update config settings by config-updater. 2018-09-19 bhthompson@google.com Promote more build only paladins to non-experimental Created with: gclient setdep -r src/third_party/chromite@0086f7aa8400 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ief9c03bd4c6368acb4e9ab2ca561e1eb09aed530 Reviewed-on: https://chromium-review.googlesource.com/1235239Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592628}
-
Wenzhao Zang authored
The DM color extracted from wallpaper may be transparent, or invalid in cases that the color calculation fails or is disabled. Use a backup color in such cases. Bug: 884315 Change-Id: I76724a9bb9f19dff2fd70a563d79fb82533b0bfa Reviewed-on: https://chromium-review.googlesource.com/1232516Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#592627}
-
Will Harris authored
../../chrome/chrome_cleaner/zip_archiver/test_zip_archiver_util.cc(114,69): warning: implicit conversion loses integer precision: 'std::vector<char, std::allocator<char> >::size_type' (aka 'unsigned long long') to 'Cr_z_uLong' (aka 'unsigned long') [-Wshorten-64-to-32] unzip_object, &file_info, filename.data(), filename.size(), ~~~~~~~~~^~~~~~ ../../third_party/googletest/src/googletest/include\gtest/gtest.h(1961,23): note: expanded from macro 'EXPECT_EQ' val1, val2) ^~~~ ../../third_party/googletest/src/googletest/include\gtest/gtest_pred_impl.h(161,36): note: expanded from macro 'EXPECT_PRED_FORMAT2' GTEST_PRED_FORMAT2_(pred_format, v1, v2, GTEST_NONFATAL_FAILURE_) ^~ ../../third_party/googletest/src/googletest/include\gtest/gtest_pred_impl.h(146,39): note: expanded from macro 'GTEST_PRED_FORMAT2_' GTEST_ASSERT_(pred_format(#v1, #v2, v1, v2), \ ^~ ../../third_party/googletest/src/googletest/include\gtest/gtest_pred_impl.h(76,52): note: expanded from macro 'GTEST_ASSERT_' if (const ::testing::AssertionResult gtest_ar = (expression)) \ ^~~~~~~~~~ ../../chrome/chrome_cleaner/test/test_service_main.cc(27,44): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'DWORD' (aka 'unsigned long') [-Wshorten-64-to-32] TestTimeouts::action_max_timeout().InMilliseconds(); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~ ../../chrome/chrome_cleaner/http/http_agent_impl.cc(465,50): warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'DWORD' (aka 'unsigned long') [-Wshorten-64-to-32] if (!::WinHttpReadData(request_.Get(), buffer, *count, &size_read)) { ~~ ^~~~~~ In file included from ../../chrome/chrome_cleaner/chrome_utils/extensions_util.cc:5: In file included from ../..\chrome/chrome_cleaner/chrome_utils/extensions_util.h:14: In file included from ../..\chrome/chrome_cleaner/json_parser/json_parser_api.h:8: In file included from ../..\base/callback.h:14: In file included from ../..\base/callback_internal.h:14: In file included from ../..\base/memory/ref_counted.h:18: ../..\base/memory/scoped_refptr.h(91,18): warning: implicit conversion loses integer precision: 'unsigned long long' to 'int' [-Wshorten-64-to-32] T* obj = new T(std::forward<Args>(args)...); ~ ^~~~~~~~~~~~~~~~~~~~~~~~ ../../chrome/chrome_cleaner/chrome_utils/extensions_util.cc(307,13): note: in instantiation of function template specialization 'base::MakeRefCounted<chrome_cleaner::(anonymous namespace)::ParseTasksRemainingCounter, unsigned long long, base::WaitableEvent *&>' requested here base::MakeRefCounted<ParseTasksRemainingCounter>(files_read.size(), done); ^ ../../chrome/chrome_cleaner/zip_archiver/target/zip_archiver_impl.cc(56,32): warning: implicit conversion loses integer precision: 'const long long' to 'int' [-Wshorten-64-to-32] offset, buffer.data(), std::min(length - offset, kReadBufferSize)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../chrome/chrome_cleaner/zip_archiver/target/zip_archiver_impl.cc(165,23): warning: implicit conversion loses integer precision: 'const long long' to 'int' [-Wshorten-64-to-32] std::min(src_length - src_offset, kReadBufferSize)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ BUG=879657 Change-Id: I80fbce280cd8a7e281d6f6ad58918aaab91514dd Reviewed-on: https://chromium-review.googlesource.com/1214050 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#592626}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d89e81168423..6c1a7f2c78db git log d89e81168423..6c1a7f2c78db --date=short --no-merges --format='%ad %ae %s' 2018-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 5c72f28d1a3f..d511948b9f82 (6 commits) Created with: gclient setdep -r src/third_party/skia@6c1a7f2c78db The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: Ic3174c7d52a9b781da9030d87a0f170cf0c68e1c Reviewed-on: https://chromium-review.googlesource.com/1235238Reviewed-by:
-
jchen10 authored
Use std::min instead. BUG=849576 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I7e6e76dd6c66e0b52d5c13bf87b1ca1785154654 Reviewed-on: https://chromium-review.googlesource.com/1233185 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#592624}
-
Tommy Steimel authored
This CL makes some visual tweaks to the media controls to match new specs. Bug: 884945 Change-Id: Ifdff1c51b6a2bd37555a7d018679dd77fc8781cc Reviewed-on: https://chromium-review.googlesource.com/1229696Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#592623}
-
Dale Curtis authored
Renderers are core to our entire pipeline, yet trace events are missing! So lets add a few that allow useful diagnosis when looking at trace reports. Specifically this adds traces for the following: - (AudioRenderer|VideoRenderer|RendererImpl)::Initialize() [async] - (AudioRenderer|VideoRenderer|RendererImpl)::Flush() [async] - DecoderSelector::SelectDecoder() [async] - RendererImpl::SetCdm - RendererImpl::StartPlayingFrom - RendererImpl::SetPlaybackRate - RendererImpl::OnBufferingStateChange - RendererImpl::StartPlayback - RendererImpl::PausePlayback - RendererImpl::OnRendererEnded - RendererImpl::OnError - RendererImpl::OnSelectedVideoTracksChanged - RendererImpl::OnEnabledAudioTracksChanged This also removes usage of ".is_null()" on callbacks in favor of the more modern built in boolean test. BUG=879970 TEST=none R=xhwang Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I79792d93b6369cfe4fe32f322f176b68acc92ee8 Reviewed-on: https://chromium-review.googlesource.com/1232688 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
Scott Violet authored
If it's not a WindowMus. This is an issue now that single-process-mash allows both WindowPortLocal and WindowPortMus at the same time. And updates WindowTreeClient::IsWindowKnown() not to assume a WindowMus. BUG=none TEST=none Change-Id: Ia4d1834b2a910707bae077dd14e4a9e46481fce0 Reviewed-on: https://chromium-review.googlesource.com/1235115 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#592621}
-
Steven Bennetts authored
Currently the code is triggering a crash indesktopui_MashLogin: http://ubercautotest.corp.google.com/tko/retrieve_logs.cgi?job=/results/239691238-chromeos-test/chromeos4-row2-rack3-host12/debug/ Bug: 843332 For extensions change: TBR=benwells@chromium.org Change-Id: I51d94a6924407fffbb49994ff4cb02718b517866 Reviewed-on: https://chromium-review.googlesource.com/1235206 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#592620}
-
John Budorick authored
Bug: 886926 Change-Id: Ifa80aa14b9684bfd3d54b944c40ebfa0d249ca71 Reviewed-on: https://chromium-review.googlesource.com/1234235Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#592619}
-
Doug Turner authored
Bug: 873219 Change-Id: I485848a2ddeb7187d51cf4a9b574942650bc6875 Reviewed-on: https://chromium-review.googlesource.com/1232887Reviewed-by:
Sarah Chan <spqchan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Doug Turner <dougt@chromium.org> Cr-Commit-Position: refs/heads/master@{#592618}
-
Chong Zhang authored
Chrome OS browser tests uses |ChromeNetworkDelegate::IsAccessAllowed| but |g_access_to_all_files_enabled| was not hooked in. This patch moved |g_access_to_all_files_enabled| to |IsAccessAllowedInternal| to make sure it's always checked. Bug: 884773 Change-Id: I5183f3250e13af151a987561bdf5f93a6f0200be Reviewed-on: https://chromium-review.googlesource.com/1235122 Commit-Queue: Chong Zhang <chongz@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#592617}
-
rbpotter authored
Note that title is to be changed to weight 400 rather than 500 per offline discussion (it was previously 500, not 700 as stated on the bug). Bug: 884896, 885109 Change-Id: I09aad405eaa07bcb7031b71e6bc91fb0c286b3e2 Reviewed-on: https://chromium-review.googlesource.com/1234995Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#592616}
-
Etienne Bergeron authored
On windows, the symbolisation (with crash server) requires the pdb name. The pdb name is often similar to the basename, but there is no real convention. ntdll.dll -> ntdll.pdb chrome.dll -> chrome.dll.pdb chrome1.exe -> chrome.exe.pdb R=wittman@chromium.org Change-Id: If69b2f4da24d88e9d260e8ee5024352250fbea43 Reviewed-on: https://chromium-review.googlesource.com/1234013 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#592615}
-
- 19 Sep, 2018 22 commits
-
-
rbpotter authored
Fixes some padding and focus issues in and around the link-container. (1) Correct padding above and below link-container (2) Make icon focusable rather than the entire row (3) Restore shortcut in system dialog string (4) Make icon not focusable when disabled (5) Correct padding in other-options-settings Bug: 884729, 885102, 884605 Change-Id: I0c8e1ac700ef93a4c6e247329d66285386af9f9f Reviewed-on: https://chromium-review.googlesource.com/1231826 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I246be1e0b4ad51cf966e6e407c8221416e2a2ebb Reviewed-on: https://chromium-review.googlesource.com/1235201 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592613}
-
Xiaohan Wang authored
The lkcr links are currently broken. Replace those with relative path. Change-Id: Iae3142d263af72f988cce18d5f054b81884fabaf Reviewed-on: https://chromium-review.googlesource.com/1235196Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#592612}
-
Zhiqiang Zhang authored
Previously if a new create route request comes in, we didn't consider the case where there is already a current session or there is a pending request. In this CL, when this happens, all active routes will be closed and the pending request will be canceled, so that the new request can be fulfilled without interacting with previous session/requests. Bug: 711860 Change-Id: I7cef7bf76743d2c122cf07dab0bc80db2871eca5 Reviewed-on: https://chromium-review.googlesource.com/1234794 Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#592611}
-
Clark DuVall authored
Now that we are running instrumentation tests for network service with --enable-features=NetworkService, I realized some tests override the enable-features flag, which would prevent the NetworkService feature from being enabled. This makes sure to preserve the previous value of enable-features when running tests. Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: If89c26f9c7c0ecc9afcca84f998c3cd6e8c77a2a Reviewed-on: https://chromium-review.googlesource.com/1232577Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#592610}
-
Yuri Wiitala authored
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: Ib98d01aceb856ca46a98065ff8d96ef315d56f24 Reviewed-on: https://chromium-review.googlesource.com/1232517Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#592609}
-
Stephen Martinis authored
The machines powering this builder are getting overloaded, and per my reading of crbug.com/855319 it doesn't need to run more than 4 builds at a time. Bug: 855319 Change-Id: I986ceb16e9b7795b61135c53701d20b374298ce6 Reviewed-on: https://chromium-review.googlesource.com/1235273Reviewed-by:
-
Kenneth Russell authored
We're finding that these configurations are frequently getting over-subscribed, so without more information, institute a threshold so the multi-dimemsion trigger script doesn't schedule jobs on these configurations *at all*. This will likely have side effects and require refinement, but will hopefully alleviate the immediate problem. Bug: 886985 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I5ea4823920d7e7c0d8fc9509bb853a7de13c21ff Reviewed-on: https://chromium-review.googlesource.com/1234858Reviewed-by:
-
rbpotter authored
Bug: 884739, 884632, 885043 Change-Id: I59303415e30a288c8adc2799a06500f33e60ddee Reviewed-on: https://chromium-review.googlesource.com/1231253 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Jia authored
BrightnessMonitor receives brightness change signals from powerd and sends out notifications if the change is requested by user. We use this class instead of powerd directly because we need final/stablized user brightness instead of intermediate values (that are individually emitted by powerd). In order to wait for brightness to stablize, we use a timer that starts when a user brightness is detected and times out after a period of time if there's no more user brightness detected, or if the next brightness change is not triggered by the user. BrightnessMonitor also notifies its observers as soon as a user brightness is detected so that an observer can decide what to do (e.g disable auto-adjustment). Bug: 881215 Change-Id: I2d9aefd8ff48eab37de9527d12657fd4dfeba793 Reviewed-on: https://chromium-review.googlesource.com/1226715Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Michael Martis <martis@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#592605}
-
Asanka Herath authored
Test is flaky. Bug: 884118 Change-Id: I0cd103f1340536eee94a28cafe579cf186804840 Reviewed-on: https://chromium-review.googlesource.com/1231157Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/299ed678d06b..91c7297741c9 Created with: gclient setdep -r src-internal@91c7297741c9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib77e2f2e057aad3c224cad04419ffcafab79e991 Reviewed-on: https://chromium-review.googlesource.com/1234826Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592603}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e2e437a4c577..7f2ef8dd8ad7 git log e2e437a4c577..7f2ef8dd8ad7 --date=short --no-merges --format='%ad %ae %s' 2018-09-19 bhthompson@google.com Promote auron_paine-paladin to non-experimental Created with: gclient setdep -r src/third_party/chromite@7f2ef8dd8ad7 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ic7743fea07c574a749f74736d252c80296cb8a32 Reviewed-on: https://chromium-review.googlesource.com/1234825Reviewed-by:
-
Thomas Guilbert authored
This CL allows MediaRouteControllers to prevent routes from being shown in the MediaRouteChooserDialog, based off of some filtering from the MediaRouter.RouteInfo. This filtering mechanism will be used in downstream code. Bug: 109926233 Change-Id: Iee0c1fa44a94a0a5618164f185ddc4237934d018 Reviewed-on: https://chromium-review.googlesource.com/1234773 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#592601}
-
Shuotao Gao authored
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: Ic537c720e32dffc9ade585a85a4b8d1afce4c001 Reviewed-on: https://chromium-review.googlesource.com/1231113Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
-
rajendrant authored
This CL implements support for the "lazyload" attribute on images, according to https://github.com/whatwg/html/pull/3752, and as part of the LazyLoad feature. The accepted values are: "off", which causes the browser to avoid lazily loading the <img> element "on" and "auto", activate the default behavior of lazily load the <img> element When the attribute is changed to "off", the deferred image loads immediately. Bug: 875080 Change-Id: I839926a9827d019f23aafc40f8315476fe1b3048 Reviewed-on: https://chromium-review.googlesource.com/1197782Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#592599}
-
Yuri Wiitala authored
A memory leak was identified in ui::Cursor::GetDefaultBitmap() on Aura platforms. This patch fixes that memory leak, and also removes the need to memory-manage the SkBitmaps returned by CreateSkBitmapFromHICON(). Note that SkBitmap internally manages a ref-counted pointer to its payload, and is also a movable type; and so there is no need for any code to treat SkBitmaps as "heavyweight" when passing them around. Bug: 873774 Change-Id: I11e7a98fcec42e27213b85d08d81fc47948d483e Reviewed-on: https://chromium-review.googlesource.com/1234372Reviewed-by:
Weidong Guo <weidongg@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a5c578ff3d46..d89e81168423 git log a5c578ff3d46..d89e81168423 --date=short --no-merges --format='%ad %ae %s' 2018-09-19 bungeman@google.com SkImageGeneratorCG.h to only expose factory method. 2018-09-19 michaelludwig@google.com Increase precision for two point gradient coordinates. 2018-09-19 halcanary@google.com SkPDF: draw persepctive text 2018-09-19 halcanary@google.com SkImageGeneratorWIC: make the header compile without src/. 2018-09-19 brianosman@google.com GrColor -> SkColor in one GM 2018-09-19 herb@google.com Clean up GPU strike sk_sp 2018-09-19 nodir@google.com Populate repo_path_map 2018-09-19 reed@google.com Revert "always optimize third_party code" Created with: gclient setdep -r src/third_party/skia@d89e81168423 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:884150,chromium:694348 TBR=reed@chromium.org Change-Id: I008043cc934cb833a7a9934714c6e9d17a99139f Reviewed-on: https://chromium-review.googlesource.com/1234823Reviewed-by:
-
smut authored
Bug: 723130 Change-Id: I514683aa6441fbe0fd9b45761b684040586412f7 Reviewed-on: https://chromium-review.googlesource.com/1234796Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: smut <smut@google.com> Cr-Commit-Position: refs/heads/master@{#592596}
-
Michael Spang authored
Move gpu::CreateVulkanImplementation() call after InitializeForGPU() so that it can work under ozone builds. Prior to InitializeForGPU(), there's no surface factory and attempting to initialize vulkan will simply crash. (2) gn gen out/linux_ozone_rel --args='use_ozone=true is_debug=false' (3) ./out/linux_ozone_rel/content_shell --enable-vulkan Bug: 861853 Test: (1) apply penghuang's WIP vulkan oop-d patches Change-Id: I85b04d1cb366afff075dc86c1698caa6e67f93f0 Reviewed-on: https://chromium-review.googlesource.com/1234222Reviewed-by:Antoine Labour <piman@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#592595}
-
Dmitry Gozman authored
This should not make any difference, but will allow to call CommitNavigation directly from StartNavigation when needed. Bug: 855189 Change-Id: Icd7184404784fde750c3d013e02042007f3aa0a7 Reviewed-on: https://chromium-review.googlesource.com/1231830 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#592594}
-
Yue Cen authored
This reverts commit f76c19a8. Reason for revert: Re-enable in M71 Original change's description: > Disable fast app reinstall feature for M70 > > The plan is to ship the feature in M71. This CL will be merge to M70 and > reverted in M71. > > Bug: 835029 > Change-Id: I741c60ccbff2570a07fc9c3535b0acea6efa1ed8 > Reviewed-on: https://chromium-review.googlesource.com/1234966 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Yue Cen <rsgingerrs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592550} TBR=xiyuan@chromium.org,rsgingerrs@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 835029 Change-Id: Ib83098f9d8f57d5325c10e9bc3ca7c6f46adb0dd Reviewed-on: https://chromium-review.googlesource.com/1235126Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#592593}
-
