- 06 Mar, 2014 4 commits
-
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255188 0039d316-1c4b-4281-b951-d872f2087c98
-
sdefresne@chromium.org authored
Manually patches in 77400c22b5bafd8aaaa75f90a1d997838204577a from upstream. Description: Also on arm64, BOOL seems to be encoded as "bool" (the 'B' objcType, or _C_BOOL) rather than the historical 'c', but NSValue can still use 'c', so we need to have those compare as equal. BUG=314720 Review URL: https://codereview.chromium.org/177373009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255187 0039d316-1c4b-4281-b951-d872f2087c98
-
tonyg@google.com authored
TBR=isherman@chromium.org,qyearsley@chromium.org NOTRY=True BUG= Review URL: https://codereview.chromium.org/181233013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255186 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
The WindowTreeHost implementation for X11 currently receives an event from X11 when the keyboard mapping changes in the system. The implementation then calls into WindowTreeHost::OnKeyboardMappingChanged(), which triggers the corresponding method in all WindowTreeHostObservers. The EventRewriter is a WindowTreeHostObserver, and so it can then reset the keycodes it maintains. But the EventRewriter is also a MessagePumpObserver, which means it already receives the X11 MappingNotify event, and so the plumbing of the event through aura is unnecessary. There is no other consumer of WindowTreeHostObserver::OnKeyboardMappingChanged(), so remove it from the api. BUG=343639 R=oshima@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/183893031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255185 0039d316-1c4b-4281-b951-d872f2087c98
-
- 05 Mar, 2014 36 commits
-
-
dvh@chromium.org authored
> Cast: Using a min filter to compute time offset > > Modifying the time offset filter to take to minimum of the first 10 values. > Once ten offset values were seen, the value will be constant for the entire session. > This may be justified by the fact we are seeking the offset between sender and > receiver without accounting the network jitter. > > Review URL: https://codereview.chromium.org/186043003 TBR=mikhal@chromium.org Review URL: https://codereview.chromium.org/183063011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255173 0039d316-1c4b-4281-b951-d872f2087c98
-
tim@chromium.org authored
> Disable HostDriven_SyncTest.testDisableAndEnableSync > > BUG=348951 > NOTRY=true > > Review URL: https://codereview.chromium.org/180273024 NOTRY=true R=boliu@chromium.org, nyquist@chromium.org TBR=nyquist@chromium.org Review URL: https://codereview.chromium.org/186643004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255168 0039d316-1c4b-4281-b951-d872f2087c98
-
zmo@chromium.org authored
BUG= TEST=mac 10.9 bots green TBR=kbr@chromium.org Review URL: https://codereview.chromium.org/188013004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255167 0039d316-1c4b-4281-b951-d872f2087c98
-
mikhal@chromium.org authored
Modifying the time offset filter to take to minimum of the first 10 values. Once ten offset values were seen, the value will be constant for the entire session. This may be justified by the fact we are seeking the offset between sender and receiver without accounting the network jitter. Review URL: https://codereview.chromium.org/186043003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255166 0039d316-1c4b-4281-b951-d872f2087c98
-
nasko@chromium.org authored
BUG=304341 R=creis@chromium.org Review URL: https://codereview.chromium.org/185993008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255165 0039d316-1c4b-4281-b951-d872f2087c98
-
dalecurtis@chromium.org authored
Also fixes a couple of the unittests and adds a debug log for when this occurs. BUG=176862 TEST=WebAudio reports the correct number of frames. Review URL: https://codereview.chromium.org/187223002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255162 0039d316-1c4b-4281-b951-d872f2087c98
-
wtc@chromium.org authored
Replace the custom ProxyConfigServiceDirect class with the equivalent net::ProxyConfigServiceFixed class. Original code review: https://codereview.chromium.org/180283003 TBR=eroman@chromium.org,stgao@chromium.org,rlarocque@chromium.org BUG=none TEST=none Review URL: https://codereview.chromium.org/185993009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255160 0039d316-1c4b-4281-b951-d872f2087c98
-
vivek.vg@samsung.com authored
While building with clang=1, clang reports this error about the above variable being unused. BUG=349521 NOTRY=true Review URL: https://codereview.chromium.org/188003002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255159 0039d316-1c4b-4281-b951-d872f2087c98
-
xians@chromium.org authored
We need to reset the render_thread_checker and render_converter_ when the WebRtcAudioRenderer is going away. NOTRY=true BUG=264611 TEST=manual test webrtc with --enable-audio-track-processor Review URL: https://codereview.chromium.org/178153007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255158 0039d316-1c4b-4281-b951-d872f2087c98
-
noamsml@chromium.org authored
Since packets we don't understand are not actually that unexpected, turn LOG(WARNING) messages in the mDNS code to DVLOG(1). BUG= Review URL: https://codereview.chromium.org/177373013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255157 0039d316-1c4b-4281-b951-d872f2087c98
-
teravest@chromium.org authored
The current behavior of FileDownloader::url() is strange since the value changes after the initial GET request. I've found this a little awkward, and decided to make url() always return the url passed to FileDownloader, and full_url() return the extra url information from the GET request. BUG= R=dmichael@chromium.org Review URL: https://codereview.chromium.org/181933005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255156 0039d316-1c4b-4281-b951-d872f2087c98
-
chrishtr@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/168183004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255155 0039d316-1c4b-4281-b951-d872f2087c98
-
alexst@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/183723003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255153 0039d316-1c4b-4281-b951-d872f2087c98
-
wjia@chromium.org authored
BUG=181069 R=ronghuawu@chromium.org Review URL: https://codereview.chromium.org/183893025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255152 0039d316-1c4b-4281-b951-d872f2087c98
-
caitkp@chromium.org authored
1. Add functionality to ServiceResolverThunk to copy a thunk without patching. 2. Move chrome_elf thunk-handling code to a common location. 3. Use a thunk instead of a f'n ptr for redirects. BUG=334379 Review URL: https://codereview.chromium.org/183833004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255151 0039d316-1c4b-4281-b951-d872f2087c98
-
ccameron@chromium.org authored
This is necessary to ensure correct ordering of the CALayers of the child NSViews of the window's content view. Most of the time the NSViews appeared in the correct order, but not all of the time (especially on 10.6). This fixes that issue. Remove code to dynamically do this when entering and leaving presentation mode. Update the FastResizeView to host a white CALayer instead of trying to call drawRect, and make the NSView opaque. This caused a performance drop last time it was tried, but other performance fixes, and the FastResizeView fix might make it so that this does not have an appreciable performance impact. BUG=348490 NOTRY=True Review URL: https://codereview.chromium.org/184433005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255150 0039d316-1c4b-4281-b951-d872f2087c98
-
mseaborn@chromium.org authored
PNaCl is being upgraded to Clang 3.4, which now warns about unused declarations inside anonymous namespaces. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3757 TEST=compile using new PNaCl toolchain R=binji@chromium.org Review URL: https://codereview.chromium.org/183743028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255149 0039d316-1c4b-4281-b951-d872f2087c98
-
viettrungluu@chromium.org authored
It's hardly used and not implemented on various platforms. (More deprecation work here to come.) R=brettw@chromium.org TBR=sky@chromium.org BUG=345734 Review URL: https://codereview.chromium.org/186473002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255148 0039d316-1c4b-4281-b951-d872f2087c98
-
mseaborn@chromium.org authored
PNaCl is being upgraded to Clang 3.4, which now warns about unused declarations inside anonymous namespaces. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3757 TEST=compile using new PNaCl toolchain R=binji@chromium.org Review URL: https://codereview.chromium.org/182733012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255147 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255146 0039d316-1c4b-4281-b951-d872f2087c98
-
mallinath@chromium.org authored
R=ajm@chromium.org, phoglund@chromium.org, ronghuawu@chromium.org Review URL: https://codereview.chromium.org/186193008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255145 0039d316-1c4b-4281-b951-d872f2087c98
-
msw@chromium.org authored
Rename the IDRs and the image asset files. This is a followup fix requested of r254805. BUG=319103,187485 TEST=none R=oshima@chromium.org TBR=oshima@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/187603007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255143 0039d316-1c4b-4281-b951-d872f2087c98
-
pkotwicz@chromium.org authored
BUG=342926 TEST=Manual, see bug Review URL: https://codereview.chromium.org/187333004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255142 0039d316-1c4b-4281-b951-d872f2087c98
-
reed@google.com authored
BUG=skia:2239 TBR=scherkus@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254567 reopened (after revewer) to address media_unittest valgrind issue Review URL: https://codereview.chromium.org/184743002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255137 0039d316-1c4b-4281-b951-d872f2087c98
-
jianli@chromium.org authored
We also remove cert from the registration request. BUG=345413 TEST=tests updated R=fgorski@chromium.org, tim@chromium.org, zea@chromium.org Review URL: https://codereview.chromium.org/179043005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255136 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255135 0039d316-1c4b-4281-b951-d872f2087c98
-
cbiesinger@chromium.org authored
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=168491:168503&mode=html TBR= BUG= Review URL: https://codereview.chromium.org/184293010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255133 0039d316-1c4b-4281-b951-d872f2087c98
-
rvargas@chromium.org authored
BUG=322664 R=mseaborn@chromium.org, cpu@chromium.org Review URL: https://codereview.chromium.org/165663002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255131 0039d316-1c4b-4281-b951-d872f2087c98
-
dmikurube@chromium.org authored
This change is to add a new build option 'use_allocator' which will replace 'linux_use_tcmalloc' in the future. It doesn't change the behavior immediately. The migration plan is as follows: 1) (this change) ... Add 'use_allocator' and set its default to "see_use_tcmalloc". ... Change allocator conditions to check use_allocator firstly. ... Use linux_use_tcmalloc if use_allocator=="see_use_tcmalloc". ... NO IMPACT without specifying use_allocator explicitly. 2) Change Blink to accept use_allocator. http://crrev.com/177053003/ 3) Change gyp to accept use_allocator. http://crrev.com/178643004/ 4) PSA the transition period to chromium-dev@. 5) (after the PSA-ed transition period) ... Make 'use_allocator' to "tcmalloc" or "none" (it depends) by default. ... Remove all linux_use_tcmalloc. ... Assert in gyp_chromium to check if linux_use_tcmalloc is not specified. At the point of this change (1), linux_use_tcmalloc is still used by default because 'use_allocator%': "see_use_tcmalloc". As written in http://crbug.com/345554, linux_use_tcmalloc would be confusing to have more options about allocators. We plan to: A) enable gperftools' heap-profiler with non-tcmalloc allocator, B) add a new memory allocator instead of tcmalloc. BUG=345554, 339604, 341349 R=agl@chromium.org, brettw@chromium.org, dgarrett@chromium.org, jam@chromium.org, jamesr@chromium.org, joi@chromium.org, miket@chromium.org, nick@chromium.org, rsleevi@chromium.org, scherkus@chromium.org, sergeyu@chromium.org, shess@chromium.org, sievers@chromium.org, sky@chromium.org, vitalybuka@chromium.org, willchan@chromium.org Review URL: https://codereview.chromium.org/177353002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255129 0039d316-1c4b-4281-b951-d872f2087c98
-
gavinp@chromium.org authored
Webkit layout tests found more media logs serializing infinite durations to JSON. R=scherkus@chromium.org TBR=ajwong@chromium.org,jar@chromium.org,jamesr@chomium.org,acolwell@chromium.org,nick@chromium.org BUG=None Review URL: https://codereview.chromium.org/186683002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255128 0039d316-1c4b-4281-b951-d872f2087c98
-
caitkp@chromium.org authored
BUG=349423 R=mark@chromium.org Review URL: https://codereview.chromium.org/177113010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255127 0039d316-1c4b-4281-b951-d872f2087c98
-
mnissler@chromium.org authored
Devices that can't keep their clocks correct will otherwise ignore the policy. We're doing the same for device policy already, and the timestamp checks remain in place for policy updates, so this is OK. BUG=chromium:347846 Review URL: https://codereview.chromium.org/184373002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255126 0039d316-1c4b-4281-b951-d872f2087c98
-
stevenjb@chromium.org authored
This changes Chrome to use Manager.DefaultService to provide the default network to Chrome (i.e. NetworkChangeNotifier) instead of relying on Manager.Services[0]. This should fix some timing issues and make the NCS more in sync with Shill. One change in behavior that should be benign is that Shill considers a connecting network to be the default network, whereas previously only a connected network would be considered. BUG=159540, 330873 R=gauravsh@chromium.org, pneubeck@chromium.org, tbarzic@chromium.org Review URL: https://codereview.chromium.org/175243004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255124 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255123 0039d316-1c4b-4281-b951-d872f2087c98
-
robertshield@chromium.org authored
BUG=264859 TEST=chrome/test/mini_installer/test_installer.py NOTRY=true TBR=gab Review URL: https://codereview.chromium.org/187813005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255122 0039d316-1c4b-4281-b951-d872f2087c98
-
nduca@chromium.org authored
TBR=dsinclair NOTRY=True Review URL: https://codereview.chromium.org/187773004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255121 0039d316-1c4b-4281-b951-d872f2087c98
-