GitLab

yet. That file is affecting page load speed.

BUG=252704
TBR=mpcomplete@chromium.org

Review URL: https://chromiumcodereview.appspot.com/17247007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208030 0039d316-1c4b-4281-b951-d872f2087c98

The CL also removes some NOTREACHED()s which could be reached in normal (but rare) cases.

BUG=247225
TEST=None

Review URL: https://chromiumcodereview.appspot.com/17247004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208029 0039d316-1c4b-4281-b951-d872f2087c98

BUG=246854
TEST=none

Review URL: https://chromiumcodereview.appspot.com/17243004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208028 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://chromiumcodereview.appspot.com/17215003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208027 0039d316-1c4b-4281-b951-d872f2087c98

Proposal:https://docs.google.com/a/chromium.org/document/d/1U_exKvPmT4AXyqFuHgVBbgBZ2RAKNBjk6MwSPcceWXw/edit

Overview
We’d like to have a set of APIs useful for diagnostics tools, and initially, an API that can be used to replicate ping and traceroute functionality.

Use cases
The sendPacket API is used by a diagnostics tool to find problems in the network configuration of an environment and determine latency issues.

BUG=250851

Review URL: https://chromiumcodereview.appspot.com/17210002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208026 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/17322003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208025 0039d316-1c4b-4281-b951-d872f2087c98

Change SessionModelAssociator and TabNodePool to reuse old tab nodes.
Old tab nodes are now added to TabNodePool and if there is an
existing old tab node with syncid of tab, the tab is reassociated
with that node.
Note: In order for tab reassociation to work, the syncid of a tab
should be persisted. This CL just introduces the sync changes for
reassociating tab nodes. Persisting syncid with tab will be done
in a separate CL for Desktop, and in a downstream CL for Android.

BUG=139670,12549,139666
TEST=Includes unit tests + MANUAL testing on Android.

Review URL: https://chromiumcodereview.appspot.com/16421003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208024 0039d316-1c4b-4281-b951-d872f2087c98

Created InstantServiceObserver to define an observer interface for InstantService. Registered InstantController as an InstantServiceObserver to get theme change events. We no longer send theme changed events on tab switch.

BUG=225760
TEST=Added an interactive ui test.

Review URL: https://chromiumcodereview.appspot.com/16413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208023 0039d316-1c4b-4281-b951-d872f2087c98

* Adds support for using the PSL for matching the origin when looking
up passwords using the default password store.
* On Android, change the layout for label and sublabels in autofill
popups.

The feature is currently behind the flag
--enable-password-autofill-psl-domain-matching

BUG=176386

Review URL: https://chromiumcodereview.appspot.com/15660018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208022 0039d316-1c4b-4281-b951-d872f2087c98

Adds fence support for EGL.

BUG=

Review URL: https://chromiumcodereview.appspot.com/14358014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208021 0039d316-1c4b-4281-b951-d872f2087c98

added back support to speech when ask_user=false. We should use the default device for the deprecated API.

TBR=henrika@chromium.org

BUG=252848
TEST=
<script>
recognition = new webkitSpeechRecognition();
recognition.start();
</script>

Review URL: https://codereview.chromium.org/17074008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208020 0039d316-1c4b-4281-b951-d872f2087c98

Before using the robot account refresh token stored in an enterprise
device's Local State, verify that the token is owned by the service
account id found in the device policy.

BUG=245121

Review URL: https://chromiumcodereview.appspot.com/17109006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208019 0039d316-1c4b-4281-b951-d872f2087c98

An important thing is that [NativeWidget A] owns Win32 input focus even
when [View X] is logically focused by FocusManager. As a result, an Win32
IME may want to interact with the native view of [NativeWidget A] rather
than that of [NativeWidget B]. This is why we need to call
GetTopLevelWidget() here.

Previous implementation treated [NativeWidget B] as associated with
the IME but it was wrong. This CL fixes the this confusion.

BUG=246534

Review URL: https://chromiumcodereview.appspot.com/17101019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208018 0039d316-1c4b-4281-b951-d872f2087c98

Crashed apps are not listed in Apps Developer Tool because of a
mismatch of argument order when calling setTerminatedReloadLink_.
Also fix setTerminatedReloadLink_ to add event listener instead of
calling chrome.developerPrivate.reload.

BUG=251912

Review URL: https://chromiumcodereview.appspot.com/17095008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208017 0039d316-1c4b-4281-b951-d872f2087c98

 should use chrome://session-favicon like other_devices.js. 

BUG=251818

Review URL: https://chromiumcodereview.appspot.com/16943018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208016 0039d316-1c4b-4281-b951-d872f2087c98

This is the case for empty files.

BUG=

Review URL: https://chromiumcodereview.appspot.com/17561002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208015 0039d316-1c4b-4281-b951-d872f2087c98

Any unrequested draws will cause UI corruption if they hit the GL path.
The strategy is to disallow any such draws, but to enable diagnosis
force them into the SW path where they cause less UI damange but we can
log or assert as appropriate.

BUG=

Review URL: https://chromiumcodereview.appspot.com/17553012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208014 0039d316-1c4b-4281-b951-d872f2087c98

Collect the custodian's GAIA account display name using the
ProfileDownloader and save it in the supervised user's prefs
so it can be shown in that profile's UI.

BUG=249691
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/16950018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208013 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208012 0039d316-1c4b-4281-b951-d872f2087c98

Now all the thing that the class does is to delete request objects.
The lifetime management duty is moved to RequestSender.
* NotifyStart => no op.
* NotifyFinish => sender_->RequestFinished.

BUG=164098

Review URL: https://chromiumcodereview.appspot.com/17175017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208011 0039d316-1c4b-4281-b951-d872f2087c98

Collect the custodian's signed-in status each time the confirmation
dialog is shown, to catch changes in status that happen after the
Settings page loads.

Also HTML-escape the new profile's name (and the custodian's email,
for good measure), so the confirmation-dialog string can be HTML rather
than text and the link to the management page can be active.

BUG=252860, 252691
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/17155020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208010 0039d316-1c4b-4281-b951-d872f2087c98

These properties (specifically related to cellular activation)
are used by MobileActivator and needed to transition it to use
the Network*Handlers.

BUG=188753

Review URL: https://chromiumcodereview.appspot.com/17091006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208009 0039d316-1c4b-4281-b951-d872f2087c98

- Anchors the zoom bubble to the magnifying glass when the zoom bubble is visible and the top-of-window view are revealed in immersive fullscreen. The top-of-window views stay revealed as long as the zoom bubble is visible.
- Positions the zoom bubble in the top right when in immersive fullscreen and the top-of-window views are not already revealed. For the sake of simplicity the zoom bubble is closed if the user reveals the top-of-window views.

BUG=181062
TEST=Manual, see bug

Review URL: https://chromiumcodereview.appspot.com/16998006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208008 0039d316-1c4b-4281-b951-d872f2087c98

16025005 had review from: palmer@chromium.org, piman@chromium.org, scherkus@chromium.org

BUG=163795
TBR=scherkus@chromium.org

Review URL: https://codereview.chromium.org/17288018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208003 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208001 0039d316-1c4b-4281-b951-d872f2087c98

If we call up view invalidate and OnDraw is not called before a
deadline, then we keep ticking the SynchronousCompositor so it can make
progress.

BUG=
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/17136003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207999 0039d316-1c4b-4281-b951-d872f2087c98

This CL contains the following fixes:
- shows the notification for display rotation / ui_scale
- adds (width x height) annotation to the display if something
  has been edited
- shows the internal display's status if something for the internal
  display has been edited and no external display is connected
- shows the tooltip text to provide the status of both internal and
  extrenal displays at the same time

This CL does not contain:
- the feature to prevent notification when the settings change happens
  from chrome://settings/display

I think we can achieve this by suppressing the notification when
the current active tab is chrome://settings/display, but anyways
it'll be done in another CL. That is marked as a TODO.

BUG=250650, 246271

Review URL: https://chromiumcodereview.appspot.com/17445002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207998 0039d316-1c4b-4281-b951-d872f2087c98

r207989. But it looks more like an accidental commit.

TBR=crogers@google.com

Review URL: https://codereview.chromium.org/17176031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207996 0039d316-1c4b-4281-b951-d872f2087c98

except for a very small subset of them, and use the safe builtins to make the
test pass.

This will give us a decent sense of confidence that web pages can't
accidentally override builtins in a way that breaks us, though there are still
infinite ways for an extension to deliberately break itself.

BUG=55316
R=jyasskin@chromium.org

Review URL: https://codereview.chromium.org/17451011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207995 0039d316-1c4b-4281-b951-d872f2087c98

This gives all the buttons appropriate roles, AXTitles, and makes accessible
more of the notification content.

BUG=238248
R=dewittj@chromium.org, dmazzoni@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/17408004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207994 0039d316-1c4b-4281-b951-d872f2087c98

use ChildThread for main loop - fix Android build

whitespace fix

minor style fix

last minute compile fixes

address Antoine's comments

minor changes to reflect latest Blink API -- address palmer comments

last minute include order fix

address last minute style nits

stub out other OSes

support Takashi's MIDIAccessor

fix minor build err

undo param traits changes

get rid of param_traits - other minor style nits

address scherkus comments

use int64 for ParamTraits

WIP fix white-space issues more style basically working some cleanup -- support for multiple clients forgot midi_manager.cc Get MIDI port information sent to renderer formatting fixes lots of cleanup - added RequestAccess and Send style more style only bother sending received messages to renderer if approval was asked early steps to granting permission to Blink some progress to sending port info to Blink send client_id when requesting access fix minor style issues in .gyp files fix context/browser DEPS fix include paths

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207992 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=tools/checkdeps/checkdeps.py succeeds
R=piman@chromium.org

Review URL: https://codereview.chromium.org/17183012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207991 0039d316-1c4b-4281-b951-d872f2087c98

1) Makes the favicons (tab, bookmarks) look the same in the browser UI as they do in the renderer). This fixes a regression (probably by one of my CLs) since https://codereview.chromium.org/6117006
2) Make the favicons in the tab strip look the same after refreshing. The difference is due to the conversions PNG -> NSImage and PNG -> SkBitmap -> NSImage producing visually different NSImages. In particular, the result is different when the input PNG data has no colorspace information specified. Cocoa defaults to the device colorspace when decoding PNG data with no colorspace information. The generic RGB colorspace is used for converting from SkBitmap to NSImage. 

BUG=242877
TEST=Manual, see bug

Review URL: https://chromiumcodereview.appspot.com/16370006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207990 0039d316-1c4b-4281-b951-d872f2087c98

> Implement Web MIDI API back-end
> 
> This involves browser-side support and IPC for sending and receiving
> MIDI messages.  Initially support for OSX is included.
> 
> BUG=163795
> R=palmer@chromium.org, piman@chromium.org, scherkus@chromium.org
> 
> Review URL: https://codereview.chromium.org/16025005

TBR=crogers@google.com

Review URL: https://codereview.chromium.org/17334006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207989 0039d316-1c4b-4281-b951-d872f2087c98

The semantics of shallow finish are to block until the GPU process has issued all prior GL commands, without necessarily waiting for the GPU to complete them. It might have better performance than a regular finish in some cases. It is also less likely to hang if the GPU hangs on some platforms, such as Windows.

Review URL: https://chromiumcodereview.appspot.com/17504006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207985 0039d316-1c4b-4281-b951-d872f2087c98

Webview allows enabling/disabling autocomplete per instance which is different than chromium browser which does it per profile. Address this using external_delegate.

BUG=b/6335434

Review URL: https://chromiumcodereview.appspot.com/15097004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207984 0039d316-1c4b-4281-b951-d872f2087c98

This involves browser-side support and IPC for sending and receiving
MIDI messages.  Initially support for OSX is included.

BUG=163795
R=palmer@chromium.org, piman@chromium.org, scherkus@chromium.org

Review URL: https://codereview.chromium.org/16025005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207983 0039d316-1c4b-4281-b951-d872f2087c98

NOTE that this must be patched on top of https://codereview.chromium.org/15176004/

TODOs: Add a list of adjustments here before review.

Review URL: https://chromiumcodereview.appspot.com/16336002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207982 0039d316-1c4b-4281-b951-d872f2087c98

From "Do not disturb" to "Do Not Disturb".

BUG=252840

Review URL: https://chromiumcodereview.appspot.com/17068015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207981 0039d316-1c4b-4281-b951-d872f2087c98

The ADT bundle link was 404'ing. This updates the link to the newer version of the ADT bundle which is up on the Android site.

BUG=252776

Review URL: https://chromiumcodereview.appspot.com/16867011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207980 0039d316-1c4b-4281-b951-d872f2087c98