- 22 Oct, 2018 40 commits
-
-
Michael Giuffrida authored
See https://crrev.com/c/1294419 for a new PRESUBMIT to check this. Bug: 897868 Change-Id: I05fab30fdf8c0b58a8925595ff22d848b3e85176 Reviewed-on: https://chromium-review.googlesource.com/c/1294589Reviewed-by:
Zachary Kuznia <zork@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#601763}
-
dpapad authored
Take into account that in Shadow DOM v1 document-fragment elements are reported in an Event's path. Bug: 897168 Change-Id: I95d16b46ec2b66244b03f5b9aec98d0ca6dc7abc Reviewed-on: https://chromium-review.googlesource.com/c/1294422Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#601762}
-
Matthew Jones authored
This patch fixes a crash caused by calling setToolbarSwipeLayout on a null object. This is the result of a device changing display size and returning to chrome. When the display size is set to small the device uses phone assets and on some devices, when the display is set to large some devices will use tablet assets. The crash comes from the value cached by the Duet feature which doesn't expect the device assets to change. Bug: 896655 Change-Id: I5d4a0d6d989a1a48d595a303a965e460592ad20b Reviewed-on: https://chromium-review.googlesource.com/c/1294515Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#601761}
-
Zhenyao Mo authored
BUG=896932 TEST=about:histograms R=kbr@chromium.org,sunnyps@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I20db893a19ff93120ce40fded22eaa153546ac3b Reviewed-on: https://chromium-review.googlesource.com/c/1290202 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#601760}
-
Greg Kerr authored
This reverts commit 9789adec. Reason for revert: High NaCl crash rate since this landed. Original change's description: > macOS V2 Sandbox: Report correct sandbox profile for nacl-loader. > > The nacl loader process, used only on macOS, currently tries to load an > invalid profile type under the V2 sandbox. This loads the correct type. > This also adds necessary IOKit resource access to the nacl sandbox profile. > > Bug: 892554 > Tbr: dschuff@chromium.org > Change-Id: Ib35c67684bfda9ef052ea62576f8277a97caefd8 > Reviewed-on: https://chromium-review.googlesource.com/c/1292606 > Commit-Queue: Greg Kerr <kerrnel@chromium.org> > Reviewed-by: Derek Schuff <dschuff@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601332} TBR=dschuff@chromium.org,kerrnel@chromium.org,rsesek@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 892554 Change-Id: I1cb2c2b998e3c1286028689b9cdbf2a8dec9519a Reviewed-on: https://chromium-review.googlesource.com/c/1294692Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#601759}
-
Zhenyao Mo authored
Because we don't want to disable necessary workarounds on bots, otherwise Chrome run may fail. BUG=895020,895945 TEST=gpu_unittests,gpu_integration_test:gpu_process R=piman@chromium.org Change-Id: I496e3cac9f16943d57cb10334648c1b54f976543 Reviewed-on: https://chromium-review.googlesource.com/c/1289699 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
-
Tanya Gupta authored
Change-Id: Id912814a9028d1a705715d7ad482db2c0ebdc36f Bug: 881502 Reviewed-on: https://chromium-review.googlesource.com/c/1279228 Commit-Queue: Tanya Gupta <tgupta@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#601757}
-
Becky Zhou authored
+ Add support for ripple color on borderless button + Refactor out background drawable logic to another class Bug: 849126, 856244 Change-Id: I5960714129110bea0b9d284779f71592d90e4a36 Reviewed-on: https://chromium-review.googlesource.com/c/1293172Reviewed-by:
-
Weidong Guo authored
Changes: 1. Avoid calculating and updating opacity for all apps for each dragging update. Instead, calculate opacity of each row in current page and only update changed apps. Also avoid button press on page switcher during dragging to prevent opacity not being reset. 2. Clear search results after widget has been destroyed to avoid jank during close animation. Bug: 897384 Change-Id: Id0e848cc82f60740212467c64e05d032081ad45b Reviewed-on: https://chromium-review.googlesource.com/c/1292386Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#601755}
-
Paul Jensen authored
Change-Id: I553d679a5330d316da75e8241a8f97fd7934bd7c Reviewed-on: https://chromium-review.googlesource.com/c/1291593Reviewed-by:
-
Nektarios Paisios authored
Removes some legacy behavior that is not present in Firefox. The busy state is not being used on the document object so checking for its presence is unnecessary. R=dmazzoni@chromium.org, aleventhal@chromium.org Bug: 897177 Change-Id: I766b0fb9c862b76803a43c38c34fd62b30336f5f Reviewed-on: https://chromium-review.googlesource.com/c/1294303Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#601753}
-
Becky Zhou authored
Bug: 890094 Change-Id: Ie5637c98d33b8602d54d86c698c63eea60f7802c Reviewed-on: https://chromium-review.googlesource.com/c/1294194Reviewed-by:
-
Jian Li authored
Bug: 897670 Change-Id: Ib5f7892332b8f6129fd9e5822aef096574856dd3 Reviewed-on: https://chromium-review.googlesource.com/c/1294834Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c18347a7..8e270567 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8ce0fb466ebb2e76688f46f0755d1697154feea5 Reviewed-on: https://chromium-review.googlesource.com/c/1294830Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601750}
-
Liquan(Max) Gu authored
In order to report Largest/LastTextPaint to UKM, this CL is to plumb Largest/LastTextPaint to WebPerformance, but a follow-up CL has to be done to pick up the metric results from the browser side. Before this CL, the metrics report the result by dumping a trace event. This CL adds a new way of reporting. When the metrics fire new results. The results will be stored in the detector class. At the same time, the detector will notify web performance of the new result so that the web performance will pick up the metric results. Bug: 869924 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id4c888b725d931cff24a44f19c017404ad9daad1 Reviewed-on: https://chromium-review.googlesource.com/c/1293752Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#601749}
-
Joe DeBlasio authored
The 'Details' link in the page info box was previously only shown for HTTPS pages. This CL provides this link for http-bad pages to help provide additional context for why HTTP is bad. Bug: 679532 Change-Id: I7f5af068d49c52df2519c2eff3f7cd87a24aa502 Reviewed-on: https://chromium-review.googlesource.com/c/1286895Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#601748}
-
Giovanni Ortuño Urquidi authored
Changes two tests to reset the received events before continuing the test. This makes it more consistent with other tests and makes it clearer how the state changes at each point in the tests. Bug: 896113 Change-Id: I06b963fa0cab0f0a1bf8bb72145711636c77ddae Reviewed-on: https://chromium-review.googlesource.com/c/1292663Reviewed-by:
Ovidio Henriquez <odejesush@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#601747}
-
Etienne Bergeron authored
This CL is adding a metric to collect metric on the fallback fonts issue. Slow-reports show that many bad cases (99th percentile) of different heartbeat metrics are affected by: gfx::GetFallbackFonts(gfx::Font const &) Previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/1281227/ The previous metrics show the problem for some users with latency above 1 minute. Unfortunately, it was hard to estimate the impact of the code since most of the subsequent calls will hit the cache. We are interrested in the initial call (not cached) since it's affecting startup time and omnibox first char typed to paint. The new metric will drive optimisation that will follow this CL. Bug: 894459 Change-Id: Iecfe02896cc08153cc630f6ba870036a408b4630 Reviewed-on: https://chromium-review.googlesource.com/c/1293272 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9b771ac49bd2..e95b35010759 git log 9b771ac49bd2..e95b35010759 --date=short --no-merges --format='%ad %ae %s' 2018-10-22 dgarrett@chromium.org Revert "chromeos_config: full builder to chromiumos-image-archive." 2018-10-22 nya@chromium.org chromeos_config: Exclude Tast tests in any group from VM tests. 2018-10-22 derat@chromium.org cbuildbot: Reland "tast_test_stages: Use cros_run_vm_test" 2018-10-21 dgarrett@google.com chromeos_config: full builder to chromiumos-image-archive. Created with: gclient setdep -r src/third_party/chromite@e95b35010759 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I8c8613811cd321e7b241fbeb871471a01e9f3c8c Reviewed-on: https://chromium-review.googlesource.com/c/1294630Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601745}
-
Elly Fong-Jones authored
This change: 1) Moves and renames ui::EscapeWindowsStyleAccelerators to make it available on other platforms; 2) Has BookmarkMenuDelegate call that function if the bookmark menu is being shown in the app menu; 3) Has BackForwardMenuModel call that function instead of hand-rolling escaping In MenuItemViews whose root MenuItemView has_mnemonics(), '&' is interpreted as a mnemonic marker, which makes it necessary to escape them. Bug: 896550,788049 Change-Id: I83f6bc6f5b71efa1d7220d8d20afa7dd833771ba Reviewed-on: https://chromium-review.googlesource.com/c/1287325Reviewed-by:
-
Christopher Cameron authored
Keyboard events that are targeted first at the web contents area, but are not handled by the web contents, are bounced back to the browser via the in content::RenderWidgetHostImpl::OnKeyboardEventAck, where they are forwarded to BrowserFrameMac::HandleKeyboardEvent to be redispatched in the browser process. This redispatch happens in the browser process even if the keyboard event originated in the app shim process. The result is strange behavior such as command-N re-focusing Chrome and creating a new browser window. Ensure that the redispatch happens in the originating process, by having BrowserFrameMac::HandleKeyboardEvent delegate the redispatch to its NativeWidgetMac base class, which will then forward the event to the app shim process. Two small wrinkles about this: - The type used by BrowserFrameMac::HandleKeyboardEvent is inconveniently content::NativeWebKeyboardEvent, which cannot be accessed in views/ - the only thing used in redispatch is |os_event|, which was reconstructed from a blink::WebKeyboardEvent - instead of passing the event over mojo, just pass the parts that are extracted by blink::WebKeyboardEvent - ideally we should switch to using a ui::KeyEvent, and just pass that directly (and add a function to reconstitute a NSEvent from a ui::KeyEvent). - When redispatched in-process, we do want to accurately know the return value from the redispatch. - To get this accurately, we take a different path in-process versus out-of-process (because the mojo call has no return value). - Always report out-of-process events as handled, to arrest further processing in the browser. Bug: 895169 Change-Id: I5fe1011374a4ca5050c7af70d6118286f7b46b34 Reviewed-on: https://chromium-review.googlesource.com/c/1292446Reviewed-by:Robert Sesek <rsesek@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#601743}
-
Ted Meyer authored
D3D11 crashes when trying to play a profile 1 or 3 video, DXVA renders the video incorrectly. This change causes these decoders to fail out during initialization if either of these profiles is in use. Bug: 888873 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ibe3d57df4a4564098523e396291a0e8ba8dbbd98 Reviewed-on: https://chromium-review.googlesource.com/c/1286190 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#601742}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/68b2df7cf1e2..201596f004c8 git log 68b2df7cf1e2..201596f004c8 --date=short --no-merges --format='%ad %ae %s' 2018-10-22 kron@webrtc.org Make packet max buffer size configurable via field trial flag Created with: gclient setdep -r src/third_party/webrtc@201596f004c8 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: If2e0293db3f2c26a6f699801a49a89896e07f353 Reviewed-on: https://chromium-review.googlesource.com/c/1294629Reviewed-by:
-
Vladislav Kaznacheev authored
Bug: 873486 Test: Chrome builds and runs Change-Id: I507b97aa1bb0c894599037c5a8cc85286ebc9bd9 Reviewed-on: https://chromium-review.googlesource.com/c/1292249Reviewed-by:
Elijah Taylor <elijahtaylor@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/08cf46bc4eec..099769d5218b Created with: gclient setdep -r src-internal@099769d5218b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6ce0632f941af9c7be3b002efe5756976b79db6f Reviewed-on: https://chromium-review.googlesource.com/c/1294789Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601739}
-
CJ DiMeglio authored
This change allows the kOnDemand option to apply for MediaStreams, meaning that we can switch over to using Surfaces when it is needed for PiP, deferring to a VideoLayer in the normal non-PiP case. Bug: 889857 Change-Id: I56019885d24e9d36f74a279d31f8259081edd1d3 Reviewed-on: https://chromium-review.googlesource.com/c/1271591Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#601738}
-
Sadrul Habib Chowdhury authored
On android, it turns out the presentation timestamp coming from the driver can be from the future. Report how far ahead in the future these timestamps are. BUG=894440 Change-Id: Ic9bf5620721de3279e8b74277273e8db63da0842 Reviewed-on: https://chromium-review.googlesource.com/c/1294193 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
-
Mikel Astiz authored
PASSWORDS is the only remaining datatype that hasn't been wrapped in pseudo-USS and also the most difficult one, due to the encryption- related particularities (entities must be encrypted at all times). The proposal is described in a dedicated section in the Design Doc: https://docs.google.com/document/d/14ScYZ0sop921gjBwXuReIEuQJlwftqkuSM1jMK_A_x4/edit#heading=h.ev0xr4j8pkot The patch includes the USS variant of the datatype controller for passwords, together with the required plumbing to enable directory-level (SyncableServiceBasedBridge) encryption of data. Cryptographer updates are posted from the sync thread directly to the model thread (password's background thread) with a newly introduced proxy observer, such that the bridge is up-to-date by the time the processor receives updates. A refcounted class (interface ModelCryptographer) is used for the plumbing to the bridge, due to the complex lifetime conditions of the involved parts. All this code is behind experimental feature toggle "SyncPseudoUSSPasswords". Because of encryption-related particularities of PASSWORDS, special care is taken with integration tests, and all tests with or without pseudo-USS enabled, including backward-compatibility tests that exercise legacy clients talking to pseudo-USS-enabled clients (and vice versa). Bug: 870624 Change-Id: I3e9ecc36d0b27c4c28e98fa709e7d13f9fb5a025 Reviewed-on: https://chromium-review.googlesource.com/c/1289889 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#601736}
-
Peter Boström authored
With Refresh launched we no longer need to support pre-Refresh modes. This code is being cleaned up, so removing them from chrome://flags prevents them from being used in the wild. TBR=sky@chromium.org Bug: None Change-Id: I4924e21c91cf9ccc6b8cce174c1260c5af4887e2 Reviewed-on: https://chromium-review.googlesource.com/c/1285082 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#601735}
-
Xiaohan Wang authored
- Define StringToCodecMap to avoid typing the long name multiple times. - base::NoDestructor supports emplace; no need to create a map first. - KEEP_FIRST_OF_DUPES is the default behavior; no need to specify. - Remove #if BUILDFLAG(ENABLE_AC3_EAC3_AUDIO_DEMUXING), because: * It's causing clang format to misbehave. * We should keep the mapping simple and should not restrict feature here, especially since MimeUtil::Codec::EAC3 is defined unconditionally. - Reformatted by "git cl format" Bug: 897767 Test: No functionality change. Change-Id: Iac8d8b8ae5a9a1acbab89105c121f1d80badd536 Reviewed-on: https://chromium-review.googlesource.com/c/1294598Reviewed-by:Sergey Volk <servolk@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#601734}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/98f1e59b41c6..149834e67d30 git log 98f1e59b41c6..149834e67d30 --date=short --no-merges --format='%ad %ae %s' 2018-10-22 ehmaldonado@chromium.org metrics: Add function to collect repeated metrics. Created with: gclient setdep -r src/third_party/depot_tools@149834e67d30 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:897394 TBR=agable@chromium.org Change-Id: I796b4e0e93af9e2319b05bf95a42a9f1f4d3d8b9 Reviewed-on: https://chromium-review.googlesource.com/c/1294226Reviewed-by:
-
Michael Spang authored
It's possible to write a fixtureless test by using TEST() instead of TEST_F(). Do this as it is slightly cleaner. Bug: none Test: events_unittests Change-Id: I67f50d73d01595de29f6346ef977891d6ea7b1c2 Reviewed-on: https://chromium-review.googlesource.com/c/1294569Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#601732}
-
Yi Gu authored
This reverts commit f7da13a2. Reason for revert: As per comments by Findit Original change's description: > [MessageLoop] Lock-free ScheduleWork() scheme > > The Lock is causing hangs because of priority inversion > mixed with priority boosting (ScheduleWork() tends to > boost the destination thread which may deschedule the > posting thread; if the posting thread is a background > thread this boost-induded-desched-while-holding-lock > can cause a livelock). See https://crbug.com/890978#c10 > for example crashes catching this. > > The Lock was only necessary for startup/shutdown and is > being replaced by a lock-free atomic scheme in this CL. > > MessagePump::ScheduleWork() itself was already thread-safe > (but the Android impl did unnecessarily check a non-atomic bool) > > This adds a WaitableEvent in ~MessageLoop(); hence the requirement > for a wait-allowance in net's EmbeddedTestServer. > > TBR=zhongyi@chromium.org (embedded_test_server.cc side-effects) > > Bug: 890978, 874237 > Change-Id: I0916e5a99035a935b0a23a770af256f334e78c43 > Reviewed-on: https://chromium-review.googlesource.com/c/1278631 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601600} TBR=gab@chromium.org,fdoray@chromium.org,zhongyi@chromium.org Change-Id: I521ef6ba2758f84d13a4f98d65cb41b276cb115e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 890978, 874237 Reviewed-on: https://chromium-review.googlesource.com/c/1294717Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#601731}
-
Robert Liao authored
Making all combobox models owned by their respective comboboxes simplifes lifetime management for the examples app as models are essentially not referenced outside of construction. In certain exceptions, when they are referenced, they occur in response to handling a combobox event. This also allows all of the examples apps using comboboxes to use the normal views destruction codepath instead of having to explicitly destroy the combobox. BUG=897337 Change-Id: I2823517296f46a17d864936397963e1eee8bbfaa Reviewed-on: https://chromium-review.googlesource.com/c/1294205 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/c320e9c7ad01..ae9bed9f4af1 git log c320e9c7ad01..ae9bed9f4af1 --date=short --no-merges --format='%ad %ae %s' 2018-10-22 thestig@chromium.org Roll v8/ 626844157..db22e96fb (203 commits) 2018-10-22 tsepez@chromium.org Fix timezone inconsistency in document methods test. 2018-10-22 hans@chromium.org Rename CPDF_Object::Type enumerators with k prefixes Created with: gclient setdep -r src/third_party/pdfium@ae9bed9f4af1 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:895475 TBR=dsinclair@chromium.org Change-Id: Iaa2bfccd1c8ae1daa2d41b7c4fc59ca2776d3eac Reviewed-on: https://chromium-review.googlesource.com/c/1294631Reviewed-by:
-
Fabio Tirelo authored
Bug: 896690 Change-Id: I7d59fab94c44ae61cfada8d40396486432ba7f81 Reviewed-on: https://chromium-review.googlesource.com/c/1294302 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#601728}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/623a134fbd08..b145370ba063 git log 623a134fbd08..b145370ba063 --date=short --no-merges --format='%ad %ae %s' 2018-10-22 Max) Gu [CpuFCP] Support CPU time FCP 2018-10-22 pasko@chromium.org androidStartupMetric: ignore the 2nd run Created with: gclient setdep -r src/third_party/catapult@b145370ba063 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:891797 TBR=sullivan@chromium.org Change-Id: If83ef19e92bf4dae24946252090007cdae728505 Reviewed-on: https://chromium-review.googlesource.com/c/1294709Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fe4fc148546b..ff1aeb953faf git log fe4fc148546b..ff1aeb953faf --date=short --no-merges --format='%ad %ae %s' 2018-10-22 jvanverth@google.com Ensure that SkYUVSizeInfo is fully initialized with old interface. 2018-10-22 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-22 halcanary@google.com SkPDF: maybe save some RAM by making the bitsets smaller 2018-10-22 halcanary@google.com SkQP-on-GCE: use fold to make output more legible, remove unnecessary status line Created with: gclient setdep -r src/third_party/skia@ff1aeb953faf The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:897245 TBR=brianosman@chromium.org Change-Id: I83e5ac477d3a09015a5dc18f2a7c277d24f6f9e6 Reviewed-on: https://chromium-review.googlesource.com/c/1294228Reviewed-by:
-
Evan Stade authored
Bug: 640365 Change-Id: I9683f06da8528cf50ce67943932bad09edac28db Reviewed-on: https://chromium-review.googlesource.com/c/1292410 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#601725}
-
Eugene But authored
This test tests implementation specific details, was a maintenance burden for chrome and never caught regressions in page state restoration code. Given that state restoration is a part of CRWWebController, the only way to test page state code is to write an EG test: crbug.com/897768 Removing this test does not really change anything, because the test has been failing consistently for very long time. Bug: 897467 Change-Id: Iaff4a9dc60b720c280c73f00b29ebcae04994e1c Reviewed-on: https://chromium-review.googlesource.com/c/1294196 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#601724}
-
