- 01 Jun, 2020 40 commits
-
-
Jeff Yoon authored
Bots are failing as they sometimes are allocated 10.13 bots when installing xcode 11.4, which requires OS 10.14. Restricting these to os.MAC_10_14. Bug: 1087161 Change-Id: If7b2937fc3bbd3a67f43f07f51e493b395426c03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225232 Auto-Submit: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#773762}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/34eef22ca072..a0aaf24a2757 2020-06-01 soxia@microsoft.com [Dual screen] Fix a hinge issue. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I92d8ac0a459926653a965f49420ae6ad88641dc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225296Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773761}
-
Dmitry Gozman authored
With PerNavigationMojoInterface launched, this boolean is not needed. Initial history navigation in the child frame will be canceled by destroying the NavigationClient. CommitNavigation IPC will be dropped on the floor because there is no receiver in the renderer, and browser will react to the NavigationClient disconnect and abandon the navigation. Bug: 1020175 Change-Id: Ifddd2d74ca2897283c39e47ec0f57d3a7470f72c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215380Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#773760}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/b4a735cc1ada..9a0423c5f727 2020-06-01 rharrison@google.com Roll third_party/spirv-cross/ 61cddd630..d385bf096 (4 commits) (#1077) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: Iec4a89dbf4c80e51cc29ea40f585fdf856cfe8d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225075Reviewed-by:
-
Mustafa Emre Acer authored
When the SafeBrowsing Delayed Warning experiment delays a warning on a page, we don't want the page to be able to request any permissions. This CL handles the desktop capture request, immediately shows the delayed warning and records a histogram entry. This CL ignores captures initiated by extensions so it doesn't modify desktop_capture_access_handler.cc or and tab_capture_access_handler.cc. Bug: 1081312 Change-Id: I95d04ad0505ae175fabe84815b4ba484055939aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213930 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#773758}
-
Tim Volodine authored
Failing on Marshmallow Tablet Tester: testPromoImpressionCountIncrementAfterDisplayingSigninPromo testPromoNotShownAfterBeingDismissed BUG=1088730 TBR=twellington@chromium.org Change-Id: Ib9a8d928ccfe3aa7ed6a6c4cac378858e1cd75ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224223 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#773757}
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 84-4142.0-1590399482-benchmark-84.0.4147.32-r1 to 85-4136.1-1589799307-benchmark-85.0.4150.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ia3d5a2ad32c0a8733ec610a9e2d5bc520997e459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225303Reviewed-by:
-
Francois Doray authored
Before this CL, a WakeUpBudgetPool was owned by MainThreadScheduler and shared among pages hosted in the renderer. This CL moves the WakeUpBudgetPool to PageScheduler. This will allow wake up rate to be set independently for each page, which is needed for the intensive wake up throttling experiment. In the intensive wake up throttling, the wake up rate will start at 1 per second and will transition to 1 per minute after 5 minutes in background. This CL also cleans up the outdated RendererSchedulerWakeUpThrottling entry in fieldtrial_testing_config.json (entry was not needed since feature has been enabled by default for a long time). Bug: 1075553 Change-Id: I74699e4d9dc883712ec6455cd8f788864dd45b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220261 Commit-Queue: François Doray <fdoray@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#773755}
-
Li Lin authored
Bug: b/157779488 Test: unit test Change-Id: Ib7626b9c78c197f2ec2b7e7b7eac489994262893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223374 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#773754}
-
Nina Satragno authored
Disable */SpokenFeedbackTest.TypeInOmnibox/*. It's flaky. TBR=dmazzoni@chromium.org Bug: 1065235 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Id7d610d2cff752965fb60baedfac78204065d84b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225130 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#773753}
-
Jidong Qin authored
The SurfaceOrigin isn't being plumbed from gpu::Capabilities to the output surface. DirectOutputsurface always specifies gfx::SurfaceOrigin::kTopLeft but it needs to pass along the value from gpu::Capabilities instead. Bug: 1077572 Change-Id: I04f96781d90d87a6dc8a9f5a192f76a417249874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217528 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#773752}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I50d74f06fb8c285c81ce9ac1890c1c712e7fe570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224645Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773751}
-
Wenbin Zhang authored
This CL puts testers win-10-perf and win-10_laptop_low_end-perf in lightweight mode with '--skip-perf'. In this case the tests will no longer upload the perf data. Bug: chromium:1045256 Change-Id: I3cc891ec6bebaf4c1becb4d690e70dd3735d734e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219563Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#773750}
-
Christopher Cameron authored
The gl::GLSurface::SwapCompletionCallback function takes two arguments: a gfx::SwapResult and gfx::GpuFence. Consolidate these into a single SwapCompletionResult structure. This mirrors the behavior of gl::GLSurface::PresentationCallback, which takes a gfx::PresentationFeedback. In a follow-on patch, we will add a gfx::CALayerParams argument to this structure, which will be used to communicate information about the CALayer tree on macOS. Bug: 894929 Change-Id: I03eeec04a1b11f1bc8b99d6e426ed04897941061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223376Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#773749}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iaab1593034059554a24e44d8bd060a148df133bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225220Reviewed-by:
-
Jeroen Dhollander authored
Without this the On-Device-Assistant will not start correctly. Bug: b/154866551 Change-Id: I04e9202fb21746304f240a2cb4cb7cd1258ec03b Tests: Launched Assistant and ensured ODA started Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225219Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Cr-Commit-Position: refs/heads/master@{#773747}
-
ckitagawa authored
This re-enables the flaky test PlayerCompositorDelegate.OnClick. The test was failing due to a bug where a tmpdir's deletion time raced with another operation. This CL fixes this by delaying the tmpdir's deletion until after the work requiring it is done. Bug: 1087768 Change-Id: I20061a77a22e2b340b7ce2c702a6c911956056f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222544Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#773746}
-
Scott Violet authored
SwipableOverlayView makes use of GestureListenerManager, which is currently rather broke. This is because GestureListenerManager needs to see cc::RenderFrameMetadata on every frame, which it currently isn't. Making GestureListenerManager get render-frame-metadata on every frame is quite costly. I'm in the process of making GestureListenerManager get every frame only when listeners are attached. This patch changes SwipableOverlayView to only attach a listener when it actually needs the information. Patch that makes GestureListenerManager get cc::RenderFrameMetadata is here: https://chromium-review.googlesource.com/c/chromium/src/+/2222623 (it's a work in progress that I'll be doing right after this). BUG=1087480 TEST=none Change-Id: Ib22f1d1ac1caefece5fb1c6059cdd37da72b4618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225139Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#773745}
-
Nate Chapin authored
The WindowAgentFactory is only stored on Document for bindings security checks. Have the bindings go to the LocalFrame instead. Move WindowAgentFactory selection entirely out of DocumentInit and into SecurityContextInit Change-Id: Ib83272185edbec212d30a9afedd4def16c2bc044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188902 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#773744}
-
Nektarios Paisios authored
In https://crrev.com/c/2205400/ a fix was made to the selection offsets that might be necessary whenever there are nodes in the internal accessibility tree that are ignored, i.e., they are not exposed to the platform tree. This patch adds a test for Linux ATK which checks whether either setting or retrieving the selection works properly in such a tree. A helper method is added to the test fixture that searches the ATK tree for a node with a specific role. Also took the opportunity to clean up the test fixture by adding comments, moving methods to be in declaration order, adding const, and renaming erroneously named variables. Example: <p> <div></div> <!-- ignored --> <span>Selected</span> </p> The anchor offset points to the second child of the paragraph and the focus offset to the third. However, the first child, the div, is not exposed to the platform tree because it is empty. The offsets should be adjusted accordingly, i.e., in ATK text, the anchor offset should be equal to 0 and the focus offset should equal the text's length. AX-Relnotes: n/a. R=dmazzoni@chromium.org Change-Id: I22fabbbdc3eea1648c088f35ee898ff307a97d24 Bug: 1082814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218042Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#773743}
-
Kevin McNee authored
A std::list was being used here due to issues with using a set with previous kinds of smart pointers (described here: https://codereview.chromium.org/1608743004/diff/1/content/browser/frame_host/render_frame_host_manager.h#newcode758 ). Bug: None Change-Id: Ie50bfe12a35ab2ea373c81d2447b44d62cd612d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219158 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#773742}
-
behdad authored
The output path to test_results should be separate for rerun and non-rerun case. Bug: chromium:1088104 Change-Id: I54b6ba26254b37af3c9df0f44ec9d43ea140e52f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224819Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
-
Brandon Wylie authored
Bug: 1082612 Change-Id: Iaf0a6c5e9aad9a7e12bfbc72e4c392cfdcd4b645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212454Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#773740}
-
Ahmed Fakhry authored
Get rid of an unused variable, and properly use OnWindowAdded() instead of OnWindowHierarchyChanged() which can be triggered for many events we're not interested in. BUG=997102 Change-Id: If9f7677bdb6c7f73ddcfa455139149e4d7922ce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223367Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#773739}
-
Frank Liberato authored
Add a check for nullptr, to verify that it's actually the cause of a nullptr deref. Should be removed after figuring that out. Bug: 1077645 Change-Id: Iad2434eb07c3f88574e3c2aff81f348d67a0070a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225257 Commit-Queue: Frank Liberato <liberato@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Auto-Submit: Frank Liberato <liberato@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#773738}
-
Nina Satragno authored
Disable SitePerProcessInteractiveBrowserTest.FullscreenElementInMultipleSubframes, it's flaky on all platforms. TBR=alexmos@chromium.org Bug: 756338 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I6887ea1ef98138f877ec1174208f616f7f670e64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225356Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f1c5b95e516e..00b172a6fa55 2020-06-01 danilchap@webrtc.org Add av1 test with temporal scalability. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iae93f3cd4130b09c8bec200500b3635d61ea2237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225072Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 84-4142.0-1590399482-benchmark-84.0.4147.27-r1 to 84-4142.0-1590399482-benchmark-84.0.4147.32-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Idc57069523a51454d3f6a722c7ae0eef613bc004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225298Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1591012454-8f48edc56ad7737be6be6679c88eb62db7b87448.profdata to chrome-mac-master-1591026828-08649a6f2f91ff46c0ee4a8534af4c349ceca721.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I5f8f563dd3bc8f70d203a0a4a9e55d73b0ab885c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225071Reviewed-by:
-
Yi Gu authored
This patch adds a timeline option to Element.animate() function based on the recent spec change: https://github.com/w3c/csswg-drafts/issues/5013. Change-Id: Ibf7e6f824f9e013f62da015cebdbc893255142dd Bug: 1080720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220352 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#773733}
-
danakj authored
The test wants to wait for the frames to all load, but with site isolation we have an extra load start/stop on the frame being swapped out, so it can't use a hard-coded number of loads. Instead, we wait for the known number of network requests to be made, and also wait for all the frames to finish loading by watching the number which have started loading. That brings us to a steady state at which we can grab a non-flaky snapshot. R=caseq@chromium.org Bug: 906879 Change-Id: Id6458313fc4c946f2327af26b8ea81478861ec5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222726 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#773732}
-
Jesse Schettler authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/9f4be0e52d52..70439a4af4be $ git log 9f4be0e52..70439a4af --date=short --no-merges --format='%ad %ae %s' 2020-05-21 fletcherw system_api: add ListScannersResponse proto Created with: roll-dep src/third_party/cros_system_api Bug: b:157577191 Change-Id: Icd1bf545c3a6633a4bbc10c26f0886a87c75f472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224914 Auto-Submit: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#773731}
-
Mario Sanchez Prada authored
This is a reland of bcb3ba73 This CL migrates the messages FrameMsg_GetSerializedHtmlWithLocalLinks and FrameHostMsg_GetSerializedHtmlWithLocalLinksResponse messages as a single mojom.Frame.GetSerializedHtmlWithLocalLinks() mojo method that accepts a pending remote to a newly added interface providing the two callbacks needed to report on the data chunks being serialized and when when the process is over (FrameHTMLSerializerWithLocalLinksCallbacks). This is necessary to deal with the fact that multiple responses can be sent from the renderer to the browser process for a single serialization process, which is the use case that produced a crash with the previous version of this migration (crrev.com/c/2207234 and crbug.com/1085721). Last, this CL also adds a new unit test to the SavePageBrowserTest test suite (i.e. SaveHTMLWithLongTextContent) to make sure that we explicitly cover the situation that caused the crash, that is, when we attempt to serialize HTML content with more than 65536 bytes of data, see WebFrameSerializerImpl::EncodeAndFlushBuffer(). Original change's description: > Migrate FrameMsg_GetSerializedHtmlWithLocalLinks to mojom::Frame > > This CL moves this message out of frame_messages.h and adds a new > method in content::mojom::Frame to allow the browser request from > the renderer the serialization of a RenderFrame's contents, regardless > of whether such contents include same-site or cross-site resources. > > Since this functionality also requires an asynchronous response from > the renderer once the serialization is complete, this CL does also > migrate FrameHostMsg_SerializedHtmlWithLocalLinksResponse, for which > some extra bit have been added to WebFrameSerializer[Client], so that > we can appropriately reply to the browser process when the serialized > data is available. > > In a future CL, this functionality will probably get moved down into > Blink itself, but at the moment there's way too much functionality > in use in Blink's public API, so this CL does not tackle that part > yet, and focused on the migration from legacy IPC to mojo only. > > Bug: 1044088 > Change-Id: I4ce5b3cfe795e5019bb30a278577ec2be3ee2854 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207234 > Commit-Queue: Mario Sanchez Prada <mario@igalia.com> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Aaron Colwell <acolwell@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#770794} Bug: 1044088, 1085721 Change-Id: Ia9ab65632194a0bcfd0c5d6fc8ce57d60fc5e271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214890 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#773730}
-
dpapad authored
Previously, when testing the focus() and blur() cases, the test was not waiting for both opacity and width transitions to finish, resulting in transitions from focus() finishing while the test was making assertions related to blur(). Properly waiting for all transitions to finish before moving on to the blur() case should fix the issue. Re-enabling the test on Mac, where it was disabled because of this reason. Bug: 997943 Change-Id: I6badb546fba4f093c2fa45490e2a52e5dae84982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223082Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#773729}
-
Chromium WPT Sync authored
Using wpt-import in Chromium cda0fb4d. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ifb5801e2cfc0570164319e9e46a87523b8533ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224644Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773728}
-
Haiyang Pan authored
This reverts commit 7a213fda. Reason for revert: The test RenderWidgetHostViewChildFrameBrowserTest.VisualPropertiesPropagation_RootWindowSegments failed quite often on "Android CFI" and android-pie-x86-rel builders, and flaky on android-asan. See http://shortn/_a3kmhb2wuI for more details of the flakiness Original change's description: > Add window segments concept to the content layer > > This change adds a the window segments concept to the > SynchronizeVisualProperties cascade. A display feature splits a view by, > e.g., a fold or a mask - an accessor is added to RenderWidgetHostViewBase > to provide this information during the calculation of visual properties. > When the root render widget is split by the display feature, there are > multiple 'window segments' that web authors will be able to use to split > their view and have a logical separation of content (either through > JavaScript or CSS). > > The root widget window segments are computed by the root > RenderWidgetHostImpl, based on the display feature on the > RenderWidgetHostView. The segments are then propagated to child local > frame roots via RenderFrameProxy and CrossProcessFrameConnector via the > new member on VisualProperties. > > Follow-up changes will finish hooking this information up to Blink in > order to expose it to the web, and also integrate with the platform > specific APIs in order to get the display feature information from the > underlying operating system. > > Explainers: > https://github.com/webscreens/window-segments/blob/master/EXPLAINER.md > https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/master/Foldables/explainer.md > > i2p: > https://groups.google.com/a/chromium.org/d/msg/blink-dev/_1_ljYsaqrU/qOoHJ7MhAgAJ > https://groups.google.com/a/chromium.org/d/msg/blink-dev/KsPRO3hkOGw/md4jgIAaAgAJ > > Bug: 1039050 1039051 > Change-Id: I6805cda5946bd5379ad6dcd68e092e5d7d9be42d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205123 > Commit-Queue: Daniel Libby <dlibby@microsoft.com> > Reviewed-by: danakj <danakj@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773545} TBR=danakj@chromium.org,kinuko@chromium.org,dlibby@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1039050 1039051 Change-Id: I74b881c8548cedfe1c694dbdee1ce617491bf75b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225141Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#773727}
-
Sreeja Kamishetty authored
This CL disables BackForwardCache when SpeechRecognizer API is used, as we believe that currently we do not handle the speech recognition properly when the page is put into BackForwardCache. Supporting the SpeechRecognizer feature is to be compatible with BackForwardCache is the next step. BUG=1088445 Change-Id: I85334ac00251a1ead69f26c5de0e2f76e07066db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224981Reviewed-by:
-
Navid Zolghadr authored
Plumb through deep press gesture recognizer bit from Android Q+ to Chrome and send long press gesture earlier than the timeout as soon as the deep press bit is set. This change will cause long press gesture to be fired earlier if user presses finger harder on the screen and causes effects such as context menu or selection happens earlier to provide a better user experience inline with other apps on Android Q+. Bug: 1086263 Change-Id: I04b7d43fdfcaefeb6ca6ea6102f730283d972fb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218551Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#773725}
-
Nina Satragno authored
Disable the ChromeVoxPanelTest.Gestures test, it has flaky crashes. Previously this had been disabled the wrong way. TBR=dtseng@chromium.org Bug: 1088438 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I76aa02d0dfbab80131a949d37c5258c0eded2de7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224648Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2f2595a89af3..b369376270f8 2020-06-01 m.maiya@samsung.com Vulkan: Enhance VulkanBarriersPerfBenchmark If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Test: Test: angle_perftest --gtest_filter=VulkanBarriersPerfBenchmark.Run/vulkan_buffer_copy Change-Id: Id5bd54da9c92f1a225db29f985243f92c7575aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224839Reviewed-by:
-
