- 06 Mar, 2019 40 commits
-
-
Matthew Cary authored
The previous registration in SetupMobileFieldTrials was too early; the g_browser_process is not initialized yet. This registration works. Bug: 932578 Change-Id: If45b6b88c1be4c1025f9ecd6ee8e5efc5685bc9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1473174Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Auto-Submit: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#638075}
-
Yoav Weiss authored
This CL is a refactor only with no functional change. It changes the finish_time variable into response_end to make it closer the what that value represents as part of the ResourceTiming entry. Change-Id: Ieca7843fcf1570b9a1ea3ba89ea6d3751529bae0 BUG: 938798 Change-Id: Ieca7843fcf1570b9a1ea3ba89ea6d3751529bae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503462 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#638074}
-
Jérôme Lebel authored
Bug: 889470 Change-Id: Id2d9309af28a82274c5041643763fce368fd26ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503756 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#638073}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/233178a15e11..0b1b7431ea96 Created with: gclient setdep -r src-internal@0b1b7431ea96 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=shend@chromium.org,zmin@chromium.org,dvadym@chromium.org,petewil@chromium.org Change-Id: I9315810656a28acc02498763ff16ff1e6a0928bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504983Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638072}
-
Olivier Robin authored
As a consequence of WebFrameMessaging, the initial processing of frames is asynchronous. Wait for it to happen in tests. Bug: 938837 Change-Id: I05a759ea17944f316a9a19999afd1cab4fe5a59b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505532 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
-
dstockwell authored
Bug: 902646 Change-Id: If6f594535a1d1cdff19e441d0995d1ef57e22885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504670 Commit-Queue: dstockwell <dstockwell@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#638070}
-
Pavel Shmakov authored
Crash 1: https://crash.corp.google.com/browse?q=expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27%5BAndroid+Java+Exception%5D+java.lang.RuntimeException+at+org.chromium.chrome.browser.ChromeActivity.getFullscreenManager%28ChromeActivity.java%29%27+AND+product_name%3D%27Chrome_Android%27#-propertyselector,productname:1000,productversion:100,magicsignature:50,magicsignature2:50,stablesignature:50,magicsignaturesorted:50 Crash 2: https://crash.corp.google.com/browse?q=product_name%3D%27Chrome_Android%27+AND+product.version%3D%2773.0.3683.37%27+AND+expanded_custom_data.ChromeCrashProto.channel%3D%27beta%27+AND+expanded_custom_data.ChromeCrashProto.ptype%3D%27browser%27+AND+expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27%5BAndroid+Java+Exception%5D+java.lang.IllegalStateException+at+org.chromium.chrome.browser.ChromeActivity.getFullscreenManager%28ChromeActivity.java%29%27 Plus potential similar crash in TWAs Bug: 938212 Change-Id: Icd183741ea042f7d4c491a4755acc7fd4aff5050 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503256Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#638069}
-
Alex Clarke authored
We no longer need to split the lock in TaskQueueImpl. Change-Id: I05d1bc597f34fbe4a1a10ffc3a95fc451b72abc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504017 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638068}
-
Sylvain Defresne authored
Replace usage to instead use JSONReader::Read that returns a base::Optional<base::Value>. Bug: 925165 Change-Id: I31077cd95a605796ef5b08a7e6d1a963afdb1dd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503752 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
-
Christian Dullweber authored
Describe which data types can be filtered by origin and how filtering works for cookies. Add an example of clearing all cookies and site data for a specific origin. Bug: 78093, 113621, 924113 Change-Id: Ib93e2ca9f8bf4a44893a9933f0b111ebc0560358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1451881 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Meggin Kearney <mkearney@chromium.org> Cr-Commit-Position: refs/heads/master@{#638066}
-
dstockwell authored
Bug: 902646 Change-Id: I8b7bb960a2cdc0a386b3a8518d20a9514c4d1eb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501236 Commit-Queue: dstockwell <dstockwell@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#638065}
-
Robbie Gibson authored
There is now a shared class in ios/chrome/common (somewhere extensions can access) that does the same thing as CreateSameConstraints. We should use that instead. Also, we can get rid of unnecessary @synthesize and method prototypes. Bug: 938317 Change-Id: I54b7a3b855015c377ebdbb8c0be2d0e47698a811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503417 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638064}
-
Sylvain Defresne authored
Replace usage to instead use JSONReader::Read that returns a base::Optional<base::Value>. Also rename PaymentResponseToDictionaryValue after changing the return type to base::Value (to use the new API). Bug: 925165, 646113 Change-Id: Ie88068c76f810dff08e8ec36230d0154c6f9effa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503329 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#638063}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/9384947f47f2..ed5dc24c07a3 git log 9384947f47f2..ed5dc24c07a3 --date=short --no-merges --format='%ad %ae %s' 2019-03-06 tsepez@chromium.org Spin in CFGAS_FormatString::ParseNum. 2019-03-05 tsepez@chromium.org Make members private in CXFA_LayoutItem, adding accessors. 2019-03-05 thestig@chromium.org Minimize simple_xfa.pdf. 2019-03-05 thestig@chromium.org Fix error in testing/resources/xfa_catalog_1_0.fragment. 2019-03-05 tsepez@chromium.org Tidy cxfa_itemlayoutprocessor.h 2019-03-05 tsepez@chromium.org ExtractLayoutItem() breaks when current item found in old list. 2019-03-05 rycsmith@google.com Add GetNumberValue function to fpdf_annot. 2019-03-05 thestig@chromium.org Fail early for data matrix barcode input that is too long. 2019-03-05 thestig@chromium.org Add CBC_DataMatrixWriterTest tests for encoding limits. 2019-03-05 thestig@chromium.org Avoid nullptr crash in CJS_App::get_active_docs(). 2019-03-05 bungeman@google.com Roll third_party/freetype/src/ 6d65c60fc..31757f969 (2 commits) 2019-03-05 thestig@chromium.org Speed up DetermineConsecutiveDigitCount() in debug builds. 2019-03-05 manojb@microsoft.com Add tests for device to page and page to device coordinate conversions 2019-03-04 thestig@chromium.org Update Skia owner in the OWNERS file. 2019-03-04 thestig@chromium.org Roll tools/clang/ b23f5a073..257c91cc4 (9 commits) Created with: gclient setdep -r src/third_party/pdfium@ed5dc24c07a3 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:937799,chromium:b/127345911,chromium:930394,chromium:930394,chromium:937572,chromium:930394 TBR=dsinclair@chromium.org Change-Id: I08e30b280eab683713d0b33c0973e38ae8ef631e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504801Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638062}
-
Robbie Gibson authored
Bug: 938239 Change-Id: I8224e85f8c29d9610975fad88ae1cd7488c9d650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503316 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638061}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d36c08623d90..be7af9399ceb git log d36c08623d90..be7af9399ceb --date=short --no-merges --format='%ad %ae %s' 2019-03-06 yvesg@webrtc.org Add dsymutil as a mac cipd dependency. 2019-03-05 steveanton@webrtc.org Use metrics::Samples in a couple pc/ tests 2019-03-05 amithi@webrtc.org Adding metrics to measure usage of simulcast API. 2019-03-05 jakobi@webrtc.org Reland "Remove field trial include from decision logic." 2019-03-05 danilchap@webrtc.org Merge rtc_task_queue(_api|_impl)? build targets into one 2019-03-05 jakobi@webrtc.org Add relative_packet_arrival_delay and jitter_buffer_packets_received statistics. 2019-03-05 danilchap@webrtc.org Replace all usage of rtc::NewClosure with webrtc::ToQueuedTask 2019-03-05 steveanton@webrtc.org Add metrics::Samples to facilitate easier testing Created with: gclient setdep -r src/third_party/webrtc@be7af9399ceb The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:780980,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Icb740edb33b449f8c9e858eb79dd2b5fed2e851e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504734Reviewed-by:
-
Vadym Doroshenko authored
This reverts commit 50b4e186. Reason for revert: It was incorrect suspicion, bot became green w/o this revert Original change's description: > Revert "[blink] Remove old script streamer thread" > > This reverts commit 96c748b0. > > Reason for revert: it's suspect in failures > https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/88931 > > Original change's description: > > [blink] Remove old script streamer thread > > > > The script streamer thread has now been replaced with posting tasks to > > the scheduler, so remove the flag picking between the two options and > > the dedicated streaming thread itself. > > > > Also, remove the streaming task re-posting now that the blocking/ > > non-blocking worker pools are merged. > > > > Bug: 874080 > > Change-Id: Ib9dabb91deddcc616d4edfe5efb13d8e584c0691 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503420 > > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > > Reviewed-by: Steven Holte <holte@chromium.org> > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> > > Auto-Submit: Leszek Swirski <leszeks@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#638031} > > TBR=kinuko@chromium.org,haraken@chromium.org,holte@chromium.org,mlippautz@chromium.org,leszeks@chromium.org > > Change-Id: Ia67f3fcfbff3155f9da4b53f371115f3dfd0089c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 874080 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505412 > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638055} TBR=kinuko@chromium.org,haraken@chromium.org,holte@chromium.org,dvadym@chromium.org,mlippautz@chromium.org,leszeks@chromium.org Change-Id: Ic4eb793dacdaa7565e92ba1b908162f5d3e02e15 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 874080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505552Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#638059}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a7e11060d2bb..233178a15e11 Created with: gclient setdep -r src-internal@233178a15e11 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=shend@chromium.org,zmin@chromium.org,dvadym@chromium.org,petewil@chromium.org Change-Id: I7e20783971a127e219b9d9aa2356f2daca6590ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504802Reviewed-by:
-
Clemens Arbesser authored
Before: https://screenshot.googleplex.com/TT263fQ8F11.png After: https://screenshot.googleplex.com/1scfPRBzvHn.png Bug: 806868 Change-Id: Ida45b7b36526ebfb4e4abf18876106c47324fbe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503313Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Jordan Demeulenaere <jdemeulenaere@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#638057}
-
Lei Zhang authored
As is, the ifdefs in the header and the ifdefs in the initializer list have to match. With this CL, there is no need for the initializer list and it is clearer that members are being initialized. Also fix lint errors. Change-Id: Ie9437fb15578b6ae89bd4911f79914eb49a9357a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1476437 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#638056}
-
Vadym Doroshenko authored
This reverts commit 96c748b0. Reason for revert: it's suspect in failures https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/88931 Original change's description: > [blink] Remove old script streamer thread > > The script streamer thread has now been replaced with posting tasks to > the scheduler, so remove the flag picking between the two options and > the dedicated streaming thread itself. > > Also, remove the streaming task re-posting now that the blocking/ > non-blocking worker pools are merged. > > Bug: 874080 > Change-Id: Ib9dabb91deddcc616d4edfe5efb13d8e584c0691 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503420 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> > Auto-Submit: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638031} TBR=kinuko@chromium.org,haraken@chromium.org,holte@chromium.org,mlippautz@chromium.org,leszeks@chromium.org Change-Id: Ia67f3fcfbff3155f9da4b53f371115f3dfd0089c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 874080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505412Reviewed-by:
-
Luciano Pacheco authored
Bug: 925516 Change-Id: I7083ffc99110f20828764c9f762a44650f278208 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504664 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#638054}
-
Boris Sazonov authored
This CL removes openAndroidAccountCreationScreen from AccountManagementScreenHelper as this flow is almost never triggered (see UMA link in the bug). Bug: 938554 Change-Id: Id323846f45a4677cb164f92c6fb6f0498a20eb11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504015 Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
-
arthursonzogni authored
NavigationURLLoaderImpl::OnComplete has code to handle a status of net::OK. The NetworkService itself will never call URLLoader::OnComplete with net::OK without calling OnReceiveResponse first. When OnReceiveResponse is called, the URLLoaderClient is unbound from the NavigationURLLoaderImpl, so OnComplete must never be received after that. Bug: 936962, 873269 Change-Id: I28e557850a3b1bd6b24ae2f6203b9090b2ac09bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503133Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#638052}
-
Lei Zhang authored
- Replace one loop with base::JoinString(). - Use newer base::Value API in another loop. Change-Id: I73fbd983e3c2306e9a97c9fd46f3fe94a944dcf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497855Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#638051}
-
Miyoung Shin authored
This CL forces to refresh the account info for Android and OnExtendedAccountInfoUpdated is fired if the info is successfully fetched. Also it replaces usage of FetchUserInfoBeforeSignin. Bug: 931716 Change-Id: I8a8eb9b55f7afd20e89cbcc6c0506fbcdfe9572a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1481170 Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#638050}
-
Sergiy Belozorov authored
This is a reland of 68ef4428 Original change's description: > Implement auto command in the update_wpr script > > R=perezju@chromium.org > > Bug: 895891 > Change-Id: Ib4b6b0ea123b64d0333cb0911930358dcb3ff2ad > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496871 > Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> > Cr-Commit-Position: refs/heads/master@{#637677} Bug: 895891, 938487 Change-Id: I4dbf7e1adee233598a78772024d71dfebc23e562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504014Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#638049}
-
Luciano Pacheco authored
Move expandTreeItem helper function from folder_shortcuts.js to background.js to be able to reuse on other tests. Bug: 925516 Change-Id: I95f425c5a6fbdd5afa424cbfd1d08b1d87cc59db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504658 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/327e9ae49a2d..a7e11060d2bb Created with: gclient setdep -r src-internal@a7e11060d2bb The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=shend@chromium.org,zmin@chromium.org,dvadym@chromium.org,petewil@chromium.org Change-Id: I35622a2dfae7b8e1f64b4cc40ba9508bcce9358f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504735Reviewed-by:
-
Yi Su authored
This CL merges RedirectTestCase into WebStateObserverTest.RedirectNavigation. Bug: 930859 Change-Id: I903d9da7799ec15850ff1c241f96bf9a9cf36ebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503461Reviewed-by:
-
Lei Zhang authored
Remove SetL10nString() helper function along the way. Change-Id: Ie738c4da4c33d83c56305bdf6ececc13483f9f84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504841Reviewed-by:
dstockwell <dstockwell@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#638045}
-
mrefaat authored
Made U2FController more of implementation details. with U2FTabHelper as the public class to be used. Added tests to U2FTabHelperTest to test the javascript execution. instead of mocking the method (was mocked in u2f_controller_unittest). Also simplified all the existing unit tests. Bug: 902048 Change-Id: Ife7ac7605bb7bb0e236095dd42871152ea696cfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1487180 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
-
Hiroki Nakagawa authored
S13nServiceWorker is now enabled by default. This CL removes unused non-S13nServiceWorker path and IsServicificationEnabled() checks. Bug: 926114 Change-Id: Ia256db8074e5ab9a98dde0196e584128f8e1d97c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1472012 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#638043}
-
Hiroki Nakagawa authored
S13nServiceWorker is now enabled by default. This CL removes unused non-S13nServiceWorker path and IsServicificationEnabled() checks. Bug: 926114 Change-Id: Iefd0c5f07cd75d05883dd8be874cf1d804e83fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504605 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/24b0b59e4409..47a505533310 git log 24b0b59e4409..47a505533310 --date=short --no-merges --format='%ad %ae %s' 2019-03-06 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@47a505533310 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: I93c0d51e92ae24c8a5869e662466931886d84198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504797Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4ad77ed4. With Chromium commits locally applied on WPT: 68d5240e "[ChromeDriver] Set key modifiers with mouse actions" 682affef "Implemented setPlaybackRate for scroll-linked Worklet Animations." 2b037bdc "[Animation Worklet] Fix flaky worklet-animation-with-fill-mode.https.html" 5fef8801 "Make -webkit-line-clamp respect line-height." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com: external/wpt/web-nfc NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ib32ca8a773ec22b0d2c1b8e3680bfdbc9f09d5c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504979Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638040}
-
Raul Tambre authored
This fixes many 64-bit truncation warnings. Bug: 488553, 879657, 921389 Change-Id: Ia3333d090f3a8137bbda8061fc205afca7be8566 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1484294Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#638039}
-
Miyoung Shin authored
- unsigned long long / unsigned long long int -> uint64_t - long long / long long int -> int64_t - No logic change. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929980 Change-Id: I1a44a3752f27b19cc3f2a493fec9540324c61dd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504479Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638038}
-
Maksim Sisov authored
The issue with fences was identified a long time ago, but it did not concern Linux before. As long as we use surfaceless drawing and insert fences between each buffer swap, we noticed some perf regression. On a powerful laptop (dell 9560) with Intel 630 graphics, gpu::AsyncSwap took ~8ms with fences and ~1ms without fences. On Raspberry Pi3 with Broadcom GPU, swap took ~105ms and after the applied workaround it took 77ms. The FPS rate became 16-17FPS instead of 11-12FPS in aquarium webgl demo. https://docs.google.com/spreadsheets/d/1dKLIQ6dkql-X0ppdc5s5y-ws2hPM-RLgqgGzkFpgUe0/edit?usp=sharing Bug: 938286 Change-Id: I9fc616976a6ee3f9b4544ad7d8effc41e3ad4a91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503576 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#638037}
-
Robbie McElrath authored
This CL increases the shard count from 10 to 21, which matches the count specified in test_suite_exceptions.pyl. TBR=jbudorick@chromium.org Bug: 938656 Change-Id: I37bfa264ea7ee37fb092eec5f8b4267adb2ea2ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504978Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
-
