GitLab

Re-land of https://codereview.chromium.org/2534633002/

In order to have a perf test looking at stats of interest we need to be
able to get the results of a JavaScript getStats call. These can be
returned as JSON-stringified JavaScript dictionaries.

In this CL:
- [g|G]etStatsReportDictionary added to webrtc_browsertest_base.cc and
  peerconnection_getstats.js, which produce/read a JSON-stringified
  version of the stats.
- RTCStatsReportDictionary and RTCStatsDictionary, helper classes for
  reading stats from the base::Dictionary representation of the stats.
- Unittests for the helper classes.

In a follow-up CL these methods/classes will be used to obtain the
stats in the to-be-added performance test. This will yield pretty
graphs.

BUG=670306, 627816

Review-Url: https://codereview.chromium.org/2543173002
Cr-Commit-Position: refs/heads/master@{#436252}

Revert of Use the modal view when signing in from chrome.identity extension API. (patchset #2 id:10001 of https://codereview.chromium.org/2462603002/ )

Reason for revert:
This CL as it is responsible for crash
https://bugs.chromium.org/p/chromium/issues/detail?id=667750

Original issue's description:
> Use the modal view when signing in from chrome.identity extension API.
>
> BUG=652791
>
> Committed: https://crrev.com/8122f2f2f0ba7bd36c264f03dd6201232335bdcb
> Cr-Commit-Position: refs/heads/master@{#429556}

TBR=anthonyvd@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=652791, 667750

Review-Url: https://codereview.chromium.org/2542423002
Cr-Commit-Position: refs/heads/master@{#436251}

Re-ran generate_buildbot_json.py. The JSON diffs were applied
incorrectly by the CQ.

BUG=369849, 624436
TBR=zmo@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2554453004
Cr-Commit-Position: refs/heads/master@{#436250}

Although there are metrics for the budget and SES at the time that budget
is consumed, there isn't currently any tracking for which events in the
budget system come via the Budget API interface.

This adds two new metrics, to track queries and reserve requests. It also
adds some basic testing to ensure the metrics are being recorded.

BUG=617971

Review-Url: https://codereview.chromium.org/2524533002
Cr-Commit-Position: refs/heads/master@{#436249}

In preparation for async stylesheet update, schedule a layout tree
update when marking tree scopes dirty for active style sheets. This is
necessary to trigger a beginFrame which will in turn call
updateActiveStyle as part of the lifecycle update.

R=meade@chromium.org
BUG=567021

Review-Url: https://codereview.chromium.org/2547883002
Cr-Commit-Position: refs/heads/master@{#436248}

BUG=537054, 666061
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2547393002
Cr-Commit-Position: refs/heads/master@{#436247}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/cd7151a2..11c28061

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2551833002
Cr-Commit-Position: refs/heads/master@{#436246}

R=hayato@chromium.org
BUG=none

Review-Url: https://codereview.chromium.org/2547843002
Cr-Commit-Position: refs/heads/master@{#436245}

Cr-Commit-Position: refs/heads/master@{#436244}

Removes unnecessary Document::wrap and associateWithWrapper.
The special code in these functions were made in order to keep
WindowProxy::m_document updated and consistent with toV8(document).
But we no longer rely on the hack, and we can remove the dead code.

WindowProxy::m_document is used to support named properties on the
document, and only used in WindowProxy::namedItem{Added,Removed}.
These functions are only called from ScriptController::namedItem
{Added,Removed} and ScriptController already guarantees that the
WindowProxy is initialized at once.  So, there is no need for
Document::wrap to call WindowProxy::updateDocumentProperty.

Plus, this CL removes WindowProxy::m_document.  Given that we knew
it's the main world, we should be able to retrieve the wrapper
object of the document in almost the same speed as before.  The
new code to retrieve the wrapper object should be almost equivalent
to
    ScriptWrappable::mainWorldWrapper(isolate)
and it's almost the same as
    m_document.newLocal(isolate)

The first attempt was: http://crrev.com/2525313004

BUG=

Review-Url: https://codereview.chromium.org/2542123002
Cr-Commit-Position: refs/heads/master@{#436243}

Now that Reload is equivalent to ReloadToRefreshContent, let's
deprecated ReloadToRefreshContent.

In this change, I do not remove actual caller code that existed
in Android port, because it was already removed accidentaly
in the following refactoring change.
https://codereview.chromium.org/2416723002

Because we already migrated to using ReloadType::MAIN_RESOURCE
for both reloads fortunately, it didn't cause any regression,
and we can safely remove this interface now.

BUG=612080, 670232
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
TBR=miguelg@chromium.org

Review-Url: https://codereview.chromium.org/2544283002
Cr-Commit-Position: refs/heads/master@{#436242}

These tests were originally skipped because they fail on Precise. When the CQ was upgraded from Precise to Trusty, these tests were unskipped. The RandomOrder Linux builder is still Precise, so we need to skip these until we upgrade it to Trusty.

BUG=670841
R=qyearsley@chromium.org

Review-Url: https://codereview.chromium.org/2551643002
Cr-Commit-Position: refs/heads/master@{#436241}

go/macviewsbuilder broke after r435575. It removed a flag that
extension_uninstall_dialog_view_browsertest.cc was using.

But extension_uninstall_dialog_view_browsertest.cc is only built on
mac_views_browser builds, which doesn't need flags in the first place
(it's a compile/build flag).

One of the tests does sadly fail (see http://crbug.com/671098), but
that's because it depends on things that should be gone by the time
mac_views_browser is a thing.

BUG=425229, 671098

Review-Url: https://codereview.chromium.org/2547923005
Cr-Commit-Position: refs/heads/master@{#436240}

After paulkinlan@ publicised this work [1,2] , it's starting to be
used, so why not count it? This CL adds UseCounters for those.

BUG=665150

[1] https://youtu.be/YJwrBbze_Ec?t=2083
[2] https://twitter.com/Paul_Kinlan/status/805148732652220416

Review-Url: https://codereview.chromium.org/2547413002
Cr-Commit-Position: refs/heads/master@{#436239}

- Need to re-collect active stylesheets when inserting already cached
  import documents.

- Missing markDocumentDirty() when inserting import documents.

- Added test for missing coverage of the need for marking for re-
  collection from HTMLImportChild::ownerInserted().

The fact that we need to recollect sheets in the document scope and
recalculate style for the whole document is not a perf regression, this
is how it used to be before considering the async stylesheet update
with ruleset invalidations, but ideally we would like to do better.
It's unlikely a common use case as html imports are typically loaded in
head as script and rendering blocking.

R=meade@chromium.org
BUG=567021

Review-Url: https://codereview.chromium.org/2551473002
Cr-Commit-Position: refs/heads/master@{#436238}

ignored. So we need to remove this in order to take the required scale
factor into account.

BUG=668023

Review-Url: https://codereview.chromium.org/2535463002
Cr-Commit-Position: refs/heads/master@{#436237}

BUG=669745
TEST=manual test as noted in the bug.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2538413002
Cr-Commit-Position: refs/heads/master@{#436236}

This change enables CSS and Web animations to apply animated
effects on CSS custom properties.

This change involves a restructure of style resolving detailed
in the design doc:
https://docs.google.com/a/chromium.org/document/d/1V27q30H-pQZVbzHCJjdFThBSeuvxkGLdGmb1hLWBAiY

This is a reland of https://codereview.chromium.org/2309963002
with fixes for when the baseComputedStyle optimisation is active.
The revert was due to crbug.com/669790 where behaviour differs
depending on whether asserts are enabled, thus none of the try
bots picked up on the bug.

BUG=644148

Review-Url: https://codereview.chromium.org/2532953008
Cr-Commit-Position: refs/heads/master@{#436235}

This contains luci/luci-go@47c9792.

R=tansell@chromium.org
BUG=666047

Review-Url: https://codereview.chromium.org/2553493002
Cr-Commit-Position: refs/heads/master@{#436234}

Changed Order to an enum class and gave it an unsigned underlying type.
Also renamed it from Order to EOrder to match the other ComputedStyle
enums, and renamed its members to match its keywords from
CSSValueKeywords.in. Also removed the '= 0' value setter for Logical and
the one callsite where this was used (implicit int conversion is not
allowed for enum classes anyway).

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EOrder to be generated in
ComputedStyleBase.

BUG=628043

Review-Url: https://codereview.chromium.org/2546333002
Cr-Commit-Position: refs/heads/master@{#436233}

Changed EPointerEvents to an enum class and gave it an unsigned
underlying type.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EPointerEvents to be generated in
ComputedStyleBase.

BUG=628043

Review-Url: https://codereview.chromium.org/2542843002
Cr-Commit-Position: refs/heads/master@{#436232}

Chrome OS needs to use values like neon-vfpv4 or crypto-neon-fp-armv8.

BUG=670541

Review-Url: https://codereview.chromium.org/2546033002
Cr-Commit-Position: refs/heads/master@{#436231}

Previously, the user image was always saved in JPEG
format at /home/chronos/<email-address>.jpg even if the user
chose a PNG file with transparent/translucent pixels.
Since JPEG format does not support transparent/translucent pixels,
these pixels were replaced with black ones.

This patch solves the problem by storing the user image in PNG
format at /home/chronos/<email-address>.png, when
transparent/translucent pixels are present.

BUG=587289
TEST=transparent pixels are honored in the login and lock screens, as well as the settings page

Review-Url: https://codereview.chromium.org/2537713002
Cr-Commit-Position: refs/heads/master@{#436230}

Cr-Commit-Position: refs/heads/master@{#436229}

Ran `tools/clang/scripts/upload_revision.py 288545`.

This brings in a regression for linux lld (bug 670397), but nobody uses that yet.
In return, it speeds up CFI blacklist processing, makes it possible to turn on blink
PCH use on Windows (would crash previously), and makes win/asan work in
component builds again.

BUG=670392
TBR=hans

Review-Url: https://codereview.chromium.org/2551603004
Cr-Commit-Position: refs/heads/master@{#436228}

BUG=544756

Review-Url: https://codereview.chromium.org/2547853002
Cr-Commit-Position: refs/heads/master@{#436227}

This patch converts "format-block-converts-false.html" to utilize w3c test
harness with |assert_selection()| to simplify test case for improving code
health.

This patch is as preparation of http://crrev.com/2532373002

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2550633002
Cr-Commit-Position: refs/heads/master@{#436226}

https://chromium.googlesource.com/chromium/src/+/77dd2d44c88d5

BUG=667128
TBR=robhogan@gmail.com

Review URL: https://codereview.chromium.org/2551753003 .

Cr-Commit-Position: refs/heads/master@{#436225}

This patch converts the layout test with assert_selection to improve
code health and also increase the usage of w3c testharness.

Note: Chrome's current behavior is incorrect. It will be fixed by
https://codereview.chromium.org/2541163003

BUG=n/a

Review-Url: https://codereview.chromium.org/2534423003
Cr-Commit-Position: refs/heads/master@{#436224}

This patch converts the layout test with assert_selection to improve code
health and also increase the usage of w3c testharness. It also moves the
test file to editing/selection/modify_extend for better organization.

Note: Chrome's current behavior is incorrect. It will be fixed by
https://codereview.chromium.org/2541163003

BUG=n/a

Review-Url: https://codereview.chromium.org/2535173009
Cr-Commit-Position: refs/heads/master@{#436223}

Planning on adding a new interface for form association code called FormAssociated.h so I'm renaming this to avoid confusion.

Review-Url: https://codereview.chromium.org/2546063002
Cr-Commit-Position: refs/heads/master@{#436222}

If using canvas.getImageData or GL textures of UNSIGNED_BYTE type, 16-bit depth
stream data is available only through 8-bit* API, so there is a precision loss.
Here, we add no-precision-loss** JavaScript access through WebGL float texture.

RGBA32F usage here enables lossless access to 16-bit depth information via WebGL1.
In related work, the same code path is used to upload 16-bit data to other WebGL2
supported formats; e.g. with GL_R16UI there is no conversion needed in
SkCanvasVideoRenderer::TexImageImpl.

* 8-bit access refers to JS ImageData and WebGL UNSIGNED_BYTE where 16-bit depth
data is now available as luminance (all 3 color channels contains upper 8 bits
of 16bit value).

** Float is used for no-precision-loss access to 16-bit data normalized to
[0-1.0] range using formula value_float = value_16bit/65535.0.

This patch also adds UNSIGNED_BYTE WebGL test which was earlier tested through
testVideoToImageBitmap since UNSIGNED_BYTE and canvas rendering still share the
same path through SkCanvasVideoRenderer::Paint.

BUG=369849, 624436
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2476693002
Cr-Commit-Position: refs/heads/master@{#436221}

Most if not all of this information is out of date, as incremental
linking is now handled more-or-less automatically by the build
and you probably shouldn't mess with the settings.

R=brucedawson@chromium.org
BUG=670518

Review-Url: https://codereview.chromium.org/2549443004
Cr-Commit-Position: refs/heads/master@{#436220}

Reason: There is no owner for this directory currently.

NOEXPORT=true

Review-Url: https://codereview.chromium.org/2553473002
Cr-Commit-Position: refs/heads/master@{#436219}

As a follow-up to https://codereview.chromium.org/2543893002/,
we make the code easy to read and remove unnecessary findbug suppression.

BUG=668692

Review-Url: https://codereview.chromium.org/2544163003
Cr-Commit-Position: refs/heads/master@{#436218}

build_config.h *looks* like a list of all of the OS_* macros, but it is
missing OS_CHROMEOS. This can lead to confusion. Documenting OS_CHROMEOS
here makes build_config.h the source of truth that developers already
assume that it is.

Review-Url: https://codereview.chromium.org/2130543002
Cr-Commit-Position: refs/heads/master@{#436217}

Account for leading space when selecting our offset for the visible text.

BUG=667128

Review-Url: https://codereview.chromium.org/2529243002
Cr-Commit-Position: refs/heads/master@{#436216}

BUG=669983

Review-Url: https://codereview.chromium.org/2537773008
Cr-Commit-Position: refs/heads/master@{#436215}

BUG=662644
TBR=zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2549003002
Cr-Commit-Position: refs/heads/master@{#436214}

BUG=644626

Review-Url: https://codereview.chromium.org/2547333002
Cr-Commit-Position: refs/heads/master@{#436213}