- 09 Jun, 2020 40 commits
-
-
Haiyang Pan authored
The disabled tests are * testIncognitoToggle_thumbnailFetchCount * AccountPickerBottomSheetTest.* Bug: 1092987, 1093050 Change-Id: I30e1a9f63038cae8902405c6ee6916590f47756e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238887 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#776727}
-
Matt Kotsenas authored
http://crrev.com/c/2229335 added Python3 support for the `test_env_unittest.py` files, but appears to have broken the test on Windows in the process. Fixing by adding back `sys.executable` in the command to run, as Windows doesn't support running scripts via shebang. Bug: 942720 Change-Id: I40757a78ad707f36481e2906251ee8451aa89318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238269Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#776726}
-
Yan, Shaobo authored
This patch add srgb format support in CPU uploading path. The copy ensures color conversion happens in the canvas color space for srgb formats in WebGPU and leave the srgb conversion in shader part. This patch also add color format validation rules for CopyImageBitmapToTexture BUG=966582 Change-Id: I139dc7addd0f74e4b22c271dfb6194bf3d59bb73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234992 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#776725}
-
Fabrice de Gans-Riberi authored
* Add a CastStreamingReceiver mojo service to handle the Cast Streaming Session startup and receive audio and video buffers in the renderer process. * Add a Stop() API in CastStreamingSession. Bug: 1042501 Change-Id: I393a5a500a01fc6f1a966339bab698ea64a1526f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187153 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#776724}
-
Renato Silva authored
Extends the marketing email opt-in in OOBE to support the following additional countries: France, Germany, Netherlands, Finland, Sweden, Norway, Denmark, Spain, Italy, Japan, and Australia. All the countries are protected behind a flag, with a special flag just for double opt-in countries such as Germany. Added suffixes to the metrics that are recorded on that screen. Opt-in rates, and backend request responses will now be based on the country. Added additional metrics to track the success rate of the current geolocation approach. Fixed: 1090724 Change-Id: Icf71e8d07d1b97465649dbd1e5c02c93b50c003b Bug: 1090724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232604Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#776723}
-
Dominic Mazzoni authored
This removes: Accessibility.ImageLabels.ContextMenuOption Accessibility.ImageLabels.FromSettings.ToggleSetting We still have overall stats on the feature usage, these distinctions don't seem important to keep around. Bug: 1061961, 1059787 Change-Id: Ic8fdc3d9e21fcf87e7f132088411f74f60ede118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233821Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#776722}
-
Ben Kelly authored
This CL extends the following histograms: ServiceWorker.CacheStorageInstalledScript.CachedMetadataSize ServiceWorker.CacheStorageInstalledScript.CachedMetadataTotalSize ServiceWorker.CacheStorageInstalledScript.Count ServiceWorker.CacheStorageInstalledScript.ScriptSize ServiceWorker.CacheStorageInstalledScript.ScriptTotalSize ServiceWorkerCache.Cache.Browser.Match.Initialized ServiceWorkerCache.DidGenerateCacheableMetadataMessageInCacheStorage.OriginAllowed ServiceWorkerCache.ListOriginsIndexValidity ServiceWorkerCache.Scheduler.OperationDuration2 ServiceWorkerCache.Scheduler.QueueDuration2 ServiceWorkerCache.Scheduler.QueueLength ServiceWorkerCache.UsedIndexFileSize SimpleCache.ConsistencyResult SimpleCache.ConsistencyResultAfterIndexFilesDeleted SimpleCache.DidDeleteIndexFilesAfterFailedConsistency SimpleCache.EntryTrailerPrefetchDiff SimpleCache.EntryTrailerPrefetchSize SimpleCache.OriginalConsistencyResultBeforeSuccessfulRetry SimpleCache.RetryConsistencyResult This CL removes the following histograms: ServiceWorkerCache.PeakParallelSharedOps2 ServiceWorkerCache.Scheduler.IsOperationSlow Fixed: 1089989,1089966,1089965,1089964,1089954,1089953,1089952,1089905,1089904,1089903,1089902,1089901,1089900,1089853,1089852,1089851,1089850,1089849,1089848,1089847,1089846,1089498,1089497,1089491,1089914,1089913,1089912 Change-Id: I62582053e4339a307ad422d4e4f1ead30211e113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236068 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#776721}
-
rbpotter authored
- Move the GestureDetector instance to the viewport, since the PDFViewer methods for the events fired just call Viewport methods. - Move contextmenu event handling to the GestureDetector, since the PDFViewer just calls a GestureDetector method to see if it should call preventDefault(). - Move mousemove/mouseout listeners to the ToolbarManager, instead of listening for these in PDFViewer only to call ToolbarManager methods. Change-Id: I932a37278b0835cc780e3a7632952885a68cf26e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236951Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#776720}
-
Wan-Teh Chang authored
Chromium creates some image decoder instances just to get image metadata, so decoding the first frame when decoding metadata will result in decoding the first frame of an image multiple times. It turns out that the AVIF spec says the container "box" or property with the the image width, height, or bit depth is mandatory. Therefore, if decoder_->containerWidth/containerHeight/containerDepth is 0 after avifDecoderParse() returns, we can consider the image as invalid. Then, the only metadata we need that libavif doesn't expose yet is whether the image is monochrome (grayscale). This will be addressed in a new version of libavif. Partially revert the changes to avif_image_decoder_test.cc in commit 11746b04 because now Parse (decoding the metadata only) and Decode are distinct phases of decoding again. Test: 1. blink_platform_unittests --gtest_filter=*AVIF* 2. Run chrome with --enable-features=AVIF and visit https://resources.link-u.co.jp/avif/images.html. Bug: 1092694 Change-Id: If4d4ea7aa02591ba9269c810931bac7e4ff85895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236888 Commit-Queue: Wan-Teh Chang <wtc@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#776719}
-
danakj authored
This was a linter error, for CLs coming after. TBR=bokan@chromium.org NOTRY=true Bug: 984438 Change-Id: Icc4d82fd806446e8a838af4a9bfeed1240f39bfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238356Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#776718}
-
Jinsuk Kim authored
When WebContents is destroyed, its ContentView is detached from View hierarchy to stop receiving UI events from framework. But it doesn't seem to stop it from processing some of events that were passed before it was detached. It uses EventForwarder to pass them to WebContents but the EventForwarder was destroyed as well, therefore can cause UAF exception. This CL updates ContentView to check EventForwarder before using it. Bug: 1080552 Change-Id: I7ab4099461d5906393e4305e4f5a88cf86302fd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235259Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#776717}
-
Rahul Singh (EDGE) authored
This CL moves shortcut_icon_bitmaps out of WebApplicationShortcutInfo. This data now lives in a separate std::vector<std::map<SquareSizePx, SkBitmap>> shortcuts_menu_icons_bitmaps; When detecting updates to the manifest, this enables direct comparison between the WebApplicationShortcutsMenuItemInfo created from the manifest and the shortcuts menu info persisted in AppRegistrar. This is The separation of icon bitmaps into shortcuts_menu_icons_bitmaps allows us to use WebApplicationShortcutsMenuItemInfo in the WebApp class. So this change also removes the WebApp::WebAppShortcutsMenuItemInfo struct. Finally, as part of this change, WebApplicationShortcutInfo has been renamed to WebApplicationShortcutsMenuItemInfo. This clarifies the feature powered by this struct. It also helps disambiguate it from the preexisting ShortcutInfo struct in the web_app namespace. This CL is part 1 of 2 to enable shortcuts menu updates when the Web App Manifest is updated. The follow up CL will contain code to detect changes to the manifest's shortcuts member and to unregister and register the Shortcuts Menu as part of the PWA update process. Bug: 1087212 Change-Id: Ib0d0401b0454ecae462acd0bdba2bda6735326d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229879Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Rahul Singh <rahsin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#776716}
-
phillis authored
Badging.AppBadgeUpdate.Win.Result was made obsolete, revert the enum removal so that the label is still shown in UMA metric dashboard with historical data. Bug: 1088645 Change-Id: Icdaef4c0892da7c87cc7f6fd1a4a9ff4120fce82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238668 Commit-Queue: Phillis Tang <phillis@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#776715}
-
Kyle Horimoto authored
Fixed: 1090183 Change-Id: I13b9cb3590bbe06192190075939578615574aa32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236955 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#776714}
-
shrekshao authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/1b5de6a..d0fcf3d Tbr: kbr@chromium.org Bug: 1082525, 1082592 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64 Change-Id: I40dec355c5a31eb82fc80d90ffe42d3c7e812ffa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238416Reviewed-by:
Shrek Shao <shrekshao@google.com> Reviewed-by:
-
Bo Liu authored
Factor out ChildServiceConnection* classes and interfaces as separate files. They are all made package private. Unit tests is moved into the same package name to access the new interfaces. Rename bind/unbind methods on ChildServiceConnection to bind/unbindServiceConnection, to avoid name clashing with ChildProcessConnection methods. Only production change should be updating some tracing event names. Change-Id: Iacd788833028808d81f5f12fddd46cd88babeb26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231717Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#776712}
-
danakj authored
This test, along with the non-virtual version both fail consistently with a different scrollX value than expected: FAIL Tests that window should snap at user scroll end. assert_equals: window.scrollX should be at snapped position. expected 400 but got 100 TBR=bokan@chromium.org Bug: 984438 Change-Id: I83e6a04ec9c20686aad6678a12ab499f82a333ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238496Reviewed-by: -
Marijn Kruisselbrink authored
This was only used by the per-tab permission model, so with that gone this code can be deleted as well. This leaves the most basic "is this tab using the API" since that is used by page info as well, and it's not easy to change that code to get usage information some other way. Bug: 1087205 Change-Id: Ic7ae3335159cecc806e9969a59659a3808fba055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237431Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Milad Farazmand authored
Above flag is not supported on AIX linker. Change-Id: I7ee10c4f5f18a53adef192208778c43062e1c37b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238752Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#776709}
-
Nate Chapin authored
Change-Id: I05213286e6ae691e90048a810ec069403e8e89c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233822 Commit-Queue: Nate Chapin <japhet@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#776708}
-
Bruce Dawson authored
In x64 builds there is an extra C runtime DLL called vcruntime140_1.dll (and it's debug equivalent). This tiny DLL seems to be responsible for some exception handling work. This DLL has existed for a while but with the recent attempt to switch to a new toolchain it started being required - its absence was causing 0xC0000135 failures when running angle_deqp_egl_tests.exe in a release component build. This change adds it to the list of CRT DLLs to copy, for x64 builds only. Bug: 1089996 Change-Id: I8c1a64864634f40007e5efeaff375bc88d86aefd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238348Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#776707}
-
Kent Tamura authored
* LastLineTextLogicalBottom() and FirstLineTextLogicalTop(): Fix wrong arguments for NGPhysicalFragment::ConvertToLogical(). This fixes <rt> positioning in vertical writing modes. * LayoutRubyText(): We did set a wrong AnnotationOverflow value computed from the top/bottom offset of a <rt>'s box. We should compute it from the top of the first line text or the bottom of the last line text of a <rt>. This fixes too-wide line spacing in some tests. Bug: 1069817 Change-Id: I3f87a0ea75cd89355fab8847ac0179586a62ff33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235271 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#776706}
-
Vikas Soni authored
SharedImageInterface currently only have methods to generate sync tokens but no dedicated method to wait on sync tokens. This CL adds a dedicated method which allows to wait on sync tokens. Bug: 1091945 Change-Id: I3d9b45c43c03bf3f6a78b5e06e0bd13311619ab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232100Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#776705}
-
Vladimir Levin authored
This patch introduces a notion of parent across the style containment boundary, which is used to produce the output of content: counters(n, '.') and the like. Since the style containment imposes a boundary such that counters are rooted in the subtree, regular Parent() navigation does not reach any counters on the other side of the containment boundary. With ParentCrossingContainmentBoundary() we use layout object parent navigation with counter checks to reach the next ancestor. This patch also adds some comments in the code, and improves the debugging function to print out slightly more meaningful information (names as opposed to addresses, etc). This patch fixes counter-scoping-001.html R=chrishtr@chromium.org Bug: 882383 Change-Id: I293ebd578e506383b35af5b72b0b3802e52476ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236463Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#776704}
-
Lucas Gadani authored
A new navigation may reuse an existing RenderViewHost if there is one being kept alive by a pending delete frame. We now re-create the views for all RenderViewHosts upon portal activation. Bug: 1083128 Change-Id: I8cd5df317ec783788084735e5673be22bf62de19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216534Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#776703}
-
Garrett Beaty authored
Bug: 1093039 Change-Id: Iaef484352ac376f9e4a382a0d68c5abae4c198bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238353 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#776702}
-
Sam Maier authored
Bug: 1090335, 1082809 Change-Id: I95537325cabcc1cce655cdb4aae040bf2ef2c3e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237714Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#776701}
-
Bo Liu authored
Some bad OS implementation throw null pointer exception here. Just catch and ignore it. Bug: 1092978 Change-Id: Ia465e6198645c2ff0e5c30b0e3c45eccf6f0508b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238451 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#776700}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5df4a7a9dcb7..82ca62d3e155 2020-06-09 fmayer@google.com Fix missing space in docs. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia129855503fc6586d8631168ddc2484d12d17a95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238691Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776699}
-
Manuel Rego Casasnovas authored
These are tests intended to verify that supbixel transforms have the very same effect after being modified. BUG=1078401 Change-Id: I8ddf2d503b6a0fe64707025be98e8ed81eabe44e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238048Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#776698}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/929d66714815..750036ef9035 2020-06-09 shanejc@microsoft.com msft-consider instructions added to TRIAGE_GUIDELINES If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I47fcc3f848c051b6f7ad56bd7c65884ec9bf9885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238607Reviewed-by:
-
spdonghao authored
The placeholder of Feed is split horizontally to text placeholder and image placeholder for flexibility and aligning with content better. Bug: 1076139 Change-Id: Ie261adf1ad52bc3c21cf16b03aa2422451e9e739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222904 Commit-Queue: Hao Dong <spdonghao@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#776696}
-
Toni Baržić authored
This reverts commit 1823ac30. Reason for revert: Breaking browser tests BUG=1093047 Original change's description: > [Assistant Opt-in] Fix regression on first run OOBE locales > > Bug: b/156405987 > Test: Manual Test > Change-Id: I57c0c37ca7865f23df730e84167f9be6368dc33a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227900 > Commit-Queue: Yue Li <updowndota@chromium.org> > Reviewed-by: Jeroen Dhollander <jeroendh@google.com> > Cr-Commit-Position: refs/heads/master@{#776593} TBR=updowndota@chromium.org,jeroendh@google.com Change-Id: I67bc4d0251bd39b6fd6a75fd91878d2fd6309a5c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/156405987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238849Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#776695}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/d8eca133b4b1..4ec77979ecd7 2020-06-09 rharrison@google.com Start shaderc v2020.2 2020-06-09 rharrison@google.com Finalize shaderc v2020.1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: I803252cb5fcd71f472e25131acb5e1d4b17b1325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238687Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ic12a4d517a859142f4e79f53d09abf3c6fdd8ae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238366Reviewed-by:
-
Tom Sepez authored
Restores a protection that was lost some time ago when PDFium, as embedded in chrome, began taking external isolates as handed to it from gin. Add tests which use the same "beep" mechanism to communicate results back from deep inside PDF javascript to the .cc test file. Bug: 1091380 Change-Id: I884b70997e3042afb967b8e4a0e51a4b88beebd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232806Reviewed-by:
-
Frank Liberato authored
Rather than crashing while trying to dereference a null d3d11 texture, skip it during drawing. This isn't a permanent fix, but crashing the gpu process is the wrong thing to do. Bug: 1077645 Change-Id: I13e3feafc5fa2803e95bd6a7899a2c15f8d7e358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238456Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#776691}
-
Stephanie Kim authored
Verified with led android-binary-size that the script runs and the resulting files can successfully be used for commit size comparisons https://ci.chromium.org/raw/build/logs.chromium.org/chromium/led/kimstephanie_google.com/1f354f7e4d2ef2bd925e7f4d5a538cb3e814d87975fa7be355e24e448ee299af/+/annotations?server=chromium-swarm.appspot.com Bug: 1078460 Change-Id: I321db344415877b1b8819b6e21123b7b9fba2941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225742 Commit-Queue: Stephanie Kim <kimstephanie@google.com> Reviewed-by:
-
sczs authored
Creates a feature flag to enable/disable the Messages UI for the Block Popup Messages UI. Bug: 1065385 Change-Id: I0f59e26127592461e3fe5a54c9997af597cec19b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233678 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#776689}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I4af590c02d35b3a9e254461a3d6903bdf5f7fd6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238406Reviewed-by:
-
