- 10 Sep, 2020 40 commits
-
-
Olivier Yiptong authored
It is unnecessary to check for Transient User Activation if the permission status has been previously granted or denied. This change ensures that the UA check is skipped in those cases on Mac, in alignment with the ChromeOS, Linux and Windows implementations. Bug: 1043306 Change-Id: I69016cdd696a7003b691d91eae1386ebf7e0f96a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404060 Auto-Submit: Olivier Yiptong <oyiptong@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#805913}
-
Robert Sesek authored
Also removes a long-dead unittests_manifest.json. Change-Id: Iaded46b3c193b77acae7103bdfa363469531d3d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404526Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#805912}
-
Egor Pasko authored
When running on buildbot, we always use the internal version. The git stash/unstash/commit/push should be avoided when running locally (options.buildbot=False). In the public repository, the OrderfileUpdater should be able to upload files, it was useful just once. With this, the OrderfileNoopUpdater looks unnecessary, since we replace OrderfileUpdater in the internal repo anyway, so remove it. Otherwise the split of functionality between the public and the internal OrderfileUpdater is accidental. Not revisiting it here. Bug: None Change-Id: Icd0fc9ed69d0def8e1fa9cfd1be05083f7c9cbf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403469Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#805911}
-
Jonah Ryan-Davis authored
Recent patches to fix the 2D texture path on Mac have fixed a number of tests on ANGLE's Metal/Swiftshader backends. Bug: angleproject:4846 Bug: chromium:1099978 Bug: chromium:1099979 Change-Id: I1f33074d61176d6ae72e2ee57fe0b847fc4b1471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380732 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#805910}
-
Michael Checo authored
Screenshot: http://shortn/_9HmkoESwea Bug: 1122235 Test: manual inspection Change-Id: I2c02dedb2b6f2201ae147349f60f872b247055bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386488 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#805909}
-
Kevin Schoedel authored
Web page-level focus was absent, which in turn meant that blink-level focus was suppressed. The aura::Window on which focus was attempted did not have an OnWindowFocused observer; this change focuses the Window that does. This is a reland of one piece of the reverted http://crrev.com/c/2274201 Bug: b/156123509 Test: manual on device Change-Id: I0a9ec66de97f346512f9ade01f7ad4821159c527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348420Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org> Cr-Commit-Position: refs/heads/master@{#805908}
-
Trevor Perrier authored
This is the last of four CLs for the Clank language decouple. It adds UI to the Language settings that allows users to set an application specific language. The UI is behind the flag DETAILED_LANGUAGE_SETTINGS. Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=1068667#c6 Bug: 1068667 Change-Id: Ie32a7efe66091a5072499bd886e1f9c8728e75e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355494 Commit-Queue: Trevor Perrier <perrier@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Lijin Shen <lazzzis@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#805907}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0e8358a4dead..feb1579dfb25 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I9a99b96f9a4fda85232926df5d55fd3e75788475 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404273Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805906}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/65dcbe124508..1bd71b48fb5c 2020-09-10 syoussefi@chromium.org Make gl::DrawBufferMask a BitSet8 2020-09-10 emaxx@chromium.org Fix useless move() in SizedMRUCache_unittest.cpp 2020-09-10 timvp@google.com Vulkan: Avoid linking to SPIR-V validation if possible If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1122844 Tbr: ianelliott@google.com Test: Test: CQ Change-Id: I58d5f34c0bc0fb77b2b49fc6756eca63b5eb56d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404083Reviewed-by:
-
Matt Jones authored
This patch throws exceptions for cases that shouldn't be happening when using the bottom sheet. These will hopefully help track down an issue where the sheet is visible with null content. Bug: 1126872 Change-Id: I65789df1a569674d19610f41e50b45e21edb1136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403902Reviewed-by:
-
Sharon Yang authored
Remove the Native / Android comment on the StringAttribute kClassName since that value is no longer populated by Android and is used on all platforms. Change-Id: I361912e66c8c2c0b4cd136a02412d135ac0180bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404408Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Sharon Yang <yangsharon@chromium.org> Cr-Commit-Position: refs/heads/master@{#805903}
-
Junbo Ke authored
|is_for_auth| is unnecessary since we only need to know which headers are signature. Bug: b/162380916 Merge-With: eureka-internal/444720 Test: On device Change-Id: Icd46e0b88d55de83cbfc1d43fb7584c25999d421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382714Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fb8d5f7d60cb..0c37bf0f193b 2020-09-10 jegarc@microsoft.com [Issues] UMA tracking for the issues panel 2020-09-10 patrick.brosset@microsoft.com Grid: Display a "no grids" message in the layout pane when there are no grids 2020-09-10 andoli@chromium.org [ts] Typecheck css_overview/CSSOverviewProcessingView.js with TypeScript 2020-09-10 jacktfranklin@chromium.org Reland "Expose the live directive from LitHtml" 2020-09-10 andoli@chromium.org [ts] Typecheck css_overview/CSSOverviewStartView.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1100658,chromium:1109177 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I939df8e1d59948d15b19a791c74d84ba77ed08c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404204Reviewed-by:
-
Kevin McNee authored
This test navigates a new tab via its opener to demonstrate that the source information in the referrer chain reflects the previously committed URL in the navigating frame, rather than the initiator of the navigation. This scenario is worth considering for any future attempt to capture information about the initiator in the referrer chain. Bug: 1096115 Change-Id: If997a84b46ea45640266cfb2e954ee291f06201f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386755Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#805900}
-
Gang Wu authored
Previously we tint icon mixing with original color in dark mode, this CL will throw out the original color and tint the icons. Bug: 1126477 Change-Id: Ie9f96f9387a0084004684036dd842465171d442d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404440Reviewed-by:
Gang Wu <gangwu@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#805899}
-
Liviu Tinta authored
Test didn't require changes to convert to WPT. I've only added calls to EventWatcher to wait for pointerup event to be done in order to avoid flaky behaviour. Change-Id: Ie7695b47b6f97769d5337b30e4810e94d339233f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398946Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#805898}
-
David Maunder authored
We now enforce URL and Title to be acquired on the UI thread. Bug: 1117396 Change-Id: I95790e2c6e7696ccbc4f2a918d9cde6ea9eba80a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404522Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#805897}
-
Prabir Pradhan authored
This adds unit tests for scale-aware clients that disable the default_dsf scale cancellation. These tests determine that the server commits the scale appropriately for different windowing modes. BUG=b:160350706 TEST=exo_unittests Change-Id: Idaaea44d60dbeb8e3e1d805484ce1fbff1494560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399762 Commit-Queue: Prabir Pradhan <prabirmsp@chromium.org> Reviewed-by:
Mitsuru Oshima (Slow: gardener) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#805896}
-
Kalvin Lee authored
This change implements PpdProvider::ReverseLookup(). This change also corrects a logic error in PpdMetadataManager, in which I overzealously assumed that callers always supply entries that we _must_ find in the corresponding metadata (untrue: caller can simply supply gibberish, and we should fail gracefully). Bug: chromium:888189 Test: chromeos_unittests --gtest_filter='PpdProviderTest.ReverseLookup' Test: chromeos_unittests --gtest_filter='PpdMetadataManagerTest.*' Change-Id: Iebf70a0ad8d60044c031178a27bd3f5c83f32b06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357249 Commit-Queue: Kalvin Lee <kdlee@chromium.org> Reviewed-by:
Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#805895}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eed10d12ed49..0ba5cb6e38f7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kmoon@google.com,seblalancette@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1099917 Tbr: kmoon@google.com,seblalancette@google.com Change-Id: I1211f0d436848cd9a720ca7a6ba3dd6f5c5dcd5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404086Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Kahmy Moon <kmoon@google.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805894}
-
phillis authored
Removes places that access AppShortcutsManager and FileHandlerManager directly, limit the suraface of sub managers to only expose a subset of getter through OsIntegrationManager. Bug: 1098027 Change-Id: I1231727935b2c05f9083df0f7c9bff0f1ffa7a85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350324Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Phillis Tang <phillis@chromium.org> Cr-Commit-Position: refs/heads/master@{#805893}
-
Alex Newcomer authored
Multiple changes: - Show a placeholder image if the ImageModel is not ready yet. - In a future CL, we will update the menu real-time. Currently if the image is not ready at menu show time, the placeholder is used instead. - Resize the rendered HTML to match the new menu look. - Remove unused vector icons. Bug: 1120750 Change-Id: I29c5595d7bd5b7330a67b991f842b1150b9614b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401809 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#805892}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/feb1579dfb25..3b19b9d3347f 2020-09-10 fmayer@google.com Merge changes Ief0ffa2c,Icce0f62c 2020-09-10 hjd@google.com Merge "Remove d8, we never used it" 2020-09-10 hjd@google.com Merge "ui: Add --incremental to TypeScript build" 2020-09-10 delphij@google.com Merge "Merge Android R" 2020-09-10 treehugger-gerrit@google.com Merge "ui: Add support to decode metrics in the UI" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I0e296d0ebcbde22955555d42ab5f62199e232bae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404205Reviewed-by:
-
Liquan (Max) Gu authored
Since OnSectionOptionSelected is PaymentRequest UI logic, move it into PaymentUIsManager. Bug: 1102522, 1114791 Change-Id: I8268493c6d65ec14aa89444b461910d58c5af4bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402119 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#805890}
-
Ryan Hansberry authored
Two tests related to Read() have been excluded from running on Windows due to undiagnosed crashes. We can resolve them in the future when Nearby launches for Windows devices. Bug: 1124992 Change-Id: I682cf64604344314c40e276042c08dbb8023c800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402442 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#805889}
-
James Vecore authored
This CL adds an observer interface to allow clients of the service to be notified when high visibility state changes as well query the current state. Previously, high-visibility was not part of the api. It was an implied state when a foreground receive surface was registered and advertising was is started successfully with a device name in the end-point info. This change makes it possible to query and monitor high visibility so UI surfaces can be in sync with the service state. Additional methods will be added to the observer interface in follow up CLs (i.e. Shutdown). Change-Id: I40b718fb9fb1ab185ef45a4ff0085d4c59c8bad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401851 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#805888}
-
Leonard Grey authored
These are to support displaying hotkeys and tagging different types of result with specific icons. Bug: 1014639 Change-Id: I93f432a2368c25285dd714c4f2fbdaef96434a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403661Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#805887}
-
chrome://nearby-internalsJosh Nohle authored
(1) Add a newline at the end of each line when saving logs file. (2) Show logs in chronological order. (3) Fix issue which showed "../../" at the start of every filename. (4) Fix issue where logs extend a few pixels past the horizontal width of the page, resulting in an overflow and making it possible to scroll left and right. (5) Clean up some code in the <log-object> element. (6) Use Polymer's array mutation method for unshift, which notifies other elements bound to the same array of the changes. This will fix the issue of needing to refresh to page to show log changes. Changes 1-5 mirror exactly crrev/c/2372600 and crrev/c/2383790, which correct the issues on the analogous chrome://multidevice-internals page. Change-Id: I3bd2d922e291f86be5533716cfac74f67c5bdd2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401807 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#805886}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1599738815-c7c05d9aad543471c0ca5060fdc90a37df9de6fc.profdata to chrome-linux-master-1599760756-c4035dc0b0474f5a6f2e7d19fc7457941683bae1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:linux-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: I0f67e98af99f1924960aea72786f1580119937d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404781Reviewed-by:
-
Federico Paredes authored
MenuScrollViewContainer now has a kIgnored (instead of kMenuBar) role on Mac. This allows the SubmenuView to be recognized as a menu by VoiceOver, so it can now read the total number of MenuItemViews inside it when navigating via keyboard. Bug: 954701 Change-Id: I4ee11c09d3331d55899ece6741f9821cbd3b2285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402098 Commit-Queue: Federico Paredes <fedpar@microsoft.com> Reviewed-by:
-
Yulun Wu authored
Bug: 1110757 Change-Id: Ide6c6ecfbfc259ac1a5b22e2441afedad6655adf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392949 Commit-Queue: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
-
Trevor Perrier authored
This CL adds the AppLocaleController interface and the GlobalAppLocaleController implementation which use the APPLICATION_OVERRIDE_LANGUAGE value to override the Clank language. Early in ChromeApplication.attachBaseContext the GlobaleAppLocaleController singleton is initialized with the override language and updates the Application level Locales/LocaleList. Doing the Application override this early also overrides the ContextUtils wrapped application Context. The base Context passed by Android to the Activity level attachBaseContext still uses the system locales so an Activity level locale override is also done. The override language is used for CCTs. This is the third of four CLs for this feature. The next will introduce the UI changes to allow users to control the preference. Bug: 1068667 Change-Id: Ifbbe9f8ed592c1b890a9069ef5cbfb685d34e00f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354546Reviewed-by:
Trevor Perrier <perrier@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#805882}
-
Sebastien Lalancette authored
This reverts commit 40d318a5. Reason for revert: New tests are failing on many builders, like: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/49280 Original change's description: > Direct Sockets: Browser implementation for TCP connection establishment > > DirectSocketsServiceImpl::OpenTcpSocket() now calls > CreateTCPConnectedSocket() on the network context. > > Browser test DirectSocketsBrowserTest.OpenTcp_Options verifies > that the remote address, port, buffer sizes and no-delay flag > are passed successfully. > > NavigatorSocket::PendingRequest has been split into > TCPSocket and UDPSocket classes, currently with no web-exposed > members implemented. > https://github.com/WICG/raw-sockets/blob/master/docs/explainer.md#tcp > https://github.com/WICG/raw-sockets/blob/master/docs/explainer.md#udp > > > > > Explainer: https://github.com/WICG/raw-sockets/blob/master/docs/explainer.md > > Intent to Prototype: > https://groups.google.com/a/chromium.org/g/blink-dev/c/ARtkaw4e9T4/m/npjeMssPCAAJ > > Design doc: > https://docs.google.com/document/d/1Xa5nFkIWxkL3hZHvDYWPhT8sZvNeFpCUKNuqIwZHxnE/edit?usp=sharing > > > > Bug: 905818 > Change-Id: I7030f73d4863767b3d51a615fd84380148011bec > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391181 > Commit-Queue: Jeremy Roman <jbroman@chromium.org> > Auto-Submit: Eric Willigers <ericwilligers@chromium.org> > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Glen Robertson <glenrob@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805850} TBR=kinuko@chromium.org,jbroman@chromium.org,ericwilligers@chromium.org,dullweber@chromium.org,glenrob@chromium.org Change-Id: I1dd6b7bab117365bf22384c61dc1d3158bf10c58 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 905818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404821Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#805881}
-
Anne Lim authored
This is a follow-up after instrument_id has been added to the AutofillTable in cr/2390970. Please refer to bug for design doc. Bug: 1121806 Change-Id: Ie118b2dba1e0d7890333de35c92489398cdae6a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402130Reviewed-by:
Anne Lim <annelim@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#805880}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I84b21f5e3155072f67d04fde846bef1adf9dcf14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404403Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#805879}
-
Maxim Kolosovskiy authored
fieldtrial_testing_config Bug: 1108692 Change-Id: I36000025bdfe905232f9b6af55997692833f98c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403366 Commit-Queue: Jesse Doherty <jwd@chromium.org> Auto-Submit: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#805878}
-
Ryan Hansberry authored
As per recommendation in Comment #30 of crbug.com/1114876. This is the same grey used in Network Settings secondary text. Bug: b:167556640 Change-Id: I5a669cae3e43fc7cfe3d57eb276a4f6584a322e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404141 Auto-Submit: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
-
Roman Aleksandrov authored
Make dots clickable and add proper aria-labels and role. Add aria-label to slides for better spoken feedback. Bug: 1125620 Change-Id: I6f20d4b1e3293aa89c81d4a6da960b6fd0fb0b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396084 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#805876}
-
Roberto Moura authored
Using a fake pan gesture recognizer, simulate 4 changes of state in the ViewRevealingVerticalPanHandler (Hidden -> Peeked -> Revealed -> Peeked -> Hidden), which are observable through a fake animatee that has a public |state| property. Bug: 1094335, 1124380 Change-Id: I2a2b1017b78fce48eb48cbde95eb9967870aee7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396090 Commit-Queue: Roberto Moura <mouraroberto@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#805875}
-
Ben Goldberger authored
Bug: 1125930 Change-Id: I8613a3c881eadb7a162550bf0321c1b87cb2ca2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397319 Commit-Queue: Ben Goldberger <benwgold@google.com> Reviewed-by:
-
