- 20 May, 2014 40 commits
-
-
teravest@chromium.org authored
This lifts more manifest processing code out of the trusted plugin. Specifically, instead of the trusted plugin receiving a PP_Var with the contents of the manifest and making another method to create the manifest id, the trusted plugin now simply receives the manifest ID directly. BUG=239656 Review URL: https://codereview.chromium.org/287153006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271719 0039d316-1c4b-4281-b951-d872f2087c98
-
prasadv@chromium.org authored
BUG= NOTRY=true Review URL: https://codereview.chromium.org/298743002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271718 0039d316-1c4b-4281-b951-d872f2087c98
-
andrewhayden@chromium.org authored
This patch makes it possible to enable dynamic mode on any platform without breaking all of the browser tests that rely upon translation functionality working properly. Basically, we copy a static version of the CLD data file into the place where it would be put by the dynamic data mechanism that has been built. This allows the browser to find it immediately, and tests can run as normal. Without this patch, all tests that rely directly or indirectly upon language detection will fail. BUG=367239 Review URL: https://codereview.chromium.org/285293004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271717 0039d316-1c4b-4281-b951-d872f2087c98
-
kbr@chromium.org authored
Failing on Linux Debug bot on Blink waterfall as well. See Issue 375103. BUG=375103 TBR=ncbray@chromium.org Review URL: https://codereview.chromium.org/299623004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271716 0039d316-1c4b-4281-b951-d872f2087c98
-
hjd@chromium.org authored
In the WebView shouldInterceptRequest is called on the IO thread. The CookieManager used to post cookie monster tasks to a thread which was sometimes the IO thread (if the WebView was started before the CookieManager) but sometimes a special thread (if the CookieManager was started before the WebView). getCookie is synchronous and blocks waiting for the result after posting its task so if getCookie was called from shouldInterceptRequest and the cookie monster was on the IO thread then it deadlocked. We fix this by always starting the special thread for the cookie monster. Android Issue: https://code.google.com/p/android/issues/detail?id=65786 BUG=374203 Review URL: https://codereview.chromium.org/284313005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271715 0039d316-1c4b-4281-b951-d872f2087c98
-
xiyuan@chromium.org authored
- Make SigninScreenHandler a ScreenlockBidge::LockHandler and get rid of middle layers; - Remove deprecated custom button click; - customButton -> customIcon renaming and HTML/js/css update; - Move api test out of cros; R=asargent@chromium.org, isherman@chromium.org, rogerta@chromium.org, tengs@chromium.org Review URL: https://codereview.chromium.org/289013002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271714 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=98313,374943 NOTRY=true Review URL: https://codereview.chromium.org/294763003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271712 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
In this case, it's not very useful and full of false positives. NOTRY=true Review URL: https://codereview.chromium.org/293843002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271711 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271710 0039d316-1c4b-4281-b951-d872f2087c98
-
earthdok@chromium.org authored
Remove suppressions for false positives / intentional leaks in Blink code. They have since been annotated with in-code annotations. BUG=121729, 242672 TBR=glider@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/292663004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271709 0039d316-1c4b-4281-b951-d872f2087c98
-
jkummerow@chromium.org authored
BUG=374838 R=kareng@google.com Review URL: https://codereview.chromium.org/294113002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271708 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
Hooks up the blink GN build to the main GN build. Android is currently disabled (some dependencies are not complete yet). R=eseidel@chromium.org, thakis@chromium.org Review URL: https://codereview.chromium.org/296513002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271707 0039d316-1c4b-4281-b951-d872f2087c98
-
stevenjb@chromium.org authored
BUG=374452 R=benchan@chromium.org, jennyz@chromium.org Review URL: https://codereview.chromium.org/286923003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271706 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271705 0039d316-1c4b-4281-b951-d872f2087c98
-
eseidel@chromium.org authored
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=174366:174386&mode=html TBR= BUG= Review URL: https://codereview.chromium.org/298723003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271704 0039d316-1c4b-4281-b951-d872f2087c98
-
fsamuel@chromium.org authored
This CL moves the New Window API and navigation to chrome. This CL removes a lot of unnecessary content APIs for BrowserPlugin now that permissions no longer live in content. Up next, in a separate CL will be a huge cleanup that removes all WebContentsDelegate code out of BrowserPluginGuest and into WebViewGuest. This should significantly reduce the size of the BrowserPlugin content API. BUG=364141, 330264 TBR=kenrb@chromium.org for trivial browser_plugin_messages.h change. Review URL: https://codereview.chromium.org/272573005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271703 0039d316-1c4b-4281-b951-d872f2087c98
-
rtenneti@chromium.org authored
internal server. Merge internal change: 67534473 R=rch@chromium.org Review URL: https://codereview.chromium.org/290893004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271702 0039d316-1c4b-4281-b951-d872f2087c98
-
aboxhall@chromium.org authored
BUG=162740 NOTRY=true Review URL: https://codereview.chromium.org/290493004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271701 0039d316-1c4b-4281-b951-d872f2087c98
-
lazyboy@chromium.org authored
BUG=None Test=Internal cleanup. Review URL: https://codereview.chromium.org/288393005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271700 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
Review URL: https://codereview.chromium.org/295893002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271699 0039d316-1c4b-4281-b951-d872f2087c98
-
leejongsoo@gmail.com authored
BUG=None (cleanup only, does not change behavior) Review URL: https://codereview.chromium.org/278013002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271698 0039d316-1c4b-4281-b951-d872f2087c98
-
zea@chromium.org authored
Breaks android builder due to PNG corruption from ASCII conversion (same error as on try job). http://build.chromium.org/p/chromium.linux/buildstatus?builder=Android%20Builder%20%28dbg%29&number=58007 > Web MIDI: add permission infobar icon for Android > > On Android, permission infobar appears for Web MIDI permission, > but correct icon is not used. This change add a proper icon. > > Submit with NOTRY=true since it contains binary files and the patch > fails on try. > > BUG=339767 > NOTRY=true > > Review URL: https://codereview.chromium.org/292743004 TBR=toyoshim@chromium.org Review URL: https://codereview.chromium.org/291213002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271697 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271693 0039d316-1c4b-4281-b951-d872f2087c98
-
earthdok@chromium.org authored
BUG=none R=glider@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/287063010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271692 0039d316-1c4b-4281-b951-d872f2087c98
-
glider@chromium.org authored
Right now TSan doesn't support suppressions for any lock inversion stacks but the top one. BUG=374135 TBR=jyasskin@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/295933004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271691 0039d316-1c4b-4281-b951-d872f2087c98
-
spang@chromium.org authored
We need SurfaceFactoryOzone initialized in the GPU process. TBR=sadrul NOTRY=true Review URL: https://codereview.chromium.org/288033019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271689 0039d316-1c4b-4281-b951-d872f2087c98
-
earthdok@chromium.org authored
I accidentally typed "git svn dcommit" instead of "git cl dcommit", which used my local commit message instead of the CL description. :( > i TBR=earthdok@chromium.org Review URL: https://codereview.chromium.org/289353003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271688 0039d316-1c4b-4281-b951-d872f2087c98
-
spang@chromium.org authored
The gestures library links jsoncpp, which we link statically. Turn off fatal-warnings while we sort this out. BUG=351168 TEST=build --board link_freon TBR=rjkroege Review URL: https://codereview.chromium.org/292513003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271687 0039d316-1c4b-4281-b951-d872f2087c98
-
antrim@chromium.org authored
BUG=370497 TBR=nkostylev@chromium.org Review URL: https://codereview.chromium.org/286933005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271686 0039d316-1c4b-4281-b951-d872f2087c98
-
droger@chromium.org authored
BUG=371845 TBR=rohitrao Review URL: https://codereview.chromium.org/292513002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271685 0039d316-1c4b-4281-b951-d872f2087c98
-
phoglund@chromium.org authored
QtKit doesn't support 1080p, which I found out when I enabled our C920- equipped mac bot. Therefore we will no longer try to test that. Also temporarily disabling QVGA for qtkit since it incorrectly acquires 320x180 rather than 320x240. BUG=375185 TBR=tommi@chromium.org Review URL: https://codereview.chromium.org/295943003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271684 0039d316-1c4b-4281-b951-d872f2087c98
-
earthdok@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271683 0039d316-1c4b-4281-b951-d872f2087c98
-
erg@chromium.org authored
Due to button refactoring patches, we now need to ask views for their preferred sizes in const methods. Across the entire codebase, the overwhelming majority of GetPreferredSize() implementations could be const. There are only a few places where we can't, and they are usually combining the sizing and layout code. BookmarksBarView was simple enough to perform this separation. Most of the other places were solved by adding "mutable" to value caches. BUG=155363 R=jam@chromium.org, pkasting@chromium.org, scheib@chromium.org, sky@chromium.org, pkasting, sky TBR=jam, scheib Review URL: https://codereview.chromium.org/273223002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271682 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
If we don't do this, then the standard frame appears with the blue one provided by views, presenting two title bars with the same information, which looks ugly. BUG=374046 TEST=build views_examples_with_content_exe on Linux, run it. Observe. The window displayed must have a unique frame, the blue one. See bug for previous-after screenshots. R=sky@chromium.org Review URL: https://codereview.chromium.org/291503006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271681 0039d316-1c4b-4281-b951-d872f2087c98
-
qsr@chromium.org authored
BUG=375178 R=tonyg@chromium.org Review URL: https://codereview.chromium.org/294943002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271680 0039d316-1c4b-4281-b951-d872f2087c98
-
stevenjb@chromium.org authored
BUG=373965 For fake_wifi_service.cc R=armansito@chromium.org, pneubeck@chromium.org TBR=mef@chromium.org Review URL: https://codereview.chromium.org/285233008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271679 0039d316-1c4b-4281-b951-d872f2087c98
-
dzhioev@chromium.org authored
BUG=316551 R=oshima@chromium.org Review URL: https://codereview.chromium.org/290423002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271678 0039d316-1c4b-4281-b951-d872f2087c98
-
toyoshim@chromium.org authored
On Android, permission infobar appears for Web MIDI permission, but correct icon is not used. This change add a proper icon. Submit with NOTRY=true since it contains binary files and the patch fails on try. BUG=339767 NOTRY=true Review URL: https://codereview.chromium.org/292743004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271677 0039d316-1c4b-4281-b951-d872f2087c98
-
motek@chromium.org authored
Automove with some manual fixes. BUG=374214 Review URL: https://codereview.chromium.org/294693002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271676 0039d316-1c4b-4281-b951-d872f2087c98
-
naiem.shaik@gmail.com authored
Bookmarks is not a layered component, so there is no need for the two level deep hierarchy, switch code from components/bookmarks/core/... to components/bookmarks/... BUG=370434 TEST=components_unittests --gtest_filter=Bookmark* R=blundell@chromium.org,sdefresne@chromium.org TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/284893003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271675 0039d316-1c4b-4281-b951-d872f2087c98
-