GitLab

Change-Id: I9e66727766422a18bc4e4c5618c49e332c548087
Reviewed-on: https://chromium-review.googlesource.com/c/1426685
Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625152}

This change adds logic to record a user action whenever the "Manage your
Google Account" link gets clicked.

Bug: 907035
Change-Id: I081886ea84b9c748d8402aafc6b64bdd768378e9
Reviewed-on: https://chromium-review.googlesource.com/c/1426785
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625151}

The lock can now outlive the AccountReconcilor.

Bug: 923094
Change-Id: I92443549d50354eb1418fe8495dddea5bf310d5d
Reviewed-on: https://chromium-review.googlesource.com/c/1425499Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625150}

AccountTrackerService will be deprecated for the servicification. So this CL
replaces all uses of ATS with IdentityManager's ones in dice_browsertest.cc

Bug: 922769
Change-Id: If17b69fac2b15a9d4afa987081def495bd19b24a
Reviewed-on: https://chromium-review.googlesource.com/c/1429312Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#625149}

Serializer is a deprecated feature in WebIDL, but we still have it on several IDL files.
This CL replaces it with toJSON() operation, which is a replacement for serializer,
but does not change user facing behaviors.

For DetectedBarcode, DetectedText, and DetectedFace, toJSON() is not defined in spec,
but this CL defines it to keep their backward compatibility.


Bug: 736332
Change-Id: Iff420493f7d41a78452cef5a203330dba6333bca
Reviewed-on: https://chromium-review.googlesource.com/c/1429310Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625148}

In jumbo builds, many files are compiled in the same translation
unit and then they also share the same anonymous namespace. Then
it becomes a problem (does not compile) if several constants/
symbols are named the same.

This follows earlier patterns of giving shared generic names
prefixes.

Bug: 918788

Change-Id: If45d63b9bfe77119735c67fca491a6227dded045
Reviewed-on: https://chromium-review.googlesource.com/c/1424842Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#625147}

TBR=chrishtr@chromium.org

Bug: 921242
Change-Id: Ifa915bc86e5148d5df71a744ef6f41c00881115f
Reviewed-on: https://chromium-review.googlesource.com/c/1429881Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625146}

TBR=kmilka@chromium.org

Bug: 923953
Change-Id: I45d42b9c1f4f7afb417300d352176d8bb86dec6f
Reviewed-on: https://chromium-review.googlesource.com/c/1429042Reviewed-by: Alexander Potapenko <glider@chromium.org>
Commit-Queue: Alexander Potapenko <glider@chromium.org>
Auto-Submit: Alexander Potapenko <glider@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625145}

Bug: 556939, 914453
Change-Id: Ibd8757967a051507e0fc2a9ae93ac789e51b005b
Reviewed-on: https://chromium-review.googlesource.com/c/1425708Reviewed-by: Jun Mukai <mukai@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Marek Haranczyk <mharanczyk@opera.com>
Cr-Commit-Position: refs/heads/master@{#625144}

Constant Labels was only used by //third_party/libjingle_xmpp.

In CL [1] I removed this error handling mechanism from libjingle_xmpp
so it is possible to remove this code and simplify
//third_party/webrtc_overrides.

[1] - https://chromium-review.googlesource.com/c/chromium/src/+/1397607

Bug: 896154
Change-Id: I3b4d8869d7813c789b7b12f8cad0fdc079796491
Reviewed-on: https://chromium-review.googlesource.com/c/1397982Reviewed-by: Tommi <tommi@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625143}

This fixes a race because both main thread and worker threads parse CSP
which uses blink::CSPDirectiveList which uses blink::SpaceSplitString.

Bug: 807838
Change-Id: Id1eafe17daf3d37f9c1b6fc64aaa18ea964c57bc
Reviewed-on: https://chromium-review.googlesource.com/c/1429819Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625142}

Simplifying destinations dialog:
- Remove recent destinations list
- Remove total destinations count
- Remove headers
- Move "Manage" link to a button
- Show location or description with no search query, since this
  information is no longer shown when the destination is selected.

Bug: 923174
Change-Id: I614949c826f2d23705f1b1829eb705e1c32c483c
Reviewed-on: https://chromium-review.googlesource.com/c/1413716
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625141}

Using wpt-import in Chromium 4c6aafc4.
With Chromium commits locally applied on WPT:
1c633d48 "Snap the snapped_dest_rect for backgrounds"
1061788d "Reland "Add quota usage details tests for all other storage backends.""
bcd3934d "Add a test for ServiceWorker and AppCache interaction with claim()"
33a49f0d "[WebLocks]: Modifying weblocks algos to be O(1)"
8e4e5d72 "Fix preload tests failing on wpt.fyi dashboard"
f643497e "[resource-timing] Modify is_secure_context_ based on resource"
20defaa4 "[LayoutNG] ComputeReplacedSize min/max width/height fix"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I21fecc27184e8c06caf4ba9cb1998c877c6141d6
Reviewed-on: https://chromium-review.googlesource.com/c/1429663Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#625140}

Cleanup imports in TabGrid.

Bug: 923973
Change-Id: I148ea89bf77b7a32ee141c80bb1fb30a556852b8
Reviewed-on: https://chromium-review.googlesource.com/c/1426402
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625139}

Thic CL changes the event type of scrim views for search bar in history
and bookmarks from UIControlEventAllTouchEvents to
UIControlEventTouchUpInside.

Bug: 894791
Change-Id: Ie15e1708dae03c4ca3ebec68bd6b8905b2b3a73a
Reviewed-on: https://chromium-review.googlesource.com/c/1426777Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625138}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/2307cc4b..f6d33d43

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I2a92a8abcc727c1a83ff3bf2f11266067d3ccd2c
Reviewed-on: https://chromium-review.googlesource.com/c/1429225Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#625137}

This reverts commit ddd4f721.

Reason for revert: Looks like some tests become flaky (or even flakier?)

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/10417
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/10418
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/10419
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/31176

Original change's description:
> Fix flakiness in previews browsertests
> 
> The previous logic relied upon the hints requested by the store upon a
> navigation to a url being loaded prior to the commit. This was not
> guaranteed to happen when cores were not available on a machine for
> background threads.
> 
> The HintCache has been modified so that it now runs the hint loaded
> callback even in the case where no hints are available for the host.
> 
> Additionally, a histogram has been added that tracks the loading of
> hints from the hint cache store has in PreviewsOptimizationGuide. The
> tests now run a priming navigation that waits for the hints to be
> loaded. This ensures that the hints are guaranteed to be available
> during the tests.
> 
> Bug: 923161
> Change-Id: I8b09dfc9391164f0a6d424ec0a8ea871334c4c8c
> Reviewed-on: https://chromium-review.googlesource.com/c/1423617
> Commit-Queue: Jered Gray <jegray@chromium.org>
> Reviewed-by: Tarun Bansal <tbansal@chromium.org>
> Reviewed-by: Doug Arnett <dougarnett@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#625056}

TBR=tbansal@chromium.org,dougarnett@chromium.org,jegray@chromium.org

Change-Id: I7d7c3393765e2d24d02c49fd5f8be95dd8eebc86
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 923161
Reviewed-on: https://chromium-review.googlesource.com/c/1429879Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625136}

The class base::NoDestructor is a simpler way to define a static
global value (aka a singleton) than base::{LazyInstance,Singleton}
and is the recommended pattern to use.

The changes were automated using a custom one-shot script, then
fine tuned by hand (to remove unnecessary classes, ...).

This fixes usages in src/ios/chrome/browser/favicon.

This CL was uploaded by git cl split.

Bug: none
Change-Id: Iec12a9f2c05d6415fffb371fa589b65d9f759c19
Reviewed-on: https://chromium-review.googlesource.com/c/1425605
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625135}

This patch drops support for Signed Exchange of
"application/signed-exchange;v=b2" format. After this patch, loading
Signed Exchanges of version 1b2 will cause fallback redirect.

SignedExchangeEnvelopeTest and SignedExchangeSignatureVerifierTest
will remain TestWithParam<SignedExchangeVersion>, since that will be
useful when adding support for future versions.

Bug: 919424
Change-Id: I8f992c2d38e21ad2fc89b9c227295867f588a04a
Reviewed-on: https://chromium-review.googlesource.com/c/1428628Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625134}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.

The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: Ide707dfdcd3571bc335ff6edb4641c79d4fb396f
Reviewed-on: https://chromium-review.googlesource.com/c/1429839Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#625133}

This is a follow-up of https://crrev.com/c/1421418 .
This patch renames |first_frame| to |entered_window_frame|, and
also renames |calling_window| to |incumbent_window|,
|entered_window|, or |accessing_window| depending on what it
actually is.

Change-Id: Ifbfc7c36d6a1b3bfe69387438928c488937d0a35
Reviewed-on: https://chromium-review.googlesource.com/c/1426254Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625132}

The class base::NoDestructor is a simpler way to define a static
global value (aka a singleton) than base::{LazyInstance,Singleton}
and is the recommended pattern to use.

The changes were automated using a custom one-shot script, then
fine tuned by hand (to remove unnecessary classes, ...).

This fixes usages in src/ios/web_view/internal/sync.

This CL was uploaded by git cl split.

Bug: none
Change-Id: I8c335cf791dbdd57860c7a45bc62fc456a3adbce
Reviewed-on: https://chromium-review.googlesource.com/c/1426680
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625131}

Actual code changes will be in the following CL.

For mock of its usage please refer to bug comment #43

Bug: 897998
Change-Id: I0f8d616ec24df1ac28ca06485cd21691f2959066
Reviewed-on: https://chromium-review.googlesource.com/c/1427959Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Siyu An <siyua@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625130}

The class base::NoDestructor is a simpler way to define a static
global value (aka a singleton) than base::{LazyInstance,Singleton}
and is the recommended pattern to use.

The changes were automated using a custom one-shot script, then
fine tuned by hand (to remove unnecessary classes, ...).

This fixes usages in src/ios/chrome/browser/invalidation.

This CL was uploaded by git cl split.

Bug: none
Change-Id: Iebcc8f75afc76ce261623a3998b1cabd472a5c59
Reviewed-on: https://chromium-review.googlesource.com/c/1426682
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625129}

Remove explicit synthesis where unnecessary.

Bug: 923980
Change-Id: Ie5bef471a34625c9f890a49800bd48a496623f68
Reviewed-on: https://chromium-review.googlesource.com/c/1426398
Auto-Submit: edchin <edchin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625128}

This patch fixes a case when a text node ends with a zero
width space followed by a new line. Before this fix, the
sequence hits a DCHECK failure hits and both the zero width
space and the new line were removed.

The correct expected behavior is to collapse the new line
but leaves the zero width space.

Bug: 918812
Change-Id: I90255be8215862a630117950164fba00a7a6e302
Reviewed-on: https://chromium-review.googlesource.com/c/1425855
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625127}

https://skia.googlesource.com/skia.git/+log/24120c2a32c6..d562545e8a23


git log 24120c2a32c6..d562545e8a23 --date=short --no-merges --format='%ad %ae %s'
2019-01-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 05459e06fde5..5313c8a89964 (3 commits)


Created with:
  gclient setdep -r src/third_party/skia@d562545e8a23

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=djsollen@chromium.org

Change-Id: Ia6a33d756a4f2aa76b91c2de9f5c01d21982cc6a
Reviewed-on: https://chromium-review.googlesource.com/c/1429659Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#625126}

When a setting is defined both as platform policy (GPO, plist, etc.)
and also is present in the cloud policy then platform policy takes
precedence but it also makes it difficult for an admin to trace the
issue. This change exposes such situations on the chrome://policy
page.

For now only a hard coded English is added but eventually a localized
error will be more apropriate.

BUG=922957
TEST=components_unittests

Change-Id: Ia8a4c7b2a1428005ddf624fb18a39faa4668ef17
Reviewed-on: https://chromium-review.googlesource.com/c/1417615Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625125}

This fixes, for example, chrome://settings/clearBrowserData checkboxes

TBR=dpapad@chromium.org
BUG=883049

Change-Id: I535c05ec0342a1e9fb735cfae1c48d38d10ae3d0
Reviewed-on: https://chromium-review.googlesource.com/c/1429665
Commit-Queue: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Reviewed-by: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Auto-Submit: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625124}

Current console info messages are not informative because it's shown so
often, almost every time when the frame runs in background.

With this patch, the message is shown only if the top request in the
queue hasn't been sent in the last 1 minute when the frame is brought
to the foreground.

Bug: 723233
Change-Id: I6fe15b3f6928701e2858cadd0d7eb9e5c64327c6
Reviewed-on: https://chromium-review.googlesource.com/c/1333587
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625123}

i18n-values and i18n-content are deprecated, to be replaced by $i18n{}
in Web UI. Allow component apps/extensions to use the same i18n template
replacements as Web UI during serving.

Update the Files app quickview localization covered by a test to use
this method.

Bug: 923206,923204
Change-Id: I647bdea906c6bc427a82981fac780cc0e6badf2c
Reviewed-on: https://chromium-review.googlesource.com/c/1424619
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625122}

We are using the original request's request_initiator to certificate request.
But we can just use an opaque Origin because SignedExchangeCertFetcher fetches
the cert with LOAD_DO_NOT_SEND_COOKIES flag, and so
URLRequestHttpJob::AddCookieHeaderAndStart() doesn't use the initiator().
https://chromium.googlesource.com/chromium/src/+/accda06/content/browser/web_package/signed_exchange_cert_fetcher.cc#112
https://chromium.googlesource.com/chromium/src/+/f3caee1/net/url_request/url_request_http_job.cc#691

Bug: 920905
Change-Id: If1512420c60bc971e959b66a0e25a39afacc57b9
Reviewed-on: https://chromium-review.googlesource.com/c/1429362
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625121}

This CL makes sure we don't only track autoPictureInPicture attribute
set in Javascript but also declaratively in HTML for Auto
Picture-in-Picture.

Bug: 923879
Change-Id: I64725d99c54c302d3d65e48a32524f7b9a485a23
Reviewed-on: https://chromium-review.googlesource.com/c/1425732Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#625120}

Fix the //device/gamepad build rules not to add Nintendo files under
Fuchsia, where they do not compile cleanly.

TBR=mattreynolds@chromium.org

Bug: 801717
Change-Id: Iaba2c7f61845f5e1039ad0eae851d004a8a256b9
Reviewed-on: https://chromium-review.googlesource.com/c/1429662
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Auto-Submit: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625119}

TBR=dpapad@chromium.org
BUG=883049

Change-Id: Icdef0838145fbc7c207d1c3d57b9cb4d13d1cbb4
Reviewed-on: https://chromium-review.googlesource.com/c/1429759Reviewed-by: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Commit-Queue: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Auto-Submit: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625118}

Move most of OutOfProcessInstance::SendNextAccessibilityPage() out into
its own function. Then unit test it.

Change-Id: I54590ac004f11d918ccb45a3e071d9cf19a927ed
Reviewed-on: https://chromium-review.googlesource.com/c/1407265
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625117}

This mixin will allow a fallback to the older stable driver version after
ten minutes of failing to find the new driver version.

Bug: 887241
Change-Id: Ieb279babadb6f57441b3c72172f70d4014b2bf8a
Reviewed-on: https://chromium-review.googlesource.com/c/1422838
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625116}

This change modifies to base::FilePath::StringType to be base::string16
on Windows. Currently there is no difference between this and the old
typedef to std::wstring, but this will change once base::string16 is
std::u16string on all platforms.

Bug: 911896, 23581
Change-Id: Id7604ca365343de8f05c384d5504e4ed8ab99110
Reviewed-on: https://chromium-review.googlesource.com/c/1425729Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625115}

Bug: 716628
Change-Id: I0eb098a88533effec8b67b499fe98f8b39b20fc3
Reviewed-on: https://chromium-review.googlesource.com/c/1420274
Commit-Queue: Donna Wu <donna.wu@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625114}

Attempting to open a '.exe' or '.msi' file shows a dialog explaining
that those are Windows specific files that aren't compatible with
ChromeOS. That dialog included text directing users to the Chrome
Web Store which doesn't provide a fix for issue of being able to
run a '.exe' file.

Bug: 787472
Tests: Ran all browser and unit tests, have existing coverage for this.
Change-Id: I625467161499527a0e74fa8c2b4cd6e07a3819fd
Reviewed-on: https://chromium-review.googlesource.com/c/1426337Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Alex Danilo <adanilo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625113}