GitLab

This variable was uninitialized and the compiler gave a warning (which
got converted into an error because we compile using -Werror) when
GetIDAndCountOfFormElement() and its children are inlined. This is
because there is a path in that function that returns true but leaves
the pair_id variable uninitialized (if s.Step() is 0).

Note that I am not a Chromium committer so you will have to commit
this.

Patch by asharif; http://codereview.chromium.org/6293011/

BUG=70144
TEST=no visible change


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71860 0039d316-1c4b-4281-b951-d872f2087c98

Update chrome/browser/gtk references & copyright dates of touched files.
Re-alphabetize include lists as necessary from this change.
Manually merge r71828

svn pset svn:eol-style LF \
  chrome/browser/automation/testing_automation_provider_gtk.cc \
  chrome/browser/speech/speech_input_bubble_gtk.cc

BUG=69289
TEST=none

Review URL: http://codereview.chromium.org/6245006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71859 0039d316-1c4b-4281-b951-d872f2087c98

BUG=67956
TEST=manual

Review URL: http://codereview.chromium.org/6330005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71858 0039d316-1c4b-4281-b951-d872f2087c98

Delete strings from .grd files that are at least 6 months old and aren't used anywhere.

BUG=none
TEST=compile

Review URL: http://codereview.chromium.org/6260013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71857 0039d316-1c4b-4281-b951-d872f2087c98

Modifying some downloads hooks to act per-window (so that incognito windows can be correctly targetted) and updating some surrounding test cases.

BUG=59259

Review URL: http://codereview.chromium.org/6159001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71856 0039d316-1c4b-4281-b951-d872f2087c98

Converted passphrase-related notifications to SyncFrontend methods.

Removed some unneeded parameters from SyncBackendHost constructor.

Moved some function definitions into .cc files.

BUG=None
TEST=unit_tests

Review URL: http://codereview.chromium.org/6380004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71855 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=brettw

Review URL: http://codereview.chromium.org/6254011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71854 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/6326006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71853 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71850 0039d316-1c4b-4281-b951-d872f2087c98

TEST=ran the conformance tests
BUG=none

Review URL: http://codereview.chromium.org/6282008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71849 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/6242007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71848 0039d316-1c4b-4281-b951-d872f2087c98

TBR=scherkus

Review URL: http://codereview.chromium.org/6250016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71846 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70157
TEST=greener tree
TBR=johnnyg@chromium.org

Review URL: http://codereview.chromium.org/6351008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71845 0039d316-1c4b-4281-b951-d872f2087c98

Change all the places where the multi-purpose sync error link is surfaced to call a common routine that either shows a login prompt or shows the passphrase prompt depending on the reason for the error.

BUG=68962
TEST=none

Review URL: http://codereview.chromium.org/6293010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71844 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=search for techcrunch and notice how the preloaded techcrunch.com is used despite the redirect

Review URL: http://codereview.chromium.org/6288007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71843 0039d316-1c4b-4281-b951-d872f2087c98

The PluginVersionInfo structure just mirrored the Windows file
metadata format.  Since we want to create a WebPluginInfo anyway,
just store a WebPluginInfo as the internal plugin info.

TEST=refactoring change, should be covered by existing tests

Review URL: http://codereview.chromium.org/6162008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71841 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70086
TEST=manual builds in various configurations

Review URL: http://codereview.chromium.org/6310013

Build failure on windows trying to include gtk related headers.
http://build.chromium.org/p/chromium/builders/Win%20Builder/builds/4080

TBR=anicolao@google.com
Review URL: http://codereview.chromium.org/6309008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71840 0039d316-1c4b-4281-b951-d872f2087c98

TEST=compiles
BUG=none

Review URL: http://codereview.chromium.org/6347008

TBR=apatrick@chromium.org
Review URL: http://codereview.chromium.org/6303011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71839 0039d316-1c4b-4281-b951-d872f2087c98

TEST=compiles
BUG=none

Review URL: http://codereview.chromium.org/6347008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71837 0039d316-1c4b-4281-b951-d872f2087c98

CSS values provided by Glen Murphy <glen@chromium.org>.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6241006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71836 0039d316-1c4b-4281-b951-d872f2087c98

- Adds oninput handling to live-save the homepage pref. I had avoided this before because I didn't want to pollute metrics, but this pref doesn't actually have a metric. (Also, if one is added, we can increment it only on the onchange events.)
- Does URL fixup for onchange events (not oninput, because it would make typing impossible).

BUG=69901,62851
TEST=Change the homepage to a non-canonical URL; it should be updated on blur to a full URL. On ChromeOS, power off the machine after changing the home page, but not blurring the field; it should be saved.

Review URL: http://codereview.chromium.org/6332006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71835 0039d316-1c4b-4281-b951-d872f2087c98

r536 All surfaces follow D3D Y convention
http://codereview.appspot.com/3265041

r535 Build fix needed on certain platforms. Explicitly cast away const.
http://codereview.appspot.com/4043042

TEST=try
BUG=none

Review URL: http://codereview.chromium.org/6254010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71834 0039d316-1c4b-4281-b951-d872f2087c98

This is just a move CL, code changes will come in a followup.  Moving the files will make the next code review easier.

BUG=56415
TEST=None

Review URL: http://codereview.chromium.org/6265010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71833 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70086
TEST=manual builds in various configurations

Review URL: http://codereview.chromium.org/6310013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71832 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/6323006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71830 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6344008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71829 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=brettw

Review URL: http://codereview.chromium.org/6250014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71828 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/6362007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71827 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/6279005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71825 0039d316-1c4b-4281-b951-d872f2087c98

OnTouchEvent now returns the status of the touch sequence, instead of a simple
bool. The gesture manager can presumably make a better decision if this
information is available to it. For more details: http://codereview.chromium.org/6347002/

BUG=none
TEST=ViewTest.TouchEvent

Review URL: http://codereview.chromium.org/6253005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71824 0039d316-1c4b-4281-b951-d872f2087c98

This makes licenses.py happy.

pdfsqueeze changes: http://code.google.com/p/pdfsqueeze/source/list

r4 Added copying file + minor change to preserve date stamps.

r3 Fixed up inputs and outputs on script phase.
   This modifies a file under xcodeproj, which should not affect Chromium
   (we have a gyp file for pdfsqueeze).


Review URL: http://codereview.chromium.org/6269012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71822 0039d316-1c4b-4281-b951-d872f2087c98

TBR=cbentzel
BUG=70115
TEST=none

Review URL: http://codereview.chromium.org/6260012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71821 0039d316-1c4b-4281-b951-d872f2087c98

tests are (usually) monitored for a fixed length of time. With this change
field trial tests turn them selves off (will use the default group) after
the expiration time (specified in the Field Trial constructor).

BUG=13463
TEST=field_trial_unittests tests this code thorougly. spdy session and testing
     field_trials in renderer process would be very helpful. thanks much.

Review URL: http://codereview.chromium.org/6317004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71820 0039d316-1c4b-4281-b951-d872f2087c98

- Fix graphical artifacting for images downloaded from the Internet caused by overwriting them with their own mip-maps. This resulted in each image being rendered with copies of itself of decreasing size in one of the corners. Cairo does not support/need mip-maps, so we now just ignore the calls to set the mip-maps.
- Do not alpha-blend new texture content with the old texture content, which is wrong and would have been wasting a bit of CPU too.

TEST=loaded O2D and verified the artifacting is fixed
BUG=none

Review URL: http://codereview.chromium.org/6268006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71819 0039d316-1c4b-4281-b951-d872f2087c98

The problem is that CrxInstaller wasn't considering updates when looking for
previously installed apps with overlapping extents.

BUG=68872
TEST=Steps outlined in bug report. 

Review URL: http://codereview.chromium.org/6292007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71818 0039d316-1c4b-4281-b951-d872f2087c98

Update chrome/browser/gtk references & copyright dates of touched files.
Re-alphabetize include lists as necessary from this change.
Update header guard & add EOF newline in chrome/browser/ui/view_ids.h
Split C/C++ system headers into blocks in:
 chrome/browser/ui/gtk/gtk_expanded_container.cc
 chrome/browser/ui/gtk/gtk_chrome_shrinkable_hbox.cc
Sync manually with r71749

BUG=69289
TEST=none
Review URL: http://codereview.chromium.org/6296012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71816 0039d316-1c4b-4281-b951-d872f2087c98

BUG=69391
TEST=Create lots of new tabs, bring up task manager, should be fast.

Review URL: http://codereview.chromium.org/6240001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71815 0039d316-1c4b-4281-b951-d872f2087c98

Re-landing r71485 (which was reverted in r71500).

BUG=23581
TEST=no visible changes; all tests pass

Review URL: http://codereview.chromium.org/6278007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71814 0039d316-1c4b-4281-b951-d872f2087c98

This mirrors the behaviour on other platforms, and allows the optimized Pepper
plugin painting path to be used (see RenderWidget::DoDeferredUpdate()).

BUG=none
TEST=MacFlapper paints correctly in the "windowed" case

Review URL: http://codereview.chromium.org/6359005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71813 0039d316-1c4b-4281-b951-d872f2087c98

Pass correct dummy filename ("name.html" instead of "name./html") to GTK MIME lookup, to fix the file-filter drop-down in GTK file dialogs.

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/6379001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71812 0039d316-1c4b-4281-b951-d872f2087c98